CPCI750: Do not enable data cache in start.S
PATCH 1/1 CPCI750: Do not enable data cache in start.S
From: Reinhard Arlt <[email protected]>
Do not enable the data cache in start.S, the decrementer do not work.
Signed-off-by Reinhard Arlt <[email protected]>
--
arch/powerpc/cpu/74xx_7xx/start.S +2 -1
@@ -247,11 +247,12 @@ in_flash: /* enable address translation */ bl enable_addr_trans sync - +#if !defined(CONFIG_CPCI750) /* enable and invalidate the data cache */ bl l1dcache_enable sync #endif +#endif #ifdef CONFIG_SYS_INIT_RAM_LOCK bl lock_ram_in_cache sync
PATCH 1/1 CPCI750: Do not enable data cache in start.S
Dear Reinhard Arlt,
Quoted 16 lines · In message <[email protected]> you wrote:
From: Reinhard Arlt <[email protected]>
Do not enable the data cache in
start.S, the decrementer do not work.Signed-off-by Reinhard Arlt <[email protected]>--
arch/powerpc/cpu/74xx_7xx/start.S +0
-0@@ -247,11 +247,12 @@ in_flash: /* enable address translation */ bl enable_addr_trans sync
arch/powerpc/cpu/74xx_7xx/start.S in_flash: · line 258
Quoted 10 lines
arch/powerpc/cpu/74xx_7xx/start.S +2
-1- +#if !defined(CONFIG_CPCI750) /* enable and invalidate the data cache */ bl l1dcache_enable sync #endif +#endif #ifdef CONFIG_SYS_INIT_RAM_LOCK bl lock_ram_in_cache sync
Sorry, but I don't want to have board specific code in arch/powerpc/cpu/74xx_7xx/start.S
Please turn this into a feature dependent define, if it is really needed.
Also, can you provide a rational explanation how the decrementer depends on data cache being enabled? This sounds pretty strange to me.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
News is what a chap who doesn't care much about anything wants to
read. And it's only news until he's read it. After that it's dead.
- Evelyn Waugh _Scoop_ (1938) bk. 1, ch. 5