arm, post: add missing post_time_ms for arm

PATCH New Heiko Schocher 4 participants 6 messages Sep 15, 2011 – Nov 22, 2011

lore

Share & tools

lore

Heiko Schocher

author

2011-09-15 05:34 UTC #0 lore raw

PATCH 1/1 arm, post: add missing post_time_ms for arm

Signed-off-by Heiko Schocher <[email protected]>

Cc Albert ARIBAUD <[email protected]>

---
 post/post.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

post/post.c +1 -1

index 6c59f91..0bfca75 100644
@@ -488,7 +488,7 @@ void post_reloc(void)
  */
 unsigned long post_time_ms(unsigned long base)
 {
-#ifdef CONFIG_PPC
+#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
 	return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
 		- base;
 #else

Signature · 1 line

1.7.6

Holger Brunck

2011-11-21 12:57 UTC #1 lore raw

PATCH 1/1 arm, post: add missing post_time_ms for arm

Hi Heiko,

Quoted 11 lines · Heiko Schocher

Signed-off-by Heiko Schocher <[email protected]>
Cc Albert ARIBAUD <[email protected]>
---
 post/post.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
post/post.c +0 -0
index 6c59f91..0bfca75 100644

post/post.c void post_reloc(void) · line 494

Quoted 8 lines

post/post.c +1 -1

@@ -488,7 +488,7 @@ void post_reloc(void)
  */
 unsigned long post_time_ms(unsigned long base)
 {
-#ifdef CONFIG_PPC
+#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
 	return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
 		- base;
 #else

this commit breaks post test support for our keymile arm boards:

Quoted 1 line

make km_kirkwood

[...]
post/libpost.o: In function `post_time_ms':
/daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined reference to get_ticks' /daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined reference to get_tbclk'

So it seems that the kirkwood code has no implementation for these functions. Any idea how to fix this?

Best regards
Holger

Heiko Schocher

author

2011-11-21 14:09 UTC #2 lore raw

PATCH 1/1 arm, post: add missing post_time_ms for arm

Hello Holger,

added Prafulla Wadaskar to cc ...

Quoted 9 lines · Holger Brunck

Hi Heiko,
Quoted 6 lines · Heiko Schocher
Signed-off-by Heiko Schocher <[email protected]>
Cc Albert ARIBAUD <[email protected]>
---
 post/post.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Quoted 15 lines

post/post.c void post_reloc(void) · line 494

Quoted 13 lines

post/post.c +1 -1

index 6c59f91..0bfca75 100644
@@ -488,7 +488,7 @@ void post_reloc(void)
  */
 unsigned long post_time_ms(unsigned long base)
 {
-#ifdef CONFIG_PPC
+#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
 	return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
 		- base;
 #else

this commit breaks post test support for our keymile arm boards:

:-(

I am sure I tried a "MAKEALL arm" ... Hmm.. how did the post support worked for you before this patch? You should have seen this warning message:

#warning "Not implemented yet"

or?

Quoted 8 lines

Quoted 1 line
make km_kirkwood
[...]
post/libpost.o: In function `post_time_ms':
/daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined reference to get_ticks' /daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined reference to get_tbclk'
So it seems that the kirkwood code has no implementation for these functions. Any idea how to fix this?

We must implement it ... Prafulla, can you comment this?

bye,
Heiko

Signature · 2 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Holger Brunck

2011-11-21 14:27 UTC #3 lore raw

PATCH 1/1 arm, post: add missing post_time_ms for arm

Hi Heiko,

Quoted 24 lines · Heiko Schocher

Quoted 7 lines · Holger Brunck
Quoted 6 lines · Heiko Schocher
Signed-off-by Heiko Schocher <[email protected]>
Cc Albert ARIBAUD <[email protected]>
---
 post/post.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 15 lines
post/post.c void post_reloc(void) · line 494
Quoted 13 lines
post/post.c +1 -1
index 6c59f91..0bfca75 100644
@@ -488,7 +488,7 @@ void post_reloc(void)
  */
 unsigned long post_time_ms(unsigned long base)
 {
-#ifdef CONFIG_PPC
+#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
 	return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
 		- base;
 #else
this commit breaks post test support for our keymile arm boards:

Quoted 3 lines

:-(
I am sure I tried a "MAKEALL arm" ... Hmm.. how did the post support

I guess that our post support wasn't mainlined at the time you test the patch.

Quoted 6 lines

worked for you before this patch? You should have seen this warning message:
#warning "Not implemented yet"
or?

Yes we got these warning in the past but this wasn't a problem for us, because we don't use these timer informations in our framework.

Quoted 11 lines

Quoted 8 lines
Quoted 1 line
make km_kirkwood
[...]
post/libpost.o: In function `post_time_ms':
/daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined reference to get_ticks' /daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined reference to get_tbclk'
So it seems that the kirkwood code has no implementation for these functions. Any idea how to fix this?
We must implement it ... Prafulla, can you comment this?

Or in the first step just add && !(CONFIG_MACH_KIRKWOOD) or similar to the #ifdef until it is supported in the generic kirkwood code.

regards
Holger

Prafulla Wadaskar

2011-11-22 08:26 UTC #4 lore raw

PATCH 1/1 arm, post: add missing post_time_ms for arm

In reply to Heiko Schocher

Quoted 60 lines

-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Monday, November 21, 2011 7:40 PM
To: Holger Brunck
Cc: u-boot at lists.denx.de; Longchamp, Valentin; Falauto, Gerlando
Subject: Re: [PATCH] arm, post: add missing post_time_ms for arm
Hello Holger,
added Prafulla Wadaskar to cc ...
Quoted 9 lines · Holger Brunck
Hi Heiko,
Quoted 6 lines · Heiko Schocher
Signed-off-by Heiko Schocher <[email protected]>
Cc Albert ARIBAUD <[email protected]>
---
 post/post.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 11 lines
post/post.c void post_reloc(void) · line 492
Quoted 11 lines
post/post.c +1 -1
index 6c59f91..0bfca75 100644
@@ -488,7 +488,7 @@ void post_reloc(void)
  */
 unsigned long post_time_ms(unsigned long base)
 {
-#ifdef CONFIG_PPC
+#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
 	return (unsigned long)(get_ticks() / (get_tbclk() /
CONFIG_SYS_HZ))
Quoted 4 lines
post/post.c void post_reloc(void) · line 494
Quoted 2 lines
post/post.c +0 -0
 		- base;
 #else
this commit breaks post test support for our keymile arm
boards:
:-(
I am sure I tried a "MAKEALL arm" ... Hmm.. how did the post support
worked for you before this patch? You should have seen this warning message:
#warning "Not implemented yet"
or?
Quoted 4 lines
Quoted 1 line
make km_kirkwood
[...]
post/libpost.o: In function `post_time_ms':
/daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined
reference to `get_ticks'

Quoted 8 lines

Quoted 1 line
/daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined
reference to `get_tbclk'
Quoted 2 lines
So it seems that the kirkwood code has no implementation for
these functions.
Quoted 1 line
Any idea how to fix this?
We must implement it ... Prafulla, can you comment this?

As per my knowledge Kirkwood has no implementation for this. Yes, we should implement this.
Patches are welcomed.

Regards..
Prafulla . . .

Mike Frysinger

2011-11-22 21:00 UTC #5 lore raw

PATCH 1/1 arm, post: add missing post_time_ms for arm

In reply to Heiko Schocher

Quoted 11 lines · On Thursday 15 September 2011 01:34:33 Heiko Schocher wrote:

Signed-off-by Heiko Schocher <[email protected]>
Cc Albert ARIBAUD <[email protected]>
---
 post/post.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
post/post.c +0 -0
index 6c59f91..0bfca75 100644

post/post.c void post_reloc(void) · line 494

Quoted 8 lines

post/post.c +1 -1

@@ -488,7 +488,7 @@ void post_reloc(void)
  */
 unsigned long post_time_ms(unsigned long base)
 {
-#ifdef CONFIG_PPC
+#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
 	return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
 		- base;
 #else

almost no one uses the result of post_time_ms(), so the warning ends up being spurious for most people.

are you enabling this define because you need the result ? or you just trying to kill the warning ? if the latter, i think we should make this so it warns only when appropriate ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111122/b73fe3fa/attachment.pgp>