198, 240: check presence of aiodio_sparce2
PATCH 1/1 198, 240: check presence of aiodio_sparce2
Use same trick with:
commit 4e9072472fbc56b9d4c8ee8094cc62ce793df9b7
Gracefully fail aio tests if they weren't built
--- 198 | 5 ++++- 240 | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-)
198 +4 -1
@@ -45,13 +45,16 @@ _cleanup() _supported_fs generic _supported_os Linux +AIO_TEST=src/aio-dio-regress/aiodio_sparse2 +[ -x $here/$AIO_TEST ] || _notrun "$AIO_TEST not built" + echo "Silence is golden." # real QA test starts here rm -f $seq.full rm -f "$TEST_DIR/aiodio_sparse*" -$here/src/aio-dio-regress/aiodio_sparse2 "$TEST_DIR/aiodio_sparse" +$here/$AIO_TEST "$TEST_DIR/aiodio_sparse" status=$? exit
240 +4 -1
@@ -53,6 +53,9 @@ _supported_os Linux _require_sparse_files +AIO_TEST=src/aio-dio-regress/aiodio_sparse2 +[ -x $here/$AIO_TEST ] || _notrun "$AIO_TEST not built" + echo "Silence is golden." # real QA test starts here
@@ -69,7 +72,7 @@ fi # 2 threads, fs block sized writes, 64k filesize, stride through file by # fs block size, start at logical block size offset -$here/src/aio-dio-regress/aiodio_sparse2 -i 2 -w $fs_block_size -s 64k -n $fs_block_size -o $logical_block_size "$TEST_DIR/aiodio_sparse" +$here/$AIO_TEST -i 2 -w $fs_block_size -s 64k -n $fs_block_size -o $logical_block_size "$TEST_DIR/aiodio_sparse" status=$? exit
Signature · 7 lines
1.7.7.3 _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 3 lines · Hidetoshi Seto
Use same trick with:
commit4e9072472fbc56b9d4c8ee8094cc62ce793df9b7
Gracefully fail aio tests if they weren't built
Good idea, but given this check is now repeated in multiple places, wrapping it in a "_require_aiodio" helper function is probably in order.
It might also be useful to define AIODIO_SPARSE and AIODIO_SPARSE2 variables (similar to, say, XFS_IO_PROG) so that it doesn't have to be open coded in all the tests....
Cheers,
Dave.
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 3 lines · Dave Chinner
Good idea, but given this check is now repeated in multiple places, wrapping it in a "
_require_aiodio" helper function is probably in order.
Good point.
OK, I'll make a patch to implement the "_require_aiodio" helper.
Thanks,
H.Seto
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs