Skip to contentSkip to conversation

spi/pl022: skip default configuration before suspending

PATCH New Linus Walleij 2 participants 2 messages Nov 22, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 3/7 spi/pl022: skip default configuration before suspending

From: Virupax Sadashivpetimath <[email protected]>

The loading of the default configuration before suspending has been in the driver since its inception, but it is not really needed. Especially so since we take to all the trouble of enabling and disabling power and clock just to do this. Let's scrap this now.

---
ChangeLog v1->v2:
- Use local dev pointer instead of copy/paste bug &adev->dev

---
 drivers/spi/spi-pl022.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
drivers/spi/spi-pl022.c +0 -5
index 0d0b165..b4038f9 100644
@@ -2310,11 +2310,6 @@ static int pl022_suspend(struct device *dev)
 		return status;
 	}
 
-	amba_vcore_enable(pl022->adev);
-	amba_pclk_enable(pl022->adev);
-	load_ssp_default_config(pl022);
-	amba_pclk_disable(pl022->adev);
-	amba_vcore_disable(pl022->adev);
 	dev_dbg(dev, "suspended\n");
 	return 0;
 }
Signature · 1 line
1.7.3.2
#1 lore raw

PATCH 3/7 spi/pl022: skip default configuration before suspending

Quoted 23 lines · Linus WALLEIJ

From: Virupax Sadashivpetimath <[email protected]>

The loading of the default configuration before suspending has been in the driver since its inception, but it is not really needed. Especially so since we take to all the trouble of enabling and disabling power and clock just to do this. Let's scrap this now.

---
ChangeLog v1->v2:
- Use local dev pointer instead of copy/paste bug &adev->dev

---
 drivers/spi/spi-pl022.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
drivers/spi/spi-pl022.c +0 -0
index 0d0b165..b4038f9 100644
@@ -2310,11 +2310,6 @@ static int pl022_suspend(struct device *dev)
 		return status;

drivers/spi/spi-pl022.c static int pl022_suspend(struct device *dev) · line 2315

Quoted 10 lines
drivers/spi/spi-pl022.c +0 -5
 	}
 
-	amba_vcore_enable(pl022->adev);
-	amba_pclk_enable(pl022->adev);
-	load_ssp_default_config(pl022);
-	amba_pclk_disable(pl022->adev);
-	amba_vcore_disable(pl022->adev);
 	dev_dbg(dev, "suspended\n");
 	return 0;
 }
Signature · 1 line
viresh