Skip to contentSkip to conversation

RFC: Rename iio_{allocate,free}_device to iio_device_{alloc,free}

DISCUSSION Lars-Peter Clausen 2 participants 2 messages Nov 22, 2011 IIO

lore
Share & tools
lore
#0 lore raw

Currently we have two pairs of functions which respectively are used to allocate/register and unregister/free a iio devices. The first pair is iio_allocate_device, iio_device_register and the second pair is iio_device_unregister, iio_free_device. So what can be seen is, that there is a bit of inconsistency here as to where to put the "device" in the function name.

So in order to streamline the API I propose to rename iio_free_device to iio_device_free and iio_allocate_device to iio_device_alloc (alloc instead of allocate to be more in sync with other in kernel APIs e.g. platform_device_alloc).

If nobody sees any problems or has any objections I'll send a patch.

- Lars

maintainer
#1 lore raw
Quoted 7 lines · Lars-Peter Clausen

Currently we have two pairs of functions which respectively are used to allocate/register and unregister/free a iio devices. The first pair is iio_allocate_device, iio_device_register and the second pair is iio_device_unregister, iio_free_device. So what can be seen is, that there is a bit of inconsistency here as to where to put the "device" in the function name.

Quoted 6 lines

So in order to streamline the API I propose to rename iio_free_device to iio_device_free and iio_allocate_device to iio_device_alloc (alloc instead of allocate to be more in sync with other in kernel APIs e.g. platform_device_alloc).

If nobody sees any problems or has any objections I'll send a patch.

Other than the allocate->alloc change I've already done the equivalent for the outofstaging tree (having noted the same thing whilst cleaning that up!). The alloc change makes sense so I'll drive it it there as well at some point. Will obviously have to update the namespace move patches but that's fine. I can't do those namespace patches until staging-next gets updated anyway so can easily make them dependent on what you do.

Jonathan

Quoted 6 lines

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html