Skip to contentSkip to conversation

busybox: update to 1.19.3

PATCH Superseded Anders Darander 4 participants 12 messages Nov 22, 2011 – Nov 29, 2011

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover busybox: update to 1.19.3

This updates busybox to the latest stable, 1.19.3.

Among other things, there should be rudimentary support in syslogd for systemd, by enabling CONFIG_FEATURE_SYSTEMD.

It has been tested and verified on qemux86 and on our local arm-based system.

However, the patch busybox-udhcpc-no_deconfig.patch has been modified to apply, but hasn't really been tested. As we're currently mostly running static configurations, we've only verified that udhcpc works to the extent that we get the network up and running, not how it behaves during dhcp renewal. Thus I'm starting this as an RFC.

Changes:
v2: * Checked the new defconfig (removed settings implying CFLAGS and
ARCH). The new defconfig should be as close as possible to the old one, with the exception of some new utils/options.
* Added one patch from upstream, to safeguard the use of CBAUD termios_init().
* The other upstream patch from http://busybox.net/downloads/fixes-1.19.3/
do only affect comments, thus I'm not adding it.

The following changes since commit dd2fdf9f5a3923c37e4ea2e46e347bb0657c2f5b:

gcc-4.6: Fix gcc ICE on qt4-x11-free/armv7-a (2011-11-21 16:55:01 +0000)

are available in the git repository at:
git://github.com/darander/oe-core busybox-systemd
https://github.com/darander/oe-core/tree/busybox-systemd

Anders Darander (1):
busybox: update to 1.19.3

 .../B921600.patch                                  |    0
 .../busybox-1.19.3/busybox-1.19.3-getty.patch      |   17 ++
 .../busybox-appletlib-dependency.patch             |    0
 .../busybox-udhcpc-no_deconfig.patch               |   66 +++--
 .../{busybox-1.18.5 => busybox-1.19.3}/defconfig   |  265 +++++++++++++-------
 .../get_header_tar.patch                           |    0
 .../run-parts.in.usr-bin.patch                     |   16 +-
 .../udhcpc-fix-nfsroot.patch                       |    0
 .../udhcpscript.patch                              |    0
 .../{busybox_1.18.5.bb => busybox_1.19.3.bb}       |    7 +-
 10 files changed, 245 insertions(+), 126 deletions(-)
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/B921600.patch (100%)
 create mode 100644 meta/recipes-core/busybox/busybox-1.19.3/busybox-1.19.3-getty.patch
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/busybox-appletlib-dependency.patch (100%)
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/busybox-udhcpc-no_deconfig.patch (62%)
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/defconfig (89%)
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/get_header_tar.patch (100%)
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/run-parts.in.usr-bin.patch (64%)
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/udhcpc-fix-nfsroot.patch (100%)
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/udhcpscript.patch (100%)
 rename meta/recipes-core/busybox/{busybox_1.18.5.bb => busybox_1.19.3.bb} (82%)
Signature · 1 line
1.7.7.3
#1 lore raw

PATCH v2 1/1 busybox: update to 1.19.3

The updates to patch busybox-udhcpc-no_deconfig.patch is not fully verified.

Adds one upstream patch to 1.19.3.

---
 .../B921600.patch                                  |    0
 .../busybox-1.19.3/busybox-1.19.3-getty.patch      |   17 ++
 .../busybox-appletlib-dependency.patch             |    0
 .../busybox-udhcpc-no_deconfig.patch               |   66 +++--
 .../{busybox-1.18.5 => busybox-1.19.3}/defconfig   |  265 +++++++++++++-------
 .../get_header_tar.patch                           |    0
 .../run-parts.in.usr-bin.patch                     |   16 +-
 .../udhcpc-fix-nfsroot.patch                       |    0
 .../udhcpscript.patch                              |    0
 .../{busybox_1.18.5.bb => busybox_1.19.3.bb}       |    7 +-
 10 files changed, 245 insertions(+), 126 deletions(-)
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/B921600.patch (100%)
 create mode 100644 meta/recipes-core/busybox/busybox-1.19.3/busybox-1.19.3-getty.patch
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/busybox-appletlib-dependency.patch (100%)
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/busybox-udhcpc-no_deconfig.patch (62%)
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/defconfig (89%)
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/get_header_tar.patch (100%)
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/run-parts.in.usr-bin.patch (64%)
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/udhcpc-fix-nfsroot.patch (100%)
 rename meta/recipes-core/busybox/{busybox-1.18.5 => busybox-1.19.3}/udhcpscript.patch (100%)
 rename meta/recipes-core/busybox/{busybox_1.18.5.bb => busybox_1.19.3.bb} (82%)
meta/recipes-core/busybox/busybox-1.19.3/B921600.patch renamed from meta/recipes-core/busybox/busybox-1.18.5/B921600.patch +0 -0
similarity index 100%
rename from meta/recipes-core/busybox/busybox-1.18.5/B921600.patch
rename to meta/recipes-core/busybox/busybox-1.19.3/B921600.patch
meta/recipes-core/busybox/busybox-1.19.3/busybox-1.19.3-getty.patch new file +17 -0
new file mode 100644
index 0000000..137d095
@@ -0,0 +1,17 @@
+Upstream-status: Backport
+
+Patch is taken from upstream 
+http://busybox.net/downloads/fixes-1.19.3/busybox-1.19.3-getty.patch
+
+--- busybox-1.19.3/loginutils/getty.c
++++ busybox-1.19.3-getty/loginutils/getty.c
+@@ -271,7 +271,9 @@ static void termios_init(int speed)
+ #ifdef CMSPAR
+ 		| CMSPAR  /* mark or space parity */
+ #endif
++#ifdef CBAUD
+ 		| CBAUD   /* (output) baud rate */
++#endif
+ #ifdef CBAUDEX
+ 		| CBAUDEX /* (output) baud rate */
+ #endif
meta/recipes-core/busybox/busybox-1.19.3/busybox-appletlib-dependency.patch renamed from meta/recipes-core/busybox/busybox-1.18.5/busybox-appletlib-dependency.patch +0 -0
similarity index 100%
rename from meta/recipes-core/busybox/busybox-1.18.5/busybox-appletlib-dependency.patch
rename to meta/recipes-core/busybox/busybox-1.19.3/busybox-appletlib-dependency.patch
meta/recipes-core/busybox/busybox-1.19.3/busybox-udhcpc-no_deconfig.patch renamed from meta/recipes-core/busybox/busybox-1.18.5/busybox-udhcpc-no_deconfig.patch +41 -25

127 lines not on this page · raw message

meta/recipes-core/busybox/busybox-1.19.3/defconfig renamed from meta/recipes-core/busybox/busybox-1.18.5/defconfig +175 -90

613 lines not on this page · raw message

meta/recipes-core/busybox/busybox-1.19.3/get_header_tar.patch renamed from meta/recipes-core/busybox/busybox-1.18.5/get_header_tar.patch +0 -0
similarity index 100%
rename from meta/recipes-core/busybox/busybox-1.18.5/get_header_tar.patch
rename to meta/recipes-core/busybox/busybox-1.19.3/get_header_tar.patch
meta/recipes-core/busybox/busybox-1.19.3/run-parts.in.usr-bin.patch renamed from meta/recipes-core/busybox/busybox-1.18.5/run-parts.in.usr-bin.patch +8 -8
similarity index 64%
rename from meta/recipes-core/busybox/busybox-1.18.5/run-parts.in.usr-bin.patch
rename to meta/recipes-core/busybox/busybox-1.19.3/run-parts.in.usr-bin.patch
index 7d532e6..1fe20d4 100644
@@ -19,11 +19,11 @@ diff -uNr busybox-1.15.3.orig//include/applets.src.h busybox-1.15.3/include/appl
 --- busybox-1.15.3.orig//include/applets.src.h	2009-12-12 22:13:28.000000000 +0100
 +++ busybox-1.15.3/include/applets.src.h	2010-04-30 15:35:40.000000000 +0200
 @@ -323,7 +323,7 @@
- IF_RPM(APPLET(rpm, _BB_DIR_BIN, _BB_SUID_DROP))
- IF_RPM2CPIO(APPLET(rpm2cpio, _BB_DIR_USR_BIN, _BB_SUID_DROP))
- IF_RTCWAKE(APPLET(rtcwake, _BB_DIR_USR_BIN, _BB_SUID_DROP))
--IF_RUN_PARTS(APPLET_ODDNAME(run-parts, run_parts, _BB_DIR_BIN, _BB_SUID_DROP, run_parts))
-+IF_RUN_PARTS(APPLET_ODDNAME(run-parts, run_parts, _BB_DIR_USR_BIN, _BB_SUID_DROP, run_parts))
- IF_RUNCON(APPLET(runcon, _BB_DIR_USR_BIN, _BB_SUID_DROP))
- IF_RUNLEVEL(APPLET(runlevel, _BB_DIR_SBIN, _BB_SUID_DROP))
- IF_RUNSV(APPLET(runsv, _BB_DIR_USR_BIN, _BB_SUID_DROP))
+ IF_RPM(APPLET(rpm, BB_DIR_BIN, BB_SUID_DROP))
+ IF_RPM2CPIO(APPLET(rpm2cpio, BB_DIR_USR_BIN, BB_SUID_DROP))
+ IF_RTCWAKE(APPLET(rtcwake, BB_DIR_USR_BIN, BB_SUID_DROP))
+-IF_RUN_PARTS(APPLET_ODDNAME(run-parts, run_parts, BB_DIR_BIN, BB_SUID_DROP, run_parts))
++IF_RUN_PARTS(APPLET_ODDNAME(run-parts, run_parts, BB_DIR_USR_BIN, BB_SUID_DROP, run_parts))
+ IF_RUNCON(APPLET(runcon, BB_DIR_USR_BIN, BB_SUID_DROP))
+ IF_RUNLEVEL(APPLET(runlevel, BB_DIR_SBIN, BB_SUID_DROP))
+ IF_RUNSV(APPLET(runsv, BB_DIR_USR_BIN, _BB_SUID_DROP))
meta/recipes-core/busybox/busybox-1.19.3/udhcpc-fix-nfsroot.patch renamed from meta/recipes-core/busybox/busybox-1.18.5/udhcpc-fix-nfsroot.patch +0 -0
similarity index 100%
rename from meta/recipes-core/busybox/busybox-1.18.5/udhcpc-fix-nfsroot.patch
rename to meta/recipes-core/busybox/busybox-1.19.3/udhcpc-fix-nfsroot.patch
meta/recipes-core/busybox/busybox-1.19.3/udhcpscript.patch renamed from meta/recipes-core/busybox/busybox-1.18.5/udhcpscript.patch +0 -0
similarity index 100%
rename from meta/recipes-core/busybox/busybox-1.18.5/udhcpscript.patch
rename to meta/recipes-core/busybox/busybox-1.19.3/udhcpscript.patch
meta/recipes-core/busybox/busybox_1.19.3.bb renamed from meta/recipes-core/busybox/busybox_1.18.5.bb +4 -3
similarity index 82%
rename from meta/recipes-core/busybox/busybox_1.18.5.bb
rename to meta/recipes-core/busybox/busybox_1.19.3.bb
index 17d583e..7a54789 100644
@@ -1,5 +1,5 @@
 require busybox.inc
-PR = "r2"
+PR = "r0"
 
 SRC_URI = "http://www.busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \
            file://udhcpscript.patch \
@@ -7,6 +7,7 @@ SRC_URI = "http://www.busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \
            file://B921600.patch \
            file://get_header_tar.patch \
            file://busybox-appletlib-dependency.patch \
+           file://busybox-1.19.3-getty.patch \
            file://run-parts.in.usr-bin.patch \
            file://busybox-udhcpc-no_deconfig.patch \
            file://find-touchscreen.sh \
@@ -25,7 +26,7 @@ SRC_URI = "http://www.busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \
            file://umount.busybox \
            file://defconfig"
 
-SRC_URI[tarball.md5sum] = "96dd43cc7cee4017a6bf31b7da82a1f5"
-SRC_URI[tarball.sha256sum] = "10954fcd5c48d8a262a3497b16227bf983a05658bf2bf661af2fdeca773f2fc0"
+SRC_URI[tarball.md5sum] = "c3938e1ac59602387009bbf1dd1af7f6"
+SRC_URI[tarball.sha256sum] = "a1a9a35732c719ef384f02b6e357c324d8be25bc154af91a48c4264b1e6038f0"
 
 EXTRA_OEMAKE += "V=1 ARCH=${TARGET_ARCH} CROSS_COMPILE=${TARGET_PREFIX} SKIP_STRIP=y"
Signature · 1 line
1.7.7.3
#2 lore raw
In reply to Anders Darander
Quoted 5 lines · Anders Darander

This updates busybox to the latest stable, 1.19.3.

Among other things, there should be rudimentary support in syslogd for systemd, by enabling CONFIG_FEATURE_SYSTEMD.

How much size does this add to busybox by having it enabled by default?
Is it possible to conditional add a config fragment if systemd is enabled ad the DISTRO/IMAGE_FEATURE level?

More info is required.

Quoted 8 lines

It has been tested and verified on qemux86 and on our local arm-based system.

However, the patch busybox-udhcpc-no_deconfig.patch has been modified to apply, but hasn't really been tested. As we're currently mostly running static configurations, we've only verified that udhcpc works to the extent that we get the network up and running, not how it behaves during dhcp renewal. Thus I'm starting this as an RFC.

Quoted 4 lines

Changes:
v2: * Checked the new defconfig (removed settings implying CFLAGS and
ARCH). The new defconfig should be as close as possible to the old one, with the exception of some new utils/options.

Can you clearly enumerate what new utils and options and what their size impact on the busybox image is.

Thanks
Sau!

Quoted 38 lines

* Added one patch from upstream, to safeguard the use of CBAUD termios_init().
* The other upstream patch from http://busybox.net/downloads/fixes-1.19.3/
do only affect comments, thus I'm not adding it.

The following changes since commit dd2fdf9f5a3923c37e4ea2e46e347bb0657c2f5b:

   gcc-4.6: Fix gcc ICE on qt4-x11-free/armv7-a (2011-11-21 16:55:01 +0000)

are available in the git repository at:
git://github.com/darander/oe-core busybox-systemd
https://github.com/darander/oe-core/tree/busybox-systemd

Anders Darander (1):

   busybox: update to 1.19.3
  .../B921600.patch                                  |    0
  .../busybox-1.19.3/busybox-1.19.3-getty.patch      |   17 ++
  .../busybox-appletlib-dependency.patch             |    0
  .../busybox-udhcpc-no_deconfig.patch               |   66 +++--
  .../{busybox-1.18.5 =>  busybox-1.19.3}/defconfig   |  265 +++++++++++++-------
  .../get_header_tar.patch                           |    0
  .../run-parts.in.usr-bin.patch                     |   16 +-
  .../udhcpc-fix-nfsroot.patch                       |    0
  .../udhcpscript.patch                              |    0
  .../{busybox_1.18.5.bb =>  busybox_1.19.3.bb}       |    7 +-
  10 files changed, 245 insertions(+), 126 deletions(-)
  rename meta/recipes-core/busybox/{busybox-1.18.5 =>  busybox-1.19.3}/B921600.patch (100%)
  create mode 100644 meta/recipes-core/busybox/busybox-1.19.3/busybox-1.19.3-getty.patch
  rename meta/recipes-core/busybox/{busybox-1.18.5 =>  busybox-1.19.3}/busybox-appletlib-dependency.patch (100%)
  rename meta/recipes-core/busybox/{busybox-1.18.5 =>  busybox-1.19.3}/busybox-udhcpc-no_deconfig.patch (62%)
  rename meta/recipes-core/busybox/{busybox-1.18.5 =>  busybox-1.19.3}/defconfig (89%)
  rename meta/recipes-core/busybox/{busybox-1.18.5 =>  busybox-1.19.3}/get_header_tar.patch (100%)
  rename meta/recipes-core/busybox/{busybox-1.18.5 =>  busybox-1.19.3}/run-parts.in.usr-bin.patch (64%)
  rename meta/recipes-core/busybox/{busybox-1.18.5 =>  busybox-1.19.3}/udhcpc-fix-nfsroot.patch (100%)
  rename meta/recipes-core/busybox/{busybox-1.18.5 =>  busybox-1.19.3}/udhcpscript.patch (100%)

rename meta/recipes-core/busybox/{busybox_1.18.5.bb => busybox_1.19.3.bb} (82%)

#3 lore raw
Quoted 9 lines · Saul Wold
Quoted 5 lines · Anders Darander

This updates busybox to the latest stable, 1.19.3.

Among other things, there should be rudimentary support in syslogd for systemd, by enabling CONFIG_FEATURE_SYSTEMD.

How much size does this add to busybox by having it enabled by default? Is it possible to conditional add a config fragment if systemd is enabled ad the DISTRO/IMAGE_FEATURE level?

I'd love that. Any suggestions for a distro/image feature? As far as I know, we don't have any for init system selection.

I let the rather small systemd feature be enabled as we already package systemd unit files for a number of packages, and we also add --with-systemddir during configure or a number of packages. If we add a distro/image feature, we should(?) conditionally ship SysV init files also, or package them separately. (Although that is for another discussion...)

Quoted 10 lines

More info is required.

Quoted 8 lines

It has been tested and verified on qemux86 and on our local arm-based system.

However, the patch busybox-udhcpc-no_deconfig.patch has been modified to apply, but hasn't really been tested. As we're currently mostly running static configurations, we've only verified that udhcpc works to the extent that we get the network up and running, not how it behaves during dhcp renewal. Thus I'm starting this as an RFC.

Quoted 6 lines
Quoted 4 lines

Changes:
v2: * Checked the new defconfig (removed settings implying CFLAGS and
ARCH). The new defconfig should be as close as possible to the old one, with the exception of some new utils/options.

Can you clearly enumerate what new utils and options and what their size impact on the busybox image is.

Sure, I'll come bak with a list, primarily focusing on any new features activated (most is deactivated though), although it could take a little time. Too much other things to handle...

Cheers,
/Anders

#4 lore raw
In reply to Saul Wold
Quoted 7 lines · Saul Wold
Quoted 4 lines · Anders Darander

This updates busybox to the latest stable, 1.19.3.

Among other things, there should be rudimentary support in syslogd for systemd, by enabling CONFIG_FEATURE_SYSTEMD.

How much size does this add to busybox by having it enabled by default?

Enabling FEATURE_SYSTEMD in busybox costs 192 bytes in my tests in qemux86.

Quoted 13 lines

Is it possible to conditional add a config fragment if systemd is enabled ad the DISTRO/IMAGE_FEATURE level?

More info is required.

Quoted 7 lines

It has been tested and verified on qemux86 and on our local arm-based system.

However, the patch busybox-udhcpc-no_deconfig.patch has been modified to apply, but hasn't really been tested. As we're currently mostly running static configurations, we've only verified that udhcpc works to the extent that we get the network up and running, not how it behaves during dhcp renewal. Thus I'm starting this as an RFC.

Quoted 6 lines
Quoted 4 lines

Changes:
v2: * Checked the new defconfig (removed settings implying CFLAGS and
ARCH). The new defconfig should be as close as possible to the old one, with the exception of some new utils/options.

Can you clearly enumerate what new utils and options and what their size impact on the busybox image is.

Apart from the FEATURE_SYSTEMD discussed above, these are the other new options that I kept the new busybox default on (i.e. these are enabled, while I turned of quite a few other options that automatically got enabled). All costs are evaluted using qemux86, and the busybox binary size is checked in the packages-split/busybox/bin directory.

I don't mind disabling any of these feature in a v3, if desired/requested. Anyway, I'm running a completely custom config for my normal uses...

FEATURE_RTMINMAX, support RTMIN[+n] RTMAX[-n] signals, claimed to cost ~250 bytes

FEATURE_REVERSE_SEARCH claimed to cost ~0.5k

FEATURE_SKIP_ROOTFS ignore rootfs entry in mount table (tools like df etc will ignore it).

FEATURE_AR_CREATE, enable ar to create files, ~2.5k

FEATURE_SEAMLESS_XZ enable xz compression in tar, no measured cost.

XZ and UNXZ, enable xz compression, 8k

FGCONSOLE, print active console number, 128 bytes

FEATURE_LOADFONT_PSF2, FEATURE_LOADFONT_RAW, cost 576 bytes

FEATURE_VI_ASK_TERMINAL, last resort to find terminal size, 352 bytes

BLOCKDEV, perform some ioctls with block devices, cost 480 bytes

FDISK_SUPPORT_LARGE_DISKS, is disabled, it no longer wants to play with LFS (both were enabled previously).

FEATURE_MOUNT_LOOP_CREATE, create new loopback devices if needed, couldn't see any cost

FEATURE_WGET_TIMEOUT, no visible cost

FEATURE_SH_HISTFILESIZE, use $HISTFILESIZE (still max limited by config), no visible cost

FEATURE_SYSLOGD_CFG, support syslog.conf, no visible cost

FEATURE_SYSLOGD_READ_BUFFER_SIZE, defines the size of the read buffer, not measured

FEATURE_KLOGD_KLOGCTL, let klogd use the klogctl() interface, no visible cost

Cheers,
Anders

Signature · 2 lines
Anders Darander
ChargeStorm AB / eStorm AB
#5 lore raw
Quoted 38 lines · Anders Darander
Quoted 7 lines · Saul Wold
Quoted 4 lines · Anders Darander

This updates busybox to the latest stable, 1.19.3.

Among other things, there should be rudimentary support in syslogd for systemd, by enabling CONFIG_FEATURE_SYSTEMD.

How much size does this add to busybox by having it enabled by default?

Enabling FEATURE_SYSTEMD in busybox costs 192 bytes in my tests in qemux86.

Quoted 13 lines

Is it possible to conditional add a config fragment if systemd is enabled ad the DISTRO/IMAGE_FEATURE level?

More info is required.

Quoted 7 lines

It has been tested and verified on qemux86 and on our local arm-based system.

However, the patch busybox-udhcpc-no_deconfig.patch has been modified to apply, but hasn't really been tested. As we're currently mostly running static configurations, we've only verified that udhcpc works to the extent that we get the network up and running, not how it behaves during dhcp renewal. Thus I'm starting this as an RFC.

Quoted 6 lines
Quoted 4 lines

Changes:
v2: * Checked the new defconfig (removed settings implying CFLAGS and
ARCH). The new defconfig should be as close as possible to the old one, with the exception of some new utils/options.

Can you clearly enumerate what new utils and options and what their size impact on the busybox image is.

Apart from the FEATURE_SYSTEMD discussed above, these are the other new options that I kept the new busybox default on (i.e. these are enabled, while I turned of quite a few other options that automatically got enabled). All costs are evaluted using qemux86, and the busybox binary size is checked in the packages-split/busybox/bin directory.

Quoted 7 lines

I don't mind disabling any of these feature in a v3, if desired/requested. Anyway, I'm running a completely custom config for my normal uses...

FEATURE_RTMINMAX, support RTMIN[+n] RTMAX[-n] signals, claimed to cost ~250 bytes

I can see these being useful

Quoted 2 lines

FEATURE_REVERSE_SEARCH claimed to cost ~0.5k

Why is this needed?

Quoted 3 lines

FEATURE_SKIP_ROOTFS ignore rootfs entry in mount table (tools like df etc will ignore it).

OK

Quoted 6 lines

FEATURE_AR_CREATE, enable ar to create files, ~2.5k

FEATURE_SEAMLESS_XZ enable xz compression in tar, no measured cost.

XZ and UNXZ, enable xz compression, 8k

This is the one and the ar create above that sticks out, are these needed in the general case or just for your config?

Quoted 4 lines

FGCONSOLE, print active console number, 128 bytes

FEATURE_LOADFONT_PSF2, FEATURE_LOADFONT_RAW, cost 576 bytes

Seems resonable, but why did we not need this before, what changed?

Quoted 2 lines

FEATURE_VI_ASK_TERMINAL, last resort to find terminal size, 352 bytes

Not sure about this and the FGCONSOLE above.

Quoted 2 lines

BLOCKDEV, perform some ioctls with block devices, cost 480 bytes

Again is this useful in the general case?

Quoted 3 lines

FDISK_SUPPORT_LARGE_DISKS, is disabled, it no longer wants to play with LFS (both were enabled previously).

OK

Quoted 3 lines

FEATURE_MOUNT_LOOP_CREATE, create new loopback devices if needed, couldn't see any cost

OK

Quoted 2 lines

FEATURE_WGET_TIMEOUT, no visible cost

OK

Quoted 3 lines

FEATURE_SH_HISTFILESIZE, use $HISTFILESIZE (still max limited by config), no visible cost

OK

Quoted 2 lines

FEATURE_SYSLOGD_CFG, support syslog.conf, no visible cost

OK

Quoted 3 lines

FEATURE_SYSLOGD_READ_BUFFER_SIZE, defines the size of the read buffer, not measured

OK

Quoted 2 lines

FEATURE_KLOGD_KLOGCTL, let klogd use the klogctl() interface, no visible cost

OK

Quoted 4 lines

Cheers,
Anders

#6 lore raw
Quoted 10 lines · Saul Wold
Quoted 8 lines · Anders Darander
Quoted 7 lines · Saul Wold
Quoted 4 lines · Anders Darander

This updates busybox to the latest stable, 1.19.3.

Among other things, there should be rudimentary support in syslogd for systemd, by enabling CONFIG_FEATURE_SYSTEMD.

How much size does this add to busybox by having it enabled by default?

Quoted 7 lines
Quoted 7 lines

Enabling FEATURE_SYSTEMD in busybox costs 192 bytes in my tests in qemux86.

Quoted 4 lines

Is it possible to conditional add a config fragment if systemd is enabled ad the DISTRO/IMAGE_FEATURE level?

More info is required.

Any more comment on this one? Otavio replied earlier that if it was a small cost, he would prefer to have it on by default. Otherwise, any suggestions for DISTRO/IMAGE_FEATURE?

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines

Changes:
v2: * Checked the new defconfig (removed settings implying CFLAGS and
ARCH). The new defconfig should be as close as possible to the old one, with the exception of some new utils/options.

Can you clearly enumerate what new utils and options and what their size impact on the busybox image is.

I'll remove all features that you didn't OK (see below), unless we get some more replies/wishes in the next day. (Thus I plan to send a v3 this week, if times allow it).

Just to clarify it once more, the choice of which new features to enable was done by trying to judge if they were reasonable, or seemed helpfull/usefull enough. I'm not normally running with the defconfig (apart from testing this patch), I'm using a heavily customized and often minimized defconfig.

Quoted 10 lines
Quoted 9 lines

Apart from the FEATURE_SYSTEMD discussed above, these are the other new options that I kept the new busybox default on (i.e. these are enabled, while I turned of quite a few other options that automatically got enabled). All costs are evaluted using qemux86, and the busybox binary size is checked in the packages-split/busybox/bin directory.

I don't mind disabling any of these feature in a v3, if desired/requested. Anyway, I'm running a completely custom config for my normal uses...

Quoted 8 lines
Quoted 2 lines

FEATURE_RTMINMAX, support RTMIN[+n] RTMAX[-n] signals, claimed to cost ~250 bytes

I can see these being useful

Quoted 1 line

FEATURE_REVERSE_SEARCH claimed to cost ~0.5k

Why is this needed?

Not needed, just nice to have. But I'll remove it in v3.

Quoted 8 lines
Quoted 5 lines

FEATURE_AR_CREATE, enable ar to create files, ~2.5k

FEATURE_SEAMLESS_XZ enable xz compression in tar, no measured cost.

XZ and UNXZ, enable xz compression, 8k

This is the one and the ar create above that sticks out, are these needed in the general case or just vfor your config?

Shouldn't be needed. I just left it enabled as all other FEATURE_SEAMLESS's was enabled. I'll disable these two in v3.

Quoted 5 lines
Quoted 3 lines

FGCONSOLE, print active console number, 128 bytes

FEATURE_LOADFONT_PSF2, FEATURE_LOADFONT_RAW, cost 576 bytes

Seems resonable, but why did we not need this before, what changed?

Not really sure what the change is (normally I'm only working on headless systems, thus no need for fonts). The two FEATURE_LOADFONT_* options were not available in the old defconfig. I'll leave these two in v3, as you thought the seemd reasonable.

Quoted 3 lines
Quoted 1 line

FEATURE_VI_ASK_TERMINAL, last resort to find terminal size, 352 bytes

Not sure about this and the FGCONSOLE above.

Sure, I'll remove these two.

Quoted 3 lines
Quoted 1 line

BLOCKDEV, perform some ioctls with block devices, cost 480 bytes

Again is this useful in the general case?

Same as previously, an arbitrary choice. I'll remove it in v3.

Signature · 2 lines
Anders Darander
ChargeStorm AB / eStorm AB
#7 lore raw
Quoted 3 lines · Anders Darander

Any more comment on this one? Otavio replied earlier that if it was a small cost, he would prefer to have it on by default. Otherwise, any suggestions for DISTRO/IMAGE_FEATURE?

We've talked about this a few times in the past and it's never seemed as though this would buy much in relation to busybox. The busybox configuration is so highly specific that each DISTRO is probably going to end up wanting its own custom configuration file and it isn't obvious that there is going to be much/any commonality between them. That being the case it seems as though it's easier for the distros to actually ship the config files themselves, rather than try to translate every conceivable option into PACKAGE_CONFIG and then express them that way.

I guess the other thing that naturally follows from this is that there probably aren't very many people using the actual defconfig that oe-core provides, and hence it probably doesn't matter all that much what is and isn't enabled in it. Enabling FEATURE_SYSTEMD seems like a reasonable idea if there is already the mechanism in oe-core to make use of it, but probably just a waste of space otherwise.

p.

#8 lore raw
In reply to Anders Darander
Quoted 14 lines · Anders Darander
Quoted 12 lines · Saul Wold
Quoted 11 lines · Anders Darander
Quoted 7 lines · Saul Wold
Quoted 4 lines · Anders Darander

This updates busybox to the latest stable, 1.19.3.

Among other things, there should be rudimentary support in syslogd for systemd, by enabling CONFIG_FEATURE_SYSTEMD.

How much size does this add to busybox by having it enabled by default?

Enabling FEATURE_SYSTEMD in busybox costs 192 bytes in my tests in qemux86.

Quoted 9 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Is it possible to conditional add a config fragment if systemd is enabled ad the DISTRO/IMAGE_FEATURE level?

More info is required.

Any more comment on this one? Otavio replied earlier that if it was a small cost, he would prefer to have it on by default. Otherwise, any suggestions for DISTRO/IMAGE_FEATURE?

Sorry for not being clear on this on, yes to the SYSTEMD change, it's small enough and something we are considering. As Phil points out in the follow-up to this, most are using custom defconfig's that we should just go ahead and enable this for future flexibility.

Quoted 52 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines

Changes:
v2: * Checked the new defconfig (removed settings implying CFLAGS and
ARCH). The new defconfig should be as close as possible to the old one, with the exception of some new utils/options.

Can you clearly enumerate what new utils and options and what their size impact on the busybox image is.

I'll remove all features that you didn't OK (see below), unless we get some more replies/wishes in the next day. (Thus I plan to send a v3 this week, if times allow it).

Just to clarify it once more, the choice of which new features to enable was done by trying to judge if they were reasonable, or seemed helpfull/usefull enough. I'm not normally running with the defconfig (apart from testing this patch), I'm using a heavily customized and often minimized defconfig.

Quoted 10 lines
Quoted 9 lines

Apart from the FEATURE_SYSTEMD discussed above, these are the other new options that I kept the new busybox default on (i.e. these are enabled, while I turned of quite a few other options that automatically got enabled). All costs are evaluted using qemux86, and the busybox binary size is checked in the packages-split/busybox/bin directory.

I don't mind disabling any of these feature in a v3, if desired/requested. Anyway, I'm running a completely custom config for my normal uses...

Quoted 8 lines
Quoted 2 lines

FEATURE_RTMINMAX, support RTMIN[+n] RTMAX[-n] signals, claimed to cost ~250 bytes

I can see these being useful

Quoted 1 line

FEATURE_REVERSE_SEARCH claimed to cost ~0.5k

Why is this needed?

Not needed, just nice to have. But I'll remove it in v3.

Quoted 8 lines
Quoted 5 lines

FEATURE_AR_CREATE, enable ar to create files, ~2.5k

FEATURE_SEAMLESS_XZ enable xz compression in tar, no measured cost.

XZ and UNXZ, enable xz compression, 8k

This is the one and the ar create above that sticks out, are these needed in the general case or just vfor your config?

Shouldn't be needed. I just left it enabled as all other FEATURE_SEAMLESS's was enabled. I'll disable these two in v3.

Quoted 1 line
Quoted 1 line

FGCONSOLE, print active console number, 128 bytes

Quoted 9 lines
Quoted 3 lines
Quoted 1 line

FEATURE_LOADFONT_PSF2, FEATURE_LOADFONT_RAW, cost 576 bytes

Seems resonable, but why did we not need this before, what changed?

Not really sure what the change is (normally I'm only working on headless systems, thus no need for fonts). The two FEATURE_LOADFONT_* options were not available in the old defconfig. I'll leave these two in v3, as you thought the seemd reasonable.

For minimal, it's good to assume headless, then we should not need the LOADFONT. I thought it was needed for headless as well.

Quoted 4 lines
Quoted 3 lines
Quoted 1 line

FEATURE_VI_ASK_TERMINAL, last resort to find terminal size, 352 bytes

Not sure about this and the FGCONSOLE above.

Quoted 9 lines

Sure, I'll remove these two.

Quoted 3 lines
Quoted 1 line

BLOCKDEV, perform some ioctls with block devices, cost 480 bytes

Again is this useful in the general case?

Same as previously, an arbitrary choice. I'll remove it in v3.

Thanks for your efforts.

Sau!

Quoted 1 line
#9 lore raw
Quoted 20 lines · Saul Wold
Quoted 18 lines · Anders Darander
Quoted 17 lines · Saul Wold
Quoted 16 lines · Anders Darander
Quoted 7 lines · Saul Wold
Quoted 4 lines · Anders Darander

This updates busybox to the latest stable, 1.19.3.

Among other things, there should be rudimentary support in syslogd for systemd, by enabling CONFIG_FEATURE_SYSTEMD.

How much size does this add to busybox by having it enabled by default?

Enabling FEATURE_SYSTEMD in busybox costs 192 bytes in my tests in qemux86.

Quoted 4 lines

Is it possible to conditional add a config fragment if systemd is enabled ad the DISTRO/IMAGE_FEATURE level?

More info is required.

Quoted 8 lines
Quoted 3 lines

Any more comment on this one? Otavio replied earlier that if it was a small cost, he would prefer to have it on by default. Otherwise, any suggestions for DISTRO/IMAGE_FEATURE?

Sorry for not being clear on this on, yes to the SYSTEMD change, it's small enough and something we are considering. As Phil points out in the follow-up to this, most are using custom defconfig's that we should just go ahead and enable this for future flexibility.

Thanks!

As we're running systemd, I'm one of those in favour of getting systemd into oe-core, at least now that is hopefully is getting slightly more stable.

And yes, just as Phil points out, we're also running custom defconfigs.

Quoted 14 lines
Quoted 13 lines
Quoted 13 lines
Quoted 11 lines
Quoted 6 lines
Quoted 4 lines

Changes:
v2: * Checked the new defconfig (removed settings implying CFLAGS and
ARCH). The new defconfig should be as close as possible to the old one, with the exception of some new utils/options.

Can you clearly enumerate what new utils and options and what their size impact on the busybox image is.

FGCONSOLE, print active console number, 128 bytes

FEATURE_LOADFONT_PSF2, FEATURE_LOADFONT_RAW, cost 576 bytes

Seems resonable, but why did we not need this before, what changed?

Quoted 7 lines
Quoted 4 lines

Not really sure what the change is (normally I'm only working on headless systems, thus no need for fonts). The two FEATURE_LOADFONT_* options were not available in the old defconfig. I'll leave these two in v3, as you thought the seemd reasonable.

For minimal, it's good to assume headless, then we should not need the LOADFONT. I thought it was needed for headless as well.

Well, there is a risk of getting a few warning when booting, at least if you also disable CONFIG_LOADFONT, unless you look through the boot process. (We're running our system without CONFIG_LOADFONT, hence the other LOADFONT-options becomes moot).

Cheers,
Anders

Signature · 2 lines
Anders Darander
ChargeStorm AB / eStorm AB
#10 lore raw
In reply to Saul Wold
Quoted 11 lines · Saul Wold
Quoted 6 lines · Anders Darander

This updates busybox to the latest stable, 1.19.3.

Among other things, there should be rudimentary support in syslogd for systemd, by enabling CONFIG_FEATURE_SYSTEMD.

How much size does this add to busybox by having it enabled by default?

Is it possible to conditional add a config fragment if systemd is enabled ad the DISTRO/IMAGE_FEATURE level?

If it is small it would be nice to have it enabled.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#11 lore raw
Quoted 6 lines · Otavio Salvador

On Tue, Nov 22, 2011 at 18:36, Saul Wold <[email protected]> wrote:

On 11/22/2011 06:34 AM, Anders Darander wrote:

This updates busybox to the latest stable, 1.19.3.

Quoted 8 lines

Among other things, there should be rudimentary support in syslogd for systemd, by enabling CONFIG_FEATURE_SYSTEMD.

How much size does this add to busybox by having it enabled by default? Is it possible to conditional add a config fragment if systemd is enabled ad the DISTRO/IMAGE_FEATURE level?

If it is small it would be nice to have it enabled.

If I didn't copy my figures wrongly, it's just a couple of hundred bytes. Thus it shouldn't really hurt more than e.g. shipping SysV-init files on a systemd-image...

OTOH, I'll leave it up to you guys to decide on the defconfig, as I'll always use my own custom defconfig.

Cheers,
Anders

Signature · 2 lines
Anders Darander
ChargeStorm AB / eStorm AB