Rework of shutdown policy in inittab
PATCH 1/1 Rework of shutdown policy in inittab
This commit follows commit ad501b66. Start up of the busybox logging daemons were moved to an init script but the shutdown were still performed in inittab. This commit moves the shutdown policy to an rcK script that calls the stop function of all the init scripts in a reversed order.
--- fs/skeleton/etc/init.d/rcK | 27 +++++++++++++++++++++++++++ fs/skeleton/etc/inittab | 3 +-- 2 files changed, 28 insertions(+), 2 deletions(-) create mode 100755 fs/skeleton/etc/init.d/rcK
fs/skeleton/etc/init.d/rcK new file +27 -0
@@ -0,0 +1,27 @@ +#!/bin/sh + + +# Stop all init scripts in /etc/init.d +# executing them in reversed numerical order. +# +for i in $(ls -r /etc/init.d/S??*) ;do + + # Ignore dangling symlinks (if any). + [ ! -f "$i" ] && continue + + case "$i" in + *.sh) + # Source shell script for speed. + ( + trap - INT QUIT TSTP + set stop + . $i + ) + ;; + *) + # No sh extension, so fork subprocess. + $i stop + ;; + esac +done +
fs/skeleton/etc/inittab +1 -2
@@ -30,8 +30,7 @@ null::sysinit:/bin/hostname -F /etc/hostname ::ctrlaltdel:/sbin/reboot # Stuff to do before rebooting -null::shutdown:/usr/bin/killall klogd -null::shutdown:/usr/bin/killall syslogd +null::shutdown:/etc/init.d/rcK null::shutdown:/bin/umount -a -r null::shutdown:/sbin/swapoff -a
Signature · 1 line
1.7.4.1
PATCH 1/1 Rework of shutdown policy in inittab
Ping ?
Quoted 60 lines · Maxime Ripard
This commit follows commit
ad501b66. Start up of the busybox logging daemons were moved to an init script but the shutdown were still performed in inittab. This commit moves the shutdown policy to an rcK script that calls the stop function of all the init scripts in a reversed order.Signed-off-by Maxime Ripard <[email protected]>--- fs/skeleton/etc/init.d/rcK | 27 +++++++++++++++++++++++++++ fs/skeleton/etc/inittab | 3 +-- 2 files changed, 28 insertions(+), 2 deletions(-) create mode 100755 fs/skeleton/etc/init.d/rcKfs/skeleton/etc/init.d/rcK new file +27
-0@@ -0,0 +1,27 @@ +#!/bin/sh + + +# Stop all init scripts in /etc/init.d +# executing them in reversed numerical order. +# +for i in $(ls -r /etc/init.d/S??*) ;do + + # Ignore dangling symlinks (if any). + [ ! -f "$i" ] && continue + + case "$i" in + *.sh) + # Source shell script for speed. + ( + trap - INT QUIT TSTP + set stop + . $i + ) + ;; + *) + # No sh extension, so fork subprocess. + $i stop + ;; + esac +done +fs/skeleton/etc/inittab +1
-2@@ -30,8 +30,7 @@ null::sysinit:/bin/hostname -F /etc/hostname ::ctrlaltdel:/sbin/reboot # Stuff to do before rebooting -null::shutdown:/usr/bin/killall klogd -null::shutdown:/usr/bin/killall syslogd +null::shutdown:/etc/init.d/rcK null::shutdown:/bin/umount -a -r null::shutdown:/sbin/swapoff -a
Signature · 4 lines
Maxime Ripard, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 Rework of shutdown policy in inittab
In reply to Maxime RipardThis policy seems more reasonable.
2011/9/2 Maxime Ripard <[email protected]>
Quoted 68 lines
This commit follows commit
ad501b66. Start up of the busybox logging daemons were moved to an init script but the shutdown were still performed in inittab. This commit moves the shutdown policy to an rcK script that calls the stop function of all the init scripts in a reversed order.Signed-off-by Maxime Ripard <[email protected]>--- fs/skeleton/etc/init.d/rcK | 27 +++++++++++++++++++++++++++ fs/skeleton/etc/inittab | 3 +-- 2 files changed, 28 insertions(+), 2 deletions(-) create mode 100755 fs/skeleton/etc/init.d/rcKfs/skeleton/etc/init.d/rcK new file +27
-0@@ -0,0 +1,27 @@ +#!/bin/sh + + +# Stop all init scripts in /etc/init.d +# executing them in reversed numerical order. +# +for i in $(ls -r /etc/init.d/S??*) ;do + + # Ignore dangling symlinks (if any). + [ ! -f "$i" ] && continue + + case "$i" in + *.sh) + # Source shell script for speed. + ( + trap - INT QUIT TSTP + set stop + . $i + ) + ;; + *) + # No sh extension, so fork subprocess. + $i stop + ;; + esac +done +fs/skeleton/etc/inittab +1
-3@@ -30,8 +30,7 @@ null::sysinit:/bin/hostname -F /etc/hostname ::ctrlaltdel:/sbin/reboot # Stuff to do before rebooting -null::shutdown:/usr/bin/killall klogd -null::shutdown:/usr/bin/killall syslogd +null::shutdown:/etc/init.d/rcK null::shutdown:/bin/umount -a -r null::shutdown:/sbin/swapoff -a --1.7.4.1
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 5 lines
Best Regards! Kelvin -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111207/141e5576/attachment.html>
PATCH 1/1 Rework of shutdown policy in inittab
In reply to Maxime RipardHi,
Quoted 57 lines · Maxime Ripard
This commit follows commit
ad501b66. Start up of the busybox logging daemons were moved to an init script but the shutdown were still performed in inittab. This commit moves the shutdown policy to an rcK script that calls the stop function of all the init scripts in a reversed order.Signed-off-by Maxime Ripard <[email protected]>---
?fs/skeleton/etc/init.d/rcK | ? 27 +++++++++++++++++++++++++++ ?fs/skeleton/etc/inittab ? ?| ? ?3 +--
?2 files changed, 28 insertions(+), 2 deletions(-) ?create mode 100755fs/skeleton/etc/init.d/rcKfs/skeleton/etc/init.d/rcK new file +27
-0@@ -0,0 +1,27 @@ +#!/bin/sh + + +# Stop all init scripts in /etc/init.d +# executing them in reversed numerical order. +# +for i in $(ls -r /etc/init.d/S??*) ;do + + ? ? # Ignore dangling symlinks (if any). + ? ? [ ! -f "$i" ] && continue + + ? ? case "$i" in + ? ? ? *.sh) + ? ? ? ? ? # Source shell script for speed. + ? ? ? ? ? ( + ? ? ? ? ? ? ? trap - INT QUIT TSTP + ? ? ? ? ? ? ? set stop + ? ? ? ? ? ? ? . $i + ? ? ? ? ? ) + ? ? ? ? ? ;; + ? ? ? *) + ? ? ? ? ? # No sh extension, so fork subprocess. + ? ? ? ? ? $i stop + ? ? ? ? ? ;; + ? ?esac +done +fs/skeleton/etc/inittab +0
-0@@ -30,8 +30,7 @@ null::sysinit:/bin/hostname -F /etc/hostname?::ctrlaltdel:/sbin/reboot
?# Stuff to do before rebooting
fs/skeleton/etc/inittab +1
-2-null::shutdown:/usr/bin/killall klogd -null::shutdown:/usr/bin/killall syslogd +null::shutdown:/etc/init.d/rcK
Quoted 2 lines
?null::shutdown:/bin/umount -a -r
?null::shutdown:/sbin/swapoff -a
This is a different behavior now. Before only the logging daemons were killed, now all init scripts are run.
For this to work properly, all init scripts that users have in /etc/init.d should actually have a stop() function. Since this behavior was not required previously, I expect several users not to have this.
For such users, a reboot would suddenly trigger several initializations that are unexpected.
I think there are at least two solutions:
1. Keep the new behavior created with this patch, but make sure that the release notes clearly state this behavior change and update the documentation.
2. Adapt the new behavior: currently you are following /etc/init.d/Sxxxx files/links, while I think that the default policy on many distributions is to use /etc/init.d/Kxxxx for shutdown (and Sxxxx only for startup). In this scenario, users who have custom Sxxx init scripts will not be impacted. Only if they choose to, can they create appropriate Kxxxx links and provide stop functions. For scripts present in the buildroot distribution, we can provide appropriate S and K links immediately.
Best regards,
Thomas
PATCH 1/1 Rework of shutdown policy in inittab
Pherhaps solution 1 is simple and feasible.
Most Sxxxx scripts under dir 'package' provide stop() function currently. And by this policy, the programs/daemons are just what should be killed, which are started at startup.
We do not need to maintain consistency between Sxxxx and Kxxxx.
2011/12/7 Thomas De Schampheleire <[email protected]>
Quoted 95 lines
Hi,
Quoted 51 lines · Maxime Ripard
This commit follows commit
ad501b66. Start up of the busybox logging daemons were moved to an init script but the shutdown were still performed in inittab. This commit moves the shutdown policy to an rcK script that calls the stop function of all the init scripts in a reversed order.Signed-off-by Maxime Ripard <[email protected]>--- fs/skeleton/etc/init.d/rcK | 27 +++++++++++++++++++++++++++ fs/skeleton/etc/inittab | 3 +-- 2 files changed, 28 insertions(+), 2 deletions(-) create mode 100755 fs/skeleton/etc/init.d/rcKfs/skeleton/etc/init.d/rcK new file +27
-0@@ -0,0 +1,27 @@ +#!/bin/sh + + +# Stop all init scripts in /etc/init.d +# executing them in reversed numerical order. +# +for i in $(ls -r /etc/init.d/S??*) ;do + + # Ignore dangling symlinks (if any). + [ ! -f "$i" ] && continue + + case "$i" in + *.sh) + # Source shell script for speed. + ( + trap - INT QUIT TSTP + set stop + . $i + ) + ;; + *) + # No sh extension, so fork subprocess. + $i stop + ;; + esac +done +fs/skeleton/etc/inittab +0
-0fs/skeleton/etc/inittab null::sysinit:/bin/hostname -F /etc/hostname · line 35
Quoted 8 lines
fs/skeleton/etc/inittab +1
-2@@ -30,8 +30,7 @@ null::sysinit:/bin/hostname -F /etc/hostname ::ctrlaltdel:/sbin/reboot # Stuff to do before rebooting -null::shutdown:/usr/bin/killall klogd -null::shutdown:/usr/bin/killall syslogd +null::shutdown:/etc/init.d/rcK null::shutdown:/bin/umount -a -r null::shutdown:/sbin/swapoff -aThis is a different behavior now. Before only the logging daemons were killed, now all init scripts are run.
For this to work properly, all init scripts that users have in
/etc/init.dshould actually have astop()function. Since this behavior was not required previously, I expect several users not to have this.
For such users, a reboot would suddenly trigger several initializations that are unexpected.I think there are at least two solutions:
1. Keep the new behavior created with this patch, but make sure that the release notes clearly state this behavior change and update the documentation.2. Adapt the new behavior: currently you are following
/etc/init.d/Sxxxxfiles/links, while I think that the default policy on many distributions is to use/etc/init.d/Kxxxxfor shutdown (and Sxxxx only for startup). In this scenario, users who have custom Sxxx init scripts will not be impacted. Only if they choose to, can they create appropriate Kxxxx links and provide stop functions. For scripts present in the buildroot distribution, we can provide appropriate S and K links immediately.Best regards,
Thomas
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 5 lines
Best Regards! Kelvin -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111207/a98cdca8/attachment-0001.html>
PATCH 1/1 Rework of shutdown policy in inittab
Quoted 6 lines · Kelvin Cheung
Pherhaps solution 1 is simple and feasible.
Most Sxxxx scripts under dir package providestop()function currently.
And by this policy, the programs/daemons are just what should be killed, which are started at startup.
We do not need to maintain consistency between Sxxxx and Kxxxx.
I'd go for option 2. it results in a saner behaviour if people don't handle the stop condition as Thomas pointed out.
Otherwise you can get nasty messages from console when people for example try to mount some filesystem in a custom script that don't make a disctintion between start/stop and things like that. Regards.
PATCH 1/1 Rework of shutdown policy in inittab
In reply to Thomas De SchampheleireQuoted 67 lines · Thomas De Schampheleire
Hi,
Quoted 51 lines · Maxime Ripard
This commit follows commit
ad501b66. Start up of the busybox logging daemons were moved to an init script but the shutdown were still performed in inittab. This commit moves the shutdown policy to an rcK script that calls the stop function of all the init scripts in a reversed order.Signed-off-by Maxime Ripard <[email protected]>--- fs/skeleton/etc/init.d/rcK | 27 +++++++++++++++++++++++++++ fs/skeleton/etc/inittab | 3 +-- 2 files changed, 28 insertions(+), 2 deletions(-) create mode 100755 fs/skeleton/etc/init.d/rcKfs/skeleton/etc/init.d/rcK new file +27
-0@@ -0,0 +1,27 @@ +#!/bin/sh + + +# Stop all init scripts in /etc/init.d +# executing them in reversed numerical order. +# +for i in $(ls -r /etc/init.d/S??*) ;do + + # Ignore dangling symlinks (if any). + [ ! -f "$i" ] && continue + + case "$i" in + *.sh) + # Source shell script for speed. + ( + trap - INT QUIT TSTP + set stop + . $i + ) + ;; + *) + # No sh extension, so fork subprocess. + $i stop + ;; + esac +done +fs/skeleton/etc/inittab +0
-0fs/skeleton/etc/inittab null::sysinit:/bin/hostname -F /etc/hostname · line 35
Quoted 8 lines
fs/skeleton/etc/inittab +1
-2@@ -30,8 +30,7 @@ null::sysinit:/bin/hostname -F /etc/hostname ::ctrlaltdel:/sbin/reboot # Stuff to do before rebooting -null::shutdown:/usr/bin/killall klogd -null::shutdown:/usr/bin/killall syslogd +null::shutdown:/etc/init.d/rcK null::shutdown:/bin/umount -a -r null::shutdown:/sbin/swapoff -aThis is a different behavior now. Before only the logging daemons were killed, now all init scripts are run.
Quoted 6 lines
For this to work properly, all init scripts that users have in
/etc/init.dshould actually have astop()function. Since this behavior was not required previously, I expect several users not to have this.
For such users, a reboot would suddenly trigger several initializations that are unexpected.
I have to admit, I didn't think about in-the-wild users in such a case.
Quoted 4 lines
I think there are at least two solutions:
1. Keep the new behavior created with this patch, but make sure that the release notes clearly state this behavior change and update the documentation.
I hardly see how this is a new behaviour, every single init scripts we have already implements it, and we require it to.
Quoted 4 lines
2. Adapt the new behavior: currently you are following
/etc/init.d/Sxxxxfiles/links, while I think that the default policy on many distributions is to use/etc/init.d/Kxxxxfor shutdown (and Sxxxx only for startup).
The only one doing that I can think of is OpenWRT, it is barely many.
Quoted 5 lines
In this scenario, users who have custom Sxxx
init scripts will not be impacted. Only if they choose to, can they create appropriate Kxxxx links and provide stop functions. For scripts present in the buildroot distribution, we can provide appropriate S and K links immediately.
You're right.
I'm glad we can finally have that sort of discussion, I was starting to think every one had a dev/null rule for my patches.
However, this touches the same area than my systemd patches, so I'd prefer not to touch the same area in every packages in such a small time frame. So maybe the easier way would be to merge such as mechanism with the init mechanism introduced with these patches.
Maxime
Signature · 4 lines
Maxime Ripard, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 Rework of shutdown policy in inittab
Hello Maxime,
Quoted 77 lines · Maxime Ripard
Quoted 67 lines · Thomas De Schampheleire
Hi,
Quoted 57 lines · Maxime Ripard
This commit follows commit
ad501b66. Start up of the busybox logging daemons were moved to an init script but the shutdown were still performed in inittab. This commit moves the shutdown policy to an rcK script that calls the stop function of all the init scripts in a reversed order.Signed-off-by Maxime Ripard <[email protected]>---
?fs/skeleton/etc/init.d/rcK | ? 27 +++++++++++++++++++++++++++ ?fs/skeleton/etc/inittab ? ?| ? ?3 +--
?2 files changed, 28 insertions(+), 2 deletions(-) ?create mode 100755fs/skeleton/etc/init.d/rcKfs/skeleton/etc/init.d/rcK new file +27
-0@@ -0,0 +1,27 @@ +#!/bin/sh + + +# Stop all init scripts in /etc/init.d +# executing them in reversed numerical order. +# +for i in $(ls -r /etc/init.d/S??*) ;do + + ? ? # Ignore dangling symlinks (if any). + ? ? [ ! -f "$i" ] && continue + + ? ? case "$i" in + ? ? ? *.sh) + ? ? ? ? ? # Source shell script for speed. + ? ? ? ? ? ( + ? ? ? ? ? ? ? trap - INT QUIT TSTP + ? ? ? ? ? ? ? set stop + ? ? ? ? ? ? ? . $i + ? ? ? ? ? ) + ? ? ? ? ? ;; + ? ? ? *) + ? ? ? ? ? # No sh extension, so fork subprocess. + ? ? ? ? ? $i stop + ? ? ? ? ? ;; + ? ?esac +done +fs/skeleton/etc/inittab +0
-0@@ -30,8 +30,7 @@ null::sysinit:/bin/hostname -F /etc/hostname?::ctrlaltdel:/sbin/reboot
?# Stuff to do before rebooting
fs/skeleton/etc/inittab +1
-2-null::shutdown:/usr/bin/killall klogd -null::shutdown:/usr/bin/killall syslogd +null::shutdown:/etc/init.d/rcKQuoted 2 lines
?null::shutdown:/bin/umount -a -r
?null::shutdown:/sbin/swapoff -aThis is a different behavior now. Before only the logging daemons were killed, now all init scripts are run.
Quoted 6 lines
For this to work properly, all init scripts that users have in
/etc/init.dshould actually have astop()function. Since this behavior was not required previously, I expect several users not to have this.
For such users, a reboot would suddenly trigger several initializations that are unexpected.I have to admit, I didn't think about in-the-wild users in such a case.
Quoted 7 lines
Quoted 4 lines
I think there are at least two solutions:
1. Keep the new behavior created with this patch, but make sure that the release notes clearly state this behavior change and update the documentation.I hardly see how this is a new behaviour, every single init scripts we have already implements it, and we require it to.
IMO it's new behavior in the sense that the 'stop' function of these scripts was never run by default, they weren't used.
So, users adding their own script may not have felt this was necessary. (and admittedly, I am such a user :-) )
Quoted 7 lines
Quoted 5 lines
2. Adapt the new behavior: currently you are following
/etc/init.d/Sxxxxfiles/links, while I think that the default policy on many distributions is to use/etc/init.d/Kxxxxfor shutdown (and Sxxxx only for startup).The only one doing that I can think of is OpenWRT, it is barely many.
I was thinking of non-embedded distributions, for example RedHat.
Quoted 11 lines
Quoted 6 lines
In this scenario, users who have custom Sxxx
init scripts will not be impacted. Only if they choose to, can they create appropriate Kxxxx links and provide stop functions. For scripts present in the buildroot distribution, we can provide appropriate S and K links immediately.You're right.
I'm glad we can finally have that sort of discussion, I was starting to think every one had a dev/null rule for my patches.
I have thought that before, too :-)
Quoted 5 lines
However, this touches the same area than my systemd patches, so I'd prefer not to touch the same area in every packages in such a small time frame. So maybe the easier way would be to merge such as mechanism with the init mechanism introduced with these patches.
Ok for me.
Best regards,
Thomas
PATCH 1/1 Rework of shutdown policy in inittab
In reply to Thomas De SchampheleireLe Wed, 7 Dec 2011 07:52:20 +0100,
Thomas De Schampheleire <[email protected]> a ?crit :
Quoted 4 lines
I think there are at least two solutions:
1. Keep the new behavior created with this patch, but make sure that the release notes clearly state this behavior change and update the documentation.
I'd go for this one. All initscripts in Buildroot itself implement the start/stop/restart logic, so author of scripts that haven't been submitted upstream should have read this as a suggestion of following a similar scheme.
Quoted 8 lines
2. Adapt the new behavior: currently you are following
/etc/init.d/Sxxxxfiles/links, while I think that the default policy on many distributions is to use/etc/init.d/Kxxxxfor shutdown (and Sxxxx only for startup). In this scenario, users who have custom Sxxx init scripts will not be impacted. Only if they choose to, can they create appropriate Kxxxx links and provide stop functions. For scripts present in the buildroot distribution, we can provide appropriate S and K links immediately.
IMO, it would be ugly to have Sxxfoobar be a regular file (the script itself) and Kxxfoobar be a symbolic link. So it means that we would have to change all all scripts to /etc/init.d/foobar, and then create symbolic links Sxxfoobar and Kxxfoobar. That's an alternative solution, certainly, but it triples the number of files/symlinks required.
Regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 Rework of shutdown policy in inittab
Quoted 8 lines · Thomas Petazzoni
Le Wed, 7 Dec 2011 07:52:20 +0100,
Thomas De Schampheleire <[email protected]> a ?crit :Quoted 4 lines
I think there are at least two solutions:
1. Keep the new behavior created with this patch, but make sure that the release notes clearly state this behavior change and update the documentation.
Quoted 4 lines
I'd go for this one. All initscripts in Buildroot itself implement the start/stop/restart logic, so author of scripts that haven't been submitted upstream should have read this as a suggestion of following a similar scheme.
No problem for me. I also think this is the best alternative.
Quoted 28 lines
Quoted 9 lines
2. Adapt the new behavior: currently you are following
/etc/init.d/Sxxxxfiles/links, while I think that the default policy on many distributions is to use/etc/init.d/Kxxxxfor shutdown (and Sxxxx only for startup). In this scenario, users who have custom Sxxx init scripts will not be impacted. Only if they choose to, can they create appropriate Kxxxx links and provide stop functions. For scripts present in the buildroot distribution, we can provide appropriate S and K links immediately.IMO, it would be ugly to have Sxxfoobar be a regular file (the script itself) and Kxxfoobar be a symbolic link. So it means that we would have to change all all scripts to
/etc/init.d/foobar, and then create symbolic links Sxxfoobar and Kxxfoobar. That's an alternative solution, certainly, but it triples the number of files/symlinks required.Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/1 Rework of shutdown policy in inittab
Quoted 10 lines · Thomas De Schampheleire
Quoted 8 lines · Thomas Petazzoni
Le Wed, 7 Dec 2011 07:52:20 +0100,
Thomas De Schampheleire <[email protected]> a ?crit :Quoted 4 lines
I think there are at least two solutions:
1. Keep the new behavior created with this patch, but make sure that the release notes clearly state this behavior change and update the documentation.
Quoted 6 lines
Quoted 4 lines
I'd go for this one. All initscripts in Buildroot itself implement the start/stop/restart logic, so author of scripts that haven't been submitted upstream should have read this as a suggestion of following a similar scheme.
No problem for me. I also think this is the best alternative.
Then I guess we are all ok for it to be merged ? :)
Signature · 4 lines
Maxime Ripard, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 Rework of shutdown policy in inittab
Quoted 12 lines · Maxime Ripard
Quoted 4 lines · Thomas De Schampheleire
Quoted 2 lines · Thomas Petazzoni
Le Wed, 7 Dec 2011 07:52:20 +0100,
Thomas De Schampheleire <[email protected]> a ?crit:
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
I think there are at least two solutions:
1. Keep the new behavior created with this patch, but make sure that the release notes clearly state this behavior change and update the documentation.
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
I'd go for this one. All initscripts in Buildroot itself implement the start/stop/restart logic, so author of scripts that haven't been submitted upstream should have read this as a suggestion of following a similar scheme.
No problem for me. I also think this is the best alternative.
Then I guess we are all ok for it to be merged ? :)
I am, but I'd like to see something added to the documentation, or at least
a mention of this in the CHANGES file.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120103/0d57aa49/attachment.html>