Skip to contentSkip to conversation

misc small changes, mostly get/set IF related

GIT PULL Antti Palosaari 2 participants 4 messages Nov 13, 2011 – Nov 24, 2011 Media (V4L/DVB)

lore
Share & tools
lore

Antti Palosaari

author
#0 lore raw

Moro

These patches are rather small enchantments and should not have any visible effect.

mxl5007t change is that register read fix I have mentioned earlier. Reg read is used only for checking chip ID and even if ID is not detected correctly it will still work. So no functional changes.

Antti

The following changes since commit df5f76dfef9bfaec1ff27d0a60a57a773bf87f0f:

af9015: limit I2C access to keep FW happy (2011-11-13 03:33:30 +0200)

are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git af9015

Antti Palosaari (12):
tda18218: implement .get_if_frequency()
tda18218: fix 6 MHz default IF frequency
af9013: use .get_if_frequency() when possible
mt2060: implement .get_if_frequency()
qt1010: implement .get_if_frequency()
tda18212: implement .get_if_frequency()
tda18212: round IF frequency to close hardware value
cxd2820r: switch to .get_if_frequency()
cxd2820r: check bandwidth earlier for DVB-T/T2
mxl5007t: fix reg read
ce6230: remove experimental from Kconfig
ce168: remove experimental from Kconfig

 drivers/media/common/tuners/mt2060.c        |    9 +++-
 drivers/media/common/tuners/mxl5007t.c      |    3 +-
 drivers/media/common/tuners/qt1010.c        |    9 +++-
 drivers/media/common/tuners/tda18212.c      |   17 +++++++-
 drivers/media/common/tuners/tda18218.c      |   18 ++++++-
 drivers/media/common/tuners/tda18218_priv.h |    2 +
 drivers/media/dvb/dvb-usb/Kconfig           |    4 +-
 drivers/media/dvb/dvb-usb/anysee.c          |    7 ---
 drivers/media/dvb/frontends/af9013.c        |   43 ++++--------------
 drivers/media/dvb/frontends/cxd2820r.h      |   13 ------
 drivers/media/dvb/frontends/cxd2820r_c.c    |   13 +++++-
 drivers/media/dvb/frontends/cxd2820r_t.c    |   55 +++++++++++++----------
 drivers/media/dvb/frontends/cxd2820r_t2.c   |   62 
+++++++++++++++------------
 drivers/media/video/em28xx/em28xx-dvb.c     |    7 ---
 14 files changed, 140 insertions(+), 122 deletions(-)
Signature · 1 line
http://palosaari.fi/
author
#1 lore raw

Mauro,
and these too for 3.3. Sorry about mistakes.

regards
Antti

Quoted 50 lines · Antti Palosaari

Moro

These patches are rather small enchantments and should not have any visible effect.

mxl5007t change is that register read fix I have mentioned earlier. Reg read is used only for checking chip ID and even if ID is not detected correctly it will still work. So no functional changes.

Antti

The following changes since commit
df5f76dfef9bfaec1ff27d0a60a57a773bf87f0f:

af9015: limit I2C access to keep FW happy (2011-11-13 03:33:30 +0200)

are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git af9015

Antti Palosaari (12):
tda18218: implement .get_if_frequency()
tda18218: fix 6 MHz default IF frequency
af9013: use .get_if_frequency() when possible
mt2060: implement .get_if_frequency()
qt1010: implement .get_if_frequency()
tda18212: implement .get_if_frequency()
tda18212: round IF frequency to close hardware value
cxd2820r: switch to .get_if_frequency()
cxd2820r: check bandwidth earlier for DVB-T/T2
mxl5007t: fix reg read
ce6230: remove experimental from Kconfig
ce168: remove experimental from Kconfig

drivers/media/common/tuners/mt2060.c | 9 +++- drivers/media/common/tuners/mxl5007t.c | 3 +- drivers/media/common/tuners/qt1010.c | 9 +++- drivers/media/common/tuners/tda18212.c | 17 +++++++- drivers/media/common/tuners/tda18218.c | 18 ++++++- drivers/media/common/tuners/tda18218_priv.h | 2 + drivers/media/dvb/dvb-usb/Kconfig | 4 +- drivers/media/dvb/dvb-usb/anysee.c | 7 --- drivers/media/dvb/frontends/af9013.c | 43 ++++-------------- drivers/media/dvb/frontends/cxd2820r.h | 13 ------ drivers/media/dvb/frontends/cxd2820r_c.c | 13 +++++- drivers/media/dvb/frontends/cxd2820r_t.c | 55 +++++++++++++---------- drivers/media/dvb/frontends/cxd2820r_t2.c | 62 +++++++++++++++------------ drivers/media/video/em28xx/em28xx-dvb.c | 7 ---

14 files changed, 140 insertions(+), 122 deletions(-)
Signature · 1 line
http://palosaari.fi/
#2 lore raw

Em 13-11-2011 17:20, Antti Palosaari escreveu:

Quoted 2 lines

Mauro,
and these too for 3.3. Sorry about mistakes.

In fact, those 3 patches seemed to be good for 3.2:

576b849 [media] mxl5007t: fix reg read
d7d89dc [media] tda18218: fix 6 MHz default IF frequency ff83bd8 [media] af9015: limit I2C access to keep FW happy

So, I've backported d7d89dc to 3.2, and applied there. the others, I've added for 3.3.

Quoted 57 lines

regards
Antti

Quoted 50 lines · Antti Palosaari

Moro

These patches are rather small enchantments and should not have any visible effect.

mxl5007t change is that register read fix I have mentioned earlier. Reg read is used only for checking chip ID and even if ID is not detected correctly it will still work. So no functional changes.

Antti

The following changes since commit
df5f76dfef9bfaec1ff27d0a60a57a773bf87f0f:

af9015: limit I2C access to keep FW happy (2011-11-13 03:33:30 +0200)

are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git af9015

Antti Palosaari (12):
tda18218: implement .get_if_frequency()
tda18218: fix 6 MHz default IF frequency
af9013: use .get_if_frequency() when possible
mt2060: implement .get_if_frequency()
qt1010: implement .get_if_frequency()
tda18212: implement .get_if_frequency()
tda18212: round IF frequency to close hardware value
cxd2820r: switch to .get_if_frequency()
cxd2820r: check bandwidth earlier for DVB-T/T2
mxl5007t: fix reg read
ce6230: remove experimental from Kconfig
ce168: remove experimental from Kconfig

drivers/media/common/tuners/mt2060.c | 9 +++- drivers/media/common/tuners/mxl5007t.c | 3 +- drivers/media/common/tuners/qt1010.c | 9 +++- drivers/media/common/tuners/tda18212.c | 17 +++++++- drivers/media/common/tuners/tda18218.c | 18 ++++++- drivers/media/common/tuners/tda18218_priv.h | 2 + drivers/media/dvb/dvb-usb/Kconfig | 4 +- drivers/media/dvb/dvb-usb/anysee.c | 7 --- drivers/media/dvb/frontends/af9013.c | 43 ++++-------------- drivers/media/dvb/frontends/cxd2820r.h | 13 ------ drivers/media/dvb/frontends/cxd2820r_c.c | 13 +++++- drivers/media/dvb/frontends/cxd2820r_t.c | 55 +++++++++++++---------- drivers/media/dvb/frontends/cxd2820r_t2.c | 62 +++++++++++++++------------ drivers/media/video/em28xx/em28xx-dvb.c | 7 ---

14 files changed, 140 insertions(+), 122 deletions(-)
author
#3 lore raw
Quoted 4 lines · Mauro Carvalho Chehab

Em 13-11-2011 17:20, Antti Palosaari escreveu:

Quoted 2 lines

Mauro,
and these too for 3.3. Sorry about mistakes.

Quoted 8 lines

In fact, those 3 patches seemed to be good for 3.2:

576b849 [media] mxl5007t: fix reg read
d7d89dc [media] tda18218: fix 6 MHz default IF frequency ff83bd8 [media] af9015: limit I2C access to keep FW happy

So, I've backported d7d89dc to 3.2, and applied there. the others, I've added for 3.3.

You could put mxl5007t and tda18218. But as I changed tda18218 to support .get_if_frequency() just before that fix and it touches same code lines, it will not apply unless you do some hand editing or apply tda18218 get_if_frequency() patch too.

DO *NOT* push af9015 I2C patch to the 3.2. I see there could be potential problems if there is heavy demodulator I2C traffic since it forces to wait some I2C related tasks. I suspect that could lead bad situation when there is more traffic we can handle due to I2C access waiting coming from patch.

I have optimized af9013 I2C load, reduced it rather much switching multibyte I2C where possible and running statistic polls using timers in backround. Now it returns all statistics from cache and not make any statistics queries directly when userspace app is asking.

After my af9013 optimizations are ready those could be put to master, which will happen likely 3.3 schedule. It is absolutely too risky put that single patch to 3.2.

regards
Antti

Signature · 1 line
http://palosaari.fi/