Skip to contentSkip to conversation

Question about mm/compaction.c/acct_isolated: computing nr_anon, nr_file

DISCUSSION Wang Sheng-Hui 1 participant 2 messages Nov 25, 2011 Memory management

lore
Share & tools
lore
#0 lore raw

Why does it double the number in line 233/234?

222/* Update the number of anon and file isolated pages in the zone */ 223static void acct_isolated(struct zone *zone, struct compact_control *cc) 224{
225 struct page *page;
226 unsigned int count[NR_LRU_LISTS] = { 0, };
227
228 list_for_each_entry(page, &cc->migratepages, lru) {
229 int lru = page_lru_base_type(page);
230 count[lru]++;
231 }
232

 233        cc->nr_anon = count[LRU_ACTIVE_ANON] + count[LRU_INACTIVE_ANON];
 234        cc->nr_file = count[LRU_ACTIVE_FILE] + count[LRU_INACTIVE_FILE];
 235        __mod_zone_page_state(zone, NR_ISOLATED_ANON, cc->nr_anon);
 236        __mod_zone_page_state(zone, NR_ISOLATED_FILE, cc->nr_file);

237}

thanks,

#1 lore raw
Quoted 14 lines · Wang Sheng-Hui

Why does it double the number in line 233/234?

222/* Update the number of anon and file isolated pages in the zone */ 223static void acct_isolated(struct zone *zone, struct compact_control *cc) 224{
225 struct page *page;
226 unsigned int count[NR_LRU_LISTS] = { 0, };
227
228 list_for_each_entry(page, &cc->migratepages, lru) {
229 int lru = page_lru_base_type(page);
230 count[lru]++;
231 }
232

Quoted 8 lines
 233        cc->nr_anon = count[LRU_ACTIVE_ANON] + count[LRU_INACTIVE_ANON];
 234        cc->nr_file = count[LRU_ACTIVE_FILE] + count[LRU_INACTIVE_FILE];
 235        __mod_zone_page_state(zone, NR_ISOLATED_ANON, cc->nr_anon);
 236        __mod_zone_page_state(zone, NR_ISOLATED_FILE, cc->nr_file);

237}

thanks,

Sorry, I mistook looking the code. Please ignore the mail.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>