Skip to contentSkip to conversation

x86: Turn on support for EFI's GPT in the coreboot config

PATCH New Gabe Black 3 participants 5 messages Nov 29, 2011

lore
Share & tools
lore

Gabe Black

author
#0 lore raw

PATCH 1/1 x86: Turn on support for EFI's GPT in the coreboot config

This allows u-boot to figure out the partitions of a chrome-os install.

Signed-off-by Gabe Black <[email protected]>
---
 include/configs/coreboot.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/configs/coreboot.h +1 -0
index 348a25b..e98201d 100644
@@ -89,6 +89,7 @@
 /************************************************************
  * DISK Partition support
  ************************************************************/
+#define CONFIG_EFI_PARTITION
 #define CONFIG_DOS_PARTITION
 #define CONFIG_MAC_PARTITION
 #define CONFIG_ISO_PARTITION		/* Experimental */
Signature · 1 line
1.7.3.1
#1 lore raw

PATCH 1/1 x86: Turn on support for EFI's GPT in the coreboot config

Hi Gabe,

Quoted 12 lines · Gabe Black

This allows u-boot to figure out the partitions of a chrome-os install.

Signed-off-by Gabe Black <[email protected]>
---
 include/configs/coreboot.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/configs/coreboot.h +0 -0
index 348a25b..e98201d 100644

include/configs/coreboot.h line 95

Quoted 7 lines
include/configs/coreboot.h +1 -0
@@ -89,6 +89,7 @@
 /************************************************************
  * DISK Partition support
  ************************************************************/
+#define CONFIG_EFI_PARTITION
 #define CONFIG_DOS_PARTITION
 #define CONFIG_MAC_PARTITION
 #define CONFIG_ISO_PARTITION		/* Experimental */

Since "x86: Initial commit for running as a coreboot payload" has not been applied yet, is there any reason this (and "x86: Fix IDE configuration for the coreboot board") could not be merged into it?

Regards,

Graeme

#2 lore raw

PATCH 1/1 x86: Turn on support for EFI's GPT in the coreboot config

No, that would be fine.

Gabe

Quoted 31 lines · Graeme Russ

Hi Gabe,

Quoted 12 lines · Gabe Black

This allows u-boot to figure out the partitions of a chrome-os install.

Signed-off-by Gabe Black <[email protected]>
---
 include/configs/coreboot.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/configs/coreboot.h +0 -0
index 348a25b..e98201d 100644

include/configs/coreboot.h line 95

Quoted 7 lines
include/configs/coreboot.h +1 -0
@@ -89,6 +89,7 @@
 /************************************************************
  * DISK Partition support
  ************************************************************/
+#define CONFIG_EFI_PARTITION
 #define CONFIG_DOS_PARTITION
 #define CONFIG_MAC_PARTITION
 #define CONFIG_ISO_PARTITION         /* Experimental */

Since "x86: Initial commit for running as a coreboot payload" has not been applied yet, is there any reason this (and "x86: Fix IDE configuration for the coreboot board") could not be merged into it?

Regards,

Graeme

#3 lore raw

PATCH 1/1 x86: Turn on support for EFI's GPT in the coreboot config

Hi Gabe,

Quoted 1 line · Gabe Black

No, that would be fine.

OK, can you send an updated patch - I'll apply it to u-boot-x86/next

Regards,

Graeme

Quoted 38 lines

Gabe

Quoted 31 lines · Graeme Russ

Hi Gabe,

Quoted 12 lines · Gabe Black

This allows u-boot to figure out the partitions of a chrome-os install.

Signed-off-by Gabe Black <[email protected]>

---
?include/configs/coreboot.h | ? ?1 +
?1 files changed, 1 insertions(+), 0 deletions(-)

include/configs/coreboot.h +0 -0
index 348a25b..e98201d 100644
@@ -89,6 +89,7 @@
Quoted 7 lines

?/************************************************************ ? * DISK Partition support
? ************************************************************/ +#define CONFIG_EFI_PARTITION
?#define CONFIG_DOS_PARTITION
?#define CONFIG_MAC_PARTITION
?#define CONFIG_ISO_PARTITION ? ? ? ? /* Experimental */

Since "x86: Initial commit for running as a coreboot payload" has not been applied yet, is there any reason this (and "x86: Fix IDE configuration for the coreboot board") could not be merged into it?

Regards,

Graeme

#4 lore raw

PATCH 1/1 x86: Turn on support for EFI's GPT in the coreboot config

Actually, I found some compile errors in the upstream EFI support. The patch I'll be sending out soon should be applied before this one so everything still builds.

Gabe

Quoted 54 lines · Graeme Russ

Hi Gabe,

Quoted 1 line · Gabe Black

No, that would be fine.

OK, can you send an updated patch - I'll apply it to u-boot-x86/next

Regards,

Graeme

Quoted 5 lines

Gabe

On Tue, Nov 29, 2011 at 2:58 AM, Graeme Russ <[email protected]>

Quoted 5 lines · wrote:
Quoted 5 lines

Hi Gabe,

Quoted 1 line · Gabe Black

This allows u-boot to figure out the partitions of a chrome-os

install.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Signed-off-by Gabe Black <[email protected]>
---
 include/configs/coreboot.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
include/configs/coreboot.h +0 -0
index 348a25b..e98201d 100644
@@ -89,6 +89,7 @@
 /************************************************************
Quoted 8 lines

include/configs/coreboot.h line 95

Quoted 6 lines
include/configs/coreboot.h +1 -0
  * DISK Partition support
  ************************************************************/
+#define CONFIG_EFI_PARTITION
 #define CONFIG_DOS_PARTITION
 #define CONFIG_MAC_PARTITION
 #define CONFIG_ISO_PARTITION         /* Experimental */

Since "x86: Initial commit for running as a coreboot payload" has not

been

Quoted 1 line
Quoted 1 line

applied yet, is there any reason this (and "x86: Fix IDE configuration

for

Quoted 7 lines
Quoted 5 lines

the coreboot board") could not be merged into it?

Regards,

Graeme