Skip to contentSkip to conversation

libx11-trim: update to 1.4.4

PATCH Applied Xiaofeng Yan 4 participants 5 messages Nov 21, 2011 – Nov 29, 2011

lore
Share & tools
lore

Xiaofeng Yan

author
#0 lore raw

cover libx11-trim: update to 1.4.4

From: Xiaofeng Yan <[email protected]>

Thanks for martin's comment.
I have modified libx11-trim_1.4.4.bb and don't remove libx11-trim_1.3.4.bb because someone could want to use previous version for some reason. If it is not necessary later, then I will remove the old version.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: xiaofeng/update_libx11-trim
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/update_libx11-trim

Thanks,
Xiaofeng Yan <[email protected]>
---

Xiaofeng Yan (1):
blibx11-trim: update to 1.4.4

 .../libx11-trim-1.4.4/keysymdef_include.patch      |   23 ++++++++++
 .../libx11-trim-1.4.4/makekeys_crosscompile.patch  |   45 ++++++++++++++++++++
 .../libx11-trim-1.4.4/x11_disable_makekeys.patch   |   29 +++++++++++++
 .../recipes-graphics/xorg-lib/libx11-trim_1.4.4.bb |   20 +++++++++
 4 files changed, 117 insertions(+), 0 deletions(-)
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/keysymdef_include.patch
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/makekeys_crosscompile.patch
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/x11_disable_makekeys.patch
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11-trim_1.4.4.bb
author
#1 lore raw

PATCH 1/1 blibx11-trim: update to 1.4.4

From: Xiaofeng Yan <[email protected]>

Some description :
1 Remove --with-xcb because xcb is necessary item in the new version.
2 keysymdef_include.patch uses in keeping native directory of X11 as the default configuration. \
or else host directory "/usr/include/X11" is selected when running ./configure.
3 makekeys_crosscompile.patch avoid host contamination.
4 x11_disable_makekeys.patch uses in compiling makekey.c needed by makekeys-makekeys.o

Signed-off-by Xiaofeng Yan <[email protected]>
---
 .../libx11-trim-1.4.4/keysymdef_include.patch      |   23 ++++++++++
 .../libx11-trim-1.4.4/makekeys_crosscompile.patch  |   45 ++++++++++++++++++++
 .../libx11-trim-1.4.4/x11_disable_makekeys.patch   |   29 +++++++++++++
 .../recipes-graphics/xorg-lib/libx11-trim_1.4.4.bb |   20 +++++++++
 4 files changed, 117 insertions(+), 0 deletions(-)
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/keysymdef_include.patch
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/makekeys_crosscompile.patch
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/x11_disable_makekeys.patch
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11-trim_1.4.4.bb
meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/keysymdef_include.patch new file +23 -0
new file mode 100644
index 0000000..d1bdab9
@@ -0,0 +1,23 @@
+Upstream-Status: Inappropriate [configuration]
+
+Signed-off-by: Martin Jansa <[email protected]>
+
+diff -uNr libX11-1.3.6.orig//configure.ac libX11-1.3.6/configure.ac
+--- libX11-1.3.6.orig//configure.ac	2010-09-20 08:04:16.000000000 +0200
++++ libX11-1.3.6/configure.ac	2010-09-28 16:29:26.000000000 +0200
+@@ -355,7 +355,14 @@
+ # Find keysymdef.h
+ #
+ AC_MSG_CHECKING([keysym definitions])
+-KEYSYMDEFDIR=`$PKG_CONFIG --variable=includedir xproto`/X11
++AC_ARG_WITH(keysymdefdir,
++        AC_HELP_STRING([--with-keysymdefdir=DIR], [The location of keysymdef.h]),
++        KEYSYMDEFDIR=$withval, KEYSYMDEFDIR="")
++
++if test x$KEYSYMDEFDIR = x; then
++	KEYSYMDEFDIR=`$PKG_CONFIG --variable=includedir xproto`/X11
++fi
++
+ FILES="keysymdef.h XF86keysym.h Sunkeysym.h DECkeysym.h HPkeysym.h"
+ for i in $FILES; do
+     if test -f "$KEYSYMDEFDIR/$i"; then
meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/makekeys_crosscompile.patch new file +45 -0

45 lines not on this page · raw message

meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/x11_disable_makekeys.patch new file +29 -0
new file mode 100644
index 0000000..9763313
@@ -0,0 +1,29 @@
+Index: libX11-1.3.4/src/util/Makefile.am
+===================================================================
+--- libX11-1.3.4.orig/src/util/Makefile.am
++++ libX11-1.3.4/src/util/Makefile.am
+@@ -1,24 +1 @@
+-
+-noinst_PROGRAMS=makekeys
+-
+-makekeys_CFLAGS = \
+-	$(X11_CFLAGS) \
+-	$(CWARNFLAGS)
+-
+-CC = @CC_FOR_BUILD@
+-CPPFLAGS = @CPPFLAGS_FOR_BUILD@
+-CFLAGS = @CFLAGS_FOR_BUILD@
+-LDFLAGS = @LDFLAGS_FOR_BUILD@
+-
+ EXTRA_DIST = mkks.sh
+-
+-if LINT
+-# Check source code with tools like lint & sparse
+-
+-ALL_LINT_FLAGS=$(LINT_FLAGS) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) \
+-		$(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS)
+-
+-lint:
+-	$(LINT) $(ALL_LINT_FLAGS) makekeys.c
+-
+-endif LINT
meta/recipes-graphics/xorg-lib/libx11-trim_1.4.4.bb new file +20 -0
new file mode 100644
index 0000000..7aed308
@@ -0,0 +1,20 @@
+require libx11.inc
+
+DESCRIPTION += " Support for XCMS is disabled in this version."
+
+LICENSE = "MIT & MIT-style & BSD"
+LIC_FILES_CHKSUM = "file://COPYING;md5=172255dee66bb0151435b2d5d709fcf7"
+
+PR = "r0"
+
+DEPENDS += "libxcb xproto xextproto xtrans libxau kbproto inputproto xf86bigfontproto xproto-native"
+
+SRC_URI += "file://x11_disable_makekeys.patch \
+            file://keysymdef_include.patch \
+            file://makekeys_crosscompile.patch"
+
+
+SRC_URI[md5sum] = "f65c9c7ecbfb64c19dbd7927160d63fd"
+SRC_URI[sha256sum] = "88d7238ce5f7cd123450567de7a3b56a43556e4ccc45df38b8324147c889a844"
+
+EXTRA_OECONF += "--with-keysymdef=${STAGING_INCDIR}/X11/ --disable-xcms "
Signature · 1 line
1.7.0.4
#2 lore raw
Quoted 37 lines · Xiaofeng Yan

+++ b/meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/makekeys_crosscompile.patch

meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/makekeys_crosscompile.patch new file +35 -0
@@ -0,0 +1,45 @@
+Because the size of "unsigned long" is different between 32-bit
+and 64-bit, judge whether target is 32-bit or 64-bit and tell
+"makekey".
+
+Upstream-Status: Pending
+
+Signed-off-by: [email protected]
+
+--- libX11-1.3.4.orig/src/util/makekeys.c      2010-01-15 09:11:36.000000000 +0800
++++ libX11-1.3.4/src/util/makekeys.c   2011-05-24 19:04:25.454774908 +0800
+@@ -33,6 +33,7 @@
+ #include <X11/keysymdef.h>
+ #include <stdio.h>
+ #include <stdlib.h>
++#include <stdint.h>
+
+ typedef unsigned long Signature;
+
+@@ -124,7 +125,12 @@
+           name = info[i].name;
+           sig = 0;
+           while ((c = *name++))
+-              sig = (sig << 1) + c;
++#ifdef USE32
++              sig = (uint32_t)(sig << 1) + c;
++#else
++              sig = (uint64_t)(sig << 1) + c;
++#endif
++
+           first = j = sig % z;
+           for (k = 0; tab[j]; k++) {
+               j += first + 1;
+@@ -163,7 +169,11 @@
+       name = info[i].name;
+       sig = 0;

meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/makekeys_crosscompile.patch line 45

Quoted 10 lines
meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/makekeys_crosscompile.patch new file +10 -0
+       while ((c = *name++))
+-          sig = (sig << 1) + c;
++#ifdef USE32
++          sig = (uint32_t)(sig << 1) + c;
++#else
++          sig = (uint64_t)(sig << 1) + c;
++#endif
+       first = j = sig % z;
+       while (offsets[j]) {
+           j += first + 1;

why use USE32 define ? why not use compiler builtin define __LP64__ ? is it something a programs that needs to know the bitness of target or something ?

#3 lore raw
Quoted 45 lines · Khem Raj
Quoted 43 lines · Xiaofeng Yan

+++ b/meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/makekeys_crosscompile.patch

meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/makekeys_crosscompile.patch new file +41 -0
@@ -0,0 +1,45 @@
+Because the size of "unsigned long" is different between 32-bit
+and 64-bit, judge whether target is 32-bit or 64-bit and tell
+"makekey".
+
+Upstream-Status: Pending
+
+Signed-off-by: [email protected]
+
+--- libX11-1.3.4.orig/src/util/makekeys.c      2010-01-15 09:11:36.000000000 +0800
++++ libX11-1.3.4/src/util/makekeys.c   2011-05-24 19:04:25.454774908 +0800
+@@ -33,6 +33,7 @@
+ #include <X11/keysymdef.h>
+ #include <stdio.h>
+ #include <stdlib.h>
++#include <stdint.h>
+
+ typedef unsigned long Signature;
+
+@@ -124,7 +125,12 @@
+           name = info[i].name;
+           sig = 0;
+           while ((c = *name++))
+-              sig = (sig << 1) + c;
++#ifdef USE32
++              sig = (uint32_t)(sig << 1) + c;
++#else
++              sig = (uint64_t)(sig << 1) + c;
++#endif
++
+           first = j = sig % z;
+           for (k = 0; tab[j]; k++) {
+               j += first + 1;
+@@ -163,7 +169,11 @@
+       name = info[i].name;
+       sig = 0;
+       while ((c = *name++))
+-          sig = (sig << 1) + c;
++#ifdef USE32
++          sig = (uint32_t)(sig << 1) + c;
++#else
++          sig = (uint64_t)(sig << 1) + c;
Quoted 8 lines

meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/makekeys_crosscompile.patch line 45

Quoted 4 lines
meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/makekeys_crosscompile.patch new file +4 -0
++#endif
+       first = j = sig % z;
+       while (offsets[j]) {
+           j += first + 1;

why use USE32 define ? why not use compiler builtin define __LP64__ ? is it something a programs that needs to know the bitness of target or something ?

This gets run on the build system but needs to generate data for the target...

Cheers,

Richard

Applied
#4 lore raw
In reply to Xiaofeng Yan
Quoted 28 lines · Xiaofeng Yan

From: Xiaofeng Yan<[email protected]>

Thanks for martin's comment.
I have modified libx11-trim_1.4.4.bb and don't remove libx11-trim_1.3.4.bb because someone could want to use previous version for some reason. If it is not necessary later, then I will remove the old version.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: xiaofeng/update_libx11-trim
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/update_libx11-trim

Thanks,
Xiaofeng Yan<[email protected]>
---

Xiaofeng Yan (1):

   blibx11-trim: update to 1.4.4
  .../libx11-trim-1.4.4/keysymdef_include.patch      |   23 ++++++++++
  .../libx11-trim-1.4.4/makekeys_crosscompile.patch  |   45 ++++++++++++++++++++
  .../libx11-trim-1.4.4/x11_disable_makekeys.patch   |   29 +++++++++++++
  .../recipes-graphics/xorg-lib/libx11-trim_1.4.4.bb |   20 +++++++++
  4 files changed, 117 insertions(+), 0 deletions(-)

create mode 100644 meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/keysymdef_include.patch create mode 100644 meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/makekeys_crosscompile.patch create mode 100644 meta/recipes-graphics/xorg-lib/libx11-trim-1.4.4/x11_disable_makekeys.patch create mode 100644 meta/recipes-graphics/xorg-lib/libx11-trim_1.4.4.bb

Quoted 5 lines

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Merged into OE-Core

Thanks
Sau!