Skip to contentSkip to conversation

Adding kernel patches using "git am"?

DISCUSSION Ulf Samuelsson 3 participants 3 messages Nov 30, 2011

lore
Share & tools
lore
#0 lore raw

Is there a reason for using "patch" instead of "git am" on let's say the kernel.

If I want to do some modification, of the kernel, I can like Graeme description at
http://www.slimlogic.co.uk/2011/05/openembeddedangstrom-kernel-workflow/ do
bitbake -c configure virtual/kernel

and then have an initialized git tree ready to be modified.

"git am" is of course more sensitive to the patch quality than "patch" but that has some advantages as well.

It also makes the recipe more complex at this stage.

--
Best Regards
Ulf Samuelsson
eMagii

#1 lore raw
Quoted 9 lines · Ulf Samuelsson

Is there a reason for using "patch" instead of "git am" on let's say the kernel.

If I want to do some modification, of the kernel, I can like Graeme description at
http://www.slimlogic.co.uk/2011/05/openembeddedangstrom-kernel-workflow/
do
bitbake -c configure virtual/kernel

Quoted 6 lines

and then have an initialized git tree ready to be modified.

"git am" is of course more sensitive to the patch quality than "patch" but that has some advantages as well.

It also makes the recipe more complex at this stage.

echo PATCHTOOL_pn-linux = "git" >> conf/local.conf # (note, uses git-apply, not git-am, but it's a step in the direction you want, anyway, and by inspecting patch.bbclass and lib/oe/patch.py and looking for that patch tool, you can see how you'd go about adding one for git-am if you desired it)

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
#2 lore raw
In reply to Ulf Samuelsson
Quoted 8 lines · Ulf Samuelsson

Is there a reason for using "patch" instead of "git am" on let's say the kernel.

If I want to do some modification, of the kernel, I can like Graeme description at
http://www.slimlogic.co.uk/2011/05/openembeddedangstrom-kernel-workflow/ do bitbake -c configure virtual/kernel

Quoted 4 lines

and then have an initialized git tree ready to be modified.

"git am" is of course more sensitive to the patch quality than "patch" but that has some advantages as well.

Not answering the question directly, but if you use the linux-yocto kernel and related infrastructure, patch is not used to apply changes to the tree. It is done under the covers with guilt or git am applying changes to the tree (along with other git operations for more complex situations).

Cheers,

Bruce

Quoted 13 lines

It also makes the recipe more complex at this stage.

--
Best Regards
Ulf Samuelsson
eMagii

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core