Skip to contentSkip to conversation

ocfs2: submit disk heartbeat bio using WRITE_SYNC

PATCH New Noboru Iwamatsu 3 participants 3 messages Dec 6, 2011 – Dec 8, 2011 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ocfs2: submit disk heartbeat bio using WRITE_SYNC

Under heavy I/O load, writing the disk heartbeat can be forced to wait for minutes, and this causes the node to be fenced.

This patch tries to use WRITE_SYNC in submitting the heartbeat bio, so that writing the heartbeat will have a priority over other requests.

---
 fs/ocfs2/cluster/heartbeat.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/ocfs2/cluster/heartbeat.c +1 -1
index 9a3e6bb..6b0c1e4 100644
@@ -491,7 +491,7 @@ static int o2hb_issue_node_write(struct o2hb_region *reg,
 	}
 
 	atomic_inc(&write_wc->wc_num_reqs);
-	submit_bio(WRITE, bio);
+	submit_bio(WRITE_SYNC, bio);
 
 	status = 0;
 bail:
Signature · 1 line
1.7.6.4
#1 lore raw

PATCH 1/1 ocfs2: submit disk heartbeat bio using WRITE_SYNC

Quoted 8 lines · Noboru Iwamatsu

Under heavy I/O load, writing the disk heartbeat can be forced to wait for minutes, and this causes the node to be fenced.

This patch tries to use WRITE_SYNC in submitting the heartbeat bio, so that writing the heartbeat will have a priority over other requests.

looks good to me.

Quoted 17 lines
---
 fs/ocfs2/cluster/heartbeat.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/ocfs2/cluster/heartbeat.c +1 -1
index 9a3e6bb..6b0c1e4 100644
@@ -491,7 +491,7 @@ static int o2hb_issue_node_write(struct o2hb_region *reg,
 	}
 
 	atomic_inc(&write_wc->wc_num_reqs);
-	submit_bio(WRITE, bio);
+	submit_bio(WRITE_SYNC, bio);
 
 	status = 0;
 bail:
#2 lore raw

PATCH 1/1 ocfs2: submit disk heartbeat bio using WRITE_SYNC

Quoted 33 lines · Tao Ma
Quoted 8 lines · Noboru Iwamatsu

Under heavy I/O load, writing the disk heartbeat can be forced to wait for minutes, and this causes the node to be fenced.

This patch tries to use WRITE_SYNC in submitting the heartbeat bio, so that writing the heartbeat will have a priority over other requests.

looks good to me.

Quoted 9 lines
---
  fs/ocfs2/cluster/heartbeat.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
fs/ocfs2/cluster/heartbeat.c +0 -0
index 9a3e6bb..6b0c1e4 100644

fs/ocfs2/cluster/heartbeat.c static int o2hb_issue_node_write(struct o2hb_region *reg, · line 497

Quoted 8 lines
fs/ocfs2/cluster/heartbeat.c +1 -1
@@ -491,7 +491,7 @@ static int o2hb_issue_node_write(struct o2hb_region *reg,
  	}
 
  	atomic_inc(&write_wc->wc_num_reqs);
-	submit_bio(WRITE, bio);
+	submit_bio(WRITE_SYNC, bio);
 
  	status = 0;
  bail:

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com
http://oss.oracle.com/mailman/listinfo/ocfs2-devel