Skip to contentSkip to conversation

ASoC: Fix build dependency for SND_SOC_JZ4740_CODEC

RFC PATCH Applied Axel Lin 3 participants 3 messages Dec 6, 2011

Subsystems (2)
Sound ASoC
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

RFC PATCH 1/1 ASoC: Fix build dependency for SND_SOC_JZ4740_CODEC

Currently SND_SOC_JZ4740_CODEC depends on SOC_JZ4740 but SOC_JZ4740 is not defined in any Kconfig. Thus the codec driver will not be built when select "Build all ASoC CODEC drivers".
(Unless it is selected by SND_JZ4740_SOC_QI_LB60).
Remove the dependency with SOC_JZ4740, then this code driver can be built when select "Build all ASoC CODEC drivers".

Signed-off-by Axel Lin <[email protected]>

---
I'm a little bit doubt if I should just remove the dependency as this patch does. Or alternatively make it depends on MACH_JZ4740.
Comments?

Axel

 sound/soc/codecs/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/codecs/Kconfig +1 -1
index bc2364ac..7c205e7 100644
@@ -35,7 +35,7 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_CX20442
 	select SND_SOC_DA7210 if I2C
 	select SND_SOC_DFBMCS320
-	select SND_SOC_JZ4740_CODEC if SOC_JZ4740
+	select SND_SOC_JZ4740_CODEC
 	select SND_SOC_LM4857 if I2C
 	select SND_SOC_MAX98088 if I2C
 	select SND_SOC_MAX98095 if I2C
Signature · 1 line
1.7.5.4
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Axel Lin

Currently SND_SOC_JZ4740_CODEC depends on SOC_JZ4740 but SOC_JZ4740 is not defined in any Kconfig. Thus the codec driver will not be built when select "Build all ASoC CODEC drivers".
(Unless it is selected by SND_JZ4740_SOC_QI_LB60).
Remove the dependency with SOC_JZ4740, then this code driver can be built when select "Build all ASoC CODEC drivers".

Signed-off-by Axel Lin <[email protected]>
Acked-by Lars-Peter Clausen <[email protected]>
Quoted 4 lines

---
I'm a little bit doubt if I should just remove the dependency as this patch does. Or alternatively make it depends on MACH_JZ4740.
Comments?

MACH_JZ4740 was called SOC_JZ4740 at some point, seems like this one slipped through the renaming. But since there is no compile time dependency on any MACH_JZ4740 specific functionality it should be fine to remove the dependency completely.

Thanks.

Quoted 18 lines

Axel

 sound/soc/codecs/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/codecs/Kconfig +1 -1
index bc2364ac..7c205e7 100644
@@ -35,7 +35,7 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_CX20442
 	select SND_SOC_DA7210 if I2C
 	select SND_SOC_DFBMCS320
-	select SND_SOC_JZ4740_CODEC if SOC_JZ4740
+	select SND_SOC_JZ4740_CODEC
 	select SND_SOC_LM4857 if I2C
 	select SND_SOC_MAX98088 if I2C
 	select SND_SOC_MAX98095 if I2C
Applied
#2 lore raw
In reply to Axel Lin
Quoted 3 lines · Axel Lin

Currently SND_SOC_JZ4740_CODEC depends on SOC_JZ4740 but SOC_JZ4740 is not defined in any Kconfig. Thus the codec driver will not be built when select "Build all ASoC CODEC drivers".

Applied, thanks.