Skip to contentSkip to conversation

USB: pxa168: Fix compilation error

PATCH Superseded Tanmay Upadhyay 3 participants 4 messages Dec 6, 2011 – Dec 8, 2011

Subsystems (2)
USB USB ehci driver
lore
Share & tools
lore

Tanmay Upadhyay

author
#0 lore raw

PATCH 1/1 USB: pxa168: Fix compilation error

After commit c430131a02d677aa708f56342c1565edfdacb3c0, HC_LENGTH takes two arguments. This patch fixes following compilation error:

In file included from drivers/usb/host/ehci-hcd.c:1323:
drivers/usb/host/ehci-pxa168.c:302:54: error: macro "HC_LENGTH" requires 2 arguments, but only 1 given In file included from drivers/usb/host/ehci-hcd.c:1323:
drivers/usb/host/ehci-pxa168.c: In function 'ehci_pxa168_drv_probe':
drivers/usb/host/ehci-pxa168.c:302: error: 'HC_LENGTH' undeclared (first use in this function) drivers/usb/host/ehci-pxa168.c:302: error: (Each undeclared identifier is reported only once drivers/usb/host/ehci-pxa168.c:302: error: for each function it appears in.)

Signed-off-by Tanmay Upadhyay <[email protected]>
---
 drivers/usb/host/ehci-pxa168.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/host/ehci-pxa168.c +1 -1
index ac0c16e..8d0e7a2 100644
@@ -299,7 +299,7 @@ static int __devinit ehci_pxa168_drv_probe(struct platform_device *pdev)
 	ehci = hcd_to_ehci(hcd);
 	ehci->caps = hcd->regs + 0x100;
 	ehci->regs = hcd->regs + 0x100 +
-		HC_LENGTH(ehci_readl(ehci, &ehci->caps->hc_capbase));
+		HC_LENGTH(ehci, ehci_readl(ehci, &ehci->caps->hc_capbase));
 	ehci->hcs_params = ehci_readl(ehci, &ehci->caps->hcs_params);
 	hcd->has_tt = 1;
 	ehci->sbrn = 0x20;
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 USB: pxa168: Fix compilation error

Hello.

Quoted 1 line · Tanmay Upadhyay

After commit c430131a02d677aa708f56342c1565edfdacb3c0,

Please also specify that commit's summary in parens.

Quoted 11 lines

HC_LENGTH takes two arguments. This patch fixes following compilation error:

In file included from drivers/usb/host/ehci-hcd.c:1323:
drivers/usb/host/ehci-pxa168.c:302:54: error: macro "HC_LENGTH" requires 2 arguments, but only 1 given In file included from drivers/usb/host/ehci-hcd.c:1323:
drivers/usb/host/ehci-pxa168.c: In function 'ehci_pxa168_drv_probe':
drivers/usb/host/ehci-pxa168.c:302: error: 'HC_LENGTH' undeclared (first use in this function) drivers/usb/host/ehci-pxa168.c:302: error: (Each undeclared identifier is reported only once drivers/usb/host/ehci-pxa168.c:302: error: for each function it appears in.)

Quoted 1 line
Signed-off-by Tanmay Upadhyay<[email protected]>

WBR, Sergei

author
#2 lore raw

PATCH v2 1/1 USB: pxa168: Fix compilation error

After commit c430131a02d677aa708f56342c1565edfdacb3c0 (Support controllers with big endian capability regs), HC_LENGTH takes two arguments. This patch fixes following compilation error:

In file included from drivers/usb/host/ehci-hcd.c:1323:
drivers/usb/host/ehci-pxa168.c:302:54: error: macro "HC_LENGTH" requires 2 arguments, but only 1 given In file included from drivers/usb/host/ehci-hcd.c:1323:
drivers/usb/host/ehci-pxa168.c: In function 'ehci_pxa168_drv_probe':
drivers/usb/host/ehci-pxa168.c:302: error: 'HC_LENGTH' undeclared (first use in this function) drivers/usb/host/ehci-pxa168.c:302: error: (Each undeclared identifier is reported only once drivers/usb/host/ehci-pxa168.c:302: error: for each function it appears in.)

v2 - Added summary of the commit that caused this change

Signed-off-by Tanmay Upadhyay <[email protected]>
---
 drivers/usb/host/ehci-pxa168.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/host/ehci-pxa168.c +1 -1
index ac0c16e..8d0e7a2 100644
@@ -299,7 +299,7 @@ static int __devinit ehci_pxa168_drv_probe(struct platform_device *pdev)
 	ehci = hcd_to_ehci(hcd);
 	ehci->caps = hcd->regs + 0x100;
 	ehci->regs = hcd->regs + 0x100 +
-		HC_LENGTH(ehci_readl(ehci, &ehci->caps->hc_capbase));
+		HC_LENGTH(ehci, ehci_readl(ehci, &ehci->caps->hc_capbase));
 	ehci->hcs_params = ehci_readl(ehci, &ehci->caps->hcs_params);
 	hcd->has_tt = 1;
 	ehci->sbrn = 0x20;
Signature · 1 line
1.7.0.4
maintainer
#3 lore raw

PATCH 1/1 USB: pxa168: Fix compilation error

In reply to Tanmay Upadhyay
Quoted 22 lines · Tanmay Upadhyay

After commit c430131a02d677aa708f56342c1565edfdacb3c0, HC_LENGTH takes two arguments. This patch fixes following compilation error:

In file included from drivers/usb/host/ehci-hcd.c:1323:
drivers/usb/host/ehci-pxa168.c:302:54: error: macro "HC_LENGTH" requires 2 arguments, but only 1 given In file included from drivers/usb/host/ehci-hcd.c:1323:
drivers/usb/host/ehci-pxa168.c: In function 'ehci_pxa168_drv_probe':
drivers/usb/host/ehci-pxa168.c:302: error: 'HC_LENGTH' undeclared (first use in this function) drivers/usb/host/ehci-pxa168.c:302: error: (Each undeclared identifier is reported only once drivers/usb/host/ehci-pxa168.c:302: error: for each function it appears in.)

Signed-off-by Tanmay Upadhyay <[email protected]>
---
 drivers/usb/host/ehci-pxa168.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/host/ehci-pxa168.c +0 -0
index ac0c16e..8d0e7a2 100644

drivers/usb/host/ehci-pxa168.c static int __devinit ehci_pxa168_drv_probe(struct platform_device *pdev) · line 305

Quoted 8 lines
drivers/usb/host/ehci-pxa168.c +1 -1
@@ -299,7 +299,7 @@ static int __devinit ehci_pxa168_drv_probe(struct platform_device *pdev)
 	ehci = hcd_to_ehci(hcd);
 	ehci->caps = hcd->regs + 0x100;
 	ehci->regs = hcd->regs + 0x100 +
-		HC_LENGTH(ehci_readl(ehci, &ehci->caps->hc_capbase));
+		HC_LENGTH(ehci, ehci_readl(ehci, &ehci->caps->hc_capbase));
 	ehci->hcs_params = ehci_readl(ehci, &ehci->caps->hcs_params);
 	hcd->has_tt = 1;
 	ehci->sbrn = 0x20;
Acked-by Alan Stern <[email protected]>