arm, da8xx, mmc: set second MMC controllers default queue]
PATCH 1/1 arm, da8xx, mmc: set second MMC controllers default queue]
Hello Sekhar,
here the forwarded comment from Ido Yariv to my patch. I tried with current kernel MMC Controller 2 on my am1808 based board without my fix, and it works fine, so no need for applying my patch.
Thanks
bye,
Heiko
here the message from Ido:
Betreff: Re: [PATCH] arm, da8xx, mmc: set second MMC controllers default queue
Datum: Mon, 5 Dec 2011 10:35:10 +0200
Von: Ido Yariv <[email protected]>
An: [email protected]
CC: [email protected]
Referenzen: <[email protected]> <20111204102741.GL32400@WorkStation> <[email protected]>
Hi Heiko,
On Dec 5, 2011 10:08 AM, "Heiko Schocher" <[email protected]> wro
Quoted 3 lines
Ok ... patch not longer needed, but isn't it better to setup here immediately the right values? If so, I can sent a v2 with your suggested comment change.
These are just default values which will get overwritten later on, so im not sure if it matters much. I guess it wouldn't hurt to use default_queue instead of queue 1.
In any case, if you do chose to submit v2, the commit message should also be changed if it doesnt really fix anything.
Thanks,
Ido.
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi Heiko,
Quoted 11 lines · Heiko Schocher
Hello Sekhar,
here the forwarded comment from Ido Yariv to my patch. I tried with current kernel MMC Controller 2 on my am1808 based board without my fix, and it works fine, so no need for applying my patch.
Thanks
bye,
Heiko
Quoted 7 lines
here the message from Ido:
Betreff: Re: [PATCH] arm, da8xx, mmc: set second MMC controllers default queue
Datum: Mon, 5 Dec 2011 10:35:10 +0200
Von: Ido Yariv <ido-Ix1uc/[email protected]>
An: [email protected]
CC: [email protected]
I think Ido replied to only you and Juha, that's why even I am not able to see his reply on the list.
Quoted 4 lines
Referenzen: <1322991210-20486-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org> <20111204102741.GL32400@WorkStation> <[email protected]>
Hi Heiko,
Quoted 9 lines
On Dec 5, 2011 10:08 AM, "Heiko Schocher" <[email protected]> wro
Quoted 3 lines
Ok ... patch not longer needed, but isn't it better to setup here immediately the right values? If so, I can sent a v2 with your suggested comment change.
These are just default values which will get overwritten later on, so im not sure if it matters much. I guess it wouldn't hurt to use
default_queueinstead of queue 1.
It would have helped if you posted the complete message here but I figured this out. I assume that Ido's explanation is as below:
EDMA channel is allocated in MMC driver through the call to edma_alloc_channel() api and the last argument passed to this api is the event queue number. Currently the event queue number being passed is EVENTQ_DEFAULT. Inside edma_alloc_channel() there is a call to map_dmach_queue() which also takes event queue number as argument. map_dmach_queue() function initializes the event queue number to default_queue (being passed from platform data), if it is EVENTQ_DEFAULT.
I wanted to know why MMC/SD was not working initially for you even with this piece of code?
Quoted 2 lines
In any case, if you do chose to submit v2, the commit message should also be changed if it doesnt really fix anything.
I would still say, your patch is the clean way of addressing the issue. May be you can modify the commit message as Ido has pointed out.
Sekhar, do you have any comments?
Thanks,
Sudhakar
Hello Rajashekhara,
Quoted 14 lines · Sudhakar
Quoted 13 lines · Heiko Schocher
Hello Sekhar,
here the forwarded comment from Ido Yariv to my patch. I tried with current kernel MMC Controller 2 on my am1808 based board without my fix, and it works fine, so no need for applying my patch.
Thanks
bye,
Heikohere the message from Ido:
Quoted 7 lines
Quoted 5 lines
Betreff: Re: [PATCH] arm, da8xx, mmc: set second MMC controllers default queue
Datum: Mon, 5 Dec 2011 10:35:10 +0200
Von: Ido Yariv <[email protected]>
An: [email protected]
CC: [email protected]I think Ido replied to only you and Juha, that's why even I am not able to see his reply on the list.
Ah, yes, you are right, sorry missed that ...
Quoted 8 lines
Quoted 8 lines
Referenzen: <[email protected]> <20111204102741.GL32400@WorkStation> <[email protected]>
Hi Heiko,
On Dec 5, 2011 10:08 AM, "Heiko Schocher" <[email protected]> wro
Quoted 3 lines
Ok ... patch not longer needed, but isn't it better to setup here immediately the right values? If so, I can sent a v2 with your suggested comment change.
Quoted 7 lines
Quoted 4 lines
These are just default values which will get overwritten later on, so im not sure if it matters much. I guess it wouldn't hurt to use
default_queueinstead of queue 1.It would have helped if you posted the complete message here but I figured this out. I assume that Ido's explanation is as below:
Hmm.. that was the complete message ...
Quoted 7 lines
EDMA channel is allocated in MMC driver through the call to
edma_alloc_channel()api and the last argument passed to this api is the event queue number. Currently the event queue number being passed isEVENTQ_DEFAULT. Insideedma_alloc_channel()there is a call tomap_dmach_queue()which also takes event queue number as argument.map_dmach_queue()function initializes the event queue number todefault_queue(being passed from platform data), if it isEVENTQ_DEFAULT.
Yep, fully correct.
Quoted 2 lines
I wanted to know why MMC/SD was not working initially for you even with this piece of code?
Because I tested with Linux-3.1 where this patch wasn't included ...
Quoted 5 lines
Quoted 2 lines
In any case, if you do chose to submit v2, the commit message should also be changed if it doesnt really fix anything.
I would still say, your patch is the clean way of addressing the issue. May be you can modify the commit message as Ido has pointed out.
Ok, send a v2, thanks!
Quoted 1 line
Sekhar, do you have any comments?
bye,
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany