Skip to contentSkip to conversation

Append board name to version identifier

PATCH New Ed Swarthout 4 participants 4 messages Dec 7, 2011 – Dec 8, 2011

lore
Share & tools
lore

Ed Swarthout

author
#0 lore raw

PATCH 1/1 Append board name to version identifier

so it is printed as part of the version command and visible when displaying the image in the various flash banks.

This allows "strings u-boot.bin | head -1" to identify target:

VU-Boot 2011.09-01427-g6ee5cf2 (Dec 07 2011 - 11:11:55) P4080DS

Signed-off-by Ed Swarthout <[email protected]>
---
 include/version.h |    2 +-
 mkconfig          |    1 +
 2 files changed, 2 insertions(+), 1 deletions(-)
include/version.h +1 -1
index c908bd3..58f42e1 100644
@@ -35,7 +35,7 @@
 #endif
 
 #define U_BOOT_VERSION_STRING U_BOOT_VERSION " (" U_BOOT_DATE " - " \
-	U_BOOT_TIME ")" CONFIG_IDENT_STRING
+	U_BOOT_TIME ") " BOARD_NAME CONFIG_IDENT_STRING
 
 #ifndef __ASSEMBLY__
 extern const char version_string[];
mkconfig +1 -0
index 438530b..50bd731 100755
@@ -155,6 +155,7 @@ else
 	> config.h		# Create new config file
 fi
 echo "/* Automatically generated - do not edit */" >>config.h
+echo "#define BOARD_NAME \"${BOARD_NAME}\"" >>config.h
 
 for i in ${TARGETS} ; do
 	i="`echo ${i} | sed '/=/ {s/=/	/;q; } ; { s/$/	1/; }'`"
Signature · 1 line
1.5.6.5
#1 lore raw

PATCH 1/1 Append board name to version identifier

Dear Ed Swarthout,

Quoted 5 lines · In message <[email protected]> you…

so it is printed as part of the version command and visible when displaying the image in the various flash banks.

This allows "strings u-boot.bin | head -1" to identify target:

Quoted 7 lines

VU-Boot 2011.09-01427-g6ee5cf2 (Dec 07 2011 - 11:11:55) P4080DS

Signed-off-by Ed Swarthout <[email protected]>
---
 include/version.h |    2 +-
 mkconfig          |    1 +
 2 files changed, 2 insertions(+), 1 deletions(-)

I don't think this is a good idea, especially as it afects the user interface for all boards.

Please feel free to define local settings for boards that are maintained by you (oops... there aren't any...), but I don't want to change this globally.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Maintain an awareness for contribution --  to  your  schedule,  your
project, our company."                         - A Group of Employees
#2 lore raw

PATCH 1/1 Append board name to version identifier

Hi Ed,

Quoted 16 lines · Wolfgang Denk

Dear Ed Swarthout,

Quoted 5 lines · In message <[email protected]> you…

so it is printed as part of the version command and visible when displaying the image in the various flash banks.

This allows "strings u-boot.bin | head -1" to identify target:

Quoted 7 lines

VU-Boot 2011.09-01427-g6ee5cf2 (Dec 07 2011 - 11:11:55) P4080DS

Signed-off-by Ed Swarthout <[email protected]>
---
 include/version.h |    2 +-
 mkconfig          |    1 +
 2 files changed, 2 insertions(+), 1 deletions(-)
Quoted 6 lines

I don't think this is a good idea, especially as it afects the user interface for all boards.

Please feel free to define local settings for boards that are maintained by you (oops... there aren't any...), but I don't want to change this globally.

Instead, you can create the localversion-<something> file and the build system will take care of the rest, for example:

------------cut----------
~/git-repo/u-boot $ cat localversion-cm-t3730
-cm-t3730-1
------------cut----------

and it gives me:

U-Boot 2011.09-cm-t3730-1 (Oct 11 2011 - 11:52:34)

Signature · 2 lines
Regards,
Igor.
#3 lore raw

PATCH 1/1 Append board name to version identifier

In reply to Wolfgang Denk
Quoted 7 lines · On Wednesday 07 December 2011 13:39:06 Wolfgang Denk wrote:
Quoted 6 lines · Ed Swarthout

so it is printed as part of the version command and visible when displaying the image in the various flash banks.

This allows "strings u-boot.bin | head -1" to identify target:

VU-Boot 2011.09-01427-g6ee5cf2 (Dec 07 2011 - 11:11:55) P4080DS

this strings|head is arbitrary and just happens to work for your setup

Quoted 2 lines

I don't think this is a good idea, especially as it afects the user interface for all boards.

+1

Quoted 3 lines

Please feel free to define local settings for boards that are maintained by you (oops... there aren't any...), but I don't want to change this globally.

isn't there though ? for Blackfin boards, i just use checkboard() to include board info. but specifically for the version string, doesn't defining CONFIG_IDENT_STRING in the board's config work ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111207/39b4003c/attachment.pgp>