Skip to contentSkip to conversation

kvm_tools: fix build fail

PATCH In review Lai Jiangshan 3 participants 3 messages Dec 8, 2011 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kvm_tools: fix build fail

Commit e5fd47bfab2df0c2184cc0bf4245d8e1bb7724fb in -tip tree adds a "bool set_pm_idle_to_default(void);" to system.h which causes kvm_tool build fail:

In file included from include/kvm/barrier.h:13:0,
from virtio/core.c:5:
../../arch/x86/include/asm/system.h:404:6: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘set_pm_idle_to_default’

---

tools/kvm/include/kvm/barrier.h +1 -0
index c11a239..480276f 100644
@@ -7,6 +7,7 @@
  * Provide the dependencies here - we can drop these wrappers once
  * the header is fixed upstream:
  */
+#include <stdbool.h>
 #include <linux/stringify.h>
 #include <linux/bitops.h>
 #include <asm/alternative.h>
#1 lore raw

Hi Lai,

This was fixed in the KVM tools tree 2 days ago, but not pulled into -tip yet.

Thanks!

Quoted 27 lines · Lai Jiangshan

Commit e5fd47bfab2df0c2184cc0bf4245d8e1bb7724fb in -tip tree adds a "bool set_pm_idle_to_default(void);" to system.h which causes kvm_tool build fail:

In file included from include/kvm/barrier.h:13:0,
from virtio/core.c:5:
../../arch/x86/include/asm/system.h:404:6: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘set_pm_idle_to_default’

---

tools/kvm/include/kvm/barrier.h +1 -1
index c11a239..480276f 100644
@@ -7,6 +7,7 @@
  * Provide the dependencies here - we can drop these wrappers once
  * the header is fixed upstream:
  */
+#include <stdbool.h>
 #include <linux/stringify.h>
 #include <linux/bitops.h>
 #include <asm/alternative.h>
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 1 line
Sasha.
#2 lore raw
Quoted 4 lines · Sasha Levin

Hi Lai,

This was fixed in the KVM tools tree 2 days ago, but not pulled into -tip yet.

Hm, i do daily pulls, sometimes more often - and this fix i pulled two days ago and pushed it out into -tip, because i was hit by it too.

Lai, are you using the right URI for -tip? The latest URI is:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git

Thanks,

Ingo