Qt4 fixes
cover Qt4 fixes
A couple of fixes that I took the opportunity to do while I was testing building Qt 4.8.0 RC1. (Incidentally I will post the 4.8.0 recipes once the release is final, which reportedly should be within the next few weeks.)
The following changes since commit 493746f1d7f1410284880203c1ac462d61ab5299:
matchbox-session-sato: respect VIRTUAL-RUNTIME_initscripts settings (2011-12-07 12:42:22 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/qt4-debug
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/qt4-debug
Paul Eggleton (2):
qt4: fix debug symbol stripping
qt4: various tidy-ups
.../qt4/files/add_nostrip_for_debug_packages.diff | 23 ++++++++++++++++++++ meta/recipes-qt/qt4/qt-4.7.4.inc | 4 +-- meta/recipes-qt/qt4/qt4-embedded.inc | 3 +- meta/recipes-qt/qt4/qt4-embedded_4.7.4.bb | 2 +- meta/recipes-qt/qt4/qt4-native.inc | 3 +- meta/recipes-qt/qt4/qt4-native_4.7.4.bb | 2 - meta/recipes-qt/qt4/qt4-x11-free.inc | 4 +- meta/recipes-qt/qt4/qt4-x11-free_4.7.4.bb | 2 +- meta/recipes-qt/qt4/qt4.inc | 6 ++++- 9 files changed, 36 insertions(+), 13 deletions(-) create mode 100644 meta/recipes-qt/qt4/files/add_nostrip_for_debug_packages.diff
Signature · 1 line
1.7.5.4
PATCH 1/2 qt4: fix debug symbol stripping
Adds a patch imported from Debian to not strip the executables as part of the Qt build process. This fixes the warnings shown at packaging stage as well as the content of the debug symbol packages.
--- .../qt4/files/add_nostrip_for_debug_packages.diff | 23 ++++++++++++++++++++ meta/recipes-qt/qt4/qt-4.7.4.inc | 1 + meta/recipes-qt/qt4/qt4-embedded_4.7.4.bb | 2 +- meta/recipes-qt/qt4/qt4-x11-free_4.7.4.bb | 2 +- 4 files changed, 26 insertions(+), 2 deletions(-) create mode 100644 meta/recipes-qt/qt4/files/add_nostrip_for_debug_packages.diff
meta/recipes-qt/qt4/files/add_nostrip_for_debug_packages.diff new file +23 -0
@@ -0,0 +1,23 @@ +author: Fathi Boudra <[email protected]> + +Qt is built in release mode and strip files by default. +Set CONFIG+=nostrip to avoid the stripping and +let dh_strip do it to generate debug packages. + +Upstream-Status: Inappropriate [Configuration] + +--- + configure | 2 ++ + 1 file changed, 2 insertions(+) + +--- a/configure ++++ b/configure +@@ -627,6 +627,8 @@ mkdir -p "$outpath/config.tests" + rm -f "$outpath/config.tests/.qmake.cache" + cp "$QMAKE_VARS_FILE" "$outpath/config.tests/.qmake.cache" + ++QMakeVar add CONFIG nostrip ++ + QMakeVar add styles "cde mac motif plastique cleanlooks windows" + QMakeVar add decorations "default windows styled" + QMakeVar add mouse-drivers "pc"
meta/recipes-qt/qt4/qt-4.7.4.inc +1 -0
@@ -14,6 +14,7 @@ SRC_URI = "http://get.qt.nokia.com/qt/source/qt-everywhere-opensource-src-${PV}. file://0001-Added-Openembedded-crossarch-option.patch \ file://blacklist-diginotar-certs.diff \ file://fix-translations.patch \ + file://add_nostrip_for_debug_packages.diff \ file://g++.conf \ file://linux.conf \ file://fix-qtbug-20925.patch \
meta/recipes-qt/qt4/qt4-embedded_4.7.4.bb +1 -1
@@ -1,7 +1,7 @@ require qt-${PV}.inc require qt4-embedded.inc -PR = "${INC_PR}.3" +PR = "${INC_PR}.4" QT_CONFIG_FLAGS_append_armv6-vfp = " -no-neon "
meta/recipes-qt/qt4/qt4-x11-free_4.7.4.bb +1 -1
@@ -1,7 +1,7 @@ require qt4-x11-free.inc require qt-${PV}.inc -PR = "${INC_PR}.3" +PR = "${INC_PR}.4" QT_CONFIG_FLAGS_append_armv6-vfp = " -no-neon "
Signature · 1 line
1.7.5.4
PATCH 2/2 qt4: various tidy-ups
In reply to Paul Eggleton* -reduce-relocations is already specified in qt4.inc, no need to add it in qt-${PV}.inc
* Add QT_GLFLAGS to QT_CONFIG_FLAGS in qt4.inc rather than spreading it through other inc files.
* Add "-xmlpatterns -no-rpath -qt3support -silent" to QT_CONFIG_FLAGS in qt4.inc rather than qt-${PV}.inc; these have been supported since at least 4.5.2 and therefore shouldn't be version-specific.
* Move "-no-fast -silent -no-rpath" to EXTRA_OECONF in qt4-native.inc rather than the versioned recipes for the same reason
* Remove redundant setting of LICENSE in qt4-embedded.inc
--- meta/recipes-qt/qt4/qt-4.7.4.inc | 3 --- meta/recipes-qt/qt4/qt4-embedded.inc | 3 +-- meta/recipes-qt/qt4/qt4-native.inc | 3 ++- meta/recipes-qt/qt4/qt4-native_4.7.4.bb | 2 -- meta/recipes-qt/qt4/qt4-x11-free.inc | 4 ++-- meta/recipes-qt/qt4/qt4.inc | 6 +++++- 6 files changed, 10 insertions(+), 11 deletions(-)
meta/recipes-qt/qt4/qt-4.7.4.inc +0 -3
@@ -43,9 +43,6 @@ do_configure_prepend() { ${S}/configure } -QT_GLFLAGS ?= "" -QT_CONFIG_FLAGS += " -xmlpatterns -no-rpath -qt3support -reduce-relocations -silent ${QT_GLFLAGS}" - do_compile() { # Fixup missing wsegl header in some SGX SDKs if ! [ -e ${STAGING_INCDIR}/wsegl.h ] ; then
meta/recipes-qt/qt4/qt4-embedded.inc +1 -2
@@ -1,9 +1,8 @@ DESCRIPTION = "Qt is a versatile cross-platform application framework -- this is the embedded version." SECTION = "libs" -LICENSE = "LGPLv2.1 | GPLv3" HOMEPAGE = "http://qt.nokia.com" DEPENDS += "directfb tslib" -INC_PR = "r37" +INC_PR = "r38" QT_BASE_NAME ?= "qt4-embedded" QT_BASE_LIB ?= "libqt-embedded"
meta/recipes-qt/qt4/qt4-native.inc +2 -1
@@ -31,7 +31,8 @@ EXTRA_OECONF = "-prefix ${prefix} \ -verbose -release \ -embedded -no-freetype -no-glib -no-iconv \ -exceptions -xmlpatterns \ - -qt3support" + -qt3support \ + -no-fast -silent -no-rpath" # yank default -e, otherwise we get the following error: # moc_qbuffer.cpp: No such file or directory
meta/recipes-qt/qt4/qt4-native_4.7.4.bb +0 -2
@@ -8,8 +8,6 @@ SRC_URI += "file://blacklist-diginotar-certs.diff \ # Find the g++.conf/linux.conf in the right directory. FILESEXTRAPATHS =. "${FILE_DIRNAME}/qt-${PV}:" -EXTRA_OECONF += " -no-fast -silent -no-rpath" - TOBUILD := "src/tools/bootstrap ${TOBUILD}" SRC_URI[md5sum] = "9831cf1dfa8d0689a06c2c54c5c65aaf"
meta/recipes-qt/qt4/qt4-x11-free.inc +2 -2
@@ -5,12 +5,12 @@ HOMEPAGE = "http://qt.nokia.com" SECTION = "x11/libs" DEPENDS += "virtual/libgl virtual/libx11 fontconfig libxft libxext libxrender libxrandr libxcursor" -INC_PR = "r34" +INC_PR = "r35" QT_GLFLAGS ?= "${@base_contains('DISTRO_FEATURES', 'opengl', '-opengl', '-no-opengl', d)} " QT_GLFLAGS_qemux86 = "-opengl" QT_GLFLAGS_qemuppc = "-opengl" -QT_CONFIG_FLAGS += "-no-xinerama -no-xkb ${QT_GLFLAGS}" +QT_CONFIG_FLAGS += "-no-xinerama -no-xkb" QT_BASE_NAME ?= "qt4" QT_BASE_LIB ?= "libqt"
meta/recipes-qt/qt4/qt4.inc +5 -1
@@ -11,12 +11,16 @@ QT_DISTRO_FLAGS_linuxstdbase = "-sm" QT_SQL_DRIVER_FLAGS ?= "-no-sql-ibase -no-sql-mysql -no-sql-psql -no-sql-odbc -plugin-sql-sqlite" +QT_GLFLAGS ?= "" + QT_CONFIG_FLAGS += "-release -no-cups -reduce-relocations \ -shared -no-nas-sound -no-nis \ -qt-gif -system-libjpeg -system-libpng -system-zlib \ -no-pch -qdbus -stl -glib -phonon -webkit \ + -xmlpatterns -no-rpath -qt3support -silent \ ${QT_SQL_DRIVER_FLAGS} \ - ${QT_DISTRO_FLAGS} " + ${QT_DISTRO_FLAGS} \ + ${QT_GLFLAGS}" EXTRA_OEMAKE = "-e"
Signature · 1 line
1.7.5.4
Saul Wold
AppliedQuoted 27 lines · Paul Eggleton
A couple of fixes that I took the opportunity to do while I was testing building Qt 4.8.0 RC1. (Incidentally I will post the 4.8.0 recipes once the release is final, which reportedly should be within the next few weeks.)
The following changes since commit
493746f1d7f1410284880203c1ac462d61ab5299:matchbox-session-sato: respect VIRTUAL-RUNTIME_initscripts settings (2011-12-07 12:42:22 +0000)are available in the git repository at:
git://git.openembedded.org/openembedded-core-contribpaule/qt4-debug
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/qt4-debugPaul Eggleton (2):
qt4: fix debug symbol stripping
qt4: various tidy-ups.../qt4/files/add_nostrip_for_debug_packages.diff | 23 ++++++++++++++++++++ meta/recipes-qt/qt4/qt-4.7.4.inc | 4 +-- meta/recipes-qt/qt4/qt4-embedded.inc | 3 +- meta/recipes-qt/qt4/qt4-embedded_4.7.4.bb | 2 +- meta/recipes-qt/qt4/qt4-native.inc | 3 +- meta/recipes-qt/qt4/qt4-native_4.7.4.bb | 2 - meta/recipes-qt/qt4/qt4-x11-free.inc | 4 +- meta/recipes-qt/qt4/qt4-x11-free_4.7.4.bb | 2 +- meta/recipes-qt/qt4/qt4.inc | 6 ++++- 9 files changed, 36 insertions(+), 13 deletions(-)
Quoted 2 lines
create mode 100644
meta/recipes-qt/qt4/files/add_nostrip_for_debug_packages.diff
Merged into OE-Core
Thanks
Sau!