mfd: jz4740-adc: Include linux/io.h
PATCH 1/2 mfd: jz4740-adc: Include linux/io.h
Include linux/io.h to fix below build error:
CC drivers/mfd/jz4740-adc.odrivers/mfd/jz4740-adc.c: In function 'jz4740_adc_irq_demux':drivers/mfd/jz4740-adc.c:73: error: implicit declaration of function 'readb'drivers/mfd/jz4740-adc.c: In function 'jz4740_adc_set_enabled':drivers/mfd/jz4740-adc.c:110: error: implicit declaration of function 'writeb' drivers/mfd/jz4740-adc.c: In function 'jz4740_adc_set_config':drivers/mfd/jz4740-adc.c:146: error: implicit declaration of function 'readl' drivers/mfd/jz4740-adc.c:151: error: implicit declaration of function 'writel' drivers/mfd/jz4740-adc.c: In function 'jz4740_adc_probe':drivers/mfd/jz4740-adc.c:249: error: implicit declaration of function 'ioremap_nocache' drivers/mfd/jz4740-adc.c:249: warning: assignment makes pointer from integer without a cast drivers/mfd/jz4740-adc.c:289: warning: passing argument 3 of 'mfd_add_devices' discards qualifiers from pointer target type include/linux/mfd/core.h:93: note: expected 'struct mfd_cell *' but argument is of type 'const struct mfd_cell *' drivers/mfd/jz4740-adc.c:299: error: implicit declaration of function 'iounmap'
make[2]: *** [drivers/mfd/jz4740-adc.o] Error 1
make[1]: *** [drivers/mfd] Error 2
make: *** [drivers] Error 2
--- drivers/mfd/jz4740-adc.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mfd/jz4740-adc.c +1 -0
@@ -16,6 +16,7 @@*/ #include <linux/err.h> +#include <linux/io.h> #include <linux/irq.h> #include <linux/interrupt.h> #include <linux/kernel.h>
Signature · 1 line
1.7.5.4
PATCH 2/2 mfd: jz4740-adc: Don't declare jz4740_adc_cells const
Remove the const keyword to fix below warning:
CC drivers/mfd/jz4740-adc.odrivers/mfd/jz4740-adc.c: In function 'jz4740_adc_probe':drivers/mfd/jz4740-adc.c:290: warning: passing argument 3 of 'mfd_add_devices' discards qualifiers from pointer target type include/linux/mfd/core.h:93: note: expected 'struct mfd_cell *' but argument is of type 'const struct mfd_cell *'
Also make jz4740_adc_cells static, is not used outside this driver so no need to make the symbol global.
--- drivers/mfd/jz4740-adc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/jz4740-adc.c +1 -1
@@ -181,7 +181,7 @@ static struct resource jz4740_battery_resources[] = { }, }; -const struct mfd_cell jz4740_adc_cells[] = { +static struct mfd_cell jz4740_adc_cells[] = { { .id =0 , .name ="jz4740-hwmon" ,
Signature · 1 line
1.7.5.4
Quoted 20 lines · Axel Lin
Include
linux/io.hto fix below build error:CC
drivers/mfd/jz4740-adc.odrivers/mfd/jz4740-adc.c: In function 'jz4740_adc_irq_demux':drivers/mfd/jz4740-adc.c:73: error: implicit declaration of function 'readb'drivers/mfd/jz4740-adc.c: In function 'jz4740_adc_set_enabled':drivers/mfd/jz4740-adc.c:110: error: implicit declaration of function 'writeb'drivers/mfd/jz4740-adc.c: In function 'jz4740_adc_set_config':drivers/mfd/jz4740-adc.c:146: error: implicit declaration of function 'readl'drivers/mfd/jz4740-adc.c:151: error: implicit declaration of function 'writel'drivers/mfd/jz4740-adc.c: In function 'jz4740_adc_probe':drivers/mfd/jz4740-adc.c:249: error: implicit declaration of function 'ioremap_nocache'drivers/mfd/jz4740-adc.c:249: warning: assignment makes pointer from integer without a castdrivers/mfd/jz4740-adc.c:289: warning: passing argument 3 of 'mfd_add_devices' discards qualifiers from pointer target typeinclude/linux/mfd/core.h:93: note: expected 'structmfd_cell*' but argument is of type 'const structmfd_cell*'drivers/mfd/jz4740-adc.c:299: error: implicit declaration of function 'iounmap'
make[2]: *** [drivers/mfd/jz4740-adc.o] Error 1
make[1]: *** [drivers/mfd] Error 2
make: *** [drivers] Error 2
Quoted 1 line
Signed-off-by Axel Lin <[email protected]>
Quoted 16 lines
--- drivers/mfd/jz4740-adc.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/mfd/jz4740-adc.c +1
-0@@ -16,6 +16,7 @@*/ #include <linux/err.h> +#include <linux/io.h> #include <linux/irq.h> #include <linux/interrupt.h> #include <linux/kernel.h>
Hi Axel,
Quoted 1 line · Axel Lin
Include
linux/io.hto fix below build error:
Thanks. This one and the next one applied.
Cheers,
Samuel.
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/