How about adding Dbus log in gdbus?

PATCH Chanyeol Park 2 participants 3 messages Dec 9, 2011 – Dec 12, 2011 Bluetooth drivers

lore

Share & tools

lore

Chanyeol Park

author

2011-12-09 15:39 UTC #0 lore raw

Hello

How about adding dbus log in gdbus when we get method call from the remote peer(application)?

Personally It could be very useful for begginer.Based on it many people could understand call procedure easily. As far as I know this was removed when bluez 3.xx. but compared to the days, recently many dbus APIs have been introduced.

But I know it is relatetd to many projects(bluez,obexd,connman,ofono). So we need to consider a few things such as dependency managing and user preference. because curren gdbus does not have dependency with log.c/log.h.

Is there good idea about this?

BR
Chanyeol Park.

gdbus/object.c +4 -3

index 8bc12f5..ac7f448 100644
@@ -33,9 +33,7 @@
 
 #include "gdbus.h"
 
-#define info(fmt...)
-#define error(fmt...)
-#define debug(fmt...)
+#include "log.h"
 
 struct generic_data {
        unsigned int refcount;

@@ -444,6 +442,9 @@ static DBusHandlerResult generic_message(DBusConnection *connection,
                                                iface->user_data) == TRUE)
                        return DBUS_HANDLER_RESULT_HANDLED;
 
+               DBG("%s: %s.%s()",dbus_message_get_path(message),
+                                               iface->name,method->name);
+
                return process_message(connection, message, method,
                                                        iface->user_data);
        }

Thanks
Chanyeol Park

Luiz Augusto von Dentz

maintainer

2011-12-09 21:08 UTC #1 lore raw

Hi Chanyeol,

2011/12/9 Chanyeol Park <[email protected]>:

Quoted 11 lines

Hello
How about adding dbus log in gdbus when we get method call from the remote peer(application)?
Personally It could be very useful for begginer.Based on it many people could understand
call procedure easily. As far as I know this was removed when bluez 3.xx. but compared to the days,
recently many dbus APIs have been introduced.

Quoted 6 lines

But I know it is relatetd to many projects(bluez,obexd,connman,ofono). So we need to consider a few things such as dependency managing and user preference.
because curren gdbus does not have dependency with log.c/log.h.
Is there good idea about this?

Yes it is probably a good idea, but I would suggest we have some environment e.g. GDBUS_DEBUG to enable/disable it. Also while talking to Johan about this he suggested to have some function to register the callback/handler to log, so the projects using gdbus can register their own function.

Signature · 1 line

Luiz Augusto von Dentz

Chanyeol Park

author

2011-12-12 12:57 UTC #2 lore raw

Quoted 19 lines · Luiz Augusto von Dentz

Hi Chanyeol,
2011/12/9 Chanyeol Park<[email protected]>:
Quoted 16 lines
Hello
How about adding dbus log in gdbus when we get method call from the remote peer(application)?
Personally It could be very useful for begginer.Based on it many people could understand
call procedure easily. As far as I know this was removed when bluez 3.xx. but compared to the days,
recently many dbus APIs have been introduced.
But I know it is relatetd to many projects(bluez,obexd,connman,ofono). So we need to consider a few things such as dependency managing and user preference.
because curren gdbus does not have dependency with log.c/log.h.

Quoted 6 lines

Quoted 1 line
Is there good idea about this?
Yes it is probably a good idea, but I would suggest we have some environment e.g. GDBUS_DEBUG to enable/disable it. Also while talking to Johan about this he suggested to have some function to register the callback/handler to log, so the projects using gdbus can register their own function.

Is it possible to relate this with bluez/obexd enable/disable debug feature? Personally if we start to use environment variable(GDBUS_DEBUG), it would be difficult to use it.

Johan: Could you explain me what you think or suggest?

Thanks
Chanyeol Park