Skip to contentSkip to conversation

gfs2-utils: Add gfs2-cluster systemd unit

PATCH New Andrew Price 3 participants 6 messages Dec 13, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gfs2-utils: Add gfs2-cluster systemd unit

Adds a systemd unit file to start gfs_controld at the correct point in the boot sequence. I've tested this as much as I can on Fedora 16 but it may require some more tweaking once the init scripts for cman, clvmd, etc. have been migrated. The gfs2 init script has not been migrated as systemd should now handle mounting of gfs2 file systems specially, after remote-fs-pre.target.

---
 gfs2/system/gfs2-cluster.service |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
 create mode 100644 gfs2/system/gfs2-cluster.service
gfs2/system/gfs2-cluster.service new file +12 -0
new file mode 100644
index 0000000..d6bc0ca
@@ -0,0 +1,12 @@
+[Unit]
+Description=GFS2 Control Daemon
+After=syslog.target network.target cman.service
+Before=remote-fs-pre.target
+Wants=remote-fs-pre.target
+
+[Service]
+Type=forking
+ExecStart=/usr/sbin/gfs_controld $OPTIONS
+
+[Install]
+WantedBy=multi-user.target
Signature · 1 line
1.7.6.4
#1 lore raw

PATCH 1/1 gfs2-utils: Add gfs2-cluster systemd unit

Hi,

Quoted 21 lines · Andrew Price

Adds a systemd unit file to start gfs_controld at the correct point in the boot sequence. I've tested this as much as I can on Fedora 16 but it may require some more tweaking once the init scripts for cman, clvmd, etc. have been migrated. The gfs2 init script has not been migrated as systemd should now handle mounting of gfs2 file systems specially, after remote-fs-pre.target.

---
 gfs2/system/gfs2-cluster.service |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
 create mode 100644 gfs2/system/gfs2-cluster.service
gfs2/system/gfs2-cluster.service new file +2 -0
new file mode 100644
index 0000000..d6bc0ca
@@ -0,0 +1,12 @@
+[Unit]
+Description=GFS2 Control Daemon

gfs2/system/gfs2-cluster.service line 12

Quoted 10 lines
gfs2/system/gfs2-cluster.service new file +10 -0
+After=syslog.target network.target cman.service
+Before=remote-fs-pre.target
+Wants=remote-fs-pre.target
+
+[Service]
+Type=forking
+ExecStart=/usr/sbin/gfs_controld $OPTIONS
+
+[Install]
+WantedBy=multi-user.target

We probably don't need the $OPTIONS, but it will probably do no harm either. Otherwise looks good,

Steve.

#2 lore raw

PATCH 1/1 gfs2-utils: Add gfs2-cluster systemd unit

In reply to Andrew Price
Quoted 6 lines · Andrew Price

Adds a systemd unit file to start gfs_controld at the correct point in the boot sequence. I've tested this as much as I can on Fedora 16 but it may require some more tweaking once the init scripts for cman, clvmd, etc. have been migrated. The gfs2 init script has not been migrated as systemd should now handle mounting of gfs2 file systems specially, after remote-fs-pre.target.

cman will not migrate to systemd, but I am a bit puzzled because I thought that gfs_controld will go away? Is there a point to go through this transition at all?

Fabio

#3 lore raw

PATCH 1/1 gfs2-utils: Add gfs2-cluster systemd unit

Hi,

Quoted 8 lines · Fabio M. Di Nitto
Quoted 6 lines · Andrew Price

Adds a systemd unit file to start gfs_controld at the correct point in the boot sequence. I've tested this as much as I can on Fedora 16 but it may require some more tweaking once the init scripts for cman, clvmd, etc. have been migrated. The gfs2 init script has not been migrated as systemd should now handle mounting of gfs2 file systems specially, after remote-fs-pre.target.

Quoted 6 lines

cman will not migrate to systemd, but I am a bit puzzled because I thought that gfs_controld will go away? Is there a point to go through this transition at all?

Fabio

I think that is unlikely to happen before f17 and we need to migrate before then I think. So its a question of timing. We'll probably have to keep gfs_controld for a few fedora versions yet bearing in mind that the kernel patches are not upstream yet.

We are still carrying mount.gfs2 in the utils, even though that has not been required for some time, and is not currently part of the fedora package, for example. I'm expecting that we'll have to do the same with gfs_controld,

Steve.

#5 lore raw

PATCH 1/1 gfs2-utils: Add gfs2-cluster systemd unit

Quoted 10 lines · Andrew Price
Quoted 1 line · Fabio M. Di Nitto

cman will not migrate to systemd

Just curious, but why? Wouldn't it risk getting cman blocked from fedora?

(
https://lists.fedoraproject.org/pipermail/devel/2011-November/159157.html )

Andy

Because systemd is not capable of handling the complexity of cman init script last I checked, and since it?s highly probable that we will remove cman before F17 anyway, there is no point to invest resources there.

Fabio