Skip to contentSkip to conversation

Python: add external modules option

PATCH Superseded yegorslists at googlemail.com 4 participants 6 messages Dec 14, 2011 – Dec 19, 2011

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

yegorslists at googlemail.com

author
#0 lore raw

PATCH v2 1/2 Python: add external modules option

From: Yegor Yefremov <[email protected]>

all external python packages/libraries should reside in "external python modules" section.

Move existing modules python-serial and python-mad there

Move python-mad from package/multimedia to package

Signed-off-by Yegor Yefremov <[email protected]>
---
 package/Config.in                           |    7 ++++-
 package/multimedia/Config.in                |    1 -
 package/multimedia/python-mad/Config.in     |    9 ------
 package/multimedia/python-mad/python-mad.mk |   41 ---------------------------
 package/python-mad/Config.in                |    9 ++++++
 package/python-mad/python-mad.mk            |   41 +++++++++++++++++++++++++++
 6 files changed, 56 insertions(+), 52 deletions(-)
 delete mode 100644 package/multimedia/python-mad/Config.in
 delete mode 100644 package/multimedia/python-mad/python-mad.mk
 create mode 100644 package/python-mad/Config.in
 create mode 100644 package/python-mad/python-mad.mk
package/Config.in +6 -1
index eb93b1c..6ab893f 100644
@@ -236,6 +236,12 @@ endif
 source "package/microperl/Config.in"
 source "package/php/Config.in"
 source "package/python/Config.in"
+if BR2_PACKAGE_PYTHON
+menu "external python modules"
+source "package/python-mad/Config.in"
+source "package/python-serial/Config.in"
+endmenu
+endif
 source "package/ruby/Config.in"
 source "package/tcl/Config.in"
 endmenu

@@ -312,7 +318,6 @@ source "package/libhid/Config.in"
 source "package/libiqrf/Config.in"
 source "package/libusb/Config.in"
 source "package/libusb-compat/Config.in"
-source "package/python-serial/Config.in"
 endmenu
 
 if BROKEN
package/multimedia/Config.in +0 -1
index d50e4fc..a05d1d9 100644
@@ -40,7 +40,6 @@ source "package/multimedia/mplayer/Config.in"
 source "package/multimedia/musepack/Config.in"
 source "package/multimedia/portaudio/Config.in"
 source "package/multimedia/pulseaudio/Config.in"
-source "package/multimedia/python-mad/Config.in"
 source "package/multimedia/speex/Config.in"
 source "package/multimedia/tidsp-binaries/Config.in"
 source "package/multimedia/taglib/Config.in"
package/multimedia/python-mad/Config.in deleted +0 -9
deleted file mode 100644
index 2535421..0000000
@@ -1,9 +0,0 @@
-config BR2_PACKAGE_PYTHON_MAD
-	bool "python-mad"
-	depends on BR2_PACKAGE_PYTHON
-	select BR2_PACKAGE_LIBMAD
-	help
-	  python-mad is a Python binding for the MAD library, a
-	  high-quality integer-only MPEG decoder.
-
-	  http://spacepants.org/src/pymad/
package/multimedia/python-mad/python-mad.mk deleted +0 -41

41 lines not on this page · raw message

package/python-mad/Config.in new file +9 -0
new file mode 100644
index 0000000..2535421
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_PYTHON_MAD
+	bool "python-mad"
+	depends on BR2_PACKAGE_PYTHON
+	select BR2_PACKAGE_LIBMAD
+	help
+	  python-mad is a Python binding for the MAD library, a
+	  high-quality integer-only MPEG decoder.
+
+	  http://spacepants.org/src/pymad/
package/python-mad/python-mad.mk new file +41 -0

41 lines not on this page · raw message

Signature · 1 line
1.7.1.1
author
#1 lore raw

PATCH v2 2/2 New package: python-dpkt

From: Yegor Yefremov <[email protected]>

python-dpkt-setup.patch removes dpkt inclusion in setup.py and stores package metadata directly in setup.py. This avoids unneeded host-python dependencies like zlib

Signed-off-by Yegor Yefremov <[email protected]>
---
 package/Config.in                           |    1 +
 package/python-dpkt/Config.in               |   11 +++++++++++
 package/python-dpkt/python-dpkt-setup.patch |   23 +++++++++++++++++++++++
 package/python-dpkt/python-dpkt.mk          |   22 ++++++++++++++++++++++
 4 files changed, 57 insertions(+), 0 deletions(-)
 create mode 100644 package/python-dpkt/Config.in
 create mode 100644 package/python-dpkt/python-dpkt-setup.patch
 create mode 100644 package/python-dpkt/python-dpkt.mk
package/Config.in +1 -0
index 6ab893f..bb5e5b0 100644
@@ -238,6 +238,7 @@ source "package/php/Config.in"
 source "package/python/Config.in"
 if BR2_PACKAGE_PYTHON
 menu "external python modules"
+source "package/python-dpkt/Config.in"
 source "package/python-mad/Config.in"
 source "package/python-serial/Config.in"
 endmenu
package/python-dpkt/Config.in new file +11 -0
new file mode 100644
index 0000000..aac9f09
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_PYTHON_DPKT
+	bool "python-dpkt"
+	depends on BR2_PACKAGE_PYTHON
+	select BR2_PACKAGE_PYTHON_ZLIB
+	help
+	  Fast, simple packet creation / parsing, with definitions
+	  for the basic TCP/IP protocols.
+
+	  http://code.google.com/p/dpkt/
+
+
package/python-dpkt/python-dpkt-setup.patch new file +23 -0
new file mode 100644
index 0000000..d6f24ce
@@ -0,0 +1,23 @@
+---
+ setup.py |    7 +++----
+ 1 file changed, 3 insertions(+), 4 deletions(-)
+
+Index: b/setup.py
+===================================================================
+--- a/setup.py
++++ b/setup.py
+@@ -1,11 +1,10 @@
+ #!/usr/bin/env python
+
+ from distutils.core import setup
+-import dpkt
+
+ setup(name='dpkt',
+-      version=dpkt.__version__,
+-      author=dpkt.__author__,
+-      url=dpkt.__url__,
++      version='1.7',
++      author='Dug Song <[email protected]>',
++      url='http://dpkt.googlecode.com/',
+       description='dumb packet module',
+       packages=[ 'dpkt' ])
package/python-dpkt/python-dpkt.mk new file +22 -0
new file mode 100644
index 0000000..7ac873c
@@ -0,0 +1,22 @@
+#############################################################
+#
+# python-dpkt
+#
+#############################################################
+
+PYTHON_DPKT_VERSION = 1.7
+PYTHON_DPKT_SOURCE  = dpkt-$(PYTHON_DPKT_VERSION).tar.gz
+PYTHON_DPKT_SITE    = http://dpkt.googlecode.com/files
+
+PYTHON_DPKT_DEPENDENCIES = python
+
+define PYTHON_DPKT_BUILD_CMDS
+	(cd $(@D); $(HOST_DIR)/usr/bin/python setup.py build)
+endef
+
+define PYTHON_DPKT_INSTALL_TARGET_CMDS
+	(cd $(@D); $(HOST_DIR)/usr/bin/python setup.py install --prefix=$(TARGET_DIR)/usr)
+endef
+
+$(eval $(call GENTARGETS))
+
Signature · 1 line
1.7.1.1
#2 lore raw

PATCH v2 2/2 New package: python-dpkt

Le Wed, 14 Dec 2011 15:36:26 +0100,
yegorslists at googlemail.com a ?crit :

package/python-dpkt/python-dpkt-setup.patch line 2

Quoted 5 lines
package/python-dpkt/python-dpkt-setup.patch new file +2 -0
@@ -0,0 +1,23 @@
+---
+ setup.py |    7 +++----

Description + SoB line needed here. And also push upstream the patch explaining why it is stupid do depends on the Python module to be installed during the build process.

package/python-dpkt/python-dpkt-setup.patch line 3

Quoted 1 line
package/python-dpkt/python-dpkt-setup.patch new file +1 -0
+PYTHON_DPKT_SOURCE  = dpkt-$(PYTHON_DPKT_VERSION).tar.gz

That's the default value, so it could be dropped.

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#3 lore raw

PATCH v2 2/2 New package: python-dpkt

Am 14.12.2011 16:25, schrieb Thomas Petazzoni:

Quoted 12 lines

Le Wed, 14 Dec 2011 15:36:26 +0100,
yegorslists at googlemail.com a ?crit :

package/python-dpkt/python-dpkt-setup.patch line 2

Quoted 5 lines
package/python-dpkt/python-dpkt-setup.patch new file +2 -0
@@ -0,0 +1,23 @@
+---
+ setup.py |    7 +++----

Description + SoB line needed here. And also push upstream the patch explaining why it is stupid do depends on the Python module to be installed during the build process.

ACK

Quoted 3 lines

package/python-dpkt/python-dpkt-setup.patch line 3

Quoted 1 line
package/python-dpkt/python-dpkt-setup.patch new file +1 -0
+PYTHON_DPKT_SOURCE  = dpkt-$(PYTHON_DPKT_VERSION).tar.gz

That's the default value, so it could be dropped.

No. It can't. Because the BR package is called python-dpkt and real package dpkt.

Best regards,
Yegor

#4 lore raw

PATCH v2 2/2 New package: python-dpkt

Le Wed, 14 Dec 2011 16:36:00 +0100,
Yegor Yefremov <[email protected]> a ?crit :

Quoted 1 line

No. It can't. Because the BR package is called python-dpkt and real package dpkt.

Ok, my bad, you're obviously right on this point.

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#5 lore raw

PATCH v2 1/2 Python: add external modules option

In reply to yegorslists at googlemail.com
Quoted 10 lines · On Wednesday 14 December 2011 15:36:25 yegorslists at googlemail.com wrote:

From: Yegor Yefremov <[email protected]>

all external python packages/libraries should reside in "external python modules" section.

Move existing modules python-serial and python-mad there

Move python-mad from package/multimedia to package

Signed-off-by Yegor Yefremov <[email protected]>
Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43