Skip to contentSkip to conversation

arm, davinci: Fix build warnings for cam_enc_4xx

PATCH New Christian Riesch 4 participants 4 messages Dec 14, 2011 – Dec 15, 2011 Arm (32-bit)

lore
Share & tools
lore

Christian Riesch

author
#0 lore raw

PATCH 1/1 arm, davinci: Fix build warnings for cam_enc_4xx

This patch fixes a build warning for the cam_enc_4xx board introduced by commit d6ec0c0dfc70447cf615ae80a952da81f73f16b4:

spl.c:35:13: warning: 'gdata' defined but not used spl.c:36:13: warning: 'bdata' defined but not used

Signed-off-by Christian Riesch <[email protected]>
Cc Tom Rini <[email protected]>
Cc Heiko Schocher <[email protected]>

---

Hi,
this patch applies on top of the ti/next branch.
Thanks, Christian

 arch/arm/cpu/arm926ejs/davinci/spl.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/cpu/arm926ejs/davinci/spl.c +3 -2
index 20f798e..f475f9b 100644
@@ -29,13 +29,14 @@
 #include <malloc.h>
 #include <spi_flash.h>
 
-DECLARE_GLOBAL_DATA_PTR;
+#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
 
+DECLARE_GLOBAL_DATA_PTR;
 /* Define global data structure pointer to it*/
 static gd_t gdata __attribute__ ((section(".data")));
 static bd_t bdata __attribute__ ((section(".data")));
 
-#ifndef CONFIG_SPL_LIBCOMMON_SUPPORT
+#else
 
 void puts(const char *str)
 {
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 arm, davinci: Fix build warnings for cam_enc_4xx

Quoted 9 lines · Christian Riesch

This patch fixes a build warning for the cam_enc_4xx board introduced by commit d6ec0c0dfc70447cf615ae80a952da81f73f16b4:

spl.c:35:13: warning: 'gdata' defined but not used spl.c:36:13: warning: 'bdata' defined but not used

Signed-off-by Christian Riesch <[email protected]>
Cc Tom Rini <[email protected]>
Cc Heiko Schocher <[email protected]>

Applied to u-boot-ti/next, thanks!

Signature · 1 line
Tom
#2 lore raw

PATCH 1/1 arm, davinci: Fix build warnings for cam_enc_4xx

In reply to Christian Riesch

Hello Christian,

Quoted 6 lines · Christian Riesch

This patch fixes a build warning for the cam_enc_4xx board introduced by commit d6ec0c0dfc70447cf615ae80a952da81f73f16b4:

spl.c:35:13: warning: 'gdata' defined but not used spl.c:36:13: warning: 'bdata' defined but not used

Quoted 8 lines
Signed-off-by Christian Riesch <[email protected]>
Cc Tom Rini <[email protected]>
Cc Heiko Schocher <[email protected]>

---

Hi,
this patch applies on top of the ti/next branch.
Thanks, Christian

Tested on the cam_enc_4x board, thanks!

Also too late, but:

Acked-by Heiko Schocher <[email protected]>
Tested-by Heiko Schocher <[email protected]>

@Tom: Could you please wait 1-2 days before applying patches, so people could test them ;-) Thanks

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#3 lore raw

PATCH 1/1 arm, davinci: Fix build warnings for cam_enc_4xx

Quoted 20 lines · Heiko Schocher

Hello Christian,

Quoted 6 lines · Christian Riesch

This patch fixes a build warning for the cam_enc_4xx board introduced by commit d6ec0c0dfc70447cf615ae80a952da81f73f16b4:

spl.c:35:13: warning: 'gdata' defined but not used spl.c:36:13: warning: 'bdata' defined but not used

Quoted 8 lines
Signed-off-by Christian Riesch <[email protected]>
Cc Tom Rini <[email protected]>
Cc Heiko Schocher <[email protected]>

---

Hi,
this patch applies on top of the ti/next branch.
Thanks, Christian

Tested on the cam_enc_4x board, thanks!

Quoted 7 lines

Also too late, but:

Acked-by Heiko Schocher <[email protected]>
Tested-by Heiko Schocher <[email protected]>

@Tom: Could you please wait 1-2 days before applying patches, so people could test them ;-) Thanks

As a general rule, yes, I am trying to make sure I do. But for things like warning fixes or things I can verify by inspection, I might pick them up quicker :)

Signature · 1 line
Tom