arm/km: speed up i2c access for keymile boards

PATCH New Holger Brunck 3 participants 6 messages Dec 14, 2011 – Feb 8, 2012

Share & tools

Holger Brunck

author

2011-12-14 15:31 UTC #0 lore raw

PATCH 1/2 arm/km: speed up i2c access for keymile boards

We don't need 3us delay for our i2c bus. Decrease it to 1us. It would also be possible to use 100ns in the future, but currently kirkwood has no ndelay implementation.

Signed-off-by Holger Brunck <[email protected]>

Cc Valentin Longchamp <[email protected]>

Cc Prafulla Wadaskar <[email protected]>

Cc Heiko Schocher <[email protected]>

---
 include/configs/km/km_arm.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

include/configs/km/km_arm.h +1 -1

index 700124c..ca84932 100644
@@ -195,7 +195,7 @@ int get_scl(void);
 #define I2C_SCL(bit)	kw_gpio_set_value(KM_KIRKWOOD_SCL_PIN, bit)
 #endif
 
-#define I2C_DELAY	udelay(3)	/* 1/4 I2C clock duration */
+#define I2C_DELAY	udelay(1)
 #define I2C_SOFT_DECLARATIONS
 
 #endif

Signature · 1 line

1.7.1

Holger Brunck

author

2012-02-08 08:49 UTC #1 lore raw

PATCH 1/2 arm/km: speed up i2c access for keymile boards

Hi Prafulla,

Quoted 4 lines · Holger Brunck

We don't need 3us delay for our i2c bus. Decrease it to 1us. It would also be possible to use 100ns in the future, but currently kirkwood has no ndelay implementation.

Quoted 8 lines

Signed-off-by Holger Brunck <[email protected]>
Cc Valentin Longchamp <[email protected]>
Cc Prafulla Wadaskar <[email protected]>
Cc Heiko Schocher <[email protected]>
---
 include/configs/km/km_arm.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

can you pull these two small updates for km_arm or is something misssing?

Thanks!

Regards
Holger

Prafulla Wadaskar

2012-02-08 09:47 UTC #2 lore raw

PATCH 1/2 arm/km: speed up i2c access for keymile boards

Quoted 26 lines

-----Original Message-----
From: Holger Brunck [mailto:holger.brunck at keymile.com]
Sent: 08 February 2012 14:20
To: Prafulla Wadaskar
Cc: u-boot at lists.denx.de; Valentin Longchamp; Heiko Schocher
Subject: Re: [PATCH 1/2] arm/km: speed up i2c access for keymile boards
Hi Prafulla,
Quoted 4 lines · Holger Brunck
We don't need 3us delay for our i2c bus. Decrease it to 1us. It would also be possible to use 100ns in the future, but currently kirkwood has no ndelay implementation.
Quoted 8 lines
Signed-off-by Holger Brunck <[email protected]>
Cc Valentin Longchamp <[email protected]>
Cc Prafulla Wadaskar <[email protected]>
Cc Heiko Schocher <[email protected]>
---
 include/configs/km/km_arm.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Quoted 2 lines

can you pull these two small updates for km_arm or is something misssing?

Applied both to u-boot-marvell.git master branch

Regards..
Prafulla . . .

Heiko Schocher

2011-12-15 06:30 UTC #3 lore raw

PATCH 1/2 arm/km: speed up i2c access for keymile boards

In reply to Holger Brunck

Hello Holger,

Quoted 11 lines · Holger Brunck

We don't need 3us delay for our i2c bus. Decrease it to 1us. It would also be possible to use 100ns in the future, but currently kirkwood has no ndelay implementation.
Signed-off-by Holger Brunck <[email protected]>
Cc Valentin Longchamp <[email protected]>
Cc Prafulla Wadaskar <[email protected]>
Cc Heiko Schocher <[email protected]>
---
 include/configs/km/km_arm.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Acked-by Heiko Schocher <[email protected]>

bye,
Heiko

Signature · 2 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Holger Brunck

author

2011-12-14 15:31 UTC #4 lore raw

PATCH 2/2 arm/km: checkpatch cleanup

In reply to Holger Brunck

Signed-off-by Holger Brunck <[email protected]>

Cc Valentin Longchamp <[email protected]>

Cc Prafulla Wadaskar <[email protected]>

---
 board/keymile/km_arm/km_arm.c |   23 +++++++++++------------
 1 files changed, 11 insertions(+), 12 deletions(-)

board/keymile/km_arm/km_arm.c +11 ~~-12~~

index ca33aae..9e9940c 100644
@@ -416,13 +416,13 @@ const ulong REPEAT_PATTERN  = 1000;
 
 void bootcount_store(ulong a)
 {
-	volatile ulong *save_addr;
-	volatile ulong size = 0;
+	ulong *save_addr;
+	ulong size = 0;
 	int i;
-	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++)
 		size += gd->bd->bi_dram[i].size;
-	}
-	save_addr = (ulong*)(size - BOOTCOUNT_ADDR);
+	save_addr = (ulong *)(size - BOOTCOUNT_ADDR);
 	writel(a, save_addr);
 	writel(BOOTCOUNT_MAGIC, &save_addr[1]);

@@ -434,15 +434,14 @@ void bootcount_store(ulong a)
 
 ulong bootcount_load(void)
 {
-	volatile ulong *save_addr;
-	volatile ulong size = 0;
+	ulong *save_addr;
+	ulong size = 0;
 	ulong counter = 0;
 	int i, tmp;
 
-	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++)
 		size += gd->bd->bi_dram[i].size;
-	}
-	save_addr = (ulong*)(size - BOOTCOUNT_ADDR);
+	save_addr = (ulong *)(size - BOOTCOUNT_ADDR);
 
 	counter = readl(&save_addr[0]);

@@ -492,13 +491,13 @@ int post_hotkeys_pressed(void)
 
 ulong post_word_load(void)
 {
-	volatile void* addr = (void *) (gd->ram_size - BOOTCOUNT_ADDR + POST_WORD_OFF);
+	void* addr = (void *) (gd->ram_size - BOOTCOUNT_ADDR + POST_WORD_OFF);
 	return in_le32(addr);
 
 }
 void post_word_store(ulong value)
 {
-	volatile void* addr = (void *) (gd->ram_size - BOOTCOUNT_ADDR + POST_WORD_OFF);
+	void* addr = (void *) (gd->ram_size - BOOTCOUNT_ADDR + POST_WORD_OFF);
 	out_le32(addr, value);
 }

Signature · 1 line

1.7.1

Heiko Schocher

2011-12-15 06:31 UTC #5 lore raw

PATCH 2/2 arm/km: checkpatch cleanup

Hello Holger,

Quoted 6 lines · Holger Brunck

Signed-off-by Holger Brunck <[email protected]>
Cc Valentin Longchamp <[email protected]>
Cc Prafulla Wadaskar <[email protected]>
---
 board/keymile/km_arm/km_arm.c |   23 +++++++++++------------
 1 files changed, 11 insertions(+), 12 deletions(-)

Acked-by Heiko Schocher <[email protected]>

bye,
Heiko

Signature · 2 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany