Skip to contentSkip to conversation

mx28evk: Add initial support for MX28EVK board

PATCH New Fabio Estevam 3 participants 5 messages Dec 14, 2011 – Dec 15, 2011

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 mx28evk: Add initial support for MX28EVK board

Add initial support for Freescale MX28EVK board.

Tested boot via SD card and by loading a kernel via TFTP through the FEC interface.

Signed-off-by Fabio Estevam <[email protected]>

---
- Currently MAC addresses are being taken from environment variables:
set ethaddr xx:xx:xx:xx:xx:xx
set eth1addr yy:yy:yy:yy:yy:yy

- For correct operation of saving environment variables into the SD card, the following patch is needed:
http://lists.denx.de/pipermail/u-boot/2011-November/111448.html

 MAINTAINERS                       |    1 +
 board/freescale/mx28evk.c         |  190 +++++++++++++++++++++++++++++++++++++
 board/freescale/mx28evk/Makefile  |   49 ++++++++++
 board/freescale/mx28evk/iomux.c   |  138 +++++++++++++++++++++++++++
 board/freescale/mx28evk/u-boot.bd |   14 +++
 boards.cfg                        |    1 +
 include/configs/mx28evk.h         |  164 ++++++++++++++++++++++++++++++++
 7 files changed, 557 insertions(+), 0 deletions(-)
 create mode 100644 board/freescale/mx28evk.c
 create mode 100644 board/freescale/mx28evk/Makefile
 create mode 100644 board/freescale/mx28evk/iomux.c
 create mode 100644 board/freescale/mx28evk/u-boot.bd
 create mode 100644 include/configs/mx28evk.h
MAINTAINERS +1 -0
index a56ca10..72e1089 100644
@@ -639,6 +639,7 @@ Kristoffer Ericson <[email protected]>
 Fabio Estevam <[email protected]>
 
 	mx25pdk		i.MX25
+	mx28evk		i.MX28
 	mx31pdk		i.MX31
 	mx53ard		i.MX53
 	mx53smd		i.MX53
board/freescale/mx28evk.c new file +190 -0

190 lines not on this page · raw message

board/freescale/mx28evk/Makefile new file +49 -0

49 lines not on this page · raw message

board/freescale/mx28evk/iomux.c new file +138 -0

138 lines not on this page · raw message

board/freescale/mx28evk/u-boot.bd new file +14 -0
new file mode 100644
index 0000000..3ce7f92
@@ -0,0 +1,14 @@
+sources {
+	u_boot_spl="spl/u-boot-spl.bin";
+	u_boot="u-boot.bin";
+}
+
+section (0) {
+        load u_boot_spl > 0x0000;
+        load ivt (entry = 0x0014) > 0x8000;
+	hab call 0x8000;
+
+        load u_boot > 0x40000100;
+        load ivt (entry = 0x40000100) > 0x8000;
+	hab call 0x8000;
+}
boards.cfg +1 -0
index 1e5b3e0..e859024 100644
@@ -160,6 +160,7 @@ zmx25                        arm         arm926ejs   zmx25               syteco
 imx27lite                    arm         arm926ejs   imx27lite           logicpd        mx27
 magnesium                    arm         arm926ejs   imx27lite           logicpd        mx27
 m28evk                       arm         arm926ejs   -                   denx           mx28
+mx28evk                      arm         arm926ejs   -                   freescale      mx28
 nhk8815                      arm         arm926ejs   nhk8815             st             nomadik
 nhk8815_onenand              arm         arm926ejs   nhk8815             st             nomadik       nhk8815:BOOT_ONENAND
 omap1610h2		     arm	 arm926ejs   omap1610inn	 ti		omap	    omap1610inn:CS3_BOOT
include/configs/mx28evk.h new file +164 -0

164 lines not on this page · raw message

Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 mx28evk: Add initial support for MX28EVK board

Quoted 7 lines

Add initial support for Freescale MX28EVK board.

Tested boot via SD card and by loading a kernel via TFTP through the FEC interface.

Signed-off-by Fabio Estevam <[email protected]>

---

Hi Fabio,

the patch looks very bad, find many comments below ;-)

[...]

Quoted 8 lines
board/freescale/mx28evk.c new file +8 -0
+	dev = eth_get_dev_by_name("FEC1");
+	if (!dev) {
+		printf("FEC MXS: Unable to get FEC1 device entry\n");
+		return -EINVAL;
+	}
+
+	ret = fecmxc_register_mii_postcall(dev, fecmxc_mii_postcall);
+	if (ret) {

board/freescale/mx28evk.c line 187

Quoted 10 lines
board/freescale/mx28evk.c new file +10 -0
+		printf("FEC MXS: Unable to register FEC1 mii postcall\n");
+		return ret;
+	}
+
+	return ret;
+}
+
+void imx_get_mac_from_fuse(char *mac)
+{
+	memset(mac, 0, 6);

OCOTP code is no good for you?

Quoted 211 lines
board/freescale/mx28evk.c new file +3 -0
+}
+
+#endif
(quoted diff) +0 -0

b/board/freescale/mx28evk/Makefile new file mode 100644 index 0000000..7459107

board/freescale/mx28evk/Makefile new file +49 -0
@@ -0,0 +1,49 @@
+#
+# (C) Copyright 2000-2006
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).o
+
+ifndef	CONFIG_SPL_BUILD
+COBJS	:= mx28evk.o
+else
+COBJS	:= iomux.o
+endif
+
+SRCS	:= $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS))
+
+$(LIB):	$(obj).depend $(OBJS)
+	$(call cmd_link_o_target, $(OBJS))
+
+all:	$(ALL)
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
(quoted diff) +0 -0

b/board/freescale/mx28evk/iomux.c new file mode 100644 index 0000000..904e3f3

board/freescale/mx28evk/iomux.c new file +138 -0
@@ -0,0 +1,138 @@
+/*
+ * Freescale MX28EVK IOMUX setup
+ *
+ * Copyright (C) 2011 Marek Vasut <[email protected]>
+ * on behalf of DENX Software Engineering GmbH
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <common.h>
+#include <config.h>
+#include <asm/io.h>
+#include <asm/arch/iomux-mx28.h>
+#include <asm/arch/imx-regs.h>
+#include <asm/arch/sys_proto.h>
+
+#define	MUX_CONFIG_SSP0	(MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
+#define	MUX_CONFIG_ENET	(MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
+#define	MUX_CONFIG_EMI	(MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_NOPULL)
+
+const iomux_cfg_t iomux_setup[] = {
+	/* DUART */
+	MX28_PAD_PWM0__DUART_RX,
+	MX28_PAD_PWM1__DUART_TX,
+
+	/* MMC0 */
+	MX28_PAD_SSP0_DATA0__SSP0_D0 | MUX_CONFIG_SSP0,
+	MX28_PAD_SSP0_DATA1__SSP0_D1 | MUX_CONFIG_SSP0,
+	MX28_PAD_SSP0_DATA2__SSP0_D2 | MUX_CONFIG_SSP0,
+	MX28_PAD_SSP0_DATA3__SSP0_D3 | MUX_CONFIG_SSP0,
+	MX28_PAD_SSP0_DATA4__SSP0_D4 | MUX_CONFIG_SSP0,
+	MX28_PAD_SSP0_DATA5__SSP0_D5 | MUX_CONFIG_SSP0,
+	MX28_PAD_SSP0_DATA6__SSP0_D6 | MUX_CONFIG_SSP0,
+	MX28_PAD_SSP0_DATA7__SSP0_D7 | MUX_CONFIG_SSP0,
+	MX28_PAD_SSP0_CMD__SSP0_CMD | MUX_CONFIG_SSP0,
+	MX28_PAD_SSP0_DETECT__SSP0_CARD_DETECT |
+		(MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_NOPULL),
+	MX28_PAD_SSP0_SCK__SSP0_SCK |
+		(MXS_PAD_12MA | MXS_PAD_3V3 | MXS_PAD_NOPULL),
+	/* write protect */
+	MX28_PAD_SSP1_SCK__GPIO_2_12,
+	/* MMC0 slot power enable */
+	MX28_PAD_PWM3__GPIO_3_28 |
+		(MXS_PAD_12MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
+
+	/* FEC0 */
+	MX28_PAD_ENET0_MDC__ENET0_MDC | MUX_CONFIG_ENET,
+	MX28_PAD_ENET0_MDIO__ENET0_MDIO | MUX_CONFIG_ENET,
+	MX28_PAD_ENET0_RX_EN__ENET0_RX_EN | MUX_CONFIG_ENET,
+	MX28_PAD_ENET0_TX_EN__ENET0_TX_EN | MUX_CONFIG_ENET,
+	MX28_PAD_ENET0_RXD0__ENET0_RXD0 | MUX_CONFIG_ENET,
+	MX28_PAD_ENET0_RXD1__ENET0_RXD1 | MUX_CONFIG_ENET,
+	MX28_PAD_ENET0_TXD0__ENET0_TXD0 | MUX_CONFIG_ENET,
+	MX28_PAD_ENET0_TXD1__ENET0_TXD1 | MUX_CONFIG_ENET,
+	MX28_PAD_ENET_CLK__CLKCTRL_ENET | MUX_CONFIG_ENET,
+	/* FEC0 Enable */
+	MX28_PAD_SSP1_DATA3__GPIO_2_15 |
+		(MXS_PAD_12MA | MXS_PAD_3V3),
+	/* FEC0 Reset */
+	MX28_PAD_ENET0_RX_CLK__GPIO_4_13 |
+		(MXS_PAD_12MA | MXS_PAD_3V3 | MXS_PAD_PULLUP),
+
+	/* FEC1 */
+	MX28_PAD_ENET0_COL__ENET1_TX_EN | MUX_CONFIG_ENET,
+	MX28_PAD_ENET0_CRS__ENET1_RX_EN | MUX_CONFIG_ENET,
+	MX28_PAD_ENET0_RXD2__ENET1_RXD0 | MUX_CONFIG_ENET,
+	MX28_PAD_ENET0_RXD3__ENET1_RXD1 | MUX_CONFIG_ENET,
+	MX28_PAD_ENET0_TXD2__ENET1_TXD0 | MUX_CONFIG_ENET,
+	MX28_PAD_ENET0_TXD3__ENET1_TXD1 | MUX_CONFIG_ENET,
+
+	/* EMI */
+	MX28_PAD_EMI_D00__EMI_DATA0 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D01__EMI_DATA1 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D02__EMI_DATA2 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D03__EMI_DATA3 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D04__EMI_DATA4 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D05__EMI_DATA5 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D06__EMI_DATA6 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D07__EMI_DATA7 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D08__EMI_DATA8 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D09__EMI_DATA9 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D10__EMI_DATA10 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D11__EMI_DATA11 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D12__EMI_DATA12 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D13__EMI_DATA13 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D14__EMI_DATA14 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_D15__EMI_DATA15 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_ODT0__EMI_ODT0 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_DQM0__EMI_DQM0 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_ODT1__EMI_ODT1 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_DQM1__EMI_DQM1 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_DDR_OPEN_FB__EMI_DDR_OPEN_FEEDBACK | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_CLK__EMI_CLK | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_DQS0__EMI_DQS0 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_DQS1__EMI_DQS1 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_DDR_OPEN__EMI_DDR_OPEN | MUX_CONFIG_EMI,
+
+	MX28_PAD_EMI_A00__EMI_ADDR0 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_A01__EMI_ADDR1 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_A02__EMI_ADDR2 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_A03__EMI_ADDR3 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_A04__EMI_ADDR4 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_A05__EMI_ADDR5 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_A06__EMI_ADDR6 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_A07__EMI_ADDR7 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_A08__EMI_ADDR8 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_A09__EMI_ADDR9 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_A10__EMI_ADDR10 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_A11__EMI_ADDR11 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_A12__EMI_ADDR12 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_A13__EMI_ADDR13 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_A14__EMI_ADDR14 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_BA0__EMI_BA0 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_BA1__EMI_BA1 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_BA2__EMI_BA2 | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_CASN__EMI_CASN | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_RASN__EMI_RASN | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_WEN__EMI_WEN | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_CE0N__EMI_CE0N | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_CE1N__EMI_CE1N | MUX_CONFIG_EMI,
+	MX28_PAD_EMI_CKE__EMI_CKE | MUX_CONFIG_EMI,
+};
+
+void board_init_ll(void)
+{
+	mx28_common_spl_init(iomux_setup, ARRAY_SIZE(iomux_setup));
+}
(quoted diff) +0 -0

b/board/freescale/mx28evk/u-boot.bd new file mode 100644 index 0000000..3ce7f92

board/freescale/mx28evk/u-boot.bd new file +3 -0
@@ -0,0 +1,14 @@
+sources {
+	u_boot_spl="spl/u-boot-spl.bin";
+	u_boot="u-boot.bin";

board/freescale/mx28evk/u-boot.bd line 13

Quoted 10 lines
board/freescale/mx28evk/u-boot.bd new file +10 -0
+}
+
+section (0) {
+        load u_boot_spl > 0x0000;
+        load ivt (entry = 0x0014) > 0x8000;
+	hab call 0x8000;
+
+        load u_boot > 0x40000100;
+        load ivt (entry = 0x40000100) > 0x8000;
+	hab call 0x8000;

Change the indent here to tabs please, similar patch is queued mainline for m28.

Quoted 8 lines
board/freescale/mx28evk/u-boot.bd new file +1 -0
+}
boards.cfg +0 -0
index 1e5b3e0..e859024 100644
@@ -160,6 +160,7 @@ zmx25                        arm         arm926ejs

zmx25 syteco imx27lite arm
arm926ejs imx27lite logicpd mx27 magnesium

Quoted 8 lines

arm arm926ejs imx27lite logicpd mx27
m28evk arm arm926ejs -
denx mx28 +mx28evk arm arm926ejs
- freescale mx28 nhk8815 arm
arm926ejs nhk8815 st nomadik
nhk8815_onenand arm arm926ejs nhk8815
st nomadik nhk8815:BOOT_ONENAND omap1610h2 arm
arm926ejs omap1610inn ti omap omap1610inn:CS3_BOOT

diff --git

Quoted 62 lines

a/include/configs/mx28evk.h b/include/configs/mx28evk.h new file mode 100644
index 0000000..2c8d06b

include/configs/mx28evk.h new file +56 -0
@@ -0,0 +1,164 @@
+/*
+ * Copyright (C) 2011 Marek Vasut <[email protected]>
+ * on behalf of DENX Software Engineering GmbH
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
+ * GNU General Public License for more details.
+ */
+#ifndef __MX28_H__
+#define __MX28_H__
+
+#include <asm/arch/regs-base.h>
+
+/*
+ * SoC configurations
+ */
+#define	CONFIG_MX28				/* i.MX28 SoC */
+#define	CONFIG_MXS_GPIO				/* GPIO control */
+#define	CONFIG_SYS_HZ		1000		/* Ticks per second */
+
+#define CONFIG_MACH_TYPE	MACH_TYPE_MX28EVK
+
+#define	CONFIG_SYS_NO_FLASH
+#define	CONFIG_SYS_ICACHE_OFF
+#define	CONFIG_SYS_DCACHE_OFF
+#define	CONFIG_BOARD_EARLY_INIT_F
+#define	CONFIG_ARCH_CPU_INIT
+#define	CONFIG_ARCH_MISC_INIT
+
+/*
+ * SPL
+ */
+#define CONFIG_SPL
+#define CONFIG_SPL_NO_CPU_SUPPORT_CODE
+#define CONFIG_SPL_START_S_PATH	"arch/arm/cpu/arm926ejs/mx28"
+#define CONFIG_SPL_LDSCRIPT	"arch/arm/cpu/arm926ejs/mx28/u-boot-spl.lds"
+#define CONFIG_SPL_LIBCOMMON_SUPPORT
+#define CONFIG_SPL_LIBGENERIC_SUPPORT
+
+/*
+ * U-Boot Commands
+ */
+#include <config_cmd_default.h>
+#define	CONFIG_DISPLAY_CPUINFO
+#define	CONFIG_DOS_PARTITION
+#define CONFIG_CMD_FAT
+
+#define	CONFIG_CMD_CACHE
+#define	CONFIG_CMD_DHCP
+#define	CONFIG_CMD_GPIO

include/configs/mx28evk.h line 66

Quoted 10 lines
include/configs/mx28evk.h new file +10 -0
+#define	CONFIG_CMD_MII
+#define	CONFIG_CMD_MMC
+#define	CONFIG_CMD_NET
+#define	CONFIG_CMD_NFS
+#define	CONFIG_CMD_PING
+
+/*
+ * Memory configurations
+ */
+#define	CONFIG_NR_DRAM_BANKS		1		/* 1 bank of

DRAM */

include/configs/mx28evk.h line 67

Quoted 1 line
include/configs/mx28evk.h new file +1 -0
+#define	PHYS_SDRAM_1			0x40000000	/* Base address

*/

include/configs/mx28evk.h line 68

Quoted 1 line
include/configs/mx28evk.h new file +1 -0
+#define	PHYS_SDRAM_1_SIZE		0x40000000	/* Max 1 GB RAM

*/

include/configs/mx28evk.h line 69

Quoted 1 line
include/configs/mx28evk.h new file +1 -0
+#define	CONFIG_STACKSIZE		0x00010000	/* 128 KB stack

*/

include/configs/mx28evk.h line 70

Quoted 1 line
include/configs/mx28evk.h new file +1 -0
+#define	CONFIG_SYS_MALLOC_LEN		0x00400000	/* 4 MB for

malloc */

include/configs/mx28evk.h line 71

Quoted 1 line
include/configs/mx28evk.h new file +1 -0
+#define	CONFIG_SYS_GBL_DATA_SIZE	128		/* Initial data

*/

include/configs/mx28evk.h line 72

Quoted 1 line
include/configs/mx28evk.h new file +1 -0
+#define	CONFIG_SYS_MEMTEST_START	0x40000000	/* Memtest start

adr */

include/configs/mx28evk.h line 73

Quoted 1 line
include/configs/mx28evk.h new file +1 -0
+#define	CONFIG_SYS_MEMTEST_END		0x40400000	/* 4 MB RAM test

*/

Quoted 7 lines
include/configs/mx28evk.h new file +7 -0
+#define	CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
+/* Point initial SP in SRAM so SPL can use it too. */
+#define	CONFIG_SYS_INIT_SP_ADDR		0x00002000
+/*
+ * We need to sacrifice first 4 bytes of RAM here to avoid triggering some
+ * strange BUG in ROM corrupting first 4 bytes of RAM when loading U-Boot
+ * binary. In case there was more of this mess, 0x100 bytes are skipped.

include/configs/mx28evk.h

Quoted 10 lines
include/configs/mx28evk.h new file +10 -0
+ */
+#define	CONFIG_SYS_TEXT_BASE		0x40000100
+
+#define CONFIG_ENV_OVERWRITE
+/*
+ * U-Boot general configurations
+ */
+#define	CONFIG_SYS_LONGHELP
+#define	CONFIG_SYS_PROMPT	"MX28EVK U-Boot > "
+#define	CONFIG_SYS_CBSIZE	1024		/* Console I/O buffer

size */

include/configs/mx28evk.h

Quoted 4 lines
include/configs/mx28evk.h new file +4 -0
+#define	CONFIG_SYS_PBSIZE	\
+	(CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
+						/* Print buffer size */
+#define	CONFIG_SYS_MAXARGS	32		/* Max number of command

args */

include/configs/mx28evk.h

Quoted 4 lines
include/configs/mx28evk.h new file +4 -0
+#define	CONFIG_SYS_BARGSIZE	CONFIG_SYS_CBSIZE
+						/* Boot argument buffer size */
+#define	CONFIG_VERSION_VARIABLE			/* U-BOOT version */
+#define	CONFIG_AUTO_COMPLETE			/* Command auto complete

*/

include/configs/mx28evk.h line 99

Quoted 1 line
include/configs/mx28evk.h new file +1 -0
+#define	CONFIG_CMDLINE_EDITING			/* Command history etc

*/

include/configs/mx28evk.h

Quoted 12 lines
include/configs/mx28evk.h new file +12 -0
+#define	CONFIG_SYS_HUSH_PARSER
+#define	CONFIG_SYS_PROMPT_HUSH_PS2	"> "
+
+/*
+ * Serial Driver
+ */
+#define	CONFIG_PL011_SERIAL
+#define	CONFIG_PL011_CLOCK		24000000
+#define	CONFIG_PL01x_PORTS		{ (void *)MXS_UARTDBG_BASE }
+#define	CONFIG_CONS_INDEX		0
+#define	CONFIG_BAUDRATE			115200	/* Default baud rate */
+#define	CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600,

115200 }

Quoted 34 lines
include/configs/mx28evk.h new file +34 -0
+
+/*
+ * MMC Driver
+ */
+#define CONFIG_ENV_IS_IN_MMC
+#define CONFIG_ENV_OFFSET	(256 * 1024)
+#define CONFIG_ENV_SIZE		(16 * 1024)
+#define CONFIG_SYS_MMC_ENV_DEV 0
+#define CONFIG_CMD_SAVEENV
+#ifdef	CONFIG_CMD_MMC
+#define	CONFIG_MMC
+#define	CONFIG_GENERIC_MMC
+#define	CONFIG_MXS_MMC
+#endif
+
+/*
+ * Ethernet on SOC (FEC)
+ */
+#ifdef	CONFIG_CMD_NET
+#define	CONFIG_NET_MULTI
+#define	CONFIG_ETHPRIME			"FEC0"
+#define	CONFIG_FEC_MXC
+#define	CONFIG_FEC_MXC_MULTI
+#define	CONFIG_MII
+#define	CONFIG_DISCOVER_PHY
+#define	CONFIG_FEC_XCV_TYPE		RMII
+#endif
+
+/*
+ * Boot Linux
+ */
+#define	CONFIG_CMDLINE_TAG
+#define	CONFIG_SETUP_MEMORY_TAGS
+#define	CONFIG_BOOTDELAY	3

include/configs/mx28evk.h line 155

Quoted 10 lines
include/configs/mx28evk.h new file +10 -0
+#define	CONFIG_BOOTFILE		"uImage"
+#define	CONFIG_BOOTCOMMAND	"run bootcmd_net"
+#define	CONFIG_LOADADDR		0x42000000
+#define	CONFIG_SYS_LOAD_ADDR	CONFIG_LOADADDR
+
+/*
+ * Extra Environments
+ */
+#define CONFIG_EXTRA_ENV_SETTINGS \
+	"console_fsl=console=ttyAM0" \

ttyAM? You sure?

include/configs/mx28evk.h line 164

Quoted 9 lines
include/configs/mx28evk.h new file +9 -0
+	"console_mainline=console=ttyAMA0" \
+	"netargs=setenv bootargs console=${console_mainline}" \
+		"root=/dev/nfs " \
+		"ip=dhcp nfsroot=${serverip}:${nfsroot}\0" \
+	"bootcmd_net=echo Booting from net ...; " \
+		"run netargs; " \
+		"dhcp ${uimage}; bootm\0" \
+
+#endif /* __MX28_H__ */

Well I was kidding at the begining of couse, it looks mostly really good. Just recheck those three things above and you'll get my ACK.

M

author
#2 lore raw

PATCH 1/1 mx28evk: Add initial support for MX28EVK board

Hi Marek,

Quoted 5 lines · Marek Vasut

board/freescale/mx28evk.c

Quoted 3 lines
board/freescale/mx28evk.c new file +3 -0
+void imx_get_mac_from_fuse(char *mac)
+{
+ ? ? memset(mac, 0, 6);

OCOTP code is no good for you?

It works fine, except that it only gets the correct MAC for FEC0:

Warning: FEC1 MAC addresses don't match:
Address in SROM is 00:04:9f:01:d2:94
Address in environment is 00:04:9f:01:d2:95

ethaddr=00:04:9F:01:D2:94
eth1addr=00:04:9F:01:D2:95

Also, I see that on m28evk this code is not being used because CONFIG_M28_FEC_MAC_IN_OCOTP
is not defined.

I think we should move this function to common code. To avoid the dual FEC MAC issue for now, I can also use a single FEC instead, as I probably won't have time to investigate this during this year.

...

Quoted 10 lines
Quoted 10 lines
board/freescale/mx28evk/u-boot.bd new file +7 -0
@@ -0,0 +1,14 @@
+sources {
+ ? ? u_boot_spl="spl/u-boot-spl.bin";
+ ? ? u_boot="u-boot.bin";
+}
+
+section (0) {
+ ? ? ? ?load u_boot_spl > 0x0000;
Quoted 8 lines

board/freescale/mx28evk/u-boot.bd line 13

Quoted 6 lines
board/freescale/mx28evk/u-boot.bd new file +6 -0
+ ? ? ? ?load ivt (entry = 0x0014) > 0x8000;
+ ? ? hab call 0x8000;
+
+ ? ? ? ?load u_boot > 0x40000100;
+ ? ? ? ?load ivt (entry = 0x40000100) > 0x8000;
+ ? ? hab call 0x8000;

Change the indent here to tabs please, similar patch is queued mainline for m28.

Ok

...

Quoted 6 lines

board/freescale/mx28evk/u-boot.bd

Quoted 4 lines
board/freescale/mx28evk/u-boot.bd new file +4 -0
+ * Extra Environments
+ */
+#define CONFIG_EXTRA_ENV_SETTINGS \
+ ? ? "console_fsl=console=ttyAM0" \

ttyAM? You sure?

Yes, FSL BSP uses ttyAM0. Mainline kernel uses ttyAMA0.

I left the mainline version as default.

Thanks,

Fabio Estevan

author
#3 lore raw

PATCH 1/1 mx28evk: Add initial support for MX28EVK board

In reply to Fabio Estevam
Quoted 1 line · Fabio Estevam

?create mode 100644 board/freescale/mx28evk.c

Ops, this should be board/freescale/mx28evk/mx28evk.c instead.

Will post another version tomorrow.

Regards,

Fabio Estevam

#4 lore raw

PATCH 1/1 mx28evk: Add initial support for MX28EVK board

In reply to Fabio Estevam
Quoted 7 lines · Fabio Estevam

Add initial support for Freescale MX28EVK board.

Tested boot via SD card and by loading a kernel via TFTP through the FEC interface.

Signed-off-by Fabio Estevam <[email protected]>

---

Hi Fabio,

Quoted 10 lines

- Currently MAC addresses are being taken from environment variables:
set ethaddr xx:xx:xx:xx:xx:xx
set eth1addr yy:yy:yy:yy:yy:yy

- For correct operation of saving environment variables into the SD card, the following patch is needed:
http://lists.denx.de/pipermail/u-boot/2011-November/111448.html

 MAINTAINERS                       |    1 +
 board/freescale/mx28evk.c         |  190 +++++++++++++++++++++++++++++++++++++

Slipped in wrong directory, I presume

Quoted 5 lines
board/freescale/mx28evk.c new file +5 -0
+
+#define	HW_DIGCTRL_SCRATCH0	0x8001c280
+#define	HW_DIGCTRL_SCRATCH1	0x8001c290
+int dram_init(void)
+{

board/freescale/mx28evk.c line 79

Quoted 10 lines
board/freescale/mx28evk.c new file +10 -0
+	uint32_t sz[2];
+
+	sz[0] = readl(HW_DIGCTRL_SCRATCH0);
+	sz[1] = readl(HW_DIGCTRL_SCRATCH1);
+
+	if (sz[0] != sz[1]) {
+		printf("MX28:\n"
+			"Error, the RAM size in HW_DIGCTRL_SCRATCH0 and\n"
+			"HW_DIGCTRL_SCRATCH1 is not the same. Please\n"
+			"verify these two registers contain valid RAM size!\n");

Here we should use puts instead of printf.

board/freescale/mx28evk.c line 85

Quoted 6 lines
board/freescale/mx28evk.c new file +6 -0
+		hang();
+	}
+
+	gd->ram_size = sz[0];
+	return 0;
+}

This function is copied from m28evk.c. Can we factorize it ? Then the board dram_init() can call the common function if a special implementation is still needed.

Quoted 40 lines
board/freescale/mx28evk.c new file +40 -0
+#ifdef	CONFIG_CMD_MMC
+static int mx28evk_mmc_wp(int id)
+{
+	if (id != 0) {
+		printf("MXS MMC: Invalid card selected (card id = %d)\n", id);
+		return 1;
+	}
+
+	return gpio_get_value(MX28_PAD_SSP1_SCK__GPIO_2_12);
+}
+
+int board_mmc_init(bd_t *bis)
+{
+	/* Configure WP as input */
+	gpio_direction_input(MX28_PAD_SSP1_SCK__GPIO_2_12);
+
+	/* Configure MMC0 Power Enable */
+	gpio_direction_output(MX28_PAD_PWM3__GPIO_3_28, 0);
+
+	return mxsmmc_initialize(bis, 0, mx28evk_mmc_wp);
+}
+#endif
+
+#ifdef	CONFIG_CMD_NET
+
+#define	MII_OPMODE_STRAP_OVERRIDE	0x16
+#define	MII_PHY_CTRL1			0x1e
+#define	MII_PHY_CTRL2			0x1f
+
+int fecmxc_mii_postcall(int phy)
+{
+	miiphy_write("FEC1", phy, MII_BMCR, 0x9000);
+	miiphy_write("FEC1", phy, MII_OPMODE_STRAP_OVERRIDE, 0x0202);
+	if (phy == 3)
+		miiphy_write("FEC1", 3, MII_PHY_CTRL2, 0x8180);
+	return 0;
+}
+
+int board_eth_init(bd_t *bis)
+{

board/freescale/mx28evk.c line 136

Quoted 10 lines
board/freescale/mx28evk.c new file +10 -0
+	struct mx28_clkctrl_regs *clkctrl_regs =
+		(struct mx28_clkctrl_regs *)MXS_CLKCTRL_BASE;
+	struct eth_device *dev;
+	int ret;
+
+	ret = cpu_eth_init(bis);
+
+	/* MX28EVK uses ENET_CLK PAD to drive FEC clock */
+	writel(CLKCTRL_ENET_TIME_SEL_RMII_CLK | CLKCTRL_ENET_CLK_OUT_EN,
+					&clkctrl_regs->hw_clkctrl_enet);

Right, I know this issue.

board/freescale/mx28evk.c line 148

Quoted 11 lines
board/freescale/mx28evk.c new file +11 -0
+	/* Power-on FECs */
+	gpio_direction_output(MX28_PAD_SSP1_DATA3__GPIO_2_15, 0);
+
+	/* Reset FEC PHYs */
+	gpio_direction_output(MX28_PAD_ENET0_RX_CLK__GPIO_4_13, 0);
+	udelay(200);
+	gpio_set_value(MX28_PAD_ENET0_RX_CLK__GPIO_4_13, 1);
+
+	ret = fecmxc_initialize_multi(bis, 0, 0, MXS_ENET0_BASE);
+	if (ret) {
+		printf("FEC MXS: Unable to init FEC0\n");

Use puts, check globally

board/freescale/mx28evk.c line 154

Quoted 3 lines
board/freescale/mx28evk.c new file +3 -0
+	ret = fecmxc_initialize_multi(bis, 1, 3, MXS_ENET1_BASE);
+	if (ret) {
+		printf("FEC MXS: Unable to init FEC1\n");

Ditto

board/freescale/mx28evk.c line 190

Quoted 6 lines
board/freescale/mx28evk.c new file +6 -0
+void imx_get_mac_from_fuse(char *mac)
+{
+	memset(mac, 0, 6);
+}
+
+#endif

Sure imx_get_mac_from_fuse() belong to the processor and not to the board - it must be moved. If it is not desired to get the MAC address from the fuses (have Freescale's SOC always a valid MAC in fuses or are they also delivered with empty MAC ?), you can add a CONFIG_ define to fall back to the implementation in this patch clearing the MAC.

Quoted 65 lines
include/configs/mx28evk.h new file +59 -0
new file mode 100644
index 0000000..2c8d06b
@@ -0,0 +1,164 @@
+/*
+ * Copyright (C) 2011 Marek Vasut <[email protected]>
+ * on behalf of DENX Software Engineering GmbH
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
+ * GNU General Public License for more details.
+ */
+#ifndef __MX28_H__
+#define __MX28_H__
+
+#include <asm/arch/regs-base.h>
+
+/*
+ * SoC configurations
+ */
+#define	CONFIG_MX28				/* i.MX28 SoC */
+#define	CONFIG_MXS_GPIO				/* GPIO control */
+#define	CONFIG_SYS_HZ		1000		/* Ticks per second */
+
+#define CONFIG_MACH_TYPE	MACH_TYPE_MX28EVK
+
+#define	CONFIG_SYS_NO_FLASH
+#define	CONFIG_SYS_ICACHE_OFF
+#define	CONFIG_SYS_DCACHE_OFF
+#define	CONFIG_BOARD_EARLY_INIT_F
+#define	CONFIG_ARCH_CPU_INIT
+#define	CONFIG_ARCH_MISC_INIT
+
+/*
+ * SPL
+ */
+#define CONFIG_SPL
+#define CONFIG_SPL_NO_CPU_SUPPORT_CODE
+#define CONFIG_SPL_START_S_PATH	"arch/arm/cpu/arm926ejs/mx28"
+#define CONFIG_SPL_LDSCRIPT	"arch/arm/cpu/arm926ejs/mx28/u-boot-spl.lds"
+#define CONFIG_SPL_LIBCOMMON_SUPPORT
+#define CONFIG_SPL_LIBGENERIC_SUPPORT
+
+/*
+ * U-Boot Commands
+ */
+#include <config_cmd_default.h>
+#define	CONFIG_DISPLAY_CPUINFO
+#define	CONFIG_DOS_PARTITION
+#define CONFIG_CMD_FAT
+
+#define	CONFIG_CMD_CACHE
+#define	CONFIG_CMD_DHCP
+#define	CONFIG_CMD_GPIO
+#define	CONFIG_CMD_MII
+#define	CONFIG_CMD_MMC
+#define	CONFIG_CMD_NET

include/configs/mx28evk.h line 69

Quoted 10 lines
include/configs/mx28evk.h new file +10 -0
+#define	CONFIG_CMD_NFS
+#define	CONFIG_CMD_PING
+
+/*
+ * Memory configurations
+ */
+#define	CONFIG_NR_DRAM_BANKS		1		/* 1 bank of DRAM */
+#define	PHYS_SDRAM_1			0x40000000	/* Base address */
+#define	PHYS_SDRAM_1_SIZE		0x40000000	/* Max 1 GB RAM */
+#define	CONFIG_STACKSIZE		0x00010000	/* 128 KB stack */

                                                ^-- I read 64KB

include/configs/mx28evk.h line 71

Quoted 2 lines
include/configs/mx28evk.h new file +2 -0
+#define	CONFIG_SYS_MALLOC_LEN		0x00400000	/* 4 MB for malloc */
+#define	CONFIG_SYS_GBL_DATA_SIZE	128		/* Initial data */

Why is not used GENERATED_GBL_DATA_SIZE ? The same question I had to post for m28evk, I know, but it seems I have not seen there during review.

include/configs/mx28evk.h line 121

Quoted 10 lines
include/configs/mx28evk.h new file +10 -0
+
+/*
+ * MMC Driver
+ */
+#define CONFIG_ENV_IS_IN_MMC
+#define CONFIG_ENV_OFFSET	(256 * 1024)
+#define CONFIG_ENV_SIZE		(16 * 1024)
+#define CONFIG_SYS_MMC_ENV_DEV 0
+#define CONFIG_CMD_SAVEENV
+#ifdef	CONFIG_CMD_MMC

Should be not CONFIG_ENV_IS_IN_MMC put inside the #ifdef ? We cannot use CONFIG_ENV_IS_IN_MMC if CONFIG_MMC is not set.

include/configs/mx28evk.h line 156

Quoted 6 lines
include/configs/mx28evk.h new file +6 -0
+/*
+ * Extra Environments
+ */
+#define CONFIG_EXTRA_ENV_SETTINGS \
+	"console_fsl=console=ttyAM0" \
+	"console_mainline=console=ttyAMA0" \

This depends on the tty driver in kernel - as far as I know, it is ttyAMA. Which is the reason for ttyAM0 ?

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================