Skip to contentSkip to conversation

omap4_panda: Initialize the USB phy

PATCH Superseded clalancette at gmail.com 3 participants 6 messages Dec 13, 2011 – Dec 15, 2011 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 omap4_panda: Initialize the USB phy

From: Chris Lalancette <[email protected]>

During misc_init_r, make sure to setup the clocks
properly for the USB hub on the pandaboard. With
this in place, the USB hub and the ethernet works
on the pandaboard.

---
v2: Incorporate changes from Aneesh (aneesh at ti.com) to support
USB PHY from sys_clk and PER dpll. Also use symbolic constants instead of magic values.

 arch/arm/include/asm/arch-omap4/clocks.h |   63 ++++++++++++++++++++++++++++++
 board/ti/panda/panda.c                   |   59 ++++++++++++++++++++++++++++
 2 files changed, 122 insertions(+), 0 deletions(-)
arch/arm/include/asm/arch-omap4/clocks.h +63 -0
index c2a9b46..cd304e8 100644
@@ -470,6 +470,47 @@ struct omap4_prcm_regs {
 
 };
 
+struct omap4_scrm_regs {
+	u32 revision;		/* 0x0000 */
+	u32 pad00[63];
+	u32 clksetuptime;	/* 0x0100 */
+	u32 pmicsetuptime;	/* 0x0104 */
+	u32 pad01[2];
+	u32 altclksrc;		/* 0x0110 */
+	u32 pad02[2];
+	u32 c2cclkm;		/* 0x011c */
+	u32 pad03[56];
+	u32 extclkreq;		/* 0x0200 */
+	u32 accclkreq;		/* 0x0204 */
+	u32 pwrreq;		/* 0x0208 */
+	u32 pad04[1];
+	u32 auxclkreq0;		/* 0x0210 */
+	u32 auxclkreq1;		/* 0x0214 */
+	u32 auxclkreq2;		/* 0x0218 */
+	u32 auxclkreq3;		/* 0x021c */
+	u32 auxclkreq4;		/* 0x0220 */
+	u32 auxclkreq5;		/* 0x0224 */
+	u32 pad05[3];
+	u32 c2cclkreq;		/* 0x0234 */
+	u32 pad06[54];
+	u32 auxclk0;		/* 0x0310 */
+	u32 auxclk1;		/* 0x0314 */
+	u32 auxclk2;		/* 0x0318 */
+	u32 auxclk3;		/* 0x031c */
+	u32 auxclk4;		/* 0x0320 */
+	u32 auxclk5;		/* 0x0324 */
+	u32 pad07[54];
+	u32 rsttime_reg;	/* 0x0400 */
+	u32 pad08[6];
+	u32 c2crstctrl;		/* 0x041c */
+	u32 extpwronrstctrl;	/* 0x0420 */
+	u32 pad09[59];
+	u32 extwarmrstst_reg;	/* 0x0510 */
+	u32 apewarmrstst_reg;	/* 0x0514 */
+	u32 pad10[1];
+	u32 c2cwarmrstst_reg;	/* 0x051C */
+};
+
 /* DPLL register offsets */
 #define CM_CLKMODE_DPLL		0
 #define CM_IDLEST_DPLL		0x4
@@ -652,6 +693,28 @@ struct omap4_prcm_regs {
 #define TPS62361_BASE_VOLT_MV	500
 #define TPS62361_VSEL0_GPIO	7
 
+/* AUXCLKx reg fields */
+#define AUXCLK_ENABLE_MASK		(1 << 8)
+#define AUXCLK_SRCSELECT_SHIFT		1
+#define AUXCLK_SRCSELECT_MASK		(3 << 1)
+#define AUXCLK_CLKDIV_SHIFT		16
+#define AUXCLK_CLKDIV_MASK		(0xF << 16)
+
+#define AUXCLK_SRCSELECT_SYS_CLK	0
+#define AUXCLK_SRCSELECT_CORE_DPLL	1
+#define AUXCLK_SRCSELECT_PER_DPLL	2
+#define AUXCLK_SRCSELECT_ALTERNATE	3
+
+#define AUXCLK_CLKDIV_2			1
+#define AUXCLK_CLKDIV_16		0xF
+
+/* ALTCLKSRC */
+#define ALTCLKSRC_MODE_MASK		3
+#define ALTCLKSRC_ENABLE_INT_MASK	4
+#define ALTCLKSRC_ENABLE_EXT_MASK	8
+
+#define ALTCLKSRC_MODE_ACTIVE		1
+
 /* Defines for DPLL setup */
 #define DPLL_LOCKED_FREQ_TOLERANCE_0		0
 #define DPLL_LOCKED_FREQ_TOLERANCE_500_KHZ	500
board/ti/panda/panda.c +59 -0

80 lines not on this page · raw message

Signature · 1 line
1.7.1
#1 lore raw

PATCH v2 1/1 omap4_panda: Initialize the USB phy

ping? Tom, Aneesh, what do you think of this version?

Chris Lalancette

Quoted 17 lines · On Tue, Dec 13, 2011 at 2:41 PM, <[email protected]> wrote:

From: Chris Lalancette <[email protected]>

During misc_init_r, make sure to setup the clocks
properly for the USB hub on the pandaboard. ?With
this in place, the USB hub and the ethernet works
on the pandaboard.

---
v2: Incorporate changes from Aneesh (aneesh at ti.com) to support ? ?USB PHY from sys_clk and PER dpll. ?Also use symbolic ? ?constants instead of magic values.

?arch/arm/include/asm/arch-omap4/clocks.h | ? 63 ++++++++++++++++++++++++++++++ ?board/ti/panda/panda.c ? ? ? ? ? ? ? ? ? | ? 59 ++++++++++++++++++++++++++++ ?2 files changed, 122 insertions(+), 0 deletions(-)

#2 lore raw

PATCH v2 1/1 omap4_panda: Initialize the USB phy

Quoted 1 line · Chris Lalancette

ping? ?Tom, Aneesh, what do you think of this version?

Just trying to make sure folks have a chance to review and comment, sorry, looks good from my PoV.

Quoted 21 lines

Chris Lalancette

Quoted 17 lines · On Tue, Dec 13, 2011 at 2:41 PM, ?<[email protected]> wrote:

From: Chris Lalancette <[email protected]>

During misc_init_r, make sure to setup the clocks
properly for the USB hub on the pandaboard. ?With
this in place, the USB hub and the ethernet works
on the pandaboard.

---
v2: Incorporate changes from Aneesh (aneesh at ti.com) to support ? ?USB PHY from sys_clk and PER dpll. ?Also use symbolic ? ?constants instead of magic values.

?arch/arm/include/asm/arch-omap4/clocks.h | ? 63 ++++++++++++++++++++++++++++++ ?board/ti/panda/panda.c ? ? ? ? ? ? ? ? ? | ? 59 ++++++++++++++++++++++++++++ ?2 files changed, 122 insertions(+), 0 deletions(-)

Signature · 1 line
Tom
#3 lore raw

PATCH v2 1/1 omap4_panda: Initialize the USB phy

In reply to clalancette at gmail.com
Quoted 7 lines · clalancette at gmail.com

From: Chris Lalancette<[email protected]>

During misc_init_r, make sure to setup the clocks
properly for the USB hub on the pandaboard. With
this in place, the USB hub and the ethernet works
on the pandaboard.

Quoted 6 lines

---
v2: Incorporate changes from Aneesh (aneesh at ti.com) to support
USB PHY from sys_clk and PER dpll. Also use symbolic constants instead of magic values.

Looks good to me. Thanks a lot for incorporating the suggested changes.

FWIW,

#4 lore raw

PATCH v2 1/1 omap4_panda: Initialize the USB phy

Quoted 16 lines · Aneesh V
Quoted 8 lines · clalancette at gmail.com

From: Chris Lalancette<[email protected]>

During misc_init_r, make sure to setup the clocks
properly for the USB hub on the pandaboard. ?With
this in place, the USB hub and the ethernet works
on the pandaboard.

Quoted 6 lines

---
v2: Incorporate changes from Aneesh (aneesh at ti.com) to support ? ? USB PHY from sys_clk and PER dpll. ?Also use symbolic ? ? constants instead of magic values.

Quoted 4 lines

Looks good to me. Thanks a lot for incorporating the suggested changes.

FWIW,

Thanks Tom, Aneesh. Tom, I presume you will pick it up through your tree?

Chris Lalancette

#5 lore raw

PATCH v2 1/1 omap4_panda: Initialize the USB phy

Quoted 17 lines · Chris Lalancette
Quoted 16 lines · Aneesh V
Quoted 14 lines · clalancette at gmail.com

From: Chris Lalancette<[email protected]>

During misc_init_r, make sure to setup the clocks
properly for the USB hub on the pandaboard. ?With
this in place, the USB hub and the ethernet works
on the pandaboard.

---
v2: Incorporate changes from Aneesh (aneesh at ti.com) to support ? ? USB PHY from sys_clk and PER dpll. ?Also use symbolic ? ? constants instead of magic values.

Quoted 6 lines
Quoted 4 lines

Looks good to me. Thanks a lot for incorporating the suggested changes.

FWIW,

Thanks Tom, Aneesh. ?Tom, I presume you will pick it up through your tree?

Correct, thanks.

Signature · 1 line
Tom