Skip to contentSkip to conversation

arm: Tidy up of PRAM init to use getenv_f()

PATCH New Simon Glass 2 participants 3 messages Oct 10, 2011 – Dec 22, 2011 Arm (32-bit)

lore
Share & tools
lore

Simon Glass

author
#0 lore raw

PATCH 1/1 arm: Tidy up of PRAM init to use getenv_f()

It seems that few people use CONFIG_PRAM on ARM. The getenv_r() function has been renamed to getenv_f().

Signed-off-by Simon Glass <[email protected]>
---
 arch/arm/lib/board.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/lib/board.c +1 -1
index 1fe3751..653345f 100644
@@ -317,7 +317,7 @@ void board_init_f(ulong bootflag)
 	/*
 	 * reserve protected RAM
 	 */
-	i = getenv_r("pram", (char *)tmp, sizeof(tmp));
+	i = getenv_f("pram", (char *)tmp, sizeof(tmp));
 	reg = (i > 0) ? simple_strtoul((const char *)tmp, NULL, 10) :
 		CONFIG_PRAM;
 	addr -= (reg << 10);		/* size is in kB */
Signature · 1 line
1.7.3.1
#1 lore raw

PATCH 1/1 arm: Tidy up of PRAM init to use getenv_f()

Hi Simon,

Le 10/10/2011 22:24, Simon Glass a ?crit :

Quoted 2 lines

It seems that few people use CONFIG_PRAM on ARM. The getenv_r() function has been renamed to getenv_f().

Please correct the commit message: it does not rename the function, it switches from callong the _r version to calling the _f version.

Quoted 10 lines
Signed-off-by Simon Glass<[email protected]>
---
  arch/arm/lib/board.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/lib/board.c +0 -0
index 1fe3751..653345f 100644

arch/arm/lib/board.c void board_init_f(ulong bootflag) · line 323

Quoted 8 lines
arch/arm/lib/board.c +1 -1
@@ -317,7 +317,7 @@ void board_init_f(ulong bootflag)
  	/*
  	 * reserve protected RAM
  	 */
-	i = getenv_r("pram", (char *)tmp, sizeof(tmp));
+	i = getenv_f("pram", (char *)tmp, sizeof(tmp));
  	reg = (i>  0) ? simple_strtoul((const char *)tmp, NULL, 10) :
  		CONFIG_PRAM;
  	addr -= (reg<<  10);		/* size is in kB */

Amicalement,

Signature · 1 line
Albert.
author
#2 lore raw

PATCH 1/1 arm: Tidy up of PRAM init to use getenv_f()

Hi Albert,

Quoted 11 lines · Albert ARIBAUD

Hi Simon,

Le 10/10/2011 22:24, Simon Glass a ?crit :

Quoted 3 lines

It seems that few people use CONFIG_PRAM on ARM. The getenv_r() function has
been renamed to getenv_f().

Please correct the commit message: it does not rename the function, it switches from callong the _r version to calling the _f version.

Please drop this patch, as it still doesn't allow PRAM to actually work on ARM.

Regards,
Simon

Quoted 25 lines
Quoted 12 lines
Signed-off-by Simon Glass<[email protected]>

---
?arch/arm/lib/board.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

arch/arm/lib/board.c +0 -0
index 1fe3751..653345f 100644
@@ -317,7 +317,7 @@ void board_init_f(ulong bootflag)
Quoted 8 lines

? ? ? ?/*
? ? ? ? * reserve protected RAM
? ? ? ? */
- ? ? ? i = getenv_r("pram", (char *)tmp, sizeof(tmp));
+ ? ? ? i = getenv_f("pram", (char *)tmp, sizeof(tmp));
? ? ? ?reg = (i> ?0) ? simple_strtoul((const char *)tmp, NULL, 10) :
? ? ? ? ? ? ? ?CONFIG_PRAM;
? ? ? ?addr -= (reg<< ?10); ? ? ? ? ? ?/* size is in kB */

Amicalement,
--
Albert.