km/common: add toolchain variable
PATCH 1/1 km/common: add toolchain variable
Add a variable "toolchain" and configure the rootpath for the nfsargs with this variable.
--- board/keymile/scripts/README | 2 +- board/keymile/scripts/develop-common.txt | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
board/keymile/scripts/README +1 -1
@@ -7,7 +7,7 @@ default environment must be parsed: run develop : setup environment to configure for rootfs via nfs run ramfs : setup environment to configure for rootfs in ram -Last change: 20.05.2011 +Last change: 24.11.2011 develop-common.txt ============================
board/keymile/scripts/develop-common.txt +2 -1
@@ -2,6 +2,7 @@ altbootcmd=run ${subbootcmds} bootcmd=run ${subbootcmds} configure=km_setboardid && saveenv && reset subbootcmds=tftpfdt tftpkernel nfsargs add_default boot -nfsargs=setenv bootargs root=/dev/nfs rw nfsroot=${serverip}:/opt/eldk/${arch} +nfsargs=setenv bootargs root=/dev/nfs rw nfsroot=${serverip}:${toolchain}/${arch} tftpkernel=tftpboot ${load_addr_r} ${hostname}/uImage +toolchain=/opt/eldk rootfssize=0
Signature · 1 line
1.7.1
PATCH 1/1 km/common: add toolchain variable
Dear Holger Brunck,
Quoted 15 lines · In message <[email protected]> you…
Add a variable "toolchain" and configure the rootpath for the nfsargs with this variable.
Signed-off-by Holger Brunck <[email protected]>cc Wolfgang Denk <[email protected]>--- board/keymile/scripts/README | 2 +- board/keymile/scripts/develop-common.txt | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)board/keymile/scripts/README +0
-0
board/keymile/scripts/README default environment must be parsed: · line 10
Quoted 5 lines
board/keymile/scripts/README +1
-1@@ -7,7 +7,7 @@ default environment must be parsed: run develop : setup environment to configure for rootfs via nfs run ramfs : setup environment to configure for rootfs in ram -Last change: 20.05.2011 +Last change: 24.11.2011
Does this really make any sense? Which date are you recording here/ When you (think) you last edited the file? When you applied the patch to your local tree? When you submitted it for mainline? When it actually got applied?
I recommend to get rid of this, and rather use git revision information instead.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The human mind ordinarily operates at only ten percent of its capacity. The rest is overhead for the operating system.
PATCH 1/1 km/common: add toolchain variable
Hi Wolfgang,
Quoted 19 lines · Wolfgang Denk
Quoted 18 lines · In message <[email protected]> you…
Add a variable "toolchain" and configure the rootpath for the nfsargs with this variable.
Signed-off-by Holger Brunck <[email protected]>cc Wolfgang Denk <[email protected]>--- board/keymile/scripts/README | 2 +- board/keymile/scripts/develop-common.txt | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)board/keymile/scripts/README +0
-0@@ -7,7 +7,7 @@ default environment must be parsed: run develop : setup environment to configure for rootfs via nfs run ramfs : setup environment to configure for rootfs in ram
Quoted 8 lines
board/keymile/scripts/README default environment must be parsed: · line 10
Quoted 2 lines
board/keymile/scripts/README +1
-1-Last change: 20.05.2011 +Last change: 24.11.2011Does this really make any sense? Which date are you recording here/ When you (think) you last edited the file? When you applied the patch to your local tree? When you submitted it for mainline? When it actually got applied?
What I want to record is to track the version of the scripts and this makes sense for me. In the end the scripts are copied into /tftpboot on each developers machine and is therefore not under git control. It is an easy indication wether the scripts are uptodate or not, without starting a diff tool and compare them with the latest git tree. Inside the git tree the information is useless, I agree.
Quoted 3 lines
I recommend to get rid of this, and rather use git revision information instead.
I would like to keep this, because git does not easily help here.
Best regards
Holger
PATCH 1/1 km/common: add toolchain variable
Dear Holger Brunck,
Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 7 lines
Quoted 2 lines
+Last change: 24.11.2011
Does this really make any sense? Which date are you recording here/ When you (think) you last edited the file? When you applied the patch to your local tree? When you submitted it for mainline? When it actually got applied?
Quoted 6 lines
What I want to record is to track the version of the scripts and this makes sense for me. In the end the scripts are copied into /tftpboot on each developers machine and is therefore not under git control. It is an easy indication wether the scripts are uptodate or not, without starting a diff tool and compare them with the latest git tree. Inside the git tree the information is useless, I agree.
You can insert such information when you export the files from git, say by adding a line like:
Last commit date: $Format:%H %cD$
That would IMO make much more sense.
See what we do with "snapshot.commit" in U-Boot [see also the entry in .git/info/attributes].
Quoted 5 lines
Quoted 3 lines
I recommend to get rid of this, and rather use git revision information instead.
I would like to keep this, because git does not easily help here.
Maybe it does - see above.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Committee, n.: A group of men who individually can do nothing but as a group decide that nothing can be done. - Fred Allen
PATCH 1/1 km/common: add toolchain variable
Hi Wolfgang,
Quoted 19 lines · Wolfgang Denk
Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 7 lines
Quoted 2 lines
+Last change: 24.11.2011
Does this really make any sense? Which date are you recording here/ When you (think) you last edited the file? When you applied the patch to your local tree? When you submitted it for mainline? When it actually got applied?
Quoted 6 lines
What I want to record is to track the version of the scripts and this makes sense for me. In the end the scripts are copied into /tftpboot on each developers machine and is therefore not under git control. It is an easy indication wether the scripts are uptodate or not, without starting a diff tool and compare them with the latest git tree. Inside the git tree the information is useless, I agree.
You can insert such information when you export the files from git, say by adding a line like:
Quoted 7 lines
Last commit date: $Format:%H %cD$
That would IMO make much more sense.
See what we do with "snapshot.commit" in U-Boot [see also the entry in .git/info/attributes].
After reading the doc I don't know how it could be used in my usecase. Please correct me if I am wrong, but this does only work in combination with the "git archive" command. And I don't want to do an archive, I want to export/copy some files out of the git tree into /tftpboot.
Best regards
Holger
PATCH 1/1 km/common: add toolchain variable
Dear Holger Brunck,
Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 5 lines
You can insert such information when you export the files from git, say by adding a line like:
Last commit date: $Format:%H %cD$
...
Quoted 4 lines
After reading the doc I don't know how it could be used in my usecase. Please correct me if I am wrong, but this does only work in combination with the "git archive" command. And I don't want to do an archive, I want to export/copy some files out of the git tree into /tftpboot.
You could for example use the following command to copy this file into /tftpboot:
$ cd board/keymile/scripts $ git archive --format=tar HEAD README | \ ( cd /tftpboot ; tar -xpvf - )
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In general, they do what you want, unless you want consistency.
- Larry Wall in the perl man pagePATCH 1/1 km/common: add toolchain variable
Hi Wolfgang,
Quoted 12 lines · Wolfgang Denk
Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 5 lines
You can insert such information when you export the files from git, say by adding a line like:
Last commit date: $Format:%H %cD$
...
Quoted 4 lines
After reading the doc I don't know how it could be used in my usecase. Please correct me if I am wrong, but this does only work in combination with the "git archive" command. And I don't want to do an archive, I want to export/copy some files out of the git tree into /tftpboot.
Quoted 7 lines
You could for example use the following command to copy this file into /tftpboot:
$ cd board/keymile/scripts $ git archive --format=tar HEAD README | \ ( cd /tftpboot ; tar -xpvf - )
hm together with the needed git configuration IMO a bit to complicated for my needs. To be honest I would like to keep this date information as it is.
If this is not acceptable then I will remove this string completely from the u-boot tree and force the users to add a VERSION file to /tftpboot/scripts with:
$ git describe > /tftpboot/scripts/VERSION
or I keep it as a OOT patch. Just let me know.
Best regards
Holger
PATCH 1/1 km/common: add toolchain variable
Dear Holger Brunck,
Quoted 3 lines · In message <[email protected]> you wrote:
hm together with the needed git configuration IMO a bit to complicated for my needs. To be honest I would like to keep this date information as it is.
OK, as you like it.
Quoted 2 lines
If this is not acceptable then I will remove this string completely from the u-boot tree and force the users to add a VERSION file to /tftpboot/scripts with:
I don't like it, that's all. But then I don't have to.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Alliance: In international politics, the union of two thieves who have their hands so deeply inserted in each other's pocket that they cannot separately plunder a third. - Ambrose Bierce
Wolfgang Denk
AppliedPATCH 1/1 km/common: add toolchain variable
In reply to Holger BrunckDear Holger Brunck,
Quoted 9 lines · In message <[email protected]> you…
Add a variable "toolchain" and configure the rootpath for the nfsargs with this variable.
Signed-off-by Holger Brunck <[email protected]>cc Wolfgang Denk <[email protected]>--- board/keymile/scripts/README | 2 +- board/keymile/scripts/develop-common.txt | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Microsoft Multitasking:
several applications can crash at the same time.