arm: Tegra: Fix Harmony and Ventana builds
PATCH 1/1 arm: Tegra: Fix Harmony and Ventana builds
BUG=none
TEST=built all 3 (Harmony, Seaboard and Ventana) and tested Seaboard
--- board/nvidia/harmony/Makefile | 1 - board/nvidia/ventana/Makefile | 3 +-- include/configs/ventana.h | 3 +++ 3 files changed, 4 insertions(+), 3 deletions(-)
board/nvidia/harmony/Makefile +0 -1
@@ -31,7 +31,6 @@ endif LIB = $(obj)lib$(BOARD).o COBJS := $(BOARD).o -COBJS += ../common/board.o SRCS := $(COBJS:.o=.c) OBJS := $(addprefix $(obj),$(COBJS))
board/nvidia/ventana/Makefile +1 -2
@@ -30,8 +30,7 @@ endif LIB = $(obj)lib$(BOARD).o -COBJS += ../seaboard/seaboard.o -COBJS += ../common/board.o +COBJS = ../seaboard/seaboard.o SRCS := $(COBJS:.o=.c) OBJS := $(addprefix $(obj),$(COBJS))
include/configs/ventana.h +3 -0
@@ -52,4 +52,7 @@#define CONFIG_EFI_PARTITION #define CONFIG_CMD_EXT2 #define CONFIG_CMD_FAT + +/* Environment not stored */ +#define CONFIG_ENV_IS_NOWHERE #endif /* __CONFIG_H */
Signature · 1 line
1.7.7.1
PATCH 1/1 arm: Tegra: Fix Harmony and Ventana builds
Tom Warren wrote at Monday, December 19, 2011 4:09 PM:
Quoted 4 lines
Signed-off-by Tom Warren <[email protected]>BUG=none
TEST=built all 3 (Harmony, Seaboard and Ventana) and tested Seaboard
Tom,
I'm a little confused by this. The patch removes ../common/board.o from COBJS for Harmony and Ventana, but not from Seaboard, and at least in u-boot-tegra/ next, Seaboard still references that file.
Also, applying this patch causes Harmony and Ventana to fail to build (link) due to undefined symbols typically provided by common/board.o.
What branch is the patch targeted at, and what build problems is it solving?
Signature · 1 line
nvpublic
PATCH 1/1 arm: Tegra: Fix Harmony and Ventana builds
Hi all,
Le 20/12/2011 01:06, Stephen Warren a ?crit :
Quoted 12 lines
Tom Warren wrote at Monday, December 19, 2011 4:09 PM:
Quoted 4 lines
Signed-off-by Tom Warren<[email protected]>BUG=none
TEST=built all 3 (Harmony, Seaboard and Ventana) and tested SeaboardTom,
I'm a little confused by this. The patch removes
../common/board.ofrom COBJS for Harmony and Ventana, but not from Seaboard, and at least in u-boot-tegra/ next, Seaboard still references that file.
Quoted 5 lines
Also, applying this patch causes Harmony and Ventana to fail to build (link) due to undefined symbols typically provided by
common/board.o.What branch is the patch targeted at, and what build problems is it solving?
Plus, I would suggest making the commit message less cryptic; I can make no heads or tails of these "BUG=" and "TEST=" lines.
Amicalement,
Signature · 1 line
Albert.
PATCH 1/1 arm: Tegra: Fix Harmony and Ventana builds
Sorry, folks. Please ignore u-boot-tegra/next for now. It's in transition.
u-boot-tegra/master has some new patches (getting ready for a pull request) that changed the Seaboard Makefile but not the Harmony or Ventana ones. The fix-it patch I submitted should've had a line that said it applies against u-boot-tegra/master (which really should be 'next', I guess).
The BUG= and TEST= lines are required for ChromeOS U-Boot submissions - I just got into the habit of always applying them to commit messages. I'll remove 'em, add some more info about where exactly this patch applies, and resubmit.
Thanks for catching all this,
Tom
Quoted 29 lines
-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Monday, December 19, 2011 11:56 PM
To: Stephen Warren
Cc: Tom Warren; u-boot at lists.denx.de; sjg at chromium.org; wd at denx.de; Tom Warren
Subject: Re: [PATCH] arm: Tegra: Fix Harmony and Ventana buildsHi all,
Le 20/12/2011 01:06, Stephen Warren a ?crit :
Quoted 12 lines
Tom Warren wrote at Monday, December 19, 2011 4:09 PM:
Quoted 4 lines
Signed-off-by Tom Warren<[email protected]>BUG=none
TEST=built all 3 (Harmony, Seaboard and Ventana) and tested SeaboardTom,
I'm a little confused by this. The patch removes
../common/board.ofrom COBJS for Harmony and Ventana, but not from Seaboard, and at least in u-boot-tegra/ next, Seaboard still references that file.Quoted 5 lines
Also, applying this patch causes Harmony and Ventana to fail to build (link) due to undefined symbols typically provided by
common/board.o.What branch is the patch targeted at, and what build problems is it solving?
Quoted 6 lines
Plus, I would suggest making the commit message less cryptic; I can make no heads or tails of these "BUG=" and "TEST=" lines.
Amicalement,
--
Albert.
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------