Skip to contentSkip to conversation

ohci-hcd: ohci-hcd: use usleep_range() instead of mdelay()

PATCH In review Dmitry Antipov 3 participants 3 messages Dec 21, 2011 – Dec 22, 2011

Subsystems (2)
USB USB ohci driver
lore
Share & tools
lore

Dmitry Antipov

author
#0 lore raw

PATCH 1/1 ohci-hcd: ohci-hcd: use usleep_range() instead of mdelay()

From ac60fe289eef3d81009f2b14a12acbac3e71878b Mon Sep 17 00:00:00 2001
From: Dmitry Antipov <[email protected]>
Date: Wed, 21 Dec 2011 11:05:27 +0400
Subject: [PATCH] ohci-hcd: use usleep_range() instead of mdelay()

---
 drivers/usb/host/ohci-hcd.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/usb/host/ohci-hcd.c +3 -1
index b263919..a6d58da 100644
@@ -574,6 +574,7 @@ static int ohci_run (struct ohci_hcd *ohci)
 	u32			mask, val;
 	int			first = ohci->fminterval == 0;
 	struct usb_hcd		*hcd = ohci_to_hcd(ohci);
+	unsigned long		usecs;
 
 	disable (ohci);
 

@@ -724,7 +725,8 @@ retry:
 	spin_unlock_irq (&ohci->lock);
 
 	// POTPGT delay is bits 24-31, in 2 ms units.
-	mdelay ((val >> 23) & 0x1fe);
+	usecs = ((val >> 23) & 0x1fe) * USEC_PER_MSEC;
+	usleep_range(usecs, usecs + 1000);
 	hcd->state = HC_STATE_RUNNING;
 
 	if (quirk_zfmicro(ohci)) {
Signature · 1 line
1.7.7.4
#1 lore raw
Quoted 5 lines · Dmitry Antipov

From ac60fe289eef3d81009f2b14a12acbac3e71878b Mon Sep 17 00:00:00 2001
From: Dmitry Antipov <[email protected]>
Date: Wed, 21 Dec 2011 11:05:27 +0400
Subject: [PATCH] ohci-hcd: use usleep_range() instead of mdelay()

You didn't sign off on this, and you failed to explain why this is needed.

You also didn't use git-send-email, making it a pain to apply (why do I need the duplicate headers in the email body?

So consider this patch totally ignored.

greg k-h

maintainer
#2 lore raw
In reply to Dmitry Antipov
Quoted 22 lines · Dmitry Antipov

From ac60fe289eef3d81009f2b14a12acbac3e71878b Mon Sep 17 00:00:00 2001
From: Dmitry Antipov <[email protected]>
Date: Wed, 21 Dec 2011 11:05:27 +0400
Subject: [PATCH] ohci-hcd: use usleep_range() instead of mdelay()

---
  drivers/usb/host/ohci-hcd.c |    4 +++-
  1 files changed, 3 insertions(+), 1 deletions(-)
drivers/usb/host/ohci-hcd.c +1 -0
index b263919..a6d58da 100644
@@ -574,6 +574,7 @@ static int ohci_run (struct ohci_hcd *ohci)
  	u32			mask, val;
  	int			first = ohci->fminterval == 0;
  	struct usb_hcd		*hcd = ohci_to_hcd(ohci);
+	unsigned long		usecs;
 
  	disable (ohci);

drivers/usb/host/ohci-hcd.c retry: · line 732

Quoted 9 lines
drivers/usb/host/ohci-hcd.c +2 -1
@@ -724,7 +725,8 @@ retry:
  	spin_unlock_irq (&ohci->lock);
 
  	// POTPGT delay is bits 24-31, in 2 ms units.
-	mdelay ((val >> 23) & 0x1fe);
+	usecs = ((val >> 23) & 0x1fe) * USEC_PER_MSEC;
+	usleep_range(usecs, usecs + 1000);
  	hcd->state = HC_STATE_RUNNING;
 
  	if (quirk_zfmicro(ohci)) {

Why not simply use msleep()?

Alan Stern