Skip to contentSkip to conversation

Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.

PATCH RESEND In review Denis Kuzmenko 2 participants 9 messages Dec 13, 2011 – Dec 29, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Denis Kuzmenko

author
#0 lore raw

PATCH RESEND v2 1/1 Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.

Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.

Signed-off-by Denis Kuzmenko <[email protected]>

---

Patch is against 3.2-rc4.
CONFIG_S3C2410_IOTIMING is not selected for MACH_MINI2440. Because of this the file s3c2410-iotiming.c is not ever compiled and enabling CONFIG_CPU_FREQ_S3C24XX_DEBUGFS option caused undefined reference to function s3c2410_iotiming_debugfs defined in that file. s3c2410_iotiming_debugfs defined as NULL for this case.

Changelog:
v1 -> v2
New CONFIG_ symbols S3C241{0,2}_IOTIMING were removed as It was observed that they already present but hidden from user.

arch/arm/Kconfig +1 -1
index e084b7e..133d005 100644
@@ -2118,7 +2118,7 @@ config CPU_FREQ_S3C24XX_DEBUG
 
 config CPU_FREQ_S3C24XX_IODEBUG
 	bool "Debug CPUfreq Samsung driver IO timing"
-	depends on CPU_FREQ_S3C24XX
+	depends on CPU_FREQ_S3C24XX && (S3C2410_IOTIMING || S3C2412_IOTIMING)
 	help
 	  Enable s3c_freq_iodbg for the Samsung S3C CPUfreq core
arch/arm/plat-samsung/include/plat/cpu-freq-core.h +23 -11
index dac4760..c465252 100644
@@ -202,13 +202,23 @@ extern int s3c_plltab_register(struct cpufreq_frequency_table *plls,
 extern struct s3c_cpufreq_config *s3c_cpufreq_getconfig(void);
 extern struct s3c_iotimings *s3c_cpufreq_getiotimings(void);
 
-extern void s3c2410_iotiming_debugfs(struct seq_file *seq,
-				     struct s3c_cpufreq_config *cfg,
-				     union s3c_iobank *iob);
-
-extern void s3c2412_iotiming_debugfs(struct seq_file *seq,
-				     struct s3c_cpufreq_config *cfg,
-				     union s3c_iobank *iob);
+#ifdef CONFIG_CPU_FREQ_S3C24XX_DEBUGFS
+	#ifdef CONFIG_S3C2410_IOTIMING
+	extern void s3c2410_iotiming_debugfs(struct seq_file *seq,
+					     struct s3c_cpufreq_config *cfg,
+					     union s3c_iobank *iob);
+	#else
+	#define s3c2410_iotiming_debugfs	NULL
+	#endif
+
+	#ifdef CONFIG_S3C2412_IOTIMING
+	extern void s3c2412_iotiming_debugfs(struct seq_file *seq,
+					     struct s3c_cpufreq_config *cfg,
+					     union s3c_iobank *iob);
+	#else
+	#define s3c2412_iotiming_debugfs	NULL
+	#endif
+#endif
 
 #ifdef CONFIG_CPU_FREQ_S3C24XX_DEBUGFS
 #define s3c_cpufreq_debugfs_call(x) x

@@ -241,10 +251,7 @@ extern void s3c2410_iotiming_set(struct s3c_cpufreq_config *cfg,
 #endif /* CONFIG_S3C2410_IOTIMING */
 
 /* S3C2412 compatible routines */
-
-extern int s3c2412_iotiming_get(struct s3c_cpufreq_config *cfg,
-				struct s3c_iotimings *timings);
-
+#ifdef CONFIG_S3C2412_IOTIMING
 extern int s3c2412_iotiming_get(struct s3c_cpufreq_config *cfg,
 				struct s3c_iotimings *timings);
 

@@ -253,6 +260,11 @@ extern int s3c2412_iotiming_calc(struct s3c_cpufreq_config *cfg,
 
 extern void s3c2412_iotiming_set(struct s3c_cpufreq_config *cfg,
 				 struct s3c_iotimings *iot);
+#else
+#define s3c2412_iotiming_calc NULL
+#define s3c2412_iotiming_get NULL
+#define s3c2412_iotiming_set NULL
+#endif
 
 #ifdef CONFIG_CPU_FREQ_S3C24XX_DEBUG
 #define s3c_freq_dbg(x...) printk(KERN_INFO x)
#1 lore raw
Quoted 6 lines · Denis Kuzmenko

Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.

Signed-off-by Denis Kuzmenko <[email protected]>

---

Quoted 10 lines

Patch is against 3.2-rc4.
CONFIG_S3C2410_IOTIMING is not selected for MACH_MINI2440. Because of this the
file s3c2410-iotiming.c is not ever compiled and enabling CONFIG_CPU_FREQ_S3C24XX_DEBUGFS option caused undefined reference to function
s3c2410_iotiming_debugfs defined in that file. s3c2410_iotiming_debugfs defined
as NULL for this case.

Hi Denis,

Well, there is no error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected in my case and s3c2410-iotiming.c is built...when is it happened? I just selected every regarding configuration in kernel menuconfig...

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Quoted 83 lines

Changelog:
v1 -> v2
New CONFIG_ symbols S3C241{0,2}_IOTIMING were removed as It was observed that
they already present but hidden from user.

arch/arm/Kconfig +1 -1
index e084b7e..133d005 100644
@@ -2118,7 +2118,7 @@ config CPU_FREQ_S3C24XX_DEBUG
 
 config CPU_FREQ_S3C24XX_IODEBUG
 	bool "Debug CPUfreq Samsung driver IO timing"
-	depends on CPU_FREQ_S3C24XX
+	depends on CPU_FREQ_S3C24XX && (S3C2410_IOTIMING ||
 S3C2412_IOTIMING)
 	help
 	  Enable s3c_freq_iodbg for the Samsung S3C CPUfreq core
arch/arm/plat-samsung/include/plat/cpu-freq-core.h +17 -7
index dac4760..c465252 100644
@@ -202,13 +202,23 @@ extern int s3c_plltab_register(struct
 cpufreq_frequency_table *plls,
 extern struct s3c_cpufreq_config *s3c_cpufreq_getconfig(void);
 extern struct s3c_iotimings *s3c_cpufreq_getiotimings(void);
 
-extern void s3c2410_iotiming_debugfs(struct seq_file *seq,
-				     struct s3c_cpufreq_config *cfg,
-				     union s3c_iobank *iob);
-
-extern void s3c2412_iotiming_debugfs(struct seq_file *seq,
-				     struct s3c_cpufreq_config *cfg,
-				     union s3c_iobank *iob);
+#ifdef CONFIG_CPU_FREQ_S3C24XX_DEBUGFS
+	#ifdef CONFIG_S3C2410_IOTIMING
+	extern void s3c2410_iotiming_debugfs(struct seq_file *seq,
+					     struct s3c_cpufreq_config *cfg,
+					     union s3c_iobank *iob);
+	#else
+	#define s3c2410_iotiming_debugfs	NULL
+	#endif
+
+	#ifdef CONFIG_S3C2412_IOTIMING
+	extern void s3c2412_iotiming_debugfs(struct seq_file *seq,
+					     struct s3c_cpufreq_config *cfg,
+					     union s3c_iobank *iob);
+	#else
+	#define s3c2412_iotiming_debugfs	NULL
+	#endif
+#endif
 
 #ifdef CONFIG_CPU_FREQ_S3C24XX_DEBUGFS

#define s3c_cpufreq_debugfs_call(x) x

arch/arm/plat-samsung/include/plat/cpu-freq-core.h +6 -4
@@ -241,10 +251,7 @@ extern void s3c2410_iotiming_set(struct
 s3c_cpufreq_config *cfg,
 #endif /* CONFIG_S3C2410_IOTIMING */
 
 /* S3C2412 compatible routines */
-
-extern int s3c2412_iotiming_get(struct s3c_cpufreq_config *cfg,
-				struct s3c_iotimings *timings);
-
+#ifdef CONFIG_S3C2412_IOTIMING
 extern int s3c2412_iotiming_get(struct s3c_cpufreq_config *cfg,
 				struct s3c_iotimings *timings);

@@ -253,6 +260,11 @@ extern int s3c2412_iotiming_calc(struct
 s3c_cpufreq_config *cfg,
 
 extern void s3c2412_iotiming_set(struct s3c_cpufreq_config *cfg,
 				 struct s3c_iotimings *iot);
+#else
+#define s3c2412_iotiming_calc NULL
+#define s3c2412_iotiming_get NULL
+#define s3c2412_iotiming_set NULL
+#endif
 
 #ifdef CONFIG_CPU_FREQ_S3C24XX_DEBUG

#define s3c_freq_dbg(x...) printk(KERN_INFO x)

author
#2 lore raw
Quoted 17 lines · Kukjin Kim
Quoted 6 lines · Denis Kuzmenko

Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.

Signed-off-by Denis Kuzmenko <[email protected]>

---

Quoted 10 lines

Patch is against 3.2-rc4.
CONFIG_S3C2410_IOTIMING is not selected for MACH_MINI2440. Because of this the
file s3c2410-iotiming.c is not ever compiled and enabling CONFIG_CPU_FREQ_S3C24XX_DEBUGFS option caused undefined reference to function
s3c2410_iotiming_debugfs defined in that file. s3c2410_iotiming_debugfs defined
as NULL for this case.

Quoted 5 lines

Hi Denis,

Well, there is no error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected in my case and s3c2410-iotiming.c is built...when is it happened? I just selected every regarding configuration in kernel menuconfig...

Please, try attached config (it's still failing in v3.2-rc6).

Signature · 5 lines
Best regards, Denis Kuzmenko.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: .config
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20111221/e70a99b9/attachment-0001.ksh>
#3 lore raw
Quoted 22 lines · Denis Kuzmenko
Quoted 9 lines · Kukjin Kim
Quoted 8 lines · Denis Kuzmenko

Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.

Signed-off-by Denis Kuzmenko <[email protected]>

---

Patch is against 3.2-rc4.
CONFIG_S3C2410_IOTIMING is not selected for MACH_MINI2440. Because of

this

Quoted 10 lines
Quoted 8 lines

the
file s3c2410-iotiming.c is not ever compiled and enabling CONFIG_CPU_FREQ_S3C24XX_DEBUGFS option caused undefined reference to function
s3c2410_iotiming_debugfs defined in that file. s3c2410_iotiming_debugfs defined
as NULL for this case.

Hi Denis,

Quoted 8 lines
Quoted 1 line

Well, there is no error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected in

my

Quoted 1 line

case and s3c2410-iotiming.c is built...when is it happened? I just

selected

Quoted 1 line

every regarding configuration in kernel menuconfig...

Please, try attached config (it's still failing in v3.2-rc6).

Hi Denis,

Yes, when s3c2410 stuff is not selected, it happened. Look at me soon and thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

author
#4 lore raw
Quoted 27 lines · Kukjin Kim
Quoted 26 lines · Denis Kuzmenko
Quoted 9 lines · Kukjin Kim
Quoted 8 lines · Denis Kuzmenko

Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.

Signed-off-by Denis Kuzmenko <[email protected]>

---

Patch is against 3.2-rc4.
CONFIG_S3C2410_IOTIMING is not selected for MACH_MINI2440. Because of

this

Quoted 11 lines
Quoted 8 lines

the
file s3c2410-iotiming.c is not ever compiled and enabling CONFIG_CPU_FREQ_S3C24XX_DEBUGFS option caused undefined reference to function
s3c2410_iotiming_debugfs defined in that file. s3c2410_iotiming_debugfs defined
as NULL for this case.

Hi Denis,

Well, there is no error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected in

my

Quoted 1 line

case and s3c2410-iotiming.c is built...when is it happened? I just

selected

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

every regarding configuration in kernel menuconfig...

Please, try attached config (it's still failing in v3.2-rc6).

Hi Denis,

Yes, when s3c2410 stuff is not selected, it happened. Look at me soon and thanks.

Hi, Kukjin,

Sorry, can you please explain as I can't understand. Especially second sentence.

Signature · 1 line
Best regards, Denis Kuzmenko.
#5 lore raw
Quoted 35 lines · Denis Kuzmenko
Quoted 10 lines · Kukjin Kim
Quoted 9 lines · Denis Kuzmenko
Quoted 7 lines · Kukjin Kim
Quoted 6 lines · Denis Kuzmenko

Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.

Signed-off-by Denis Kuzmenko <[email protected]>

---

Quoted 8 lines
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines

Patch is against 3.2-rc4.
CONFIG_S3C2410_IOTIMING is not selected for MACH_MINI2440. Because of

this

Quoted 5 lines
Quoted 5 lines

the
file s3c2410-iotiming.c is not ever compiled and enabling CONFIG_CPU_FREQ_S3C24XX_DEBUGFS option caused undefined reference to function
s3c2410_iotiming_debugfs defined in that file.

s3c2410_iotiming_debugfs

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines

defined
as NULL for this case.

Hi Denis,

Well, there is no error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected

in

Quoted 7 lines
Quoted 7 lines

my

Quoted 1 line

case and s3c2410-iotiming.c is built...when is it happened? I just

selected

Quoted 1 line

every regarding configuration in kernel menuconfig...

Please, try attached config (it's still failing in v3.2-rc6).

Quoted 9 lines
Quoted 4 lines

Hi Denis,

Yes, when s3c2410 stuff is not selected, it happened. Look at me soon and thanks.

Hi, Kukjin,

Sorry, can you please explain as I can't understand. Especially second sentence.

Oops, mis-typing. Let me look at that with your patch :)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#6 lore raw
In reply to Denis Kuzmenko
Quoted 27 lines · Denis Kuzmenko

Fix compilation error when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS selected.

Signed-off-by Denis Kuzmenko <[email protected]>

---

Patch is against 3.2-rc4.
CONFIG_S3C2410_IOTIMING is not selected for MACH_MINI2440. Because of this the
file s3c2410-iotiming.c is not ever compiled and enabling CONFIG_CPU_FREQ_S3C24XX_DEBUGFS option caused undefined reference to function
s3c2410_iotiming_debugfs defined in that file. s3c2410_iotiming_debugfs defined
as NULL for this case.

Changelog:
v1 -> v2
New CONFIG_ symbols S3C241{0,2}_IOTIMING were removed as It was observed that
they already present but hidden from user.

arch/arm/Kconfig +0 -0
index e084b7e..133d005 100644

arch/arm/Kconfig config CPU_FREQ_S3C24XX_DEBUG · line 2122

Quoted 6 lines
arch/arm/Kconfig +1 -1
@@ -2118,7 +2118,7 @@ config CPU_FREQ_S3C24XX_DEBUG
 
 config CPU_FREQ_S3C24XX_IODEBUG
 	bool "Debug CPUfreq Samsung driver IO timing"
-	depends on CPU_FREQ_S3C24XX
+	depends on CPU_FREQ_S3C24XX && (S3C2410_IOTIMING ||
 S3C2412_IOTIMING)

As you know, CONFIG_CPU_FREQ_S3C24XX_IODEBUG is for enabling of s3c_freq_iodbg() and there is no problem when CONFIG_S3C241{0,2}_IOTIMING is not selected, even though s3c_freq_iodbg() is used only at s3c2410-iotiming.c now. So this is not necessary to fix the problem you said.

Quoted 27 lines
arch/arm/Kconfig +0 -0
 	help
 	  Enable s3c_freq_iodbg for the Samsung S3C CPUfreq core
arch/arm/plat-samsung/include/plat/cpu-freq-core.h +7 -7
index dac4760..c465252 100644
@@ -202,13 +202,23 @@ extern int s3c_plltab_register(struct
 cpufreq_frequency_table *plls,
 extern struct s3c_cpufreq_config *s3c_cpufreq_getconfig(void);
 extern struct s3c_iotimings *s3c_cpufreq_getiotimings(void);
 
-extern void s3c2410_iotiming_debugfs(struct seq_file *seq,
-				     struct s3c_cpufreq_config *cfg,
-				     union s3c_iobank *iob);
-
-extern void s3c2412_iotiming_debugfs(struct seq_file *seq,
-				     struct s3c_cpufreq_config *cfg,
-				     union s3c_iobank *iob);
+#ifdef CONFIG_CPU_FREQ_S3C24XX_DEBUGFS
+	#ifdef CONFIG_S3C2410_IOTIMING
+	extern void s3c2410_iotiming_debugfs(struct seq_file *seq,
+					     struct s3c_cpufreq_config *cfg,
+					     union s3c_iobank *iob);
+	#else
+	#define s3c2410_iotiming_debugfs	NULL

arch/arm/plat-samsung/include/plat/cpu-freq-core.h extern int s3c_plltab_register(struct · line 222

Quoted 10 lines
arch/arm/plat-samsung/include/plat/cpu-freq-core.h +10 -0
+	#endif
+
+	#ifdef CONFIG_S3C2412_IOTIMING
+	extern void s3c2412_iotiming_debugfs(struct seq_file *seq,
+					     struct s3c_cpufreq_config *cfg,
+					     union s3c_iobank *iob);
+	#else
+	#define s3c2412_iotiming_debugfs	NULL
+	#endif
+#endif

Well, do we really need to have '#ifdef CONFIG_CPU_FREQ_S3C24XX_DEBUGFS' here?
I think, just having dependency with CONFIG_S3C241{1,2}_IOTIMING can avoid the build error.

arch/arm/plat-samsung/include/plat/cpu-freq-core.h extern void s3c2410_iotiming_set(struct · line 248

Quoted 12 lines
arch/arm/plat-samsung/include/plat/cpu-freq-core.h +0 -4
 #ifdef CONFIG_CPU_FREQ_S3C24XX_DEBUGFS
 #define s3c_cpufreq_debugfs_call(x) x

@@ -241,10 +251,7 @@ extern void s3c2410_iotiming_set(struct
 s3c_cpufreq_config *cfg,
 #endif /* CONFIG_S3C2410_IOTIMING */
 
 /* S3C2412 compatible routines */
-
-extern int s3c2412_iotiming_get(struct s3c_cpufreq_config *cfg,
-				struct s3c_iotimings *timings);
-

Yes, why is this duplicated :(

Quoted 16 lines
arch/arm/plat-samsung/include/plat/cpu-freq-core.h +6 -0
+#ifdef CONFIG_S3C2412_IOTIMING
 extern int s3c2412_iotiming_get(struct s3c_cpufreq_config *cfg,
 				struct s3c_iotimings *timings);

@@ -253,6 +260,11 @@ extern int s3c2412_iotiming_calc(struct
 s3c_cpufreq_config *cfg,
 
 extern void s3c2412_iotiming_set(struct s3c_cpufreq_config *cfg,
 				 struct s3c_iotimings *iot);
+#else
+#define s3c2412_iotiming_calc NULL
+#define s3c2412_iotiming_get NULL
+#define s3c2412_iotiming_set NULL
+#endif
 
 #ifdef CONFIG_CPU_FREQ_S3C24XX_DEBUG
Quoted 1 line

#define s3c_freq_dbg(x...) printk(KERN_INFO x)

So how about at below?
If you're ok, will send before v3.2.

---

Quoted 1 line

From 41bb50bd22cdc6d3aa7fb75efab78d341f932ae5 Mon Sep 17 00:00:00 2001

From: Denis Kuzmenko <[email protected]>
Date: Wed, 28 Dec 2011 14:04:51 +0900
Subject: [PATCH] ARM: SAMSUNG: Fix build error when selecting CPU_FREQ_S3C24XX_DEBUGFS on S3C2440

Following is happened when CONFIG_CPU_FREQ_S3C24XX_DEBUGFS is selected without building of s3c2410-iotiming.c file:

arch/arm/mach-s3c2440/built-in.o:(.data+0x38c): undefined reference to `s3c2410_iotiming_debugfs

Basically, the CONFIG_S3C2410_IOTIMING is not selected for MACH_MINI2440. Because the s3c2410-iotiming.c is not ever compiled and enabling CONFIG_CPU_FREQ_S3C24XX_DEBUGFS option caused undefined reference to s3c2410_iotiming_debugfs() defined in that file. The s3c2410_iotiming_debugfs defined as NULL for this case.

Signed-off-by Denis Kuzmenko <[email protected]>
[kgene.kim at samsung.com: removed useless changes]
Signed-off-by Kukjin Kim <[email protected]>
---
 arch/arm/plat-samsung/include/plat/cpu-freq-core.h |   25
++++++++++++--------
 1 files changed, 15 insertions(+), 10 deletions(-)
(quoted diff) +0 -0

b/arch/arm/plat-samsung/include/plat/cpu-freq-core.h index dac4760..95509d8 100644

arch/arm/plat-samsung/include/plat/cpu-freq-core.h +0 -0
@@ -202,14 +202,6 @@ extern int s3c_plltab_register(struct

cpufreq_frequency_table *plls,
extern struct s3c_cpufreq_config *s3c_cpufreq_getconfig(void); extern struct s3c_iotimings *s3c_cpufreq_getiotimings(void);

-extern void s3c2410_iotiming_debugfs(struct seq_file *seq,
- struct s3c_cpufreq_config *cfg,
- union s3c_iobank *iob);
-
-extern void s3c2412_iotiming_debugfs(struct seq_file *seq,
- struct s3c_cpufreq_config *cfg,
- union s3c_iobank *iob);
-
#ifdef CONFIG_CPU_FREQ_S3C24XX_DEBUGFS
#define s3c_cpufreq_debugfs_call(x) x
#else
@@ -226,6 +218,10 @@ extern void s3c2410_cpufreq_setrefresh(struct s3c_cpufreq_config *cfg);
extern void s3c2410_set_fvco(struct s3c_cpufreq_config *cfg);

#ifdef CONFIG_S3C2410_IOTIMING
+extern void s3c2410_iotiming_debugfs(struct seq_file *seq,
+ struct s3c_cpufreq_config *cfg,
+ union s3c_iobank *iob);
+
extern int s3c2410_iotiming_calc(struct s3c_cpufreq_config *cfg,
struct s3c_iotimings *iot);

@@ -235,6 +231,7 @@ extern int s3c2410_iotiming_get(struct s3c_cpufreq_config *cfg,
extern void s3c2410_iotiming_set(struct s3c_cpufreq_config *cfg,
struct s3c_iotimings *iot);
#else
+#define s3c2410_iotiming_debugfs NULL
#define s3c2410_iotiming_calc NULL
#define s3c2410_iotiming_get NULL
#define s3c2410_iotiming_set NULL
@@ -242,8 +239,10 @@ extern void s3c2410_iotiming_set(struct s3c_cpufreq_config *cfg,

/* S3C2412 compatible routines */

-extern int s3c2412_iotiming_get(struct s3c_cpufreq_config *cfg,
- struct s3c_iotimings *timings);
+#ifdef CONFIG_S3C2412_IOTIMING
+extern void s3c2412_iotiming_debugfs(struct seq_file *seq,
+ struct s3c_cpufreq_config *cfg,
+ union s3c_iobank *iob);

extern int s3c2412_iotiming_get(struct s3c_cpufreq_config *cfg,
struct s3c_iotimings *timings);
@@ -253,6 +252,12 @@ extern int s3c2412_iotiming_calc(struct s3c_cpufreq_config *cfg,

extern void s3c2412_iotiming_set(struct s3c_cpufreq_config *cfg,
struct s3c_iotimings *iot);
+#else
+#define s3c2412_iotiming_debugfs NULL
+#define s3c2412_iotiming_calc NULL
+#define s3c2412_iotiming_get NULL
+#define s3c2412_iotiming_set NULL
+#endif /* CONFIG_S3C2412_IOTIMING */

#ifdef CONFIG_CPU_FREQ_S3C24XX_DEBUG
#define s3c_freq_dbg(x...) printk(KERN_INFO x)

Signature · 7 lines
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
author
#7 lore raw

Hi Kukjin,

Your patch applies (note that it looks like your email-client have wrapped long lines thus broke the path) and works OK. Looks good to me. See some additional comments below.

Quoted 1 line · Kukjin Kim

Denis Kuzmenko wrote:

(snip)

Quoted 8 lines
Quoted 2 lines
(quoted diff) +1 -0
+	depends on CPU_FREQ_S3C24XX && (S3C2410_IOTIMING ||

S3C2412_IOTIMING)

As you know, CONFIG_CPU_FREQ_S3C24XX_IODEBUG is for enabling of s3c_freq_iodbg() and there is no problem when CONFIG_S3C241{0,2}_IOTIMING is not selected, even though s3c_freq_iodbg() is used only at s3c2410-iotiming.c now. So this is not necessary to fix the problem you said.

I'm OK with this approach, however I don't see any future use of s3c_freq_iodbg() without s3c2410-iotiming.c. But it's not anyway critical so please pick any variant which you like.

(snip)

Quoted 4 lines

Well, do we really need to have '#ifdef CONFIG_CPU_FREQ_S3C24XX_DEBUGFS' here?
I think, just having dependency with CONFIG_S3C241{1,2}_IOTIMING can avoid the build error.

Yes, CONFIG_S3C241{1,2}_IOTIMING dependency is just enough.

(snip)

Quoted 5 lines

Review

Quoted 3 lines
(quoted diff) +0 -3
-extern int s3c2412_iotiming_get(struct s3c_cpufreq_config *cfg,
-				struct s3c_iotimings *timings);
-

Yes, why is this duplicated :(

Don't have an idea. I'm new to this platform and to Linux at all so I don't know how it appeared.
Just another harmless mistype I think.

(snip)

Quoted 2 lines

So how about at below?
If you're ok, will send before v3.2.

So, as already said, I have no objections.
And thank you for review.

Signature · 1 line
Best regards, Denis Kuzmenko.
#8 lore raw
Quoted 3 lines · Denis Kuzmenko

Hi Kukjin,

Hi Denis,

Quoted 1 line

Your patch applies (note that it looks like your email-client have

Yeah, if over 76 columns, my e-mail client changes its line so maybe happened wrapped long lines.

Quoted 11 lines

wrapped long lines thus broke the path) and works OK. Looks good to me. See some additional comments below.

Quoted 1 line · Kukjin Kim

Denis Kuzmenko wrote:

(snip)

Quoted 5 lines
Quoted 2 lines
(quoted diff) +1 -0
+	depends on CPU_FREQ_S3C24XX && (S3C2410_IOTIMING ||

S3C2412_IOTIMING)

As you know, CONFIG_CPU_FREQ_S3C24XX_IODEBUG is for enabling of s3c_freq_iodbg() and there is no problem when

Quoted 9 lines

CONFIG_S3C241{0,2}_IOTIMING is

Quoted 3 lines

not selected, even though s3c_freq_iodbg() is used only at s3c2410-iotiming.c now. So this is not necessary to fix the problem you said.

I'm OK with this approach, however I don't see any future use of s3c_freq_iodbg() without s3c2410-iotiming.c. But it's not anyway critical so please pick any variant which you like.

Yes. I think we need to sort out the CPUFREQ on S3C24XX next time :)

(snip)

Quoted 7 lines

(snip)

Quoted 2 lines

So how about at below?
If you're ok, will send before v3.2.

So, as already said, I have no objections.
And thank you for review.

Thanks and Happy New Year!

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.