Skip to contentSkip to conversation

arm/tegra: Support Tegra30 in decompressor UART setup

PATCH New Stephen Warren 2 participants 3 messages Dec 22, 2011 – Jan 3, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm/tegra: Support Tegra30 in decompressor UART setup

On Tegra20, the UART clock runs at 216MHz, whereas on Tegra30 it runs at 408MHz. Modify arch_decomp_setup() to detect Tegra20-vs-Tegra30 at run- time, and program the correct divisor.

This makes uncompressor messages work correctly on Tegra30. This also fixes early printk, assuming zImage is used and this setup code runs.

---
 arch/arm/mach-tegra/include/mach/uncompress.h |   20 ++++++++++++++++++--
 1 files changed, 18 insertions(+), 2 deletions(-)
arch/arm/mach-tegra/include/mach/uncompress.h +18 -2
index 4e83237..61d6e08 100644
@@ -24,6 +24,8 @@
 #include <linux/types.h>
 #include <linux/serial_reg.h>
 
+#include <asm/hardware/gic.h>
+
 #include <mach/iomap.h>
 
 static void putc(int c)
@@ -45,15 +47,29 @@ static inline void flush(void)
 
 static inline void arch_decomp_setup(void)
 {
+	u8 *distctr = (u8 *)(TEGRA_ARM_INT_DIST_BASE +
+			     GIC_DIST_CTR);
+	u32 ctlrs, div;
 	volatile u8 *uart = (volatile u8 *)TEGRA_DEBUG_UART_BASE;
 	int shift = 2;
 
 	if (uart == NULL)
 		return;
 
+	/*
+	 * Tegra20 has 4 interrupt controllers
+	 * Tegra30 has 5 interrupt controllers
+	 * Future SoCs may need additional means of identification
+	 */
+	ctlrs = (*distctr) & 0x1f;
+	if (ctlrs == 4)
+		div = 0x0075;
+	else
+		div = 0x00dd;
+
 	uart[UART_LCR << shift] |= UART_LCR_DLAB;
-	uart[UART_DLL << shift] = 0x75;
-	uart[UART_DLM << shift] = 0x0;
+	uart[UART_DLL << shift] = div & 0xff;
+	uart[UART_DLM << shift] = div >> 8;
 	uart[UART_LCR << shift] = 3;
 }
 
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 arm/tegra: Support Tegra30 in decompressor UART setup

Hello.

Quoted 16 lines · Stephen Warren

On Tegra20, the UART clock runs at 216MHz, whereas on Tegra30 it runs at 408MHz. Modify arch_decomp_setup() to detect Tegra20-vs-Tegra30 at run- time, and program the correct divisor.

This makes uncompressor messages work correctly on Tegra30. This also fixes early printk, assuming zImage is used and this setup code runs.

---
  arch/arm/mach-tegra/include/mach/uncompress.h |   20 ++++++++++++++++++--
  1 files changed, 18 insertions(+), 2 deletions(-)
arch/arm/mach-tegra/include/mach/uncompress.h +0 -0
index 4e83237..61d6e08 100644

[...]

Quoted 9 lines
arch/arm/mach-tegra/include/mach/uncompress.h +3 -0
@@ -45,15 +47,29 @@ static inline void flush(void)
 
  static inline void arch_decomp_setup(void)
  {
+	u8 *distctr = (u8 *)(TEGRA_ARM_INT_DIST_BASE +
+			     GIC_DIST_CTR);
+	u32 ctlrs, div;
  	volatile u8 *uart = (volatile u8 *)TEGRA_DEBUG_UART_BASE;
  	int shift = 2;

arch/arm/mach-tegra/include/mach/uncompress.h static inline void flush(void) · line 64

Quoted 10 lines
arch/arm/mach-tegra/include/mach/uncompress.h +6 -0
 
  	if (uart == NULL)
  		return;
 
+	/*
+	 * Tegra20 has 4 interrupt controllers
+	 * Tegra30 has 5 interrupt controllers
+	 * Future SoCs may need additional means of identification
+	 */
+	ctlrs = (*distctr) & 0x1f;

() not necessary.

WBR, Sergei

#2 lore raw

PATCH 1/1 arm/tegra: Support Tegra30 in decompressor UART setup

In reply to Stephen Warren

Stephen Warren wrote at Thursday, December 22, 2011 2:02 PM:

Quoted 6 lines

On Tegra20, the UART clock runs at 216MHz, whereas on Tegra30 it runs at 408MHz. Modify arch_decomp_setup() to detect Tegra20-vs-Tegra30 at run- time, and program the correct divisor.

This makes uncompressor messages work correctly on Tegra30. This also fixes early printk, assuming zImage is used and this setup code runs.

I'll be posting a V2 for this patch soon; I'll rework it to use Tegra's CHIPID register instead of a random GIC register, which should make the code a little more future-proof.

Signature · 1 line
nvpublic