Skip to contentSkip to conversation

U-boot doesn't work on OMAP4430 ES2.0

U-Boot New Raúl Porcel 5 participants 9 messages Dec 26, 2011 – Jan 3, 2012 Arm (32-bit)

lore
Share & tools
lore

Raúl Porcel

author
#0 lore raw

Hi,

Following with the issue on
http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/111922

Looks like the 23e9f0723e48615332119de4f4ec7a833a282628 commit was supposed to fix this, but it doesn't, the problem is still present.

Steve Sakoman's git tree has a different patch:
http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=edb614543dbd007f5b9873e022b8f5aaefe65ba5;hp=1ffe0d2865184336d9e7176dbaf8bb4781f8719a

Indeed applying the patch in his tree makes it work. After talking with him he guessed that maybe the fix was supposed to touch efuse_2 and not efuse_1 like in the original patch.

Thanks

#1 lore raw
Quoted 13 lines

Hi,

Following with the issue on
http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/111922

Looks like the 23e9f0723e48615332119de4f4ec7a833a282628 commit was supposed to fix this, but it doesn't, the problem is still present.

Steve Sakoman's git tree has a different patch:
http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=edb61
4543dbd007f5b9873e022b8f5aaefe65ba5;hp=1ffe0d2865184336d9e7176dbaf8bb4781f8 719a

Quoted 5 lines

Indeed applying the patch in his tree makes it work. After talking with him he guessed that maybe the fix was supposed to touch efuse_2 and not efuse_1 like in the original patch.

Thanks

Please Cc the omap custodian with this. Also, if you have a patch, please submit it too.

M

#2 lore raw
Quoted 13 lines · Marek Vasut
Quoted 13 lines

Hi,

Following with the issue on
http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/111922

Looks like the 23e9f0723e48615332119de4f4ec7a833a282628 commit was supposed to fix this, but it doesn't, the problem is still present.

Steve Sakoman's git tree has a different patch:
http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=edb61
4543dbd007f5b9873e022b8f5aaefe65ba5;hp=1ffe0d2865184336d9e7176dbaf8bb4781f8 719a

Quoted 8 lines
Quoted 5 lines

Indeed applying the patch in his tree makes it work. After talking with him he guessed that maybe the fix was supposed to touch efuse_2 and not efuse_1 like in the original patch.

Thanks

Please Cc the omap custodian with this. Also, if you have a patch, please submit it too.

Note that I've seen this but I'm on vacation this week so I've seen this. Tested on a few boards patches greatly appreciated otherwise I'll see what I can get going early next week (and I might have to hunt up someone with ES2.0 silicon). Thanks!

Signature · 1 line
Tom
#3 lore raw
In reply to Raúl Porcel

Hi Raul,

Quoted 8 lines · Ra?l Porcel

Hi,

Following with the issue on
http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/111922

Looks like the 23e9f0723e48615332119de4f4ec7a833a282628 commit was supposed to fix this, but it doesn't, the problem is still present.

Quoted 6 lines

Steve Sakoman's git tree has a different patch:
http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=edb614543dbd007f5b9873e022b8f5aaefe65ba5;hp=1ffe0d2865184336d9e7176dbaf8bb4781f8719a

Indeed applying the patch in his tree makes it work. After talking with him he guessed that maybe the fix was supposed to touch efuse_2 and not efuse_1 like in the original patch.

Yes, this is a mix-up. I shall send a new patch. Will you be able to test it for me. I don't have an ES2.0 Panda with me anymore. This issue is not there on ES2.0 SDP.

regards,
Aneesh

author
#4 lore raw

Hi Aneesh

Quoted 19 lines · Aneesh V

Hi Raul,

Quoted 8 lines · Ra?l Porcel

Hi,

Following with the issue on
http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/111922

Looks like the 23e9f0723e48615332119de4f4ec7a833a282628 commit was supposed to fix this, but it doesn't, the problem is still present.

Quoted 7 lines

Steve Sakoman's git tree has a different patch:
http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=edb614543dbd007f5b9873e022b8f5aaefe65ba5;hp=1ffe0d2865184336d9e7176dbaf8bb4781f8719a

Indeed applying the patch in his tree makes it work. After talking with him he guessed that maybe the fix was supposed to touch efuse_2 and not efuse_1 like in the original patch.

Quoted 6 lines

Yes, this is a mix-up. I shall send a new patch. Will you be able to test it for me. I don't have an ES2.0 Panda with me anymore. This issue is not there on ES2.0 SDP.

regards,
Aneesh

Sure, feel free to send a patch and i'll test it.

Thanks!

#5 lore raw

PATCH 1/1 omap4: fix boot issue on ES2.0 Panda

In reply to Raúl Porcel

Fix boot issue on ES2.0 Panda by tuning some IO settings. The CONTROL_EFUSE_2 register has to be over-ridden in software for 4430 boards.

Commit 23e9f0723e48615332119de4f4ec7a833a282628 wrongly did this for CONTROL_EFUSE_1. Reverting this and doing it for CONTROL_EFUSE_2.

Signed-off-by Aneesh V <[email protected]>
---
 arch/arm/cpu/armv7/omap4/hwinit.c      |    4 ++--
 arch/arm/include/asm/arch-omap4/omap.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/cpu/armv7/omap4/hwinit.c +2 -2
index 37a86b4..91f8320 100644
@@ -110,10 +110,10 @@ void do_io_settings(void)
 	 *	i. unconditionally for all 4430
 	 *	ii. only if un-trimmed for 4460
 	 */
-	if ((omap4_rev < OMAP4460_ES1_0) || !readl(&ctrl->control_efuse_1))
+	if (!readl(&ctrl->control_efuse_1))
 		writel(CONTROL_EFUSE_1_OVERRIDE, &ctrl->control_efuse_1);
 
-	if (!readl(&ctrl->control_efuse_2))
+	if ((omap4_rev < OMAP4460_ES1_0) || !readl(&ctrl->control_efuse_2))
 		writel(CONTROL_EFUSE_2_OVERRIDE, &ctrl->control_efuse_2);
 }
 #endif
arch/arm/include/asm/arch-omap4/omap.h +1 -1
index 4d8c89f..416c6de 100644
@@ -116,7 +116,7 @@
 #define LDOSRAM_ACTMODE_VSET_IN_MASK	(0x1F << 5)
 #define LDOSRAM_VOLT_CTRL_OVERRIDE	0x0401040f
 #define CONTROL_EFUSE_1_OVERRIDE	0x1C4D0110
-#define CONTROL_EFUSE_2_OVERRIDE	0x00084000
+#define CONTROL_EFUSE_2_OVERRIDE	0x99084000
 
 /* LPDDR2 IO regs */
 #define CONTROL_LPDDR2IO_SLEW_125PS_DRV8_PULL_DOWN	0x1C1C1C1C
Signature · 1 line
1.7.1
#6 lore raw

PATCH 1/1 omap4: fix boot issue on ES2.0 Panda

Quoted 9 lines · Aneesh V

Fix boot issue on ES2.0 Panda by tuning some IO settings. The CONTROL_EFUSE_2 register has to be over-ridden in software for 4430 boards.

Commit 23e9f0723e48615332119de4f4ec7a833a282628 wrongly did this for CONTROL_EFUSE_1. Reverting this and doing it for CONTROL_EFUSE_2.

Signed-off-by Aneesh V <[email protected]>

[snip]

Hi,

works fine:

U-Boot SPL 2011.12-00046-gbfcc40b-dirty (Dec 31 2011 - 12:14:09) Texas Instruments OMAP4430 ES2.0
OMAP SD/MMC: 0
reading u-boot.img
reading u-boot.img

U-Boot 2011.12-00046-gbfcc40b-dirty (Dec 31 2011 - 12:14:09)

CPU  : OMAP4430 ES2.0
Board: OMAP4 Panda
I2C:   ready
DRAM:  1 GiB
MMC:   OMAP SD/MMC: 0

Using default environment

Thanks!

Tested-by Ra?l Porcel <[email protected]>
author
#7 lore raw

PATCH 1/1 omap4: fix boot issue on ES2.0 Panda

On 12/31/2011 01:27 PM, asad wrote:
[snip]

Jeez, obviously this is me...

Thanks and sorry

#8 lore raw

PATCH 1/1 omap4: fix boot issue on ES2.0 Panda

In reply to asad
Quoted 32 lines · asad
Quoted 9 lines · Aneesh V

Fix boot issue on ES2.0 Panda by tuning some IO settings. The CONTROL_EFUSE_2 register has to be over-ridden in software for 4430 boards.

Commit 23e9f0723e48615332119de4f4ec7a833a282628 wrongly did this for CONTROL_EFUSE_1. Reverting this and doing it for CONTROL_EFUSE_2.

Signed-off-by Aneesh V <[email protected]>

[snip]

Hi,

works fine:

U-Boot SPL 2011.12-00046-gbfcc40b-dirty (Dec 31 2011 - 12:14:09) Texas Instruments OMAP4430 ES2.0
OMAP SD/MMC: 0
reading u-boot.img
reading u-boot.img

U-Boot 2011.12-00046-gbfcc40b-dirty (Dec 31 2011 - 12:14:09)

CPU ?: OMAP4430 ES2.0
Board: OMAP4 Panda
I2C: ? ready
DRAM: ?1 GiB
MMC: ? OMAP SD/MMC: 0
Using default environment

Quoted 3 lines

Thanks!

Tested-by Ra?l Porcel <[email protected]>

Applied to u-boot-ti/master, thanks!

Signature · 1 line
Tom