Skip to contentSkip to conversation

tcp_diag: Don't report max ack backlog in wqueue

PATCH In review Pavel Emelyanov 2 participants 2 messages Dec 28, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/5 tcp_diag: Don't report max ack backlog in wqueue

This is not correct and actually makes ss work differently on proc vs netlink -- in the former case 0 is reported.

---
 net/ipv4/tcp_diag.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/ipv4/tcp_diag.c +1 -1
index 8cd357a..3f2e2ef 100644
@@ -25,7 +25,7 @@ static void tcp_diag_get_info(struct sock *sk, struct inet_diag_msg *r,
 
 	if (sk->sk_state == TCP_LISTEN) {
 		r->idiag_rqueue = sk->sk_ack_backlog;
-		r->idiag_wqueue = sk->sk_max_ack_backlog;
+		r->idiag_wqueue = 0;
 	} else {
 		r->idiag_rqueue = max_t(int, tp->rcv_nxt - tp->copied_seq, 0);
 		r->idiag_wqueue = tp->write_seq - tp->snd_una;
Signature · 1 line
1.5.5.6
maintainer
#1 lore raw

From: Pavel Emelyanov <[email protected]>
Date: Wed, 28 Dec 2011 17:36:28 +0400

Quoted 4 lines

This is not correct and actually makes ss work differently on proc vs netlink -- in the former case 0 is reported.

It's very much intentional Pavel, Alexey Kuznetsov put this there on purpose.

There is no other place in the diag interface where the max_ack_backlog value is provided.

I'm not applying this.