Skip to contentSkip to conversation

MTD/GPMI : select more modules for GPMI by default

PATCH New Huang Shijie 4 participants 8 messages Dec 30, 2011 – Dec 31, 2011

Subsystems (2)
Memory technology devices (MTD) NAND flash
lore
Share & tools
lore

Huang Shijie

author
#0 lore raw

PATCH 1/1 MTD/GPMI : select more modules for GPMI by default

The gpmi-nand driver needs the mxs-dma driver. So select the MXS_DMA by default. So does the MTD_CHAR.

Signed-off-by Huang Shijie <[email protected]>
---
 drivers/mtd/nand/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mtd/nand/Kconfig +2 -0
index 07c4774..1b14a3a 100644
@@ -420,6 +420,8 @@ config MTD_NAND_NANDSIM
 config MTD_NAND_GPMI_NAND
         bool "GPMI NAND Flash Controller driver"
         depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28)
+	select MXS_DMA
+	select MTD_CHAR
 	select MTD_PARTITIONS
 	select MTD_CMDLINE_PARTS
         help
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 MTD/GPMI : select more modules for GPMI by default

Quoted 13 lines · Huang Shijie

The gpmi-nand driver needs the mxs-dma driver. So select the MXS_DMA by default. So does the MTD_CHAR.

Signed-off-by Huang Shijie <[email protected]>
---
 drivers/mtd/nand/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mtd/nand/Kconfig +0 -0
index 07c4774..1b14a3a 100644

drivers/mtd/nand/Kconfig config MTD_NAND_NANDSIM · line 423

Quoted 4 lines
drivers/mtd/nand/Kconfig +1 -0
@@ -420,6 +420,8 @@ config MTD_NAND_NANDSIM
 config MTD_NAND_GPMI_NAND
         bool "GPMI NAND Flash Controller driver"
         depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28)
+	select MXS_DMA

We should probably have it depend on MXS_DMA rather than select it.

Regards,
Shawn

Quoted 6 lines
drivers/mtd/nand/Kconfig +1 -0
+	select MTD_CHAR
 	select MTD_PARTITIONS
 	select MTD_CMDLINE_PARTS
         help
Signature · 1 line
1.7.0.4
author
#2 lore raw

PATCH 1/1 MTD/GPMI : select more modules for GPMI by default

? 2011?12?31? 13:44, Shawn Guo ??:

Quoted 9 lines · Huang Shijie
Quoted 8 lines

The gpmi-nand driver needs the mxs-dma driver. So select the MXS_DMA by default. So does the MTD_CHAR.

Signed-off-by Huang Shijie<[email protected]>
---
  drivers/mtd/nand/Kconfig |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
Quoted 10 lines

drivers/mtd/nand/Kconfig config MTD_NAND_NANDSIM · line 423

Quoted 9 lines
drivers/mtd/nand/Kconfig +1 -0
index 07c4774..1b14a3a 100644
@@ -420,6 +420,8 @@ config MTD_NAND_NANDSIM
  config MTD_NAND_GPMI_NAND
          bool "GPMI NAND Flash Controller driver"
          depends on MTD_NAND&&  (SOC_IMX23 || SOC_IMX28)
+	select MXS_DMA

We should probably have it depend on MXS_DMA rather than select it.

IMHO, I think select is better. :)
The MXS_DMA not only service for NAND, but SD card, etc. In logic, the GPMI does not depends on MXS_DMA, the GPMI may use SDMA too(just in logically).

Best Regards
Huang Shijie

Quoted 9 lines

Regards,
Shawn

Quoted 6 lines
drivers/mtd/nand/Kconfig +1 -0
+	select MTD_CHAR
  	select MTD_PARTITIONS
  	select MTD_CMDLINE_PARTS
          help
Signature · 1 line
1.7.0.4
#3 lore raw

PATCH 1/1 MTD/GPMI : select more modules for GPMI by default

Quoted 22 lines

? 2011?12?31? 13:44, Shawn Guo ??:

Quoted 21 lines · Huang Shijie
Quoted 20 lines

The gpmi-nand driver needs the mxs-dma driver. So select the MXS_DMA by default. So does the MTD_CHAR.

Signed-off-by Huang Shijie<[email protected]>

---

  drivers/mtd/nand/Kconfig |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mtd/nand/Kconfig +0 -0
index 07c4774..1b14a3a 100644
@@ -420,6 +420,8 @@ config MTD_NAND_NANDSIM
 
  config MTD_NAND_GPMI_NAND
 
          bool "GPMI NAND Flash Controller driver"
          depends on MTD_NAND&&  (SOC_IMX23 || SOC_IMX28)
Quoted 8 lines
Quoted 3 lines

drivers/mtd/nand/Kconfig config MTD_NAND_NANDSIM · line 423

Quoted 1 line
drivers/mtd/nand/Kconfig +1 -0
+	select MXS_DMA

We should probably have it depend on MXS_DMA rather than select it.

IMHO, I think select is better. :)
The MXS_DMA not only service for NAND, but SD card, etc. In logic, the GPMI does not depends on MXS_DMA, the GPMI may use SDMA too(just in logically).

And does it use that ? Technically, it's still dependent on MXS_DMA, right ? Also, why select mtd_char, it's totally unrelated.

M

Quoted 19 lines

Best Regards
Huang Shijie

Quoted 9 lines

Regards,
Shawn

Quoted 6 lines
drivers/mtd/nand/Kconfig +1 -0
+	select MTD_CHAR

select MTD_PARTITIONS
select MTD_CMDLINE_PARTS

help

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author
#4 lore raw

PATCH 1/1 MTD/GPMI : select more modules for GPMI by default

? 2011?12?31? 15:01, Marek Vasut ??:

Quoted 22 lines
Quoted 22 lines

? 2011?12?31? 13:44, Shawn Guo ??:

Quoted 21 lines · Huang Shijie
Quoted 20 lines

The gpmi-nand driver needs the mxs-dma driver. So select the MXS_DMA by default. So does the MTD_CHAR.

Signed-off-by Huang Shijie<[email protected]>

---

   drivers/mtd/nand/Kconfig |    2 ++
   1 files changed, 2 insertions(+), 0 deletions(-)
drivers/mtd/nand/Kconfig +0 -0
index 07c4774..1b14a3a 100644
@@ -420,6 +420,8 @@ config MTD_NAND_NANDSIM
 
   config MTD_NAND_GPMI_NAND
 
           bool "GPMI NAND Flash Controller driver"
           depends on MTD_NAND&&   (SOC_IMX23 || SOC_IMX28)
Quoted 7 lines
Quoted 6 lines
Quoted 2 lines

drivers/mtd/nand/Kconfig config MTD_NAND_NANDSIM · line 423

Quoted 1 line
drivers/mtd/nand/Kconfig +1 -0
+	select MXS_DMA

We should probably have it depend on MXS_DMA rather than select it.

IMHO, I think select is better. :)
The MXS_DMA not only service for NAND, but SD card, etc. In logic, the GPMI does not depends on MXS_DMA, the GPMI may use SDMA too(just in logically).

And does it use that ? Technically, it's still dependent on MXS_DMA, right ?

NO. Just assumption.

the GPMI driver will continue to depend on MXS_DMA in the following chips, such as MX6Q.

Quoted 1 line

Also, why select mtd_char, it's totally unrelated.

The GPMI works with UBIFS, the UBIFS is based on /dev/mtd0..,

Huang Shijie

Quoted 18 lines

M

Quoted 17 lines

Best Regards
Huang Shijie

Quoted 9 lines

Regards,
Shawn

Quoted 6 lines
drivers/mtd/nand/Kconfig +1 -0
+	select MTD_CHAR

select MTD_PARTITIONS
select MTD_CMDLINE_PARTS

help

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw

PATCH 1/1 MTD/GPMI : select more modules for GPMI by default

In reply to Huang Shijie
Quoted 8 lines · Huang Shijie

? 2011?12?31? 13:44, Shawn Guo ??:

Quoted 2 lines

drivers/mtd/nand/Kconfig config MTD_NAND_NANDSIM · line 423

Quoted 1 line
drivers/mtd/nand/Kconfig +1 -0
+	select MXS_DMA

We should probably have it depend on MXS_DMA rather than select it.

IMHO, I think select is better. :)
The MXS_DMA not only service for NAND, but SD card, etc. In logic, the GPMI does not depends on MXS_DMA, the GPMI may use SDMA too(just in logically).

Here is what Documentation/kbuild/kconfig-language.txt tells:

select should be used with care. select will force a symbol to a value without visiting the dependencies. By abusing select you are able to select a symbol FOO even if FOO depends on BAR that is not set.
In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies. That will limit the usefulness but on the other hand avoid the illegal configurations all over.

Signature · 2 lines
Regards,
Shawn
author
#6 lore raw

PATCH 1/1 MTD/GPMI : select more modules for GPMI by default

Hi,

thanks a lot!

Quoted 4 lines

Here is what Documentation/kbuild/kconfig-language.txt tells:

select should be used with care. select will force a symbol to a value without visiting the dependencies.

:( I ever thought the select will do the dependencies automatically.

I do not like the GPMI depend on the MXS-DMA. It looks very strange when you do the "make menuconfig".

to Arterm:
Maybe you can drop this patch.

thanks

Huang Shijie

Quoted 7 lines

By abusing select you are able to select a symbol FOO even if FOO depends on BAR that is not set.
In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies. That will limit the usefulness but on the other hand avoid the illegal configurations all over.

#7 lore raw

PATCH 1/1 MTD/GPMI : select more modules for GPMI by default

Quoted 2 lines

I do not like the GPMI depend on the MXS-DMA. It looks very strange when you do the "make menuconfig".

That doesn't change that it DOES depend on it :) (You can't use GPMI without DMA, right?)

Signature · 9 lines
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20111231/ed8a9016/attachment.sig>