lib/parse_opts: STD_LP_sbrk and STD_start_break should only be defined when UCLINUX=0
PATCH 1/21 lib/parse_opts: STD_LP_sbrk and STD_start_break should only be defined when UCLINUX=0
Hi,
Please review the attached patch.
Signature · 1 line
markos
From 73d72d74229c0598b2e1d5e070418c5855159373 Mon Sep 17 00:00:00 2001
From: Markos Chandras <[email protected]>
Date: Thu, 22 Dec 2011 10:36:35 +0000
Subject: [PATCH 01/21] lib/parse_opts: STD_LP_sbrk and STD_start_break should only be defined when UCLINUX=0
These variables are only used when the UCLINUX macro is not defined therefore it is better to declare them conditionally.
--- lib/parse_opts.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
lib/parse_opts.c +2 -0
@@ -139,8 +139,10 @@ static int STD_LP_shmem=0; /* flag to do shmem_puts and gets during TEST_LOOPIstatic int STD_LD_recfun=0 ;/* do recressive function calls in loop delay */ static int STD_LP_recfun=0 ;/* do recressive function calls in TEST_LOOPING */ static int STD_TP_sbrk=0 ;/* do sbrk in TEST_PAUSE */ +#ifndef UCLINUX static int STD_LP_sbrk=0 ;/* do sbrk in TEST_LOOPING */ static char *STD_start_break=0 ;/* original sbrk size */ +#endif static int Debug=0 ;struct std_option_t {
Signature · 1 line
1.7.1
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
please use git send-email to properly post patches. attaching them like this makes it a pita to review.
-mike
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 2 lines · Mike Frysinger
please use
git send-emailto properly post patches. attaching them like this makes it a pita to review.
+1. Or just use what's noted in the style guide as well for submitting patches if you really want to go down this path of creating patch review/commit request emails.
Thanks,
-Garrett
------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 9 lines · Garrett Cooper
Quoted 2 lines · Mike Frysinger
please use
git send-emailto properly post patches. attaching them like this makes it a pita to review.+1. Or just use what's noted in the style guide as well for submitting patches if you really want to go down this path of creating patch review/commit request emails.
Thanks,
-Garrett
Thanks. I will do that from now on.
Signature · 13 lines
markos ------------------------------------------------------------------------------ Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex infrastructure or vast IT resources to deliver seamless, secure access to virtual desktops. With this all-in-one solution, easily deploy virtual desktops for less than the cost of PCs and save 60% on VDI infrastructure costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list