Skip to contentSkip to conversation

Build system: Always append CFLAGS at the end

PATCH In review Markos Chandras 2 participants 2 messages Jan 3, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 13/21 Build system: Always append CFLAGS at the end

Hi, please review the attached patch

Signature · 1 line
markos

From 5800c95986bb1d63ef0af9dda4eb87c771bcccf3 Mon Sep 17 00:00:00 2001
From: Markos Chandras <[email protected]>
Date: Thu, 22 Dec 2011 17:22:48 +0000
Subject: [PATCH 13/21] Build system: Always append CFLAGS at the end

The build system sets -g -O2 -fno-strict-aliasing -pipe by default. We append the enviromental CFLAGS at the end to allow the user to override the default CFLAGS

---
 include/mk/config.mk.in |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
include/mk/config.mk.in +5 -2
index b835c86..6148b2c 100644
@@ -72,8 +72,11 @@ WCFLAGS			?= -Wall
 WCXXFLAGS		?= $(WCFLAGS)
 
 LDFLAGS			+= $(WLDFLAGS)
-CFLAGS			+= $(DEBUG_CFLAGS) $(OPT_CFLAGS) $(WCFLAGS)
-CXXFLAGS		+= $(DEBUG_CXXFLAGS) $(OPT_CXXFLAGS) $(WCXXFLAGS)
+AMCFLAGS		= $(DEBUG_CFLAGS) $(OPT_CFLAGS) $(WCFLAGS) $(CFLAGS)
+AMCXXFLAGS		= $(DEBUG_CXXFLAGS) $(OPT_CXXFLAGS) $(WCXXFLAGS) $(CXXFLAGS)
+
+CFLAGS			:= $(AMCFLAGS)
+CXXFLAGS		:= $(AMCXXFLAGS)
 
 ifeq ($(strip $(prefix)),)
 $(error you are using $$(prefix) incorrectly -- set it to $(abs_top_srcdir) if you want to build in the source tree)
Signature · 1 line
1.7.1

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw
Quoted 1 line · Markos Chandras

Hi, please review the attached patch

I'm going to think about this proposed change for a while because
it might break certain scenarios. Please test this change and other build changes via the testscripts/build/test_* scripts before sending them out for review.
Thanks,
-Garrett

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list