Skip to contentSkip to conversation

ath6kl: force building as a module

PATCH NAK Kalle Valo 4 participants 4 messages Jan 4, 2012 1 message not in the archive

Subsystems (2)
Linux-next tree Atheros ATH6KL wireless driver
lore
Share & tools
lore

Kalle Valo

author
#0 lore raw

PATCH 1/1 ath6kl: force building as a module

Stephen reported that ath6kl fails if both sdio and usb are built into the kernel:

ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME' ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function) ath6kl/cfg80211.c:27:1: error: expected ',' or ';' before string constant

As a temporary fix make ath6kl build only as a module. This will be reverted once a separate ath6kl core module is implemented which will fix this properly.

Reported-by Stephen Rothwell <[email protected]>
Signed-off-by Kalle Valo <[email protected]>
---
 drivers/net/wireless/ath/ath6kl/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/net/wireless/ath/ath6kl/Kconfig +2 -0
index d755a5e..d290ec7 100644
@@ -6,6 +6,7 @@ config ATH6KL_SDIO
 	depends on ATH6KL
 	depends on MMC
 	depends on CFG80211
+	depends on m
 	---help---
 	  This module adds support for wireless adapters based on
 	  Atheros AR6003 and AR6004 chipsets running over SDIO. If you

@@ -19,6 +20,7 @@ config ATH6KL_USB
 	depends on USB
 	depends on CFG80211
 	depends on EXPERIMENTAL
+	depends on m
 	---help---
 	  This module adds support for wireless adapters based on
 	  Atheros AR6004 chipset running over USB. This is still under
#1 lore raw
Quoted 7 lines · Kalle Valo

Stephen reported that ath6kl fails if both sdio and usb are built into the kernel:

ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME' ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function) ath6kl/cfg80211.c:27:1: error: expected ',' or ';' before string constant

Quoted 6 lines

As a temporary fix make ath6kl build only as a module. This will be reverted once a separate ath6kl core module is implemented which will fix this properly.

Reported-by Stephen Rothwell <[email protected]>
Signed-off-by Kalle Valo <[email protected]>

Sorry, forgot to CC people. The original patch is here:

http://marc.info/?l=linux-wireless&m=132567025132302&w=2

John, can you please take this directly so that the build problem gets fixed quickly? I will also apply it to ath6kl.git but that should not create any merge problems.

Kalle
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

From: Kalle Valo <[email protected]>
Date: Wed, 4 Jan 2012 11:48:40 +0200

Quoted 15 lines · Kalle Valo
Quoted 7 lines

Stephen reported that ath6kl fails if both sdio and usb are built into the kernel:

ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME' ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function) ath6kl/cfg80211.c:27:1: error: expected ',' or ';' before string constant

Quoted 6 lines

As a temporary fix make ath6kl build only as a module. This will be reverted once a separate ath6kl core module is implemented which will fix this properly.

Reported-by Stephen Rothwell <[email protected]>
Signed-off-by Kalle Valo <[email protected]>
Quoted 7 lines

Sorry, forgot to CC people. The original patch is here:

http://marc.info/?l=linux-wireless&m=132567025132302&w=2

John, can you please take this directly so that the build problem gets fixed quickly? I will also apply it to ath6kl.git but that should not create any merge problems.

John can you very much NOT include this change, and if the ath6kl maintainers can't fix this properly then revert the changes that caused this regression in the first place?
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

NAK
#4 lore raw
In reply to Kalle Valo

From: Kalle Valo <[email protected]>
Date: Wed, 04 Jan 2012 11:41:34 +0200

Quoted 7 lines

Stephen reported that ath6kl fails if both sdio and usb are built into the kernel:

ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME' ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function) ath6kl/cfg80211.c:27:1: error: expected ',' or ';' before string constant

Quoted 6 lines

As a temporary fix make ath6kl build only as a module. This will be reverted once a separate ath6kl core module is implemented which will fix this properly.

Reported-by Stephen Rothwell <[email protected]>
Signed-off-by Kalle Valo <[email protected]>

NACK, fix this properly.