Skip to contentSkip to conversation

realtime/lib/Makefile: Fix path for config.mk

PATCH In review Markos Chandras 3 participants 7 messages Jan 3, 2012 – Jun 28, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 9/21 realtime/lib/Makefile: Fix path for config.mk

Hi, please review the attached patch

Signature · 1 line
markos

From 34eab5207f365db3ed43614bb499a8863ca2ca82 Mon Sep 17 00:00:00 2001
From: Markos Chandras <[email protected]>
Date: Thu, 15 Dec 2011 12:14:47 +0000
Subject: [PATCH 09/21] realtime/lib/Makefile: Fix path for config.mk

The autotools in realtime subfolders overwrites the top level autotools variables. To avoid this problem, we use relative
paths instead of using variables that may or may not be have been overwritten by another autotools build.

---
 testcases/realtime/lib/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
testcases/realtime/lib/Makefile +1 -1
index 8860549..ecf4b5c 100644
@@ -22,7 +22,7 @@
 
 top_srcdir		?= ../../..
 
-include $(top_srcdir)/../config.mk
+include ../config.mk
 
 CFLAGS			+= -D_GNU_SOURCE
 
Signature · 1 line
1.7.1

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw
Quoted 1 line · Markos Chandras

Hi, please review the attached patch

No -- this breaks out-of-tree compiles.
-Garrett

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#2 lore raw
Quoted 6 lines · Garrett Cooper
Quoted 1 line · Markos Chandras

Hi, please review the attached patch

No -- this breaks out-of-tree compiles.
-Garrett

But without this patch, the in-tree 'distclean' target is broken

Signature · 13 lines
markos


------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#3 lore raw
Quoted 5 lines · Markos Chandras
Quoted 4 lines · Garrett Cooper
Quoted 1 line · Markos Chandras
Quoted 7 lines
Quoted 5 lines
Quoted 1 line

Hi, please review the attached patch

No -- this breaks out-of-tree compiles.
-Garrett

But without this patch, the in-tree 'distclean' target is broken

Hmmm... it worked once upon a time. I'll look at this when I have a chance.
Thanks,
-Garrett

------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex infrastructure or vast IT resources to deliver seamless, secure access to virtual desktops. With this all-in-one solution, easily deploy virtual desktops for less than the cost of PCs and save 60% on VDI infrastructure costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#4 lore raw

Hi!

Quoted 9 lines
Quoted 7 lines
Quoted 5 lines
Quoted 1 line

Hi, please review the attached patch

No -- this breaks out-of-tree compiles.
-Garrett

But without this patch, the in-tree 'distclean' target is broken

Hmmm... it worked once upon a time. I'll look at this when I have a chance.

It's broken since 21e14b79ce269f27be8ce49475dc49c5bc5838bd, reverting it fixed the build.

Signature · 13 lines
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#5 lore raw

Hi!

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 1 line

Hi, please review the attached patch

No -- this breaks out-of-tree compiles.
-Garrett

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

But without this patch, the in-tree 'distclean' target is broken

Hmmm... it worked once upon a time. I'll look at this when I have a chance.

It's broken since 21e14b79ce269f27be8ce49475dc49c5bc5838bd, reverting it fixed the build.

Ping. Any chance you will look at this, the out of tree build is broken without that patch and the in tree with.

Signature · 13 lines
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#6 lore raw

Hi!
What about attached patch?

Signature · 2 lines
Cyril Hrubis
[email protected]

From 36ae7233c9606b78edcb2ca0eaf1a0a926cbd470 Mon Sep 17 00:00:00 2001
From: Cyril Hrubis <[email protected]>
Date: Wed, 20 Jun 2012 17:14:57 +0200
Subject: [PATCH 1/3] Fix realtime build.

---
 testcases/realtime/lib/Makefile |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
testcases/realtime/lib/Makefile +3 -2
index 8860549..fc4784b 100644
@@ -2,6 +2,7 @@
 #    realtime/lib Makefile.
 #
 #    Copyright (C) 2009, Cisco Systems Inc.
+#    Copyright (C) 2012  Cyril Hrubis <[email protected]>
 #
 #    This program is free software; you can redistribute it and/or modify
 #    it under the terms of the GNU General Public License as published by
@@ -22,9 +23,9 @@
 
 top_srcdir		?= ../../..
 
-include $(top_srcdir)/../config.mk
+include $(top_srcdir)/include/mk/env_pre.mk
 
-CFLAGS			+= -D_GNU_SOURCE
+CFLAGS			+= -D_GNU_SOURCE -I../include/
 
 LDLIBS			+= -lpthread -lrt -lm
 
Signature · 1 line
1.7.3.4

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list