m28evk: Use GENERATED_GBL_DATA_SIZE
PATCH 1/1 m28evk: Use GENERATED_GBL_DATA_SIZE
Use GENERATED_GBL_DATA_SIZE for calculating CONFIG_SYS_INIT_SP_OFFSET.
--- include/configs/m28evk.h | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-)
include/configs/m28evk.h +8 -1
@@ -92,7 +92,14 @@#define CONFIG_SYS_MEMTEST_END 0x40400000/* 4 MB RAM test */ #define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1/* Point initial SP in SRAM so SPL can use it too. */ -#define CONFIG_SYS_INIT_SP_ADDR 0x00002000 + +#define CONFIG_SYS_INIT_RAM_ADDR 0x00002000 +#define CONFIG_SYS_INIT_RAM_SIZE (128 * 1024) + +#define CONFIG_SYS_INIT_SP_OFFSET \ + (CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE) +#define CONFIG_SYS_INIT_SP_ADDR \ + (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)/* * We need to sacrifice first 4 bytes of RAM here to avoid triggering some * strange BUG in ROM corrupting first 4 bytes of RAM when loading U-Boot
Signature · 1 line
1.7.1
PATCH 1/1 m28evk: Use GENERATED_GBL_DATA_SIZE
Quoted 3 lines
Use
GENERATED_GBL_DATA_SIZEfor calculatingCONFIG_SYS_INIT_SP_OFFSET.Signed-off-by Fabio Estevam <[email protected]>
Maybe I'd be better to consolidate the i.MX28 config to a common config file and have only board specific stuff in the board-specific configs, which would in turn include the file?
M
include/configs/m28evk.h line 92
Quoted 10 lines
--- include/configs/m28evk.h | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-)include/configs/m28evk.h +0
-0@@ -92,7 +92,14 @@#define CONFIG_SYS_MEMTEST_END 0x40400000/* 4 MB RAM test
*/
Quoted 14 lines
include/configs/m28evk.h +8
-1#define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1/* Point initial SP in SRAM so SPL can use it too. */ -#define CONFIG_SYS_INIT_SP_ADDR 0x00002000 + +#define CONFIG_SYS_INIT_RAM_ADDR 0x00002000 +#define CONFIG_SYS_INIT_RAM_SIZE (128 * 1024) + +#define CONFIG_SYS_INIT_SP_OFFSET \ + (CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE) +#define CONFIG_SYS_INIT_SP_ADDR \ + (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)/* * We need to sacrifice first 4 bytes of RAM here to avoid triggering some * strange BUG in ROM corrupting first 4 bytes of RAM when loading U-Boot
PATCH 1/1 m28evk: Use GENERATED_GBL_DATA_SIZE
Quoted 3 lines · Marek Vasut
Maybe I'd be better to consolidate the i.MX28 config to a common config file and have only board specific stuff in the board-specific configs, which would in turn include the file?
Sounds like a good idea.
Regards,
Fabio Estevam
PATCH 1/1 m28evk: Use GENERATED_GBL_DATA_SIZE
In reply to Marek VasutQuoted 7 lines · Marek Vasut
Quoted 3 lines
Use
GENERATED_GBL_DATA_SIZEfor calculatingCONFIG_SYS_INIT_SP_OFFSET.Signed-off-by Fabio Estevam <[email protected]>Maybe I'd be better to consolidate the i.MX28 config to a common config file and have only board specific stuff in the board-specific configs, which would in turn include the file?
But this issue is not strictly related only to MX28. The same is for any SOC in u-boot, and most of CONFIG_ are duplicated in the configuration files for boards having the same SOC.
At the moment, we do this only for slightly different boards (imx27lite and magnesium, for example) or for boards having the same SOM.
Agree we can rationalize better, but it should be discussed if we plan to introduce some hierarchy in the configuration files - the board configuration file can include a SOC configuration file, that can include a ARCH configuration file....
Apart of that, I think it is not bad to merge this Fabio's patch - it makes the board consistent with the other ones.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
PATCH 1/1 m28evk: Use GENERATED_GBL_DATA_SIZE
Quoted 16 lines · Marek Vasut
Quoted 7 lines
Quoted 3 lines
Use
GENERATED_GBL_DATA_SIZEfor calculatingCONFIG_SYS_INIT_SP_OFFSET.Signed-off-by Fabio Estevam <[email protected]>Maybe I'd be better to consolidate the i.MX28 config to a common config file and have only board specific stuff in the board-specific configs, which would in turn include the file?
But this issue is not strictly related only to MX28. The same is for any SOC in u-boot, and most of
CONFIG_are duplicated in the configuration files for boards having the same SOC.At the moment, we do this only for slightly different boards (imx27lite and magnesium, for example) or for boards having the same SOM.
Quoted 7 lines
Agree we can rationalize better, but it should be discussed if we plan to introduce some hierarchy in the configuration files - the board configuration file can include a SOC configuration file, that can include a ARCH configuration file....
Apart of that, I think it is not bad to merge this Fabio's patch - it makes the board consistent with the other ones.
Fine by me, but I can't test it.
M
Quoted 3 lines
Best regards,
Stefano Babic
PATCH 1/1 m28evk: Use GENERATED_GBL_DATA_SIZE
In reply to Fabio EstevamQuoted 4 lines · Fabio Estevam
Use
GENERATED_GBL_DATA_SIZEfor calculatingCONFIG_SYS_INIT_SP_OFFSET.Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
PATCH 1/1 m28evk: Use GENERATED_GBL_DATA_SIZE
In reply to Fabio EstevamDear Fabio Estevam,
I think this patch is wrong ... did I ack this one?
include/configs/m28evk.h line 92
Quoted 13 lines
Use
GENERATED_GBL_DATA_SIZEfor calculatingCONFIG_SYS_INIT_SP_OFFSET.Signed-off-by Fabio Estevam <[email protected]>--- include/configs/m28evk.h | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-)include/configs/m28evk.h +0
-0@@ -92,7 +92,14 @@#define CONFIG_SYS_MEMTEST_END 0x40400000/* 4 MB RAM test
*/
include/configs/m28evk.h line 96
Quoted 5 lines
include/configs/m28evk.h +2
-1#define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1/* Point initial SP in SRAM so SPL can use it too. */ -#define CONFIG_SYS_INIT_SP_ADDR 0x00002000 + +#define CONFIG_SYS_INIT_RAM_ADDR 0x00002000
This 0x2000 is wrong, it should be 0x0. Otherwise your maths below overflow and SP is located at 0x21f80.
include/configs/m28evk.h line 105
Quoted 9 lines
include/configs/m28evk.h +6
-0+#define CONFIG_SYS_INIT_RAM_SIZE (128 * 1024) + +#define CONFIG_SYS_INIT_SP_OFFSET \ + (CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE) +#define CONFIG_SYS_INIT_SP_ADDR \ + (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)/* * We need to sacrifice first 4 bytes of RAM here to avoid triggering some * strange BUG in ROM corrupting first 4 bytes of RAM when loading U-Boot
Best regards,
Marek Vasut