lttng-2.0 new recipe
cover lttng-2.0 new recipe
Hi All,
This patchset adds support for lttng-2.0, including the folloing four bb files:
babeltrace_0.8.bb
lttng-modules_v2.0.pre11.bb
lttng-tools_2.0-pre16.bb
lttng-ust_1.9.4.bb
And two patches for smoothly compiling:
lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch lttng-tools-fix-compiling-error-for-powerpc-arm-and-mips.patch
There is a clear description of the LTTng 2.0 architecture in the followiing site:
http://lttng.org/sites/lttng.org/files/LTTng2_0Architecture_pa3.pdf
Currently lttng-2.0 is still in pre-release phrase, so I add this into the patch header for reminder. And another goal of this RR is intended to bring forward the following issues:
lttng-2.0 has been added into recipies-kernel, which coexisted with lttng(the previous version), because there are some mainly changes from lttng-control to lttng-tools, which both monitors tracepoints and dynamic probes from kernel and userspace. But I'm not sure if we should remove the previous version lttng. My suggestion is to preserve for 2.6.37 kernel :-)
lttng-2.0 supports lttng-modules extra builds, which don't need any patches on Linux kernel vs the previous version of lttng. As described in README of lttng-modules-2.0, so far, it has been tested in current 3.0 kernel on x86 32/64-bit, and powerpc 32-bit, , build tested on ARM. So the related tests on qemux86 and qemuppc has been validated and a build test on qemuarm passed too with this patcheset.
Babeltrace provides as a trace converter, which used to convert LTTng 2.0 traces into human-readable log(see below example for qemuppc)
lttng-ust_1.9.4 is Linux Trace Toolkit 2.0 Userspace Tracer.
I'm still keep an eye on the development of lttng for updates.
Regard,
Zumeng
root@qemuppc:/# lttng list -k
Kernel events:
-------------
sched_kthread_stop (type: tracepoint)
sched_kthread_stop_ret (type: tracepoint)
sched_wakeup (type: tracepoint)
sched_wakeup_new (type: tracepoint)
sched_switch (type: tracepoint)
sched_migrate_task (type: tracepoint)
sched_process_free (type: tracepoint)
sched_process_exit (type: tracepoint)
sched_wait_task (type: tracepoint)
sched_process_wait (type: tracepoint)
sched_process_fork (type: tracepoint)
sched_stat_wait (type: tracepoint)
sched_stat_sleep (type: tracepoint)
sched_stat_iowait (type: tracepoint)
sched_stat_runtime (type: tracepoint)
sched_pi_setprio (type: tracepoint)
irq_handler_entry (type: tracepoint)
irq_handler_exit (type: tracepoint)
softirq_entry (type: tracepoint)
softirq_exit (type: tracepoint)
softirq_raise (type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]
(type: tracepoint) [disabled]root@qemuppc:/# lttng create mysession Session mysession created. Traces will be written in /home/root/lttng-traces/mysession-20111230-152610 root@qemuppc:/# lttng enable-event -a -k All kernel events are enabled in channel channel0 root@qemuppc:/# lttng enable-event sched_switch,sched_wakeup -k kernel event sched_switch created in channel channel0 kernel event sched_wakeup created in channel channel0 root@qemuppc:/# lttng enable-event -a -k --tracepoint All kernel tracepoints are enabled in channel channel0 root@qemuppc:/# lttng add-context -k -e sched_switch -t pid kernel context pid added to sched_switch event in all channels root@qemuppc:/# lttng start Tracing started for session mysession root@qemuppc:/# lttng list -u UST events: ------------- None
root@qemuppc:/# lttng stop Tracing stopped for session mysession root@qemuppc:/# lttng list -u UST events: ------------- None
root@qemuppc:/# uname -a
Linux qemuppc 3.0.12-yocto-standard+ #1 PREEMPT Thu Dec 29 22:23:52 CST 2011 ppc GNU/Linux
root@qemuppc:/#
root@qemuppc:/# babeltrace /home/root/lttng-traces/mysession-20111230-152610 | less
[2078772597067] softirq_raise: { 0 }, { vec = 1 }
[2078773657367] softirq_raise: { 0 }, { vec = 9 }
[2078773943557] sched_stat_runtime: { 0 }, { comm = "lttng-sessiond", tid = 404, runtime = 5104592, vruntime = 61173667721 }
[2078774051587] softirq_entry: { 0 }, { vec = 1 }
[2078774081797] softirq_exit: { 0 }, { vec = 1 }
[2078774086557] softirq_entry: { 0 }, { vec = 9 }
[2078774094247] softirq_exit: { 0 }, { vec = 9 }
[2078774105437] sched_stat_runtime: { 0 }, { comm = "lttng-sessiond", tid = 404, runtime = 230192, vruntime = 61173897913 }
[2078774185387] sched_stat_wait: { 0 }, { comm = "lttng-consumerd", tid = 418, delay = 5334784 }
[2078774328677] sched_switch: { 0 }, 385, { prev_comm = "lttng-sessiond", prev_tid = 404, prev_prio = 20, prev_state = 0, next_comm = "lttng-consumerd", next_tid = 418, next_prio = 20 }
[2078774802747] exit_syscall: { 0 }, { ret = 1 }
[2078774968937] sys_unknown: { 0 }, { id = 102, args = [ [0] = 17, [1] = 1218120660, [2] = 0, [3] = 268526120, [4] = 32, [5] = 4294967232 ] }
[2078775075597] exit_syscall: { 0 }, { ret = 4136 }
[2078775109747] sys_unknown: { 0 }, { id = 167, args = [ [0] = 1218124968, [1] = 2, [2] = 4294967295, [3] = 268526120, [4] = 32, [5] = 4294967232 ] }
[2078775130867] exit_syscall: { 0 }, { ret = 1 }
[2078775339007] sys_unknown: { 0 }, { id = 102, args = [ [0] = 17, [1] = 1218120612, [2] = 0, [3] = 268526120, [4] = 32, [5] = 4294967232 ] }
[2078776095757] exit_syscall: { 0 }, { ret = 1 }
[2078776238357] softirq_raise: { 0 }, { vec = 1 }
[2078776245827] softirq_raise: { 0 }, { vec = 9 }
[2078776265487] sched_stat_runtime: { 0 }, { comm = "lttng-consumerd", tid = 418, runtime = 2149408, vruntime = 61169846169 }
[2078776291187] softirq_entry: { 0 }, { vec = 1 }
[2078776306217] softirq_exit: { 0 }, { vec = 1 }
[2078776310607] softirq_entry: { 0 }, { vec = 9 }
[2078776317337] softirq_exit: { 0 }, { vec = 9 }
....snip..........................The following changes since commit 5797feac5f06f5cc363869cd440b82b3eaafd456:
image-mklibs/package_ipk: Remove bashisms (2012-01-05 22:26:25 +0000)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib zumeng/lttng-2.0
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zumeng/lttng-2.0
Zumeng Chen (4):
lttng-ust: Integrate into yocto linux
lttng-tools: Integrated from git repo.
lttng-modules: from lttng-modules 2.0 git repo.
babeltrace: Integrated from version 0.8
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb | 30 ++++++++++++++ ...modules-replace-KERNELDIR-with-KERNEL_SRC.patch | 41 ++++++++++++++++++++ .../lttng-2.0/lttng-modules_v2.0.pre11.bb | 23 +++++++++++ ...-compiling-error-for-powerpc-arm-and-mips.patch | 23 +++++++++++ .../lttng-2.0/lttng-tools_2.0-pre16.bb | 24 +++++++++++ meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb | 23 +++++++++++ 6 files changed, 164 insertions(+), 0 deletions(-) create mode 100644 meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm-and-mips.patch create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb
Signature · 1 line
1.7.5.4
PATCH 1/4 lttng-ust: Integrate into yocto linux
--- meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb | 23 ++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-) create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb
meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb new file +23 -0
@@ -0,0 +1,23 @@ +SUMMARY = "Linux Trace Toolkit Userspace Tracer 2.0" +DESCRIPTION = "The LTTng UST 2.0 package contains the userspace tracer library to trace userspace codes." +HOMEPAGE = "http://lttng.org/lttng2.0" +BUGTRACKER = "n/a" + +LICENSE = "LGPLv2.1+ & BSD" +LIC_FILES_CHKSUM = "file://COPYING;md5=e647752e045a8c45b6f583771bd561ef" + +inherit autotools + +DEPENDS = "liburcu util-linux" + +SRC_URI = "http://lttng.org/files/lttng-ust/lttng-ust-${PV}.tar.gz" + +SRC_URI[md5sum] = "0f09bb954c99cb99ab6997cd492953c1" +SRC_URI[sha256sum] = "e9ec3c55c2251b3f3b512bfa1015b0f67e35d55793850ccea5134f7b24ee3ba1" + +S = "${WORKDIR}/lttng-ust-${PV}" + +# Due to liburcu not building on MIPS currently this recipe needs to +# be limited also. +# So here let us first suppport x86/arm/powerpc platforms now. +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'
Signature · 1 line
1.7.5.4
Re: [PATCH 1/4] lttng-ust: Integrate into yocto linux
Hi Zumeng,
Thanks for putting these together.
Please provide a commit message. See:
https://wiki.yoctoproject.org/wiki/Contribution_Guidelines#Patch_Headers_and_Commit_Messages
meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb line 7
Quoted 2 lines
meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb new file +2
-0+LICENSE = "LGPLv2.1+ & BSD" +LIC_FILES_CHKSUM = "file://COPYING;md5=e647752e045a8c45b6f583771bd561ef"
COPYING only covers the LGPL, please add another file to cover the BSD license.
Quoted 6 lines
meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb new file +6
-0+ +inherit autotools + +DEPENDS = "liburcu util-linux" + +SRC_URI = "http://lttng.org/files/lttng-ust/lttng-ust-${PV}.tar.gz"
meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb line 23
Quoted 10 lines
meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb new file +10
-0+ +SRC_URI[md5sum] = "0f09bb954c99cb99ab6997cd492953c1" +SRC_URI[sha256sum] = "e9ec3c55c2251b3f3b512bfa1015b0f67e35d55793850ccea5134f7b24ee3ba1" + +S = "${WORKDIR}/lttng-ust-${PV}" + +# Due to liburcu not building on MIPS currently this recipe needs to +# be limited also. +# So here let us first suppport x86/arm/powerpc platforms now. +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'
I don't think this is what you meant. You are restricting the type of build system, not the type of target you can build for.
Signature · 3 lines
Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel
Re: [PATCH 1/4] lttng-ust: Integrate into yocto linux
Quoted 7 lines · Darren Hart
Hi Zumeng,
Thanks for putting these together.
Please provide a commit message. See:
https://wiki.yoctoproject.org/wiki/Contribution_Guidelines#Patch_Headers_and_Commit_Messages
Thanks for your information, Darren.
Quoted 6 lines
Review
Quoted 4 lines
(quoted diff) +2
-0+LICENSE = "LGPLv2.1+& BSD" +LIC_FILES_CHKSUM = "file://COPYING;md5=e647752e045a8c45b6f583771bd561ef"COPYING only covers the LGPL, please add another file to cover the BSD license.
Yeah. Added.
Quoted 12 lines
Quoted 12 lines
meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb new file +11
-0+ +inherit autotools + +DEPENDS = "liburcu util-linux" + +SRC_URI = "http://lttng.org/files/lttng-ust/lttng-ust-${PV}.tar.gz" + +SRC_URI[md5sum] = "0f09bb954c99cb99ab6997cd492953c1" +SRC_URI[sha256sum] = "e9ec3c55c2251b3f3b512bfa1015b0f67e35d55793850ccea5134f7b24ee3ba1" + +S = "${WORKDIR}/lttng-ust-${PV}"
Quoted 9 lines
meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb line 23
Quoted 6 lines
meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb new file +5
-0+ +# Due to liburcu not building on MIPS currently this recipe needs to +# be limited also. +# So here let us first suppport x86/arm/powerpc platforms now. +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'I don't think this is what you meant. You are restricting the type of build system, not the type of target you can build for.
Sorry, I copied from liburcu, and I heard its Poky's convention.
Regards,
Zumeng
PATCH 2/4 lttng-tools: Integrated from git repo.
In reply to Zumeng Chenlttng-tools 2.0 is currently in pre-release phase (-pre16).
--- ...-compiling-error-for-powerpc-arm-and-mips.patch | 23 +++++++++++++++++++ .../lttng-2.0/lttng-tools_2.0-pre16.bb | 24 ++++++++++++++++++++ 2 files changed, 47 insertions(+), 0 deletions(-) create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm-and-mips.patch create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb
meta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm-and-mips.patch new file +23 -0
@@ -0,0 +1,23 @@ +Upstream-Status: Pending + +lttng-tools: fix compiling error for powerpc, arm + +Signed-off-by: Zumeng Chen <[email protected]> +--- + librunas/runas.c | 1 + + 1 files changed, 1 insertions(+), 0 deletions(-) + +diff --git a/librunas/runas.c b/librunas/runas.c +--- a/librunas/runas.c ++++ b/librunas/runas.c +@@ -29,6 +29,7 @@ + #include <fcntl.h> + #include <sched.h> + #include <sys/mman.h> ++#include <asm/mman.h> + + #include <lttngerr.h> + +-- +1.7.5.4 +
meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb new file +24 -0
@@ -0,0 +1,24 @@ +SECTION = "devel" +SUMMARY = "Linux Trace Toolkit Control" +DESCRIPTION = "The Linux trace toolkit is a suite of tools designed to \ +extract program execution details from the Linux operating system and \ +interpret them." +LICENSE = "GPLv2.1" +LIC_FILES_CHKSUM = "file://COPYING;md5=ab682a4729389c3f11913d758affe98e" + +DEPENDS = "liburcu popt lttng-ust" + +SRC_URI = "http://lttng.org/files/lttng-tools/lttng-tools-${PV}.tar.bz2 \ + file://fix-compiling-error-for-powerpc-arm-and-mips.patch" + +SRC_URI[md5sum] = "58ed0a15db80a00172d5b0413a55451c" +SRC_URI[sha256sum] = "188d262bda80043dd939c9aa7aec1795ca77aeec0cb3c0f23c28bfe754049491" + +S = "${WORKDIR}/lttng-tools-${PV}" + + +inherit autotools + +export KERNELDIR="${STAGING_KERNEL_DIR}" + +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'
Signature · 1 line
1.7.5.4
Re: [PATCH 2/4] lttng-tools: Integrated from git repo.
于 2012年01月06日 14:11, Zumeng Chen 写道
Quoted 2 lines
+DEPENDS = "liburcu popt lttng-ust"
And there is a depend on liburcu, which version should
Quoted 1 line
= 0.6.6,
it just has been updated recently. Lucky and Thanks :)
Regards,
Zumeng
Quoted 16 lines
meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb new file +15
-0+ +SRC_URI = "http://lttng.org/files/lttng-tools/lttng-tools-${PV}.tar.bz2 \ + file://fix-compiling-error-for-powerpc-arm-and-mips.patch" + +SRC_URI[md5sum] = "58ed0a15db80a00172d5b0413a55451c" +SRC_URI[sha256sum] = "188d262bda80043dd939c9aa7aec1795ca77aeec0cb3c0f23c28bfe754049491" + +S = "${WORKDIR}/lttng-tools-${PV}" + + +inherit autotools + +export KERNELDIR="${STAGING_KERNEL_DIR}" + +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'
Re: [PATCH 2/4] lttng-tools: Integrated from git repo.
In reply to Zumeng ChenThis commit message doesn't tell me anything about what this patch is intended to do.
meta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm-and-mips.patch line 4
Quoted 6 lines
+++
b/meta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm-and-mips.patchmeta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm-and-mips.patch new file +4
-0@@ -0,0 +1,23 @@ +Upstream-Status: Pending + +lttng-tools: fix compiling error for powerpc, arm +
Add some commentary here about what the compilation error is.
Quoted 27 lines
meta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm-and-mips.patch new file +19
-0+Signed-off-by: Zumeng Chen <[email protected]> +--- + librunas/runas.c | 1 + + 1 files changed, 1 insertions(+), 0 deletions(-) + +diff --git a/librunas/runas.c b/librunas/runas.c +--- a/librunas/runas.c ++++ b/librunas/runas.c +@@ -29,6 +29,7 @@ + #include <fcntl.h> + #include <sched.h> + #include <sys/mman.h> ++#include <asm/mman.h> + + #include <lttngerr.h> + +-- +1.7.5.4 +meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb new file +2
-0@@ -0,0 +1,24 @@ +SECTION = "devel" +SUMMARY = "Linux Trace Toolkit Control"
meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb line 12
Quoted 10 lines
meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb new file +10
-0+DESCRIPTION = "The Linux trace toolkit is a suite of tools designed to \ +extract program execution details from the Linux operating system and \ +interpret them." +LICENSE = "GPLv2.1" +LIC_FILES_CHKSUM = "file://COPYING;md5=ab682a4729389c3f11913d758affe98e" + +DEPENDS = "liburcu popt lttng-ust" + +SRC_URI = "http://lttng.org/files/lttng-tools/lttng-tools-${PV}.tar.bz2 \ + file://fix-compiling-error-for-powerpc-arm-and-mips.patch"
Whitespace error. Indent with spaces after the initial block indent (which doesn't exist here).
meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb line 24
Quoted 12 lines
meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb new file +12
-0+ +SRC_URI[md5sum] = "58ed0a15db80a00172d5b0413a55451c" +SRC_URI[sha256sum] = "188d262bda80043dd939c9aa7aec1795ca77aeec0cb3c0f23c28bfe754049491" + +S = "${WORKDIR}/lttng-tools-${PV}" + + +inherit autotools + +export KERNELDIR="${STAGING_KERNEL_DIR}" + +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'
This requires a comment as in the previous patch. Again, I don't think this is what you are looking for. You want to limit which target architectures you build this for. Right?
Signature · 3 lines
Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel
Re: [PATCH 2/4] lttng-tools: Integrated from git repo.
Quoted 4 lines · Darren Hart
This commit message doesn't tell me anything about what this patch is intended to do.
Quoted 9 lines
meta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm-and-mips.patch line 4
Quoted 7 lines
+++
b/meta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm-and-mips.patchmeta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm-and-mips.patch new file +4
-0@@ -0,0 +1,23 @@ +Upstream-Status: Pending + +lttng-tools: fix compiling error for powerpc, arm +Add some commentary here about what the compilation error is.
OK. in V2.
Quoted 33 lines
Quoted 33 lines
meta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm-and-mips.patch new file +19
-0+Signed-off-by: Zumeng Chen<[email protected]> +--- + librunas/runas.c | 1 + + 1 files changed, 1 insertions(+), 0 deletions(-) + +diff --git a/librunas/runas.c b/librunas/runas.c +--- a/librunas/runas.c ++++ b/librunas/runas.c +@@ -29,6 +29,7 @@ + #include<fcntl.h> + #include<sched.h> + #include<sys/mman.h> ++#include<asm/mman.h> + + #include<lttngerr.h> + +-- +1.7.5.4 +meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb new file +7
-0@@ -0,0 +1,24 @@ +SECTION = "devel" +SUMMARY = "Linux Trace Toolkit Control" +DESCRIPTION = "The Linux trace toolkit is a suite of tools designed to \ +extract program execution details from the Linux operating system and \ +interpret them." +LICENSE = "GPLv2.1" +LIC_FILES_CHKSUM = "file://COPYING;md5=ab682a4729389c3f11913d758affe98e"
Quoted 9 lines
meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb line 12
Quoted 6 lines
meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb new file +5
-0+ +DEPENDS = "liburcu popt lttng-ust" + +SRC_URI = "http://lttng.org/files/lttng-tools/lttng-tools-${PV}.tar.bz2 \ + file://fix-compiling-error-for-powerpc-arm-and-mips.patch"Whitespace error. Indent with spaces after the initial block indent (which doesn't exist here).
fix.ed
Quoted 18 lines
Quoted 4 lines
meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb new file +2
-0+ +SRC_URI[md5sum] = "58ed0a15db80a00172d5b0413a55451c"meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb line 24
Quoted 10 lines
meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb new file +10
-0+SRC_URI[sha256sum] = "188d262bda80043dd939c9aa7aec1795ca77aeec0cb3c0f23c28bfe754049491" + +S = "${WORKDIR}/lttng-tools-${PV}" + + +inherit autotools + +export KERNELDIR="${STAGING_KERNEL_DIR}" + +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'This requires a comment as in the previous patch. Again, I don't think this is what you are looking for. You want to limit which target architectures you build this for. Right?
Right, but the same reason for another email.
Regards,
Zumeng
PATCH 3/4 lttng-modules: from lttng-modules 2.0 git repo.
In reply to Zumeng ChenLTTng-modules 2.0 is currently in pre-release phase (-pre11)
--- ...modules-replace-KERNELDIR-with-KERNEL_SRC.patch | 41 ++++++++++++++++++++ .../lttng-2.0/lttng-modules_v2.0.pre11.bb | 23 +++++++++++ 2 files changed, 64 insertions(+), 0 deletions(-) create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb
meta/recipes-kernel/lttng-2.0/lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch new file +41 -0
@@ -0,0 +1,41 @@ +Upstream-Status: Inappropriate [embedded specific] + +lttng-modules: replace KERNELDIR with KERNEL_SRC + +Since lttng-modules uses the default way of module.bbclass to +build and install lttng-modules, so we do this replacement for +it as-is. + +Signed-off-by: Zumeng Chen <[email protected]> +--- + Makefile | 7 +++---- + 1 files changed, 3 insertions(+), 4 deletions(-) + +diff --git a/Makefile b/Makefile +index 5ac13d7..25caad5 100644 +--- a/Makefile ++++ b/Makefile +@@ -38,17 +38,16 @@ obj-m += lib/ + endif + + else +- KERNELDIR ?= /lib/modules/$(shell uname -r)/build + PWD := $(shell pwd) + CFLAGS = $(EXTCFLAGS) + + default: +- $(MAKE) -C $(KERNELDIR) M=$(PWD) modules ++ $(MAKE) -C $(KERNEL_SRC) M=$(PWD) modules + + modules_install: +- $(MAKE) -C $(KERNELDIR) M=$(PWD) modules_install ++ $(MAKE) -C $(KERNEL_SRC) M=$(PWD) modules_install + + clean: +- $(MAKE) -C $(KERNELDIR) M=$(PWD) clean ++ $(MAKE) -C $(KERNEL_SRC) M=$(PWD) clean + + endif +-- +1.7.5.4 +
meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb new file +23 -0
@@ -0,0 +1,23 @@ +SECTION = "devel" +SUMMARY = "Linux Trace Toolkit KERNEL MODULE" +DESCRIPTION = "The lttng-modules 2.0 package contains the kernel tracer modules" +LICENSE = "LGPLv2.1 & GPLv2" +LIC_FILES_CHKSUM = "file://LICENSE;md5=1eb086682a7c65a45acd9bcdf6877b3e \ + "file://gpl-2.0.txt;md5=751419260aa954499f7abaabaa882bbe \ + "file://lgpl-2.1.txt;md5=243b725d71bb5df4a1e5920b344b86ad" + +DEPENDS = virtual/kernel + +inherit module + +SRCREV = "4d3e89e379fc66480d729abe8daa5c86eb585400" +PV = "v2.0.pre11+git${SRCPV}" +PR = "r0" + +SRC_URI += "git://git.lttng.org/lttng-modules.git;protocol=git \ + file://lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch" + +export INSTALL_MOD_DIR="kernel/lttng-modules" + +S = "${WORKDIR}/git" +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'
Signature · 1 line
1.7.5.4
Re: [PATCH 3/4] lttng-modules: from lttng-modules 2.0 git repo.
Quoted 1 line · Zumeng Chen
LTTng-modules 2.0 is currently in pre-release phase (-pre11)
If the commit message is identical, one could reasonably expect the patch to be identical ;-) Please provide a complete commit message.
Quoted 15 lines
Signed-off-by Zumeng Chen <[email protected]>--- ...modules-replace-KERNELDIR-with-KERNEL_SRC.patch | 41 ++++++++++++++++++++ .../lttng-2.0/lttng-modules_v2.0.pre11.bb | 23 +++++++++++ 2 files changed, 64 insertions(+), 0 deletions(-) create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bbmeta/recipes-kernel/lttng-2.0/lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch new file +0
-0
meta/recipes-kernel/lttng-2.0/lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch line 7
Quoted 7 lines
meta/recipes-kernel/lttng-2.0/lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch new file +7
-0@@ -0,0 +1,41 @@ +Upstream-Status: Inappropriate [embedded specific] + +lttng-modules: replace KERNELDIR with KERNEL_SRC + +Since lttng-modules uses the default way of module.bbclass to +build and install lttng-modules, so we do this replacement for +it as-is.
Since and so are redundant: s/so///
Quoted 40 lines
meta/recipes-kernel/lttng-2.0/lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch new file +34
-0+ +Signed-off-by: Zumeng Chen <[email protected]> +--- + Makefile | 7 +++---- + 1 files changed, 3 insertions(+), 4 deletions(-) + +diff --git a/Makefile b/Makefile +index 5ac13d7..25caad5 100644 +--- a/Makefile ++++ b/Makefile +@@ -38,17 +38,16 @@ obj-m += lib/ + endif + + else +- KERNELDIR ?= /lib/modules/$(shell uname -r)/build + PWD := $(shell pwd) + CFLAGS = $(EXTCFLAGS) + + default: +- $(MAKE) -C $(KERNELDIR) M=$(PWD) modules ++ $(MAKE) -C $(KERNEL_SRC) M=$(PWD) modules + + modules_install: +- $(MAKE) -C $(KERNELDIR) M=$(PWD) modules_install ++ $(MAKE) -C $(KERNEL_SRC) M=$(PWD) modules_install + + clean: +- $(MAKE) -C $(KERNELDIR) M=$(PWD) clean ++ $(MAKE) -C $(KERNEL_SRC) M=$(PWD) clean + + endif +-- +1.7.5.4 +meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb new file +0
-0
meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb line 7
Quoted 7 lines
meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb new file +7
-0@@ -0,0 +1,23 @@ +SECTION = "devel" +SUMMARY = "Linux Trace Toolkit KERNEL MODULE" +DESCRIPTION = "The lttng-modules 2.0 package contains the kernel tracer modules" +LICENSE = "LGPLv2.1 & GPLv2" +LIC_FILES_CHKSUM = "file://LICENSE;md5=1eb086682a7c65a45acd9bcdf6877b3e \ + "file://gpl-2.0.txt;md5=751419260aa954499f7abaabaa882bbe \ + "file://lgpl-2.1.txt;md5=243b725d71bb5df4a1e5920b344b86ad"
Whitespace errors. Please use spaces here.
meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb line 18
Quoted 11 lines
meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb new file +11
-0+ +DEPENDS = virtual/kernel + +inherit module + +SRCREV = "4d3e89e379fc66480d729abe8daa5c86eb585400" +PV = "v2.0.pre11+git${SRCPV}" +PR = "r0" + +SRC_URI += "git://git.lttng.org/lttng-modules.git;protocol=git \ + file://lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch"
Spaces please.
meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb line 23
Quoted 5 lines
meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb new file +5
-0+ +export INSTALL_MOD_DIR="kernel/lttng-modules" + +S = "${WORKDIR}/git" +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'
I think you want a solution for TARGET.
Signature · 3 lines
Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel
Re: [PATCH 3/4] lttng-modules: from lttng-modules 2.0 git repo.
Quoted 8 lines · Darren Hart
Quoted 2 lines · Zumeng Chen
LTTng-modules 2.0 is currently in pre-release phase (-pre11)
If the commit message is identical, one could reasonably expect the patch to be identical ;-) Please provide a complete commit message.
OK, in V2.
Quoted 9 lines
Quoted 9 lines
Signed-off-by Zumeng Chen<[email protected]>--- ...modules-replace-KERNELDIR-with-KERNEL_SRC.patch | 41 ++++++++++++++++++++ .../lttng-2.0/lttng-modules_v2.0.pre11.bb | 23 +++++++++++ 2 files changed, 64 insertions(+), 0 deletions(-)create mode 100644
meta/recipes-kernel/lttng-2.0/lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patchcreate mode 100644 meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb
Quoted 16 lines
Quoted 7 lines
meta/recipes-kernel/lttng-2.0/lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch new file +0
-0meta/recipes-kernel/lttng-2.0/lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch line 7
Quoted 7 lines
meta/recipes-kernel/lttng-2.0/lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch new file +7
-0@@ -0,0 +1,41 @@ +Upstream-Status: Inappropriate [embedded specific] + +lttng-modules: replace KERNELDIR with KERNEL_SRC + +Since lttng-modules uses the default way of module.bbclass to +build and install lttng-modules, so we do this replacement for +it as-is.Since and so are redundant: s/so///
fixed.
Quoted 42 lines
Quoted 42 lines
meta/recipes-kernel/lttng-2.0/lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch new file +34
-0+ +Signed-off-by: Zumeng Chen<[email protected]> +--- + Makefile | 7 +++---- + 1 files changed, 3 insertions(+), 4 deletions(-) + +diff --git a/Makefile b/Makefile +index 5ac13d7..25caad5 100644 +--- a/Makefile ++++ b/Makefile +@@ -38,17 +38,16 @@ obj-m += lib/ + endif + + else +- KERNELDIR ?= /lib/modules/$(shell uname -r)/build + PWD := $(shell pwd) + CFLAGS = $(EXTCFLAGS) + + default: +- $(MAKE) -C $(KERNELDIR) M=$(PWD) modules ++ $(MAKE) -C $(KERNEL_SRC) M=$(PWD) modules + + modules_install: +- $(MAKE) -C $(KERNELDIR) M=$(PWD) modules_install ++ $(MAKE) -C $(KERNEL_SRC) M=$(PWD) modules_install + + clean: +- $(MAKE) -C $(KERNELDIR) M=$(PWD) clean ++ $(MAKE) -C $(KERNEL_SRC) M=$(PWD) clean + + endif +-- +1.7.5.4 +meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb new file +1
-0@@ -0,0 +1,23 @@ +SECTION = "devel"
Quoted 9 lines
meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb line 7
Quoted 7 lines
meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb new file +6
-0+SUMMARY = "Linux Trace Toolkit KERNEL MODULE" +DESCRIPTION = "The lttng-modules 2.0 package contains the kernel tracer modules" +LICENSE = "LGPLv2.1& GPLv2" +LIC_FILES_CHKSUM = "file://LICENSE;md5=1eb086682a7c65a45acd9bcdf6877b3e \ + "file://gpl-2.0.txt;md5=751419260aa954499f7abaabaa882bbe \ + "file://lgpl-2.1.txt;md5=243b725d71bb5df4a1e5920b344b86ad"Whitespace errors. Please use spaces here.
fixed.
Quoted 15 lines
meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb line 18
Quoted 13 lines
meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb new file +11
-0+ +DEPENDS = virtual/kernel + +inherit module + +SRCREV = "4d3e89e379fc66480d729abe8daa5c86eb585400" +PV = "v2.0.pre11+git${SRCPV}" +PR = "r0" + +SRC_URI += "git://git.lttng.org/lttng-modules.git;protocol=git \ + file://lttng-modules-replace-KERNELDIR-with-KERNEL_SRC.patch"Spaces please.
fixed.
Quoted 9 lines
meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb line 23
Quoted 7 lines
meta/recipes-kernel/lttng-2.0/lttng-modules_v2.0.pre11.bb new file +5
-0+ +export INSTALL_MOD_DIR="kernel/lttng-modules" + +S = "${WORKDIR}/git" +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'I think you want a solution for TARGET.
The same reason.
Regards,
Zumeng
PATCH 4/4 babeltrace: Integrated from version 0.8
In reply to Zumeng ChenIt provides trace read and write libraries, as well as a trace converter.
--- meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb | 30 +++++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) create mode 100644 meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb new file +30 -0
@@ -0,0 +1,30 @@ +SUMMARY = "Babeltrace - Trace Format Babel Tower" +DESCRIPTION = "Babeltrace provides trace read and write libraries in host side,\ + as well as a trace converter, which used to convert LTTng 2.0 \ + traces into human-readable log." +HOMEPAGE = "http://www.efficios.com/babeltrace/" +BUGTRACKER = "n/a" + +LICENSE = "MIT & GPLV2" +LIC_FILES_CHKSUM = "file://LICENSE;md5=8d1a03b3c17bdd158b3cbb34813b1423" + +inherit autotools + +DEPENDS = "gtk+ util-linux" + +SRCREV = "31e670293588d7882a232bc14b93d5e956fa43f4" +PV = "0.8+git${SRCPV}" +PR = "r0" + +SRC_URI += "git://git.efficios.com/babeltrace.git;protocol=git" + +S = "${WORKDIR}/git" + +do_configure_prepend () { + ${S}/bootstrap +} + +# Due to liburcu not building on MIPS currently this recipe needs to +# be limited also. +# So here let us first suppport x86/arm/powerpc platforms now. +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'
Signature · 1 line
1.7.5.4
Re: [PATCH 4/4] babeltrace: Integrated from version 0.8
Quoted 14 lines · Zumeng Chen
It provides trace read and write libraries, as well as a trace converter.
Signed-off-by Zumeng Chen <[email protected]>--- meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb | 30 +++++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) create mode 100644 meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bbmeta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb new file +0
-0
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb line 4
Quoted 4 lines
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb new file +4
-0@@ -0,0 +1,30 @@ +SUMMARY = "Babeltrace - Trace Format Babel Tower" +DESCRIPTION = "Babeltrace provides trace read and write libraries in host side,\ + as well as a trace converter, which used to convert LTTng 2.0 \ + traces into human-readable log."
In the previous patches you aligned the additional lines with column 0, here you indent with tabs and spaces. A quick survey of the existing sources suggest the DESCRIPTION field typically does not indent the subsequent lines.
Quoted 6 lines
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb new file +6
-0+HOMEPAGE = "http://www.efficios.com/babeltrace/" +BUGTRACKER = "n/a" + +LICENSE = "MIT & GPLV2" +LIC_FILES_CHKSUM = "file://LICENSE;md5=8d1a03b3c17bdd158b3cbb34813b1423" +
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb line 20
Quoted 10 lines
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb new file +10
-0+inherit autotools + +DEPENDS = "gtk+ util-linux" + +SRCREV = "31e670293588d7882a232bc14b93d5e956fa43f4" +PV = "0.8+git${SRCPV}" +PR = "r0" + +SRC_URI += "git://git.efficios.com/babeltrace.git;protocol=git" +
This should be a "=" assignment, not "+=".
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb line 24
Quoted 4 lines
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb new file +4
-0+S = "${WORKDIR}/git" + +do_configure_prepend () { + ${S}/bootstrap
Please use tabs for indentation here.
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb line 30
Quoted 6 lines
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb new file +6
-0+} + +# Due to liburcu not building on MIPS currently this recipe needs to +# be limited also. +# So here let us first suppport x86/arm/powerpc platforms now. +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'
Again, I think you want to filter based on target arch.
Signature · 3 lines
Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel
Re: [PATCH 4/4] babeltrace: Integrated from version 0.8
Quoted 11 lines · Darren Hart
Quoted 8 lines · Zumeng Chen
It provides trace read and write libraries, as well as a trace converter.
Signed-off-by Zumeng Chen<[email protected]>--- meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb | 30 +++++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-)create mode 100644 meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb
Quoted 16 lines
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb line 4
Quoted 11 lines
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb new file +4
-0@@ -0,0 +1,30 @@ +SUMMARY = "Babeltrace - Trace Format Babel Tower" +DESCRIPTION = "Babeltrace provides trace read and write libraries in host side,\ + as well as a trace converter, which used to convert LTTng 2.0 \ + traces into human-readable log."In the previous patches you aligned the additional lines with column 0, here you indent with tabs and spaces. A quick survey of the existing sources suggest the DESCRIPTION field typically does not indent the subsequent lines.
OK. fixed.
Quoted 11 lines
Quoted 11 lines
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb new file +10
-0+HOMEPAGE = "http://www.efficios.com/babeltrace/" +BUGTRACKER = "n/a" + +LICENSE = "MIT& GPLV2" +LIC_FILES_CHKSUM = "file://LICENSE;md5=8d1a03b3c17bdd158b3cbb34813b1423" + +inherit autotools + +DEPENDS = "gtk+ util-linux" +
Quoted 9 lines
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb line 20
Quoted 7 lines
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb new file +6
-0+SRCREV = "31e670293588d7882a232bc14b93d5e956fa43f4" +PV = "0.8+git${SRCPV}" +PR = "r0" + +SRC_URI += "git://git.efficios.com/babeltrace.git;protocol=git" +This should be a "=" assignment, not "+=".
fixed.
Quoted 8 lines
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb line 24
Quoted 6 lines
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb new file +4
-0+S = "${WORKDIR}/git" + +do_configure_prepend () { + ${S}/bootstrapPlease use tabs for indentation here.
fixed.
Quoted 10 lines
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb line 30
Quoted 8 lines
meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb new file +6
-0+} + +# Due to liburcu not building on MIPS currently this recipe needs to +# be limited also. +# So here let us first suppport x86/arm/powerpc platforms now. +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'Again, I think you want to filter based on target arch.