Build Fixes and Updates
Richard,
This is a set of changes that have been built and booted for sato. This address the failure we have seen on the Autobuilder, please check the master_under_test build currenly building.
We have another kernel update from Bruce, with the sanity checks from Scott G. along with other change from the community. The matchbox changes make sense based on a better explaination from Edwin.
Please review overall, but I am positive about this change set.
Sau!
The following changes since commit f309769d10cb3d8b72b8c7c4f7f418dcb8422c61:
valgrind: Fix for automake update (2012-01-04 16:03:59 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib sgw/stage
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=sgw/stage
Bruce Ashfield (3):
kern-tools: import flexible branching support
linux-yocto: bump kernel version to v3.0.14
linux-yocto: use src_patches for out of tree kernel feature support
Christopher Larson (1):
opkg-utils: use /usr/bin/env python
Derek Buitenhuis (2):
binutils-cross-canadian: Allow ld-is-gold
binutils: Allow plugins
Gary Thomas (1):
xserver-kdrive: work around issues with -Werror=address
Joshua Lock (2):
alsa-state: add alsa-state from oe classic
task-base: add alsa-state to task-base-alsa
Otavio Salvador (3):
udev: use 'echo' instead of 'echo -n' in init script
udev: split utilities onto udev-utils
udev: remove commented code from init script (no code changes)
Phil Blundell (1):
python-native: correct prefix handling for oe-core sysroot layout
Saul Wold (6):
image_types: Fix rootfs size calcuation
glib-2.0: ensure dtrace is diabled for all distro options and fix
packaging
libxp: fix cast error
Patch Upstream-Status Update
util-linux: Update patch for non-GPLv3
gnutls: remove gettext patch for non-GPLv3
Scott Garman (7):
ncurses: move libraries to base_libdir
libcap: move library to base_libdir
util-linux: move libraries to base_libdir
e2fsprogs: move libraries to base_libdir
libusb1: move libraries to base_libdir
libusb-compat: move libraries to base_libdir insane.bbclass: add QA tests for unsafe references to exec_prefix
Zhai Edwin (1):
matchbox-wm: Remove x-session-manager handling
Zhenhua Luo (1):
linux-dtb: add multi-dtb build support and keep dtb in deploy cache
package
meta/classes/image_types.bbclass | 2 +- meta/classes/insane.bbclass | 111 ++++++- meta/classes/kernel-yocto.bbclass | 67 ++++- meta/recipes-bsp/alsa-state/alsa-state.bb | 57 +++ meta/recipes-bsp/alsa-state/alsa-state/alsa-state | 29 ++ meta/recipes-bsp/alsa-state/alsa-state/asound.conf | 12 + .../recipes-bsp/alsa-state/alsa-state/asound.state | 1 + meta/recipes-core/glib-2.0/glib-2.0_2.30.2.bb | 2 +- meta/recipes-core/glib-2.0/glib.inc | 9 +- meta/recipes-core/ncurses/ncurses.inc | 27 +- meta/recipes-core/tasks/task-base.bb | 5 +- meta/recipes-core/udev/udev.inc | 18 +- meta/recipes-core/udev/udev/init | 3 +- meta/recipes-core/udev/udev_164.bb | 2 +- .../util-linux-2.20.1/remove-lscpu.patch | 94 +----- meta/recipes-core/util-linux/util-linux.inc | 20 +- meta/recipes-core/util-linux/util-linux_2.20.1.bb | 2 +- .../binutils/binutils-cross-canadian.inc | 4 +- meta/recipes-devtools/binutils/binutils-cross.inc | 3 +- .../e2fsprogs/e2fsprogs_1.41.14.bb | 29 +- meta/recipes-devtools/guilt/files/guilt-bash.patch | 2 + .../guilt/files/guilt-import-commit.patch | 2 + meta/recipes-devtools/guilt/files/guilt-init.patch | 2 + meta/recipes-devtools/guilt/files/guilt-pop.patch | 2 + .../guilt/files/guilt-push-no-series.patch | 2 + meta/recipes-devtools/guilt/files/guilt-push.patch | 2 + .../guilt/files/guilt-set-git_exec_path.patch | 2 + meta/recipes-devtools/guilt/files/guilt.patch | 2 + .../guilt/files/improve_auto_header_gen.patch | 2 + .../files/make_git_commands_conditional.patch | 2 + .../guilt/files/optional_head_check.patch | 2 + .../guilt/files/uninstall_force.patch | 2 + .../opkg-utils/opkg-utils/shebang.patch | 46 +++ meta/recipes-devtools/opkg-utils/opkg-utils_svn.bb | 3 +- ...2-distutils-prefix-is-inside-staging-area.patch | 22 +- .../recipes-devtools/python/python-native_2.7.2.bb | 2 +- .../matchbox-wm/matchbox-wm_1.2.bb | 9 +- .../matchbox-wm/matchbox-wm_git.bb | 9 +- .../mini-x-session/mini-x-session_0.1.bb | 2 +- .../xorg-lib/libxp/fix-cast-error.patch | 42 +++ meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb | 4 +- .../error-address-work-around.patch | 362 ++++++++++++++++++++ .../xorg-xserver/xserver-kdrive_1.7.99.2.bb | 3 +- .../kern-tools/kern-tools-native_git.bb | 2 +- meta/recipes-kernel/linux/linux-dtb.inc | 33 ++- meta/recipes-kernel/linux/linux-yocto-rt_3.0.bb | 8 +- meta/recipes-kernel/linux/linux-yocto_3.0.bb | 19 +- meta/recipes-support/gnutls/gnutls_2.12.14.bb | 13 +- meta/recipes-support/libcap/libcap.inc | 15 +- meta/recipes-support/libcap/libcap_2.22.bb | 2 +- meta/recipes-support/libusb/libusb-compat_0.1.3.bb | 12 +- meta/recipes-support/libusb/libusb1_1.0.8.bb | 16 +- 52 files changed, 935 insertions(+), 210 deletions(-) create mode 100644 meta/recipes-bsp/alsa-state/alsa-state.bb create mode 100755 meta/recipes-bsp/alsa-state/alsa-state/alsa-state create mode 100644 meta/recipes-bsp/alsa-state/alsa-state/asound.conf create mode 100644 meta/recipes-bsp/alsa-state/alsa-state/asound.state create mode 100644 meta/recipes-devtools/opkg-utils/opkg-utils/shebang.patch create mode 100644 meta/recipes-graphics/xorg-lib/libxp/fix-cast-error.patch create mode 100644 meta/recipes-graphics/xorg-xserver/xserver-kdrive-1.7.99.2/error-address-work-around.patch
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 01/28] linux-dtb: add multi-dtb build support and keep dtb in deploy cache package
From: Zhenhua Luo <[email protected]>
1. add multiple dtb build support, define KERNEL_DEVICETREE as following:
KERNEL_DEVICETREE= "${S}/arch/powerpc/boot/dts/p3041ds.dts \
${S}/arch/powerpc/boot/dts/p3041ds-usdpaa.dts"
2. keep dtb files are included in the deploy cache package
--- meta/recipes-kernel/linux/linux-dtb.inc | 33 ++++++++++++++++++++++++------ 1 files changed, 26 insertions(+), 7 deletions(-)
meta/recipes-kernel/linux/linux-dtb.inc +26 -7
@@ -15,13 +15,32 @@ python __anonymous () { do_install_append() { if test -n "${KERNEL_DEVICETREE}"; then - dtc -I dts -O dtb ${KERNEL_DEVICETREE_FLAGS} -o devicetree ${KERNEL_DEVICETREE} - install -m 0644 devicetree ${D}/boot/devicetree-${KERNEL_VERSION} - install -d ${DEPLOY_DIR_IMAGE} - install -m 0644 devicetree ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGE_BASE_NAME}.dtb - cd ${DEPLOY_DIR_IMAGE} - rm -f ${KERNEL_IMAGE_SYMLINK_NAME}.dtb - ln -sf ${KERNEL_IMAGE_BASE_NAME}.dtb ${KERNEL_IMAGE_SYMLINK_NAME}.dtb + for DTS_FILE in ${KERNEL_DEVICETREE}; do + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'` + DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"` + DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"` + dtc -I dts -O dtb ${KERNEL_DEVICETREE_FLAGS} -o devicetree ${DTS_FILE} + install -m 0644 devicetree ${D}/boot/devicetree-${DTS_BASE_NAME}-${KERNEL_VERSION} + install -d ${DEPLOY_DIR_IMAGE} + install -m 0644 devicetree ${DEPLOY_DIR_IMAGE}/${DTB_NAME}.dtb + cd ${DEPLOY_DIR_IMAGE} + rm -f ${DTB_SYMLINK_NAME}.dtb + ln -sf ${DTB_NAME}.dtb ${DTB_SYMLINK_NAME}.dtb + cd - + done fi } +do_deploy_append() { + if test -n "${KERNEL_DEVICETREE}"; then + for DTS_FILE in ${KERNEL_DEVICETREE}; do + DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'` + DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"` + DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"` + install -d ${DEPLOYDIR} + install -m 0644 ${DEPLOY_DIR_IMAGE}/${DTB_NAME}.dtb ${DEPLOYDIR}/${DTB_NAME}.dtb + cd ${DEPLOYDIR} + ln -sf ${DTB_NAME}.dtb ${DTB_SYMLINK_NAME=}.dtb + done + fi +}
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 02/28] alsa-state: add alsa-state from oe classic
In reply to Saul WoldFrom: Joshua Lock <[email protected]>
alsa-state adds an init script and configuration files to enable a consistent and centralised mechanism for setting and restoring alsa configuration.
--- meta/recipes-bsp/alsa-state/alsa-state.bb | 57 ++++++++++++++++++++ meta/recipes-bsp/alsa-state/alsa-state/alsa-state | 29 ++++++++++ meta/recipes-bsp/alsa-state/alsa-state/asound.conf | 12 ++++ .../recipes-bsp/alsa-state/alsa-state/asound.state | 1 + 4 files changed, 99 insertions(+), 0 deletions(-) create mode 100644 meta/recipes-bsp/alsa-state/alsa-state.bb create mode 100755 meta/recipes-bsp/alsa-state/alsa-state/alsa-state create mode 100644 meta/recipes-bsp/alsa-state/alsa-state/asound.conf create mode 100644 meta/recipes-bsp/alsa-state/alsa-state/asound.state
meta/recipes-bsp/alsa-state/alsa-state.bb new file +57 -0
@@ -0,0 +1,57 @@ +# Copyright Matthias Hentges <[email protected]> (c) 2007 +# License: MIT (see http://www.opensource.org/licenses/mit-license.php +# for a copy of the license) +# +# Filename: alsa-state.bb + +SUMMARY = "Alsa scenario files to enable alsa state restoration." +DESCRIPTION = "Alsa Scenario Files - an init script and state files to restore \ +sound state at system boot and save it at system shut down." +LICENSE = "MIT" +LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" +PV = "0.2.0" +PR = "r0" + +SRC_URI = "\ + file://asound.conf \ + file://asound.state \ + file://alsa-state \ +" + +RDEPENDS = "alsa-utils-alsactl" + +inherit update-rc.d + +INITSCRIPT_NAME = "alsa-state" +INITSCRIPT_PARAMS = "start 39 S . stop 31 0 6 ." + +do_install() { + install -d ${D}${sysconfdir}/init.d + install -m 0755 ${WORKDIR}/alsa-state ${D}${sysconfdir}/init.d + + install -m 0644 ${WORKDIR}/asound.conf ${D}${sysconfdir} + install -m 0644 ${WORKDIR}/*.state ${D}${sysconfdir} +} + +PACKAGES += "alsa-states" + +RRECOMMENDS_alsa-state = "alsa-states" + +FILES_${PN} = "${sysconfdir}/init.d ${sysconfdir}/asound.conf" +CONFFILES_${PN} = "${sysconfdir}/asound.conf" + +FILES_alsa-states = "${sysconfdir}/*.state" + +pkg_postinst_${PN}() { + if test -z "$D" + then + if test -x /usr/sbin/alsactl + then + /usr/sbin/alsactl -f ${sysconfdir}/asound.state restore + fi + # INITSCRIPT_PARAMS changed, so remove the old and + # install the new setting. + update-rc.d -f ${INITSCRIPT_NAME} remove + update-rc.d ${INITSCRIPT_NAME} ${INITSCRIPT_PARAMS} + fi +}
meta/recipes-bsp/alsa-state/alsa-state/alsa-state new file +29 -0
@@ -0,0 +1,29 @@ +#! /bin/sh +# +# Copyright Matthias Hentges <[email protected]> (c) 2007 +# License: GPL (see http://www.gnu.org/licenses/gpl.txt for a copy of the license) +# +# Filename: alsa-state +# Date: 20070308 (YMD) + + +asound_restore(){ + echo "ALSA: Restoring mixer settings..." + if test -x /usr/sbin/alsactl -a -e /etc/asound.state + then + /usr/sbin/alsactl -f /etc/asound.state restore & + fi +} + +asound_store(){ + echo "ALSA: Storing mixer settings..." + if test -x /usr/sbin/alsactl + then + /usr/sbin/alsactl -f /etc/asound.state store + fi +} + +case "$1" in +start) asound_restore ;; +stop) asound_store ;; +esac
meta/recipes-bsp/alsa-state/alsa-state/asound.conf new file +12 -0
@@ -0,0 +1,12 @@ +# default dmix configuration + +pcm.!default { + type plug + slave.pcm "dmix" +} + +ctl.mixer0 { + type hw + card 0 +} +
meta/recipes-bsp/alsa-state/alsa-state/asound.state new file +1 -0
@@ -0,0 +1 @@ +# Dummy file, do not delete
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 04/28] ncurses: move libraries to base_libdir
In reply to Saul WoldFrom: Scott Garman <[email protected]>
Various utilities (including bash and the util-linux programs) located in base_bindir (/bin) or base_sbindir (/sbin) dynamically link against many of the ncurses libraries. So move these libraries from libdir (/usr/lib) to base_libdir (/lib).
--- meta/recipes-core/ncurses/ncurses.inc | 27 ++++++++++++++++++--------- 1 files changed, 18 insertions(+), 9 deletions(-)
meta/recipes-core/ncurses/ncurses.inc +18 -9
@@ -26,6 +26,9 @@ ENABLE_WIDEC ?= "true" # builds. BUILD_CPPFLAGS += "-D_GNU_SOURCE" +# tic from the -native build cannot run without setting this explicitly +BUILD_LDFLAGS_virtclass-native += "-Wl,-rpath,${base_libdir}" + # Helper function for do_configure to allow multiple configurations # $1 the directory to run configure in # $@ the arguments to pass to configure
@@ -41,6 +44,7 @@ ncurses_configure() { --enable-hard-tabs \ --enable-xmc-glitch \ --enable-colorfgbg \ + --libdir=${base_libdir} \ --with-termpath='${sysconfdir}/termcap:${datadir}/misc/termcap' \ --with-terminfo-dirs='${sysconfdir}/terminfo:${datadir}/terminfo' \ --with-shared \
@@ -120,7 +124,6 @@ do_install() { ! ${ENABLE_WIDEC} || \ oe_runmake -C widec ${_install_opts} - cd narrowc # include some basic terminfo files
@@ -155,28 +158,29 @@ do_install() { # else when '-Wl,--no-copy-dt-needed-entries' has been set in # linker flags. for i in libncurses libncursesw; do - f=${D}${libdir}/$i.so + f=${D}${base_libdir}/$i.so test -h $f || continue rm -f $f echo '/* GNU ld script */' >$f echo "INPUT($i.so.5 AS_NEEDED(-ltinfo))" >>$f done - # Make sure that libcurses is linked so that it gets -ltinfo - # also, this should be addressed upstream really. - ln -sf libncurses.so ${D}${libdir}/libcurses.so + + # Make sure that libcurses is linked so that it gets -ltinfo + # also, this should be addressed upstream really. + ln -sf libncurses.so ${D}${base_libdir}/libcurses.so # create libtermcap.so linker script for backward compatibility - f=${D}${libdir}/libtermcap.so + f=${D}${base_libdir}/libtermcap.so echo '/* GNU ld script */' >$f echo 'INPUT(AS_NEEDED(-ltinfo))' >>$f - oe_multilib_header curses.h + oe_multilib_header curses.h } python populate_packages_prepend () { - libdir = bb.data.expand("${libdir}", d) + base_libdir = bb.data.expand("${base_libdir}", d) pnbase = bb.data.expand("${PN}-lib%s", d) - do_split_packages(d, libdir, '^lib(.*)\.so\..*', pnbase, 'ncurses %s library', prepend=True, extra_depends = '', allow_links=True) + do_split_packages(d, base_libdir, '^lib(.*)\.so\..*', pnbase, 'ncurses %s library', prepend=True, extra_depends = '', allow_links=True) }
@@ -210,6 +214,10 @@ FILES_${PN} = "\ ${datadir}/tabset \ " +FILES_${PN}-dev += "\ + ${base_libdir}/*.so \ +" + # This keeps only tput/tset in ncurses # clear/reset are in already busybox FILES_${PN}-tools = "\
@@ -223,6 +231,7 @@ FILES_${PN}-tools = "\ ${bindir}/tack \ ${bindir}/tabs \ " + # 'reset' is a symlink to 'tset' which is in the 'ncurses' package RDEPENDS_${PN}-tools = "${PN}"
Signature · 1 line
1.7.6.4
Re: [CONSOLIDATED PULL 04/28] ncurses: move libraries to base_libdir
meta/recipes-core/ncurses/ncurses.inc do_install() { · line 161
Quoted 2 lines · Saul Wold
meta/recipes-core/ncurses/ncurses.inc +1
-1- f=${D}${libdir}/$i.so + f=${D}${base_libdir}/$i.so
this breaks builds because 'ld' does not search ${base_libdir}:
| gcc -shared ... -ltermcap | /usr/bin/ld: cannot find -ltermcap | ERROR: Task 216 (virtual:native:.../readline/readline_6.2.bb, do_install) failed with exit code '1' | ERROR: 'virtual:native:.../readline/readline_6.2.bb' failed
Enrico
Re: [CONSOLIDATED PULL 04/28] ncurses: move libraries to base_libdir
Quoted 11 lines · Enrico Scholz
meta/recipes-core/ncurses/ncurses.inc do_install() { · line 161
Quoted 2 lines · Saul Wold
meta/recipes-core/ncurses/ncurses.inc +1
-1- f=${D}${libdir}/$i.so + f=${D}${base_libdir}/$i.sothis breaks builds because 'ld' does not search ${base_libdir}:
| gcc -shared ... -ltermcap | /usr/bin/ld: cannot find -ltermcap | ERROR: Task 216 (virtual:native:.../readline/readline_6.2.bb, do_install) failed with exit code '1' | ERROR: 'virtual:native:.../readline/readline_6.2.bb' failed
Note this is a -native problem, not a target library one. I suspect we need to enhance:
export BUILD_LDFLAGS = "-L${STAGING_LIBDIR_NATIVE} \
-Wl,-rpath-link,${STAGING_LIBDIR_NATIVE} \
-Wl,-rpath,${STAGING_LIBDIR_NATIVE} -Wl,-O1"in bitbake.conf.
Cheers,
Richard
Re: [CONSOLIDATED PULL 04/28] ncurses: move libraries to base_libdir
Quoted 8 lines · Richard Purdie
Quoted 7 lines · Enrico Scholz
meta/recipes-core/ncurses/ncurses.inc do_install() { · line 161
Quoted 2 lines · Saul Wold
meta/recipes-core/ncurses/ncurses.inc +1
-1- f=${D}${libdir}/$i.so + f=${D}${base_libdir}/$i.sothis breaks builds because 'ld' does not search ${base_libdir}:
Quoted 6 lines
Quoted 4 lines
| gcc -shared ... -ltermcap | /usr/bin/ld: cannot find -ltermcap | ERROR: Task 216 (virtual:native:.../readline/readline_6.2.bb, do_install) failed with exit code '1' | ERROR: 'virtual:native:.../readline/readline_6.2.bb' failedNote this is a -native problem, not a target library one.
It looks to me like the same would probably occur on the target. The .so devel symlinks should be in ${libdir} not ${base_libdir} since the latter is indeed not in the linker's standard search path.
There are some commented-out bits in bitbake.conf which would put it there:
#export TARGET_LDFLAGS = "-L${STAGING_DIR_TARGET}${libdir} \
# -Wl,-rpath-link,${STAGING_DIR_TARGET}${libdir} \
# -Wl,-O1"
but even then it would still fail for on-target builds that don't use bitbake and I think we should just fix ncurses to install itself into the correct place. Or everyone should use micro and avoid this whole class of problems. :-)
p.
Re: [CONSOLIDATED PULL 04/28] ncurses: move libraries to base_libdir
Quoted 14 lines · Phil Blundell
Quoted 13 lines · Richard Purdie
Quoted 11 lines · Enrico Scholz
meta/recipes-core/ncurses/ncurses.inc do_install() { · line 161
Quoted 2 lines · Saul Wold
meta/recipes-core/ncurses/ncurses.inc +1
-1- f=${D}${libdir}/$i.so + f=${D}${base_libdir}/$i.sothis breaks builds because 'ld' does not search ${base_libdir}:
| gcc -shared ... -ltermcap | /usr/bin/ld: cannot find -ltermcap | ERROR: Task 216 (virtual:native:.../readline/readline_6.2.bb, do_install) failed with exit code '1' | ERROR: 'virtual:native:.../readline/readline_6.2.bb' failed
Quoted 5 lines
Quoted 1 line
Note this is a -native problem, not a target library one.
It looks to me like the same would probably occur on the target. The .so devel symlinks should be in ${libdir} not ${base_libdir} since the latter is indeed not in the linker's standard search path.
Are you 100% sure about that? I was pretty sure that /lib is in the default linker's search path as well as /usr/lib?
I can't find a commandline option to make ld dump its search path but looking at the linker scripts for various architectures, it does appear that /lib is listed as a search directory...
Cheers,
Richard
Re: [CONSOLIDATED PULL 04/28] ncurses: move libraries to base_libdir
Quoted 15 lines · Richard Purdie
Quoted 14 lines · Phil Blundell
Quoted 13 lines · Richard Purdie
Quoted 11 lines · Enrico Scholz
meta/recipes-core/ncurses/ncurses.inc do_install() { · line 161
Quoted 2 lines · Saul Wold
meta/recipes-core/ncurses/ncurses.inc +1
-1- f=${D}${libdir}/$i.so + f=${D}${base_libdir}/$i.sothis breaks builds because 'ld' does not search ${base_libdir}:
| gcc -shared ... -ltermcap | /usr/bin/ld: cannot find -ltermcap | ERROR: Task 216 (virtual:native:.../readline/readline_6.2.bb, do_install) failed with exit code '1' | ERROR: 'virtual:native:.../readline/readline_6.2.bb' failed
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Note this is a -native problem, not a target library one.
It looks to me like the same would probably occur on the target. The .so devel symlinks should be in ${libdir} not ${base_libdir} since the latter is indeed not in the linker's standard search path.
Are you 100% sure about that? I was pretty sure that /lib is in the default linker's search path as well as
/usr/lib?
Not 100%, admittedly, but I can't think of any other instances of these things being installed in /lib. I know that glibc, for example, puts libc.so in /usr/lib even though the corresponding libraries are in /lib. Admittedly that one isn't a symlink though.
Quoted 3 lines
I can't find a commandline option to make ld dump its search path but looking at the linker scripts for various architectures, it does appear that /lib is listed as a search directory...
I think "ld -verbose" should do that. Look for SEARCH_DIR or some such.
p.
Re: [CONSOLIDATED PULL 04/28] ncurses: move libraries to base_libdir
Quoted 30 lines · Phil Blundell
Quoted 15 lines · Richard Purdie
Quoted 14 lines · Phil Blundell
Quoted 13 lines · Richard Purdie
Quoted 11 lines · Enrico Scholz
meta/recipes-core/ncurses/ncurses.inc do_install() { · line 161
Quoted 2 lines · Saul Wold
meta/recipes-core/ncurses/ncurses.inc +1
-1- f=${D}${libdir}/$i.so + f=${D}${base_libdir}/$i.sothis breaks builds because 'ld' does not search ${base_libdir}:
| gcc -shared ... -ltermcap | /usr/bin/ld: cannot find -ltermcap | ERROR: Task 216 (virtual:native:.../readline/readline_6.2.bb, do_install) failed with exit code '1' | ERROR: 'virtual:native:.../readline/readline_6.2.bb' failedQuoted 8 lines
Quoted 5 lines
Quoted 1 line
Note this is a -native problem, not a target library one.
It looks to me like the same would probably occur on the target. The .so devel symlinks should be in ${libdir} not ${base_libdir} since the latter is indeed not in the linker's standard search path.
Are you 100% sure about that? I was pretty sure that /lib is in the default linker's search path as well as
/usr/lib?Not 100%, admittedly, but I can't think of any other instances of these things being installed in /lib. I know that glibc, for example, puts libc.so in
/usr/libeven though the corresponding libraries are in /lib. Admittedly that one isn't a symlink though.
Quoted 5 lines
Quoted 3 lines
I can't find a commandline option to make ld dump its search path but looking at the linker scripts for various architectures, it does appear that /lib is listed as a search directory...
I think "ld -verbose" should do that. Look for
SEARCH_DIRor some such.
$ ./i586-poky-linux-ld --verbose | grep SEARCH
SEARCH_DIR("/media/build1/poky/build/tmp/sysroots/x86_64-linux/usr/i586-poky-linux/lib32"); SEARCH_DIR("=/usr/local/lib32"); SEARCH_DIR("=/lib32"); SEARCH_DIR("=/usr/lib32"); SEARCH_DIR("=/usr/local/lib"); SEARCH_DIR("=/lib"); SEARCH_DIR("=/usr/lib");which makes sense since the builds are all still working...
Cheers,
Richard
Re: [CONSOLIDATED PULL 04/28] ncurses: move libraries to base_libdir
Quoted 4 lines · Richard Purdie
$ ./i586-poky-linux-ld --verbose | grep SEARCH SEARCH_DIR("/media/build1/poky/build/tmp/sysroots/x86_64-linux/usr/i586-poky-linux/lib32"); SEARCH_DIR("=/usr/local/lib32"); SEARCH_DIR("=/lib32"); SEARCH_DIR("=/usr/lib32"); SEARCH_DIR("=/usr/local/lib"); SEARCH_DIR("=/lib"); SEARCH_DIR("=/usr/lib");which makes sense since the builds are all still working...
Oh, right, fair enough. I guess it does need to search /lib for NEEDED libs, at least, and maybe it just uses the same search path for .so links. Anyway, yeah, that seems fine then.
p.
Re: [CONSOLIDATED PULL 04/28] ncurses: move libraries to base_libdir
In reply to Enrico ScholzQuoted 11 lines · Enrico Scholz
meta/recipes-core/ncurses/ncurses.inc do_install() { · line 161
Quoted 2 lines · Saul Wold
meta/recipes-core/ncurses/ncurses.inc +1
-1- f=${D}${libdir}/$i.so + f=${D}${base_libdir}/$i.sothis breaks builds because 'ld' does not search ${base_libdir}:
| gcc -shared ... -ltermcap | /usr/bin/ld: cannot find -ltermcap | ERROR: Task 216 (virtual:native:.../readline/readline_6.2.bb, do_install) failed with exit code '1' | ERROR: 'virtual:native:.../readline/readline_6.2.bb' failed
Which is why I added:
# tic from the -native build cannot run without setting this explicitly
BUILD_LDFLAGS_virtclass-native += "-Wl,-rpath,${base_libdir}"to ncurses.inc
Is this not working?
I build-tested this with our -minimal and -sato images, and readline is built as a part of this. Not sure how I could have missed this, unless some host contamination was creeping in.
Scott
Signature · 3 lines
Scott Garman Embedded Linux Engineer - Yocto Project Intel Open Source Technology Center
Re: [CONSOLIDATED PULL 04/28] ncurses: move libraries to base_libdir
Scott Garman <[email protected]>
Quoted 10 lines · writes:
Quoted 9 lines
meta/recipes-core/ncurses/ncurses.inc do_install() { · line 161
Quoted 2 lines
meta/recipes-core/ncurses/ncurses.inc +1
-1- f=${D}${libdir}/$i.so + f=${D}${base_libdir}/$i.sothis breaks builds because 'ld' does not search ${base_libdir}:
| gcc -shared ... -ltermcap | /usr/bin/ld: cannot find -ltermcap | ERROR: Task 216 (virtual:native:.../readline/readline_6.2.bb, do_install) failed with exit code '1' | ERROR: 'virtual:native:.../readline/readline_6.2.bb' failed
Quoted 8 lines
Which is why I added:
# tic from the -native build cannot run without setting this explicitly BUILD_LDFLAGS_virtclass-native += "-Wl,-rpath,${base_libdir}"to ncurses.inc
Is this not working?
no; error happens when building 'readline-native' (which does not read ncurses.inc). Build of 'ncurses(-native)' succeeded.
Quoted 3 lines
I build-tested this with our -minimal and -sato images, and readline is built as a part of this. Not sure how I could have missed this, unless some host contamination was creeping in.
probably, the ncurses development files were installed on the host and '-ltermcap' linked against them and not against the oe ones..
Enrico
[CONSOLIDATED PULL 03/28] task-base: add alsa-state to task-base-alsa
In reply to Saul WoldFrom: Joshua Lock <[email protected]>
This enables automatic configuration setting and restoration on systems with alsa.
--- meta/recipes-core/tasks/task-base.bb | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
meta/recipes-core/tasks/task-base.bb +3 -2
@@ -2,7 +2,7 @@ DESCRIPTION = "Merge machine and distro options to create a basic machine task/p LICENSE = "MIT" LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \ file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" -PR = "r72" +PR = "r73" inherit task
@@ -183,7 +183,8 @@ RRECOMMENDS_task-base-vfat = "\ RDEPENDS_task-base-alsa = "\ alsa-utils-alsactl \ - alsa-utils-alsamixer" + alsa-utils-alsamixer \ + alsa-state" RRECOMMENDS_task-base-alsa = "\ kernel-module-snd-mixer-oss \
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 06/28] util-linux: move libraries to base_libdir
In reply to Saul WoldFrom: Scott Garman <[email protected]>
Various util-linux programs in base_sbindir (/sbin) linked to libraries located under exec_prefix (/usr). Since this is not safe, move these libraries from libdir (/usr/lib) to base_libdir (/lib).
--- meta/recipes-core/util-linux/util-linux.inc | 20 +++++++++++--------- meta/recipes-core/util-linux/util-linux_2.20.1.bb | 2 +- 2 files changed, 12 insertions(+), 10 deletions(-)
meta/recipes-core/util-linux/util-linux.inc +11 -9
@@ -17,7 +17,6 @@ inherit autotools gettext pkgconfig DEPENDS = "zlib ncurses" DEPENDS_virtclass-native = " lzo-native" - SRC_URI = "ftp://ftp.infradead.org/pub/util-linux/v${MAJOR_VERSION}/util-linux-${PV}.tar.bz2 \ file://MCONFIG \ file://swapargs.h \
@@ -30,11 +29,14 @@ PACKAGES =+ "util-linux-agetty util-linux-fdisk util-linux-cfdisk util-linux-sfd util-linux-mount util-linux-readprofile util-linux-libblkid \ util-linux-libblkid-dev util-linux-libuuid util-linux-libuuid-dev \ util-linux-uuidgen util-linux-lscpu util-linux-fsck util-linux-blkid \ - util-linux-chkdupexe util-linux-mkfs util-linux-mcookie" + util-linux-chkdupexe util-linux-mkfs util-linux-mcookie" -EXTRA_OECONF = "--disable-use-tty-group --disable-makeinstall-chown --enable-elvtune --enable-init --enable-kill --enable-last \ - --enable-mesg --enable-partx --enable-raw --enable-rdev --enable-reset \ - --disable-login-utils --enable-write --enable-arch --enable-mount --with-fsprobe=builtin --enable-libuuid --enable-libblkid --enable-fsck" +EXTRA_OECONF = "--libdir=${base_libdir} --disable-use-tty-group \ + --disable-makeinstall-chown --enable-elvtune --enable-init \ + --enable-kill --enable-last --enable-mesg --enable-partx \ + --enable-raw --enable-rdev --enable-reset --disable-login-utils \ + --enable-write --enable-arch --enable-mount --with-fsprobe=builtin \ + --enable-libuuid --enable-libblkid --enable-fsck" FILES_${PN}-doc += "${datadir}/getopt/getopt-*.*"
@@ -50,10 +52,10 @@ FILES_util-linux-umount = "${base_bindir}/umount.${PN}" FILES_util-linux-readprofile = "${base_sbindir}/readprofile.${PN}" FILES_util-linux-uuidgen = "${bindir}/uuidgen" -FILES_util-linux-libblkid = "${libdir}/libblkid.so.*" -FILES_util-linux-libblkid-dev = "${libdir}/libblkid.so ${libdir}/libblkid.a ${libdir}/libblkid.la ${includedir}/blkid" -FILES_util-linux-libuuid = "${libdir}/libuuid.so.*" -FILES_util-linux-libuuid-dev = "${libdir}/libuuid.so ${libdir}/libuuid.a ${libdir}/libuuid.la ${includedir}/uuid" +FILES_util-linux-libblkid = "${base_libdir}/libblkid.so.*" +FILES_util-linux-libblkid-dev = "${base_libdir}/libblkid.so ${base_libdir}/libblkid.a ${base_libdir}/libblkid.la ${includedir}/blkid" +FILES_util-linux-libuuid = "${base_libdir}/libuuid.so.*" +FILES_util-linux-libuuid-dev = "${base_libdir}/libuuid.so ${base_libdir}/libuuid.a ${base_libdir}/libuuid.la ${includedir}/uuid" FILES_util-linux-lscpu = "${bindir}/lscpu" FILES_util-linux-fsck = "${base_sbindir}/fsck*"
meta/recipes-core/util-linux/util-linux_2.20.1.bb +1 -1
@@ -1,5 +1,5 @@ MAJOR_VERSION = "2.20" -PR = "r0" +PR = "r1" require util-linux.inc # note that `lscpu' is under GPLv3+
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 08/28] libusb1: move libraries to base_libdir
In reply to Saul WoldFrom: Scott Garman <[email protected]>
udev links to libusb1, and so these libraries need to be in base_libdir (/lib) instead of libdir (/usr/lib).
--- meta/recipes-support/libusb/libusb1_1.0.8.bb | 16 ++++++++++++++-- 1 files changed, 14 insertions(+), 2 deletions(-)
meta/recipes-support/libusb/libusb1_1.0.8.bb +14 -2
@@ -1,4 +1,4 @@ -DESCRIPTION = "userspace library to access USB (version 1.0)" +DESCRIPTION = "Userspace library to access USB (version 1.0)" HOMEPAGE = "http://libusb.sf.net" BUGTRACKER = "http://www.libusb.org/report" SECTION = "libs"
@@ -6,7 +6,7 @@ SECTION = "libs" LICENSE = "LGPLv2.1+" LIC_FILES_CHKSUM = "file://COPYING;md5=fbc093901857fcd118f065f900982c24" -PR = "r0" +PR = "r1" SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2"
@@ -15,3 +15,15 @@ SRC_URI[sha256sum] = "21d0d3a5710f7f4211c595102c6b9eccb42435a17a4f5bd2c3f4166ab1 S = "${WORKDIR}/libusb-${PV}" inherit autotools pkgconfig + +EXTRA_OECONF = "--libdir=${base_libdir}" + +do_install_append() { + install -d ${D}${libdir} + mv ${D}${base_libdir}/*.la ${D}${libdir} + mv ${D}${base_libdir}/pkgconfig ${D}${libdir} +} + +FILES_${PN} += "${base_libdir}/*.so.*" + +FILES_${PN}-dev += "${base_libdir}/*.so"
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 07/28] e2fsprogs: move libraries to base_libdir
In reply to Saul WoldFrom: Scott Garman <[email protected]>
The e2fsprogs utilities are installed into base_sbindir (/sbin) and should not link to libraries under exec_prefix (/usr). So move these libraries from libdir (/usr/lib) to base_libdir (/lib).
--- .../e2fsprogs/e2fsprogs_1.41.14.bb | 29 ++++++++++++------- 1 files changed, 18 insertions(+), 11 deletions(-)
meta/recipes-devtools/e2fsprogs/e2fsprogs_1.41.14.bb +18 -11
@@ -1,6 +1,6 @@ require e2fsprogs.inc -PR = "r3" +PR = "r4" SRC_URI += "file://quotefix.patch \ file://acinclude.m4"
@@ -11,9 +11,9 @@ SRC_URI[sha256sum] = "3f8ac1fedd7c4bec480afcbe4acabdd4ac59ec0446a0fd50c8975cd0aa PARALLEL_MAKE = "" -EXTRA_OECONF += " --sbindir=${base_sbindir} --enable-elf-shlibs --disable-libuuid --disable-uuidd" -EXTRA_OECONF_darwin = "--sbindir=${base_sbindir} --enable-bsd-shlibs" -EXTRA_OECONF_darwin8 = "--sbindir=${base_sbindir} --enable-bsd-shlibs" +EXTRA_OECONF += "--libdir=${base_libdir} --sbindir=${base_sbindir} --enable-elf-shlibs --disable-libuuid --disable-uuidd" +EXTRA_OECONF_darwin = "--libdir=${base_libdir} --sbindir=${base_sbindir} --enable-bsd-shlibs" +EXTRA_OECONF_darwin8 = "--libdir=${base_libdir} --sbindir=${base_sbindir} --enable-bsd-shlibs" do_configure_prepend () { cp ${WORKDIR}/acinclude.m4 ${S}/
@@ -28,9 +28,16 @@ do_install () { oe_runmake 'DESTDIR=${D}' install oe_runmake 'DESTDIR=${D}' install-libs # We use blkid from util-linux now so remove from here - rm -f ${D}${libdir}/libblkid* + rm -f ${D}${base_libdir}/libblkid* rm -rf ${D}${includedir}/blkid - rm -f ${D}${libdir}/pkgconfig/blkid.pc + rm -f ${D}${base_libdir}/pkgconfig/blkid.pc +} + +do_install_append () { + # e2initrd_helper and the pkgconfig files belong in libdir + install -d ${D}${libdir} + mv ${D}${base_libdir}/e2initrd_helper ${D}${libdir} + mv ${D}${base_libdir}/pkgconfig ${D}${libdir} } # blkid used to be part of e2fsprogs but is useful outside, add it
@@ -47,10 +54,10 @@ FILES_e2fsprogs-e2fsck = "${base_sbindir}/e2fsck ${base_sbindir}/fsck.ext*" FILES_e2fsprogs-mke2fs = "${base_sbindir}/mke2fs ${base_sbindir}/mkfs.ext* ${sysconfdir}/mke2fs.conf" FILES_e2fsprogs-tune2fs = "${base_sbindir}/tune2fs ${base_sbindir}/e2label ${base_sbindir}/findfs" FILES_e2fsprogs-badblocks = "${base_sbindir}/badblocks" -FILES_libcomerr = "${libdir}/libcom_err.so.*" -FILES_libss = "${libdir}/libss.so.*" -FILES_libe2p = "${libdir}/libe2p.so.*" -FILES_libext2fs = "${libdir}/e2initrd_helper ${libdir}/libext2fs.so.*" -FILES_${PN}-dev += "${datadir}/*/*.awk ${datadir}/*/*.sed" +FILES_libcomerr = "${base_libdir}/libcom_err.so.*" +FILES_libss = "${base_libdir}/libss.so.*" +FILES_libe2p = "${base_libdir}/libe2p.so.*" +FILES_libext2fs = "${base_libdir}/e2initrd_helper ${libdir}/libext2fs.so.*" +FILES_${PN}-dev += "${datadir}/*/*.awk ${datadir}/*/*.sed ${base_libdir}/*.so" BBCLASSEXTEND = "native"
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 05/28] libcap: move library to base_libdir
In reply to Saul WoldFrom: Scott Garman <[email protected]>
ls from coreutils links to libcap, so move the libcap library from libdir (/usr/lib) to base_libdir (/lib).
--- meta/recipes-support/libcap/libcap.inc | 15 +++++++++++++-- meta/recipes-support/libcap/libcap_2.22.bb | 2 +- 2 files changed, 14 insertions(+), 3 deletions(-)
meta/recipes-support/libcap/libcap.inc +13 -2
@@ -21,6 +21,8 @@ do_configure() { sed -e 's,BUILD_CFLAGS ?=,BUILD_CFLAGS := $(BUILD_CFLAGS),' -i Make.Rules } +BUILD_LDFLAGS_virtclass_native += "-Wl,rpath=${base_libdir}" + EXTRA_OEMAKE = " \ LIBATTR=yes \ PAM_CAP=${@base_contains('DISTRO_FEATURES', 'pam', 'yes', 'no', d)} \
@@ -42,8 +44,17 @@ do_install() { oe_runmake install DESTDIR="${D}" prefix="${prefix}" } +do_install_append() { + # Move the library to base_libdir + install -d ${D}${base_libdir} + mv ${D}${libdir}/* ${D}${base_libdir} + rmdir ${D}${libdir} +} + +FILES_${PN}-dev += "${base_libdir}/*.so" + # pam files -FILES_${PN} += "${libdir}/security/*.so" -FILES_${PN}-dbg += "${libdir}/security/.debug/*.so" +FILES_${PN} += "${base_libdir}/security/*.so" +FILES_${PN}-dbg += "${base_libdir}/security/.debug/*.so" BBCLASSEXTEND = "native"
meta/recipes-support/libcap/libcap_2.22.bb +1 -1
@@ -1,6 +1,6 @@ require libcap.inc -PR = "r2" +PR = "r3" SRC_URI[md5sum] = "ce64058bdb3f086ddbfca8ce6c919845" SRC_URI[sha256sum] = "73ebbd4877b5f69dd28b72098e510c5b318bc480f8201c4061ac98b78c04050f"
Signature · 1 line
1.7.6.4
Re: [CONSOLIDATED PULL 05/28] libcap: move library to base_libdir
Quoted 5 lines · Saul Wold
From: Scott Garman <[email protected]>
ls from coreutils links to libcap, so move the libcap library from libdir (
/usr/lib) tobase_libdir(/lib).
what is motivation behind this ? needless we are tweaking the default install mechanism that original package maintainer intended. This can be a maintenace hassle. Is there a very strong reason to make these kind of changes ?
Quoted 59 lines
Signed-off-by Scott Garman <[email protected]>--- meta/recipes-support/libcap/libcap.inc | 15 +++++++++++++-- meta/recipes-support/libcap/libcap_2.22.bb | 2 +- 2 files changed, 14 insertions(+), 3 deletions(-)meta/recipes-support/libcap/libcap.inc +13
-2@@ -21,6 +21,8 @@ do_configure() { sed -e 's,BUILD_CFLAGS ?=,BUILD_CFLAGS := $(BUILD_CFLAGS),' -i Make.Rules } +BUILD_LDFLAGS_virtclass_native += "-Wl,rpath=${base_libdir}" + EXTRA_OEMAKE = " \ LIBATTR=yes \ PAM_CAP=${@base_contains('DISTRO_FEATURES', 'pam', 'yes', 'no', d)} \@@ -42,8 +44,17 @@ do_install() { oe_runmake install DESTDIR="${D}" prefix="${prefix}" } +do_install_append() { + # Move the library to base_libdir + install -d ${D}${base_libdir} + mv ${D}${libdir}/* ${D}${base_libdir} + rmdir ${D}${libdir} +} + +FILES_${PN}-dev += "${base_libdir}/*.so" + # pam files -FILES_${PN} += "${libdir}/security/*.so" -FILES_${PN}-dbg += "${libdir}/security/.debug/*.so" +FILES_${PN} += "${base_libdir}/security/*.so" +FILES_${PN}-dbg += "${base_libdir}/security/.debug/*.so" BBCLASSEXTEND = "native"meta/recipes-support/libcap/libcap_2.22.bb +1
-1@@ -1,6 +1,6 @@ require libcap.inc -PR = "r2" +PR = "r3" SRC_URI[md5sum] = "ce64058bdb3f086ddbfca8ce6c919845" SRC_URI[sha256sum] = "73ebbd4877b5f69dd28b72098e510c5b318bc480f8201c4061ac98b78c04050f"Signature · 7 lines
1.7.6.4 _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Signature · 1 line
-Khem
[CONSOLIDATED PULL 10/28] insane.bbclass: add QA tests for unsafe references to exec_prefix
In reply to Saul WoldFrom: Scott Garman <[email protected]>
Files under exec_prefix (commonly /usr) may not be available during system recovery. exec_prefix may also be kept on a separate partition that is mounted late in the boot process.
This QA test throws an warning if a binary in base_[bindir|sbindir|libdir] is dynamically linked to a file under exec_prefix. The intention is to turn this into an error in the near future.
It also checks executable non-binaries (e.g, shell scripts) in the above base directories with a simple grep test to look for references to exec_prefix. This test only produces a warning, since false positives are likely.
This fixes [YOCTO #1008]
--- meta/classes/insane.bbclass | 111 ++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 109 insertions(+), 2 deletions(-)
meta/classes/insane.bbclass +109 -2
@@ -11,6 +11,10 @@ # -Check if packages contains .debug directories or .so files # where they should be in -dev or -dbg # -Check if config.log contains traces to broken autoconf tests +# -Ensure that binaries in base_[bindir|sbindir|libdir] do not link +# into exec_prefix +# -Check that scripts in base_[bindir|sbindir|libdir] do not reference +# files under exec_prefix #
@@ -19,9 +23,14 @@ # The package.bbclass can help us here. # inherit package -PACKAGE_DEPENDS += "pax-utils-native desktop-file-utils-native" +PACKAGE_DEPENDS += "pax-utils-native desktop-file-utils-native ${QADEPENDS}" PACKAGEFUNCS += " do_package_qa " +# unsafe-references-in-binaries requires prelink-rtld from +# prelink-native, but we don't want this DEPENDS for -native builds +QADEPENDS = "prelink-native" +QADEPENDS_virtclass-native = "" +QADEPENDS_virtclass-nativesdk = "" # # dictionary for elf headers
@@ -100,7 +109,7 @@ def package_qa_get_machine_dict(): # Currently not being used by default "desktop" -WARN_QA ?= "ldflags useless-rpaths rpaths" +WARN_QA ?= "ldflags useless-rpaths rpaths unsafe-references-in-binaries unsafe-references-in-scripts" ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch la2 pkgconfig la perms" def package_qa_clean_path(path,d):
@@ -201,6 +210,104 @@ def package_qa_check_perm(path,name,d, elf, messages): """ return +QAPATHTEST[unsafe-references-in-binaries] = "package_qa_check_unsafe_references_in_binaries" +def package_qa_check_unsafe_references_in_binaries(path, name, d, elf, messages): + """ + Ensure binaries in base_[bindir|sbindir|libdir] do not link to files under exec_prefix + """ + if unsafe_references_skippable(path, name, d): + return + + if elf: + import subprocess as sub + pn = d.getVar('PN', True) + + exec_prefix = d.getVar('exec_prefix', True) + sysroot_path = d.getVar('STAGING_DIR_TARGET', True) + sysroot_path_usr = sysroot_path + exec_prefix + + try: + ldd_output = sub.check_output(["prelink-rtld", "--root", sysroot_path, path]) + except sub.CalledProcessError as e: + if e.returncode != 127: + error_msg = pn + ": prelink-rtld aborted when processing %s" % path + package_qa_handle_error("unsafe-references-in-binaries", error_msg, d) + return False + else: + # Sometimes this is done deliberately (e.g, e2fsprogs), so only warn + bb.warn("%s has missing library dependencies" % path) + return + if sysroot_path_usr in ldd_output: + error_msg = pn + ": %s links to something under exec_prefix" % path + package_qa_handle_error("unsafe-references-in-binaries", error_msg, d) + error_msg = "ldd reports: %s" % ldd_output + package_qa_handle_error("unsafe-references-in-binaries", error_msg, d) + return False + +QAPATHTEST[unsafe-references-in-scripts] = "package_qa_check_unsafe_references_in_scripts" +def package_qa_check_unsafe_references_in_scripts(path, name, d, elf, messages): + """ + Warn if scripts in base_[bindir|sbindir|libdir] reference files under exec_prefix + """ + if unsafe_references_skippable(path, name, d): + return + + if not elf: + import stat + pn = d.getVar('PN', True) + + # Ensure we're checking an executable script + statinfo = os.stat(path) + if bool(statinfo.st_mode & stat.S_IXUSR): + # grep shell scripts for possible references to /exec_prefix/ + exec_prefix = d.getVar('exec_prefix', True) + statement = "grep -e '%s/' %s > /dev/null" % (exec_prefix, path) + if os.system(statement) == 0: + error_msg = pn + ": Found a reference to %s/ in %s" % (exec_prefix, path) + package_qa_handle_error("unsafe-references-in-scripts", error_msg, d) + error_msg = "Shell scripts in base_bindir and base_sbindir should not reference anything in exec_prefix" + package_qa_handle_error("unsafe-references-in-scripts", error_msg, d) + +def unsafe_references_skippable(path, name, d): + if bb.data.inherits_class('native', d) or bb.data.inherits_class('nativesdk', d): + return True + + if "-dbg" in name or "-dev" in name: + return True + + # Other package names to skip: + if name.startswith("kernel-module-"): + return True + + # Skip symlinks + if os.path.islink(path): + return True + + # Skip unusual rootfs layouts which make these tests irrelevant + exec_prefix = d.getVar('exec_prefix', True) + if exec_prefix == "": + return True + + pkgdest = d.getVar('PKGDEST', True) + pkgdest = pkgdest + "/" + name + pkgdest = os.path.abspath(pkgdest) + base_bindir = pkgdest + d.getVar('base_bindir', True) + base_sbindir = pkgdest + d.getVar('base_sbindir', True) + base_libdir = pkgdest + d.getVar('base_libdir', True) + bindir = pkgdest + d.getVar('bindir', True) + sbindir = pkgdest + d.getVar('sbindir', True) + libdir = pkgdest + d.getVar('libdir', True) + + if base_bindir == bindir and base_sbindir == sbindir and base_libdir == libdir: + return True + + # Skip files not in base_[bindir|sbindir|libdir] + path = os.path.abspath(path) + if not (base_bindir in path or base_sbindir in path or base_libdir in path): + return True + + return False + QAPATHTEST[arch] = "package_qa_check_arch" def package_qa_check_arch(path,name,d, elf, messages): """
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 11/28] python-native: correct prefix handling for oe-core sysroot layout
In reply to Saul WoldFrom: Phil Blundell <[email protected]>
Don't try to guess a path based on ${HOST_SYS} since this is not where the files in the sysroot are likely to be. Instead, just use the "plat_specific" approach of taking STAGING_INCDIR and knocking off the trailing "/include" for all cases. This is still evidently suboptimal but does at least seem to give the correct results.
--- ...2-distutils-prefix-is-inside-staging-area.patch | 22 ++++++++----------- .../recipes-devtools/python/python-native_2.7.2.bb | 2 +- 2 files changed, 10 insertions(+), 14 deletions(-)
meta/recipes-devtools/python/python-native/12-distutils-prefix-is-inside-staging-area.patch +9 -13
@@ -2,12 +2,11 @@ Upstream-Status: Inappropriate [embedded specific] # The proper prefix is inside our staging area. # Signed-Off: Michael 'Mickey' Lauer <[email protected]> +# Signed-off-by: Phil Blundell <[email protected]> -Index: Python-2.6.6/Lib/distutils/sysconfig.py -=================================================================== ---- Python-2.6.6.orig/Lib/distutils/sysconfig.py -+++ Python-2.6.6/Lib/distutils/sysconfig.py -@@ -19,8 +19,8 @@ import sys +--- Python-2.6.6/Lib/distutils/sysconfig.py.orig 2012-01-03 14:02:03.027005296 +0000 ++++ Python-2.6.6/Lib/distutils/sysconfig.py 2012-01-03 14:02:31.517601081 +0000 +@@ -19,8 +19,8 @@ from distutils.errors import DistutilsPlatformError # These are needed in a couple of spots, so just compute them once.
@@ -18,19 +17,16 @@ Index: Python-2.6.6/Lib/distutils/sysconfig.py # Path to the base directory of the project. On Windows the binary may # live in project/PCBuild9. If we're dealing with an x64 Windows build, -@@ -70,7 +70,10 @@ def get_python_inc(plat_specific=0, pref +@@ -70,7 +70,7 @@ sys.exec_prefix -- i.e., ignore 'plat_specific'. """ if prefix is None: - prefix = plat_specific and EXEC_PREFIX or PREFIX -+ if plat_specific: -+ prefix = plat_specific and os.environ['STAGING_INCDIR'].rstrip('include') -+ else: -+ prefix = plat_specific and EXEC_PREFIX or PREFIX ++ prefix = os.environ['STAGING_INCDIR'].rstrip('include') if os.name == "posix": if python_build: -@@ -115,12 +118,16 @@ def get_python_lib(plat_specific=0, stan +@@ -115,12 +115,16 @@ If 'prefix' is supplied, use it instead of sys.prefix or sys.exec_prefix -- i.e., ignore 'plat_specific'. """
@@ -49,7 +45,7 @@ Index: Python-2.6.6/Lib/distutils/sysconfig.py if standard_lib: return libpython else: -@@ -216,7 +223,7 @@ def get_config_h_filename(): +@@ -216,7 +220,7 @@ else: # The name of the config.h file changed in 2.2 config_h = 'pyconfig.h'
@@ -58,7 +54,7 @@ Index: Python-2.6.6/Lib/distutils/sysconfig.py def get_makefile_filename(): -@@ -225,7 +232,7 @@ def get_makefile_filename(): +@@ -225,7 +229,7 @@ return os.path.join(os.path.dirname(os.path.realpath(sys.executable)), "Makefile") lib_dir = get_python_lib(plat_specific=1, standard_lib=1)
meta/recipes-devtools/python/python-native_2.7.2.bb +1 -1
@@ -1,6 +1,6 @@ require python.inc DEPENDS = "openssl-native bzip2-full-native zlib-native readline-native sqlite3-native" -PR = "${INC_PR}.2" +PR = "${INC_PR}.3" SRC_URI += "file://04-default-is-optimized.patch \ file://05-enable-ctypes-cross-build.patch \
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 09/28] libusb-compat: move libraries to base_libdir
In reply to Saul WoldFrom: Scott Garman <[email protected]>
udev links to libusb-compat, and so this library needs to be in base_libdir (/lib) instead of libdir (/usr/lib).
--- meta/recipes-support/libusb/libusb-compat_0.1.3.bb | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-)
meta/recipes-support/libusb/libusb-compat_0.1.3.bb +11 -1
@@ -15,7 +15,7 @@ DEPENDS = "libusb1" PROVIDES = "libusb" PE = "1" -PR = "r0" +PR = "r1" SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-compat-${PV}.tar.bz2 \ file://0.1.0-beta1-gcc3.4-fix.patch"
@@ -24,3 +24,13 @@ SRC_URI[md5sum] = "570ac2ea085b80d1f74ddc7c6a93c0eb" SRC_URI[sha256sum] = "a590a03b6188030ee1ca1a0af55685fcde005ca807b963970f839be776031d94" inherit autotools pkgconfig binconfig + +EXTRA_OECONF = "--libdir=${base_libdir}" + +do_install_append() { + install -d ${D}${libdir} + mv ${D}${base_libdir}/*.la ${D}${libdir} + mv ${D}${base_libdir}/pkgconfig ${D}${libdir} +} + +FILES_${PN}-dev += "${base_libdir}/*.so"
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 12/28] opkg-utils: use /usr/bin/env python
In reply to Saul WoldFrom: Christopher Larson <[email protected]>
--- .../opkg-utils/opkg-utils/shebang.patch | 46 ++++++++++++++++++++ meta/recipes-devtools/opkg-utils/opkg-utils_svn.bb | 3 +- 2 files changed, 48 insertions(+), 1 deletions(-) create mode 100644 meta/recipes-devtools/opkg-utils/opkg-utils/shebang.patch
meta/recipes-devtools/opkg-utils/opkg-utils/shebang.patch new file +46 -0
@@ -0,0 +1,46 @@ +Use python via the PATH, rather than hardcoding /usr/bin/python + +Upstream-Status: Pending + +Signed-off-by: Christopher Larson <[email protected]> + +--- opkg-utils.orig/opkg-list-fields ++++ opkg-utils/opkg-list-fields +@@ -1,4 +1,4 @@ +-#!/usr/bin/python ++#!/usr/bin/env python + + import sys, opkg + +--- opkg-utils.orig/opkg-make-index ++++ opkg-utils/opkg-make-index +@@ -1,4 +1,4 @@ +-#!/usr/bin/python ++#!/usr/bin/env python + + import sys, os, posixpath + from glob import glob +--- opkg-utils.orig/opkg-show-deps ++++ opkg-utils/opkg-show-deps +@@ -1,4 +1,4 @@ +-#!/usr/bin/python ++#!/usr/bin/env python + + import sys, os, posixpath + from glob import glob +--- opkg-utils.orig/opkg-unbuild ++++ opkg-utils/opkg-unbuild +@@ -1,4 +1,4 @@ +-#!/usr/bin/python ++#!/usr/bin/env python + + import sys, os, re + +--- opkg-utils.orig/opkg-update-index ++++ opkg-utils/opkg-update-index +@@ -1,4 +1,4 @@ +-#!/usr/bin/env python2.1 ++#!/usr/bin/env python + + import sys, os + from glob import glob
meta/recipes-devtools/opkg-utils/opkg-utils_svn.bb +2 -1
@@ -8,13 +8,14 @@ RDEPENDS_${PN} = "python" RDEPENDS_${PN}_virtclass-native = "" SRCREV = "4747" PV = "0.1.8+svnr${SRCPV}" -PR = "r6" +PR = "r7" SRC_URI = "svn://svn.openmoko.org/trunk/src/host/;module=opkg-utils;proto=http \ file://index-ignore-filenotfound.patch \ file://mtime-int.patch \ file://add-license-field.patch \ file://arfile_header_split.patch \ + file://shebang.patch \ " S = "${WORKDIR}/opkg-utils"
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 13/28] binutils-cross-canadian: Allow ld-is-gold
In reply to Saul WoldFrom: Derek Buitenhuis <[email protected]>
In order to actually generate a toolchain (with bitbake meta-toolchain) that supports gold, binutils- cross-canadian also needs to be built this way.
--- .../binutils/binutils-cross-canadian.inc | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
meta/recipes-devtools/binutils/binutils-cross-canadian.inc +2 -1
@@ -7,7 +7,8 @@ BPN = "binutils" DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/libc-nativesdk zlib-nativesdk gettext-nativesdk" EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \ --program-prefix=${TARGET_PREFIX} \ - --disable-werror" + --disable-werror \ + ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}" do_install () { autotools_do_install
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 16/28] glib-2.0: ensure dtrace is diabled for all distro options and fix packaging
In reply to Saul Wold--- meta/recipes-core/glib-2.0/glib-2.0_2.30.2.bb | 2 +- meta/recipes-core/glib-2.0/glib.inc | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-)
meta/recipes-core/glib-2.0/glib-2.0_2.30.2.bb +1 -1
@@ -1,6 +1,6 @@ require glib.inc -PR = "r1" +PR = "r2" PE = "1" DEPENDS += "libffi python-argparse-native zlib"
meta/recipes-core/glib-2.0/glib.inc +6 -3
@@ -27,11 +27,14 @@ S = "${WORKDIR}/glib-${PV}" EXTRA_OECONF = "--disable-debug --enable-included-printf=no --disable-dtrace" EXTRA_OECONF_virtclass-native = "--disable-dtrace --disable-systemtap" -EXTRA_OECONF_linuxstdbase = "--enable-included-printf=no" +EXTRA_OECONF_linuxstdbase = "--enable-included-printf=no --disbale-dtrace" FILES_${PN} = "${libdir}/lib*${SOLIBS} ${sysconfdir}/bash_completion.d ${datadir}/glib-2.0/schemas" -FILES_${PN}-dev += "${libdir}/glib-2.0/include" -FILES_${PN}-dbg += "${datadir}/glib-2.0/gdb ${datadir}/gdb" +FILES_${PN}-dev += "${libdir}/glib-2.0/include \ + ${libdir}/gio/modules/lib*${SOLIBSDEV} \ + ${libdir}/gio/modules/*.la" +FILES_${PN}-dbg += "${datadir}/glib-2.0/gdb ${datadir}/gdb \ + ${libdir}/gio/modules/.debug" ARM_INSTRUCTION_SET = "arm" USE_NLS = "yes"
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 15/28] image_types: Fix rootfs size calcuation
In reply to Saul WoldThe ROOTFS_SIZE calculation was not correctly taking into account the IMAGE_ROOTFS_EXTRA_SPACE variable, it would only be applied if the size as determined by the ((du * overhead) + extra space) was greater than the IMAGE_ROOTFS_SIZE, so if the du * overhead was smaller
--- meta/classes/image_types.bbclass | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
meta/classes/image_types.bbclass +1 -1
@@ -23,7 +23,7 @@ def get_imagecmds(d): runimagecmd () { # Image generation code for image type ${type} - ROOTFS_SIZE=`du -ks ${IMAGE_ROOTFS}|awk '{size = $1 * ${IMAGE_OVERHEAD_FACTOR} + ${IMAGE_ROOTFS_EXTRA_SPACE}; OFMT = "%.0f" ; print (size > ${IMAGE_ROOTFS_SIZE} ? size : ${IMAGE_ROOTFS_SIZE}) }'` + ROOTFS_SIZE=`du -ks ${IMAGE_ROOTFS}|awk '{base_size = ($1 * ${IMAGE_OVERHEAD_FACTOR}); OFMT = "%.0f" ; print ((base_size > ${IMAGE_ROOTFS_SIZE} ? base_size : ${IMAGE_ROOTFS_SIZE}) + ${IMAGE_ROOTFS_EXTRA_SPACE}) }'` ${cmd} cd ${DEPLOY_DIR_IMAGE}/ rm -f ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.${type}
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 14/28] binutils: Allow plugins
In reply to Saul WoldFrom: Derek Buitenhuis <[email protected]>
Make sure it's possible to build binutils with
plugin support.
--- .../binutils/binutils-cross-canadian.inc | 3 ++- meta/recipes-devtools/binutils/binutils-cross.inc | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)
meta/recipes-devtools/binutils/binutils-cross-canadian.inc +2 -1
@@ -8,7 +8,8 @@ DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/l EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \ --program-prefix=${TARGET_PREFIX} \ --disable-werror \ - ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}" + ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \ + ${@base_contains('DISTRO_FEATURES', 'binutils-plugins', '--enable-plugins', '', d)}" do_install () { autotools_do_install
meta/recipes-devtools/binutils/binutils-cross.inc +2 -1
@@ -10,7 +10,8 @@ EXTRA_OECONF = "--with-sysroot=${STAGING_DIR_TARGET} \ --disable-werror \ --enable-poison-system-directories \ ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \ - ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}" + ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \ + ${@base_contains('DISTRO_FEATURES', 'binutils-plugins', '--enable-plugins', '', d)}" do_install () { oe_runmake 'DESTDIR=${D}' install
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 17/28] kern-tools: import flexible branching support
In reply to Saul WoldFrom: Bruce Ashfield <[email protected]>
The commit:
kern-tools: update SRCREV to pickup git operation fixes
Brought in the ability to trap failed git operations on the working tree, but what it missed were some branching changes that allow arbitrary branch points and the ability to create a branch multiple times (if a feature is included multiple times). The graphics driver branches used by some BSPs need this part of the change to properly handle graphics driver branches.
Updating the SRCREV to pickup the associated kern-tools changes for this support.
--- .../kern-tools/kern-tools-native_git.bb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-kernel/kern-tools/kern-tools-native_git.bb +1 -1
@@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://git/tools/kgit;beginline=5;endline=9;md5=e2bf4415f3d8 DEPENDS = "git-native guilt-native" -SRCREV = "806f1452eeced0bbd05433456ac0d6786d5362dc" +SRCREV = "710067f39a2518f095456eed0232de6300f0b6df" PR = r12 PV = "0.1+git${SRCPV}"
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 19/28] linux-yocto: use src_patches for out of tree kernel feature support
In reply to Saul WoldFrom: Bruce Ashfield <[email protected]>
To support larger out of tree kernel features and enhanced patching schemes, this changeset modifies the linux-yocto patching routines to call the recently factored out 'src_patches' routine. Using the returned list of local URIs for all valid patches, the logic can then determine whether or not patches can be used in place, or need to be migrated and have re-usable kernel features created. The results are then fed to the existing infrastructure to be applied and commited to the tree.
--- meta/classes/kernel-yocto.bbclass | 67 +++++++++++++++++++++++++++++++++++- 1 files changed, 65 insertions(+), 2 deletions(-)
meta/classes/kernel-yocto.bbclass +65 -2
@@ -1,5 +1,15 @@ S = "${WORKDIR}/linux" + +def find_patches(d): + patches=src_patches(d) + patch_list=[] + for p in patches: + _, _, local, _, _, _ = bb.decodeurl(p) + patch_list.append(local) + + return patch_list + do_patch() { cd ${S} if [ -f ${WORKDIR}/defconfig ]; then
@@ -31,14 +41,67 @@ do_patch() { exit 1 fi - # updates or generates the target description + patches="${@" ".join(find_patches(d))}" + + # This loops through all patches, and looks for directories that do + # not already have feature descriptions. If a directory doesn't have + # a feature description, we switch to the ${WORKDIR} variant of the + # feature (so we can write to it) and generate a feature for those + # patches. The generated feature will respect the patch order. + # + # By leaving source patch directories that already have .scc files + # as-is it means that a SRC_URI can only contain a .scc file, and all + # patches that the .scc references will be picked up, without having + # to be repeated on the SRC_URI line .. which is more intutive + set +e + patch_dirs= + for p in ${patches}; do + pdir=`dirname ${p}` + pname=`basename ${p}` + scc=`find ${pdir} -maxdepth 1 -name '*.scc'` + if [ -z "${scc}" ]; then + # there is no scc file. We need to switch to someplace that we know + # we can create content (the workdir) + workdir_subdir=`echo ${pdir} | sed "s%^.*/${PN}%%" | sed 's%^/%%'` + suggested_dir="${WORKDIR}/${workdir_subdir}" + echo ${gen_feature_dirs} | grep -q ${suggested_dir} + if [ $? -ne 0 ]; then + gen_feature_dirs="${gen_feature_dirs} ${suggested_dir}" + fi + # we call the file *.scc_tmp, so the test above will continue to find + # that patches from a common subdirectory don't have a scc file and + # they'll be placed in order, into this file. We'll rename it later. + echo "patch ${pname}" >> ${suggested_dir}/gen_${workdir_subdir}_desc.scc_tmp + else + suggested_dir="${pdir}" + fi + echo ${patch_dirs} | grep -q ${suggested_dir} + if [ $? -ne 0 ]; then + patch_dirs="${patch_dirs} ${suggested_dir}" + fi + done + + # go through the patch directories and look for any scc feature files + # that were constructed above. If one is found, rename it to ".scc" so + # the kernel patching can see it. + for pdir in ${patch_dirs}; do + scc=`find ${pdir} -maxdepth 1 -name '*.scc_tmp'` + if [ -n "${scc}" ]; then + new_scc=`echo ${scc} | sed 's/_tmp//'` + mv -f ${scc} ${new_scc} + fi + done + + # add any explicitly referenced features onto the end of the feature + # list that is passed to the kernel build scripts. if [ -n "${KERNEL_FEATURES}" ]; then for feat in ${KERNEL_FEATURES}; do addon_features="$addon_features --feature $feat" done fi + # updates or generates the target description updateme --branch ${kbranch} -DKDESC=${KMACHINE}:${LINUX_KERNEL_TYPE} \ - ${addon_features} ${ARCH} ${KMACHINE} ${WORKDIR} + ${addon_features} ${ARCH} ${KMACHINE} ${patch_dirs} if [ $? -ne 0 ]; then echo "ERROR. Could not update ${kbranch}" exit 1
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 18/28] linux-yocto: bump kernel version to v3.0.14
In reply to Saul WoldFrom: Bruce Ashfield <[email protected]>
Updating the 3.0 kernel recipe to contain v3.0.14 -stable.
--- meta/recipes-kernel/linux/linux-yocto-rt_3.0.bb | 8 ++++---- meta/recipes-kernel/linux/linux-yocto_3.0.bb | 19 ++++++++++--------- 2 files changed, 14 insertions(+), 13 deletions(-)
meta/recipes-kernel/linux/linux-yocto-rt_3.0.bb +4 -4
@@ -11,12 +11,12 @@ KMACHINE_qemumips = "mti-malta32-be" KBRANCH = "yocto/standard/preempt-rt/base" KBRANCH_qemuppc = "yocto/standard/preempt-rt/qemu-ppc32" -LINUX_VERSION ?= "3.0.12" +LINUX_VERSION ?= "3.0.14" LINUX_KERNEL_TYPE = "preempt-rt" -SRCREV_machine ?= "6e96ccbbf19a4a7b67d98fdcd74d2c9da2c7c463" -SRCREV_machine_qemuppc ?= "8ea61de7fd201ff0001a039f2fda8ec2e4a562a1" -SRCREV_meta ?= "c979f1365b1eb74e882b2cbbc8407ec536ab6eb8" +SRCREV_machine ?= "bcf4107c7f22d10952618a2ad146e6149d240cd2" +SRCREV_machine_qemuppc ?= "1e5511ea2cb5f150ffce86071035a81c0499494b" +SRCREV_meta ?= "e6d8ed43eb051a5db90856cb6226d1cc05d301c5" PR = "r1" PV = "${LINUX_VERSION}+git${SRCPV}"
meta/recipes-kernel/linux/linux-yocto_3.0.bb +10 -9
@@ -10,15 +10,16 @@ KMACHINE_qemuarm = "yocto/standard/arm-versatile-926ejs" KBRANCH = ${KMACHINE} -LINUX_VERSION ?= "3.0.12" - -SRCREV_machine_qemuarm ?= "b2a7d668b963f1c5f9876f130278dd9fb7df4831" -SRCREV_machine_qemumips ?= "62bb04e5ba19b5b8aacd9079fdfbcb8284cd9fc8" -SRCREV_machine_qemuppc ?= "7ecece328c5987112de2959f8f998dfcedaf7210" -SRCREV_machine_qemux86 ?= "a611ba462ac51b2bfdac1c5c6538dac95ad9b4dd" -SRCREV_machine_qemux86-64 ?= "b15a9b67089e31ef9780fdbd0481f48ef7facdba" -SRCREV_machine ?= "f389d310965a56091f688b28ea8be6d9cbb7fbbe" -SRCREV_meta ?= "c979f1365b1eb74e882b2cbbc8407ec536ab6eb8" +LINUX_VERSION ?= "3.0.14" + + +SRCREV_machine_qemuarm ?= "5a941c2d553d3244527845f096d0a7d95cdfac22" +SRCREV_machine_qemumips ?= "0f2c18fe373339e61a55a6d826784b0cde2d5704" +SRCREV_machine_qemuppc ?= "925b585f17da9c51e2159023f813bca391528013" +SRCREV_machine_qemux86 ?= "54794354969774f71fdd71bd20de02f1a990b84d" +SRCREV_machine_qemux86-64 ?= "20a790396e6eeb7c0e77135fa2a86ea8ad505b6f" +SRCREV_machine ?= "e143cd3316f18a15d93365442e1f6eea716aab84" +SRCREV_meta ?= "e6d8ed43eb051a5db90856cb6226d1cc05d301c5" PR = "r2" PV = "${LINUX_VERSION}+git${SRCPV}"
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 20/28] xserver-kdrive: work around issues with -Werror=address
In reply to Saul WoldFrom: Gary Thomas <[email protected]>
A number of calls to REGION_INIT() use a static box which is flagged as an error with -Werror=address. This patch works around the problem, but should not be considered a final solution.
Upstream-Status: Inappropriate
--- .../error-address-work-around.patch | 362 ++++++++++++++++++++ .../xorg-xserver/xserver-kdrive_1.7.99.2.bb | 3 +- 2 files changed, 364 insertions(+), 1 deletions(-) create mode 100644 meta/recipes-graphics/xorg-xserver/xserver-kdrive-1.7.99.2/error-address-work-around.patch
meta/recipes-graphics/xorg-xserver/xserver-kdrive-1.7.99.2/error-address-work-around.patch new file +362 -0
@@ -0,0 +1,362 @@ +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/dix/window.c xorg-server-1.7.99.2/dix/window.c +--- xorg-server-1.7.99.2.ORIG/dix/window.c 2012-01-04 13:12:40.417640130 -0700 ++++ xorg-server-1.7.99.2/dix/window.c 2012-01-04 12:13:20.678605493 -0700 +@@ -559,10 +559,10 @@ + box.y1 = 0; + box.x2 = pScreen->width; + box.y2 = pScreen->height; +- REGION_INIT(pScreen, &pWin->clipList, &box, 1); +- REGION_INIT(pScreen, &pWin->winSize, &box, 1); +- REGION_INIT(pScreen, &pWin->borderSize, &box, 1); +- REGION_INIT(pScreen, &pWin->borderClip, &box, 1); ++ REGION_INIT2(pScreen, &pWin->clipList, &box, 1); ++ REGION_INIT2(pScreen, &pWin->winSize, &box, 1); ++ REGION_INIT2(pScreen, &pWin->borderSize, &box, 1); ++ REGION_INIT2(pScreen, &pWin->borderClip, &box, 1); + + pWin->drawable.class = InputOutput; + pWin->optional->visual = pScreen->rootVisual; +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/exa/exa_accel.c xorg-server-1.7.99.2/exa/exa_accel.c +--- xorg-server-1.7.99.2.ORIG/exa/exa_accel.c 2009-12-11 11:20:48.000000000 -0700 ++++ xorg-server-1.7.99.2/exa/exa_accel.c 2012-01-04 12:58:11.218616328 -0700 +@@ -1275,7 +1275,7 @@ + Box.x2 = Box.x1 + w; + Box.y2 = Box.y1 + h; + +- REGION_INIT(pScreen, &Reg, &Box, 1); ++ REGION_INIT2(pScreen, &Reg, &Box, 1); + + pixmaps[0].as_dst = FALSE; + pixmaps[0].as_src = TRUE; +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/exa/exa.c xorg-server-1.7.99.2/exa/exa.c +--- xorg-server-1.7.99.2.ORIG/exa/exa.c 2009-12-11 11:20:48.000000000 -0700 ++++ xorg-server-1.7.99.2/exa/exa.c 2012-01-04 12:56:30.592593427 -0700 +@@ -161,7 +161,7 @@ + if (box.x1 >= box.x2 || box.y1 >= box.y2) + return; + +- REGION_INIT(pScreen, ®ion, &box, 1); ++ REGION_INIT2(pScreen, ®ion, &box, 1); + DamageRegionAppend(&pPix->drawable, ®ion); + DamageRegionProcessPending(&pPix->drawable); + REGION_UNINIT(pScreen, ®ion); +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/exa/exa_classic.c xorg-server-1.7.99.2/exa/exa_classic.c +--- xorg-server-1.7.99.2.ORIG/exa/exa_classic.c 2009-11-28 13:44:58.000000000 -0700 ++++ xorg-server-1.7.99.2/exa/exa_classic.c 2012-01-04 12:54:50.586576675 -0700 +@@ -131,8 +131,8 @@ + box.y1 = 0; + box.x2 = w; + box.y2 = h; +- REGION_INIT(pScreen, &pExaPixmap->validSys, &box, 0); +- REGION_INIT(pScreen, &pExaPixmap->validFB, &box, 0); ++ REGION_INIT2(pScreen, &pExaPixmap->validSys, &box, 0); ++ REGION_INIT2(pScreen, &pExaPixmap->validFB, &box, 0); + + exaSetAccelBlock(pExaScr, pExaPixmap, + w, h, bpp); +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/exa/exa_migration_classic.c xorg-server-1.7.99.2/exa/exa_migration_classic.c +--- xorg-server-1.7.99.2.ORIG/exa/exa_migration_classic.c 2009-11-28 13:44:58.000000000 -0700 ++++ xorg-server-1.7.99.2/exa/exa_migration_classic.c 2012-01-04 12:54:43.077500333 -0700 +@@ -177,7 +177,7 @@ + box.x2 = max(pValidExt->x2, pDamageExt->x2); + box.y2 = max(pValidExt->y2, pDamageExt->y2); + +- REGION_INIT(pScreen, &closure, &box, 0); ++ REGION_INIT2(pScreen, &closure, &box, 0); + REGION_INTERSECT(pScreen, &CopyReg, &CopyReg, &closure); + } else + REGION_INTERSECT(pScreen, &CopyReg, &CopyReg, pending_damage); +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/exa/exa_render.c xorg-server-1.7.99.2/exa/exa_render.c +--- xorg-server-1.7.99.2.ORIG/exa/exa_render.c 2009-11-28 13:44:58.000000000 -0700 ++++ xorg-server-1.7.99.2/exa/exa_render.c 2012-01-04 12:59:18.234297490 -0700 +@@ -576,7 +576,7 @@ + * (see use of DamagePendingRegion in exaCopyDirty) + */ + +- REGION_INIT(pScreen, ®ion, &box, 1); ++ REGION_INIT2(pScreen, ®ion, &box, 1); + + DamageRegionAppend(pDst->pDrawable, ®ion); + +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/exa/exa_unaccel.c xorg-server-1.7.99.2/exa/exa_unaccel.c +--- xorg-server-1.7.99.2.ORIG/exa/exa_unaccel.c 2009-12-11 11:20:48.000000000 -0700 ++++ xorg-server-1.7.99.2/exa/exa_unaccel.c 2012-01-04 12:59:25.915375559 -0700 +@@ -344,7 +344,7 @@ + Box.x2 = Box.x1 + w; + Box.y2 = Box.y1 + h; + +- REGION_INIT(pScreen, &Reg, &Box, 1); ++ REGION_INIT2(pScreen, &Reg, &Box, 1); + + pExaScr->prepare_access_reg(pPix, EXA_PREPARE_SRC, &Reg); + } else +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/fb/fboverlay.c xorg-server-1.7.99.2/fb/fboverlay.c +--- xorg-server-1.7.99.2.ORIG/fb/fboverlay.c 2009-11-04 09:25:50.000000000 -0700 ++++ xorg-server-1.7.99.2/fb/fboverlay.c 2012-01-04 12:24:43.855400893 -0700 +@@ -147,7 +147,7 @@ + pbits)) + return FALSE; + pScrPriv->layer[i].u.run.pixmap = pPixmap; +- REGION_INIT(pScreen, &pScrPriv->layer[i].u.run.region, &box, 0); ++ REGION_INIT2(pScreen, &pScrPriv->layer[i].u.run.region, &box, 0); + } + pScreen->devPrivate = pScrPriv->layer[0].u.run.pixmap; + return TRUE; +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/hw/kdrive/src/kdrive.c xorg-server-1.7.99.2/hw/kdrive/src/kdrive.c +--- xorg-server-1.7.99.2.ORIG/hw/kdrive/src/kdrive.c 2012-01-04 13:12:40.418640141 -0700 ++++ xorg-server-1.7.99.2/hw/kdrive/src/kdrive.c 2012-01-04 13:05:08.771897914 -0700 +@@ -144,8 +144,8 @@ + box.y2 = pScreen->height; + pWin->drawable.width = pScreen->width; + pWin->drawable.height = pScreen->height; +- REGION_INIT (pScreen, &pWin->winSize, &box, 1); +- REGION_INIT (pScreen, &pWin->borderSize, &box, 1); ++ REGION_INIT2 (pScreen, &pWin->winSize, &box, 1); ++ REGION_INIT2 (pScreen, &pWin->borderSize, &box, 1); + REGION_RESET(pScreen, &pWin->borderClip, &box); + REGION_BREAK (pWin->drawable.pScreen, &pWin->clipList); + } +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/hw/kdrive/src/kxv.c xorg-server-1.7.99.2/hw/kdrive/src/kxv.c +--- xorg-server-1.7.99.2.ORIG/hw/kdrive/src/kxv.c 2008-11-14 14:27:05.000000000 -0700 ++++ xorg-server-1.7.99.2/hw/kdrive/src/kxv.c 2012-01-04 13:07:32.625411023 -0700 +@@ -674,7 +674,7 @@ + WinBox.y2 = WinBox.y1 + portPriv->drw_h; + + /* clip to the window composite clip */ +- REGION_INIT(portPriv->pDraw->pScreen, &WinRegion, &WinBox, 1); ++ REGION_INIT2(portPriv->pDraw->pScreen, &WinRegion, &WinBox, 1); + REGION_INIT(portPriv->pDraw->pScreen, &ClipRegion, NullBox, 1); + REGION_INTERSECT(portPriv->pDraw->pScreen, &ClipRegion, &WinRegion, portPriv->pCompositeClip); + +@@ -738,7 +738,7 @@ + WinBox.y2 = WinBox.y1 + portPriv->drw_h; + + /* clip to the window composite clip */ +- REGION_INIT(pScreen, &WinRegion, &WinBox, 1); ++ REGION_INIT2(pScreen, &WinRegion, &WinBox, 1); + REGION_INIT(pScreen, &ClipRegion, NullBox, 1); + REGION_INTERSECT(Screen, &ClipRegion, &WinRegion, portPriv->pCompositeClip); + +@@ -752,7 +752,7 @@ + VPBox.x2 = screen->width; + VPBox.y2 = screen->height; + +- REGION_INIT(pScreen, &VPReg, &VPBox, 1); ++ REGION_INIT2(pScreen, &VPReg, &VPBox, 1); + REGION_INTERSECT(Screen, &ClipRegion, &ClipRegion, &VPReg); + REGION_UNINIT(pScreen, &VPReg); + } +@@ -827,7 +827,7 @@ + WinBox.y2 = WinBox.y1 + portPriv->drw_h; + + /* clip to the window composite clip */ +- REGION_INIT(pScreen, &WinRegion, &WinBox, 1); ++ REGION_INIT2(pScreen, &WinRegion, &WinBox, 1); + REGION_INIT(pScreen, &ClipRegion, NullBox, 1); + REGION_INTERSECT(Screen, &ClipRegion, &WinRegion, portPriv->pCompositeClip); + +@@ -841,7 +841,7 @@ + VPBox.x2 = screen->width; + VPBox.y2 = screen->height; + +- REGION_INIT(pScreen, &VPReg, &VPBox, 1); ++ REGION_INIT2(pScreen, &VPReg, &VPBox, 1); + REGION_INTERSECT(Screen, &ClipRegion, &ClipRegion, &VPReg); + REGION_UNINIT(pScreen, &VPReg); + } +@@ -1337,7 +1337,7 @@ + WinBox.x2 = WinBox.x1 + drw_w; + WinBox.y2 = WinBox.y1 + drw_h; + +- REGION_INIT(pScreen, &WinRegion, &WinBox, 1); ++ REGION_INIT2(pScreen, &WinRegion, &WinBox, 1); + REGION_INIT(pScreen, &ClipRegion, NullBox, 1); + REGION_INTERSECT(pScreen, &ClipRegion, &WinRegion, pGC->pCompositeClip); + +@@ -1350,7 +1350,7 @@ + VPBox.x2 = screen->width; + VPBox.y2 = screen->height; + +- REGION_INIT(pScreen, &VPReg, &VPBox, 1); ++ REGION_INIT2(pScreen, &VPReg, &VPBox, 1); + REGION_INTERSECT(Screen, &ClipRegion, &ClipRegion, &VPReg); + REGION_UNINIT(pScreen, &VPReg); + } +@@ -1490,7 +1490,7 @@ + WinBox.x2 = WinBox.x1 + drw_w; + WinBox.y2 = WinBox.y1 + drw_h; + +- REGION_INIT(pScreen, &WinRegion, &WinBox, 1); ++ REGION_INIT2(pScreen, &WinRegion, &WinBox, 1); + REGION_INIT(pScreen, &ClipRegion, NullBox, 1); + REGION_INTERSECT(pScreen, &ClipRegion, &WinRegion, pGC->pCompositeClip); + +@@ -1637,7 +1637,7 @@ + WinBox.x2 = WinBox.x1 + drw_w; + WinBox.y2 = WinBox.y1 + drw_h; + +- REGION_INIT(pScreen, &WinRegion, &WinBox, 1); ++ REGION_INIT2(pScreen, &WinRegion, &WinBox, 1); + REGION_INIT(pScreen, &ClipRegion, NullBox, 1); + REGION_INTERSECT(pScreen, &ClipRegion, &WinRegion, pGC->pCompositeClip); + +@@ -1650,7 +1650,7 @@ + VPBox.x2 = pScreen->width; + VPBox.y2 = pScreen->height; + +- REGION_INIT(pScreen, &VPReg, &VPBox, 1); ++ REGION_INIT2(pScreen, &VPReg, &VPBox, 1); + REGION_INTERSECT(Screen, &ClipRegion, &ClipRegion, &VPReg); + REGION_UNINIT(pScreen, &VPReg); + } +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/include/regionstr.h xorg-server-1.7.99.2/include/regionstr.h +--- xorg-server-1.7.99.2.ORIG/include/regionstr.h 2009-11-04 09:25:50.000000000 -0700 ++++ xorg-server-1.7.99.2/include/regionstr.h 2012-01-04 12:13:06.174461574 -0700 +@@ -152,6 +152,12 @@ + } \ + } + ++#define REGION_INIT2(_pScreen, _pReg, _rect, _size) \ ++{ \ ++ (_pReg)->extents = *(_rect); \ ++ (_pReg)->data = (RegDataPtr)NULL; \ ++ } ++ + + #define REGION_UNINIT(_pScreen, _pReg) \ + { \ +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/mi/micopy.c xorg-server-1.7.99.2/mi/micopy.c +--- xorg-server-1.7.99.2.ORIG/mi/micopy.c 2009-11-04 09:25:50.000000000 -0700 ++++ xorg-server-1.7.99.2/mi/micopy.c 2012-01-04 12:44:17.003144611 -0700 +@@ -315,7 +315,7 @@ + box.y1 = box_y1; + box.x2 = box_x2; + box.y2 = box_y2; +- REGION_INIT(pGC->pScreen, &rgnDst, &box, 1); ++ REGION_INIT2(pGC->pScreen, &rgnDst, &box, 1); + } + + /* Clip against complex source if needed */ +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/mi/miexpose.c xorg-server-1.7.99.2/mi/miexpose.c +--- xorg-server-1.7.99.2.ORIG/mi/miexpose.c 2009-11-04 09:25:50.000000000 -0700 ++++ xorg-server-1.7.99.2/mi/miexpose.c 2012-01-04 12:46:29.400478668 -0700 +@@ -206,7 +206,7 @@ + box.x2 = pSrcDrawable->width; + box.y2 = pSrcDrawable->height; + prgnSrcClip = &rgnSrcRec; +- REGION_INIT(pscr, prgnSrcClip, &box, 1); ++ REGION_INIT2(pscr, prgnSrcClip, &box, 1); + pSrcWin = NULL; + } + +@@ -239,11 +239,11 @@ + box.x2 = pDstDrawable->width; + box.y2 = pDstDrawable->height; + prgnDstClip = &rgnDstRec; +- REGION_INIT(pscr, prgnDstClip, &box, 1); ++ REGION_INIT2(pscr, prgnDstClip, &box, 1); + } + + /* drawable-relative source region */ +- REGION_INIT(pscr, &rgnExposed, &srcBox, 1); ++ REGION_INIT2(pscr, &rgnExposed, &srcBox, 1); + + /* now get the hidden parts of the source box*/ + REGION_SUBTRACT(pscr, &rgnExposed, &rgnExposed, prgnSrcClip); +@@ -491,7 +491,7 @@ + box = *REGION_EXTENTS( pWin->drawable.pScreen, exposures); + if (exposures == prgn) { + exposures = &expRec; +- REGION_INIT( pWin->drawable.pScreen, exposures, &box, 1); ++ REGION_INIT2( pWin->drawable.pScreen, exposures, &box, 1); + REGION_RESET( pWin->drawable.pScreen, prgn, &box); + } else { + REGION_RESET( pWin->drawable.pScreen, exposures, &box); +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/mi/mioverlay.c xorg-server-1.7.99.2/mi/mioverlay.c +--- xorg-server-1.7.99.2.ORIG/mi/mioverlay.c 2009-11-04 09:25:50.000000000 -0700 ++++ xorg-server-1.7.99.2/mi/mioverlay.c 2012-01-04 12:47:50.114300224 -0700 +@@ -209,8 +209,8 @@ + fullBox.y1 = 0; + fullBox.x2 = pScreen->width; + fullBox.y2 = pScreen->height; +- REGION_INIT(pScreen, &(pTree->borderClip), &fullBox, 1); +- REGION_INIT(pScreen, &(pTree->clipList), &fullBox, 1); ++ REGION_INIT2(pScreen, &(pTree->borderClip), &fullBox, 1); ++ REGION_INIT2(pScreen, &(pTree->clipList), &fullBox, 1); + } + } else xfree(pTree); + } +@@ -1027,7 +1027,7 @@ + box = *REGION_EXTENTS(pScreen, exposures); + if (exposures == prgn) { + exposures = &expRec; +- REGION_INIT(pScreen, exposures, &box, 1); ++ REGION_INIT2(pScreen, exposures, &box, 1); + REGION_RESET(pScreen, prgn, &box); + } else { + REGION_RESET(pScreen, exposures, &box); +@@ -1672,7 +1672,7 @@ + box.x1 = x1; box.x2 = x2; + box.y1 = y1; box.y2 = y2; + +- REGION_INIT(pScreen, ®, &box, 1); ++ REGION_INIT2(pScreen, ®, &box, 1); + + REGION_INTERSECT(pScreen, ®, ®, clipList); + if (generateExposures) +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/mi/miwindow.c xorg-server-1.7.99.2/mi/miwindow.c +--- xorg-server-1.7.99.2.ORIG/mi/miwindow.c 2009-11-04 09:25:50.000000000 -0700 ++++ xorg-server-1.7.99.2/mi/miwindow.c 2012-01-04 12:48:38.055787835 -0700 +@@ -111,7 +111,7 @@ + box.y2 = y2; + + pScreen = pWin->drawable.pScreen; +- REGION_INIT(pScreen, ®, &box, 1); ++ REGION_INIT2(pScreen, ®, &box, 1); + + REGION_INTERSECT(pScreen, ®, ®, &pWin->clipList); + if (generateExposures) +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/miext/damage/damage.c xorg-server-1.7.99.2/miext/damage/damage.c +--- xorg-server-1.7.99.2.ORIG/miext/damage/damage.c 2009-11-04 09:25:50.000000000 -0700 ++++ xorg-server-1.7.99.2/miext/damage/damage.c 2012-01-04 12:51:04.883281430 -0700 +@@ -324,7 +324,7 @@ + box.y1 = draw_y; + box.x2 = draw_x + pDamage->pDrawable->width; + box.y2 = draw_y + pDamage->pDrawable->height; +- REGION_INIT(pScreen, &pixClip, &box, 1); ++ REGION_INIT2(pScreen, &pixClip, &box, 1); + REGION_INTERSECT (pScreen, pDamageRegion, pRegion, &pixClip); + REGION_UNINIT(pScreen, &pixClip); + } +@@ -2085,7 +2085,7 @@ + box.y1 = pDrawable->y; + box.x2 = pDrawable->x + pDrawable->width; + box.y2 = pDrawable->y + pDrawable->height; +- REGION_INIT (pDrawable->pScreen, &pixmapClip, &box, 1); ++ REGION_INIT2 (pDrawable->pScreen, &pixmapClip, &box, 1); + pClip = &pixmapClip; + } + REGION_TRANSLATE (pDrawable->pScreen, &pDamage->damage, pDrawable->x, pDrawable->y); +diff -ur --exclude='*.lo' --exclude='config*' --exclude='Make*' --exclude='ac*' xorg-server-1.7.99.2.ORIG/Xext/xace.c xorg-server-1.7.99.2/Xext/xace.c +--- xorg-server-1.7.99.2.ORIG/Xext/xace.c 2009-11-04 09:25:50.000000000 -0700 ++++ xorg-server-1.7.99.2/Xext/xace.c 2012-01-04 12:49:36.850385965 -0700 +@@ -255,7 +255,7 @@ + imageBox.y1 = y; + imageBox.x2 = x + w; + imageBox.y2 = y + h; +- REGION_INIT(pScreen, &imageRegion, &imageBox, 1); ++ REGION_INIT2(pScreen, &imageRegion, &imageBox, 1); + REGION_NULL(pScreen, &censorRegion); + + /* censorRegion = imageRegion - visibleRegion */ +--- xorg-server-1.7.99.2.ORIG/mi/mibank.c 2009-11-04 09:25:50.000000000 -0700 ++++ xorg-server-1.7.99.2/mi/mibank.c 2012-01-04 12:37:42.251184747 -0700 +@@ -772,7 +772,7 @@ + } + else + { +- REGION_INIT(pScreen, &rgnDst, &fastBox, 1); ++ REGION_INIT2(pScreen, &rgnDst, &fastBox, 1); + REGION_INTERSECT(pScreen, &rgnDst, &rgnDst, prgnSrcClip); + pBox = REGION_RECTS(&rgnDst); + nBox = REGION_NUM_RECTS(&rgnDst);
meta/recipes-graphics/xorg-xserver/xserver-kdrive_1.7.99.2.bb +2 -1
@@ -7,7 +7,7 @@ RDEPENDS_${PN} += "xkeyboard-config" EXTRA_OECONF += "--disable-glx" PE = "1" -PR = "r27" +PR = "r28" SRC_URI = "${XORG_MIRROR}/individual/xserver/xorg-server-${PV}.tar.bz2 \ file://extra-kmodes.patch \
@@ -19,6 +19,7 @@ SRC_URI = "${XORG_MIRROR}/individual/xserver/xorg-server-${PV}.tar.bz2 \ file://fbdev_xrandr_ioctl.patch \ file://fix-newer-xorg-headers.patch \ file://crosscompile.patch \ + file://error-address-work-around.patch \ file://nodolt.patch" # file://kdrive-evdev.patch # file://kdrive-use-evdev.patch
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 22/28] udev: use 'echo' instead of 'echo -n' in init script
In reply to Saul WoldFrom: Otavio Salvador <[email protected]>
Avoid using two stage progress output to avoid text garbage during parallel boot.
--- meta/recipes-core/udev/udev/init | 3 +-- meta/recipes-core/udev/udev_164.bb | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)
meta/recipes-core/udev/udev/init +1 -2
@@ -25,7 +25,7 @@ kill_udevd() { export ACTION=add # propagate /dev from /sys -echo -n "Starting udev" +echo "Starting udev" # mount the tmpfs on /dev, if not already done LANG=C awk '$2 == "/dev" && ($3 == "tmpfs" || $3 == "devtmpfs") { exit 1 }' /proc/mounts && {
@@ -55,5 +55,4 @@ else /sbin/udevadm settle fi -echo exit 0
meta/recipes-core/udev/udev_164.bb +1 -1
@@ -1,6 +1,6 @@ include udev.inc -PR = "r8" +PR = "r10" SRC_URI += "file://udev-166-v4l1-1.patch"
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 21/28] libxp: fix cast error
In reply to Saul Wold--- .../xorg-lib/libxp/fix-cast-error.patch | 42 ++++++++++++++++++++ meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb | 4 +- 2 files changed, 45 insertions(+), 1 deletions(-) create mode 100644 meta/recipes-graphics/xorg-lib/libxp/fix-cast-error.patch
meta/recipes-graphics/xorg-lib/libxp/fix-cast-error.patch new file +42 -0
@@ -0,0 +1,42 @@ +This patch fixes these new errors: + +| XpNotifyPdm.c:234:10: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] +| XpNotifyPdm.c:271:10: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] +| XpNotifyPdm.c:286:10: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] + + +Upstream-Status: Pending + +Signed-off-by: Saul Wold <[email protected]> + +Index: libXp-1.0.1/src/XpNotifyPdm.c +=================================================================== +--- libXp-1.0.1.orig/src/XpNotifyPdm.c ++++ libXp-1.0.1/src/XpNotifyPdm.c +@@ -231,7 +231,7 @@ XpGetPdmStartParams ( + /* + * Error - cannot determine or establish a selection_display. + */ +- return( (Status) NULL ); ++ return( (Status) 0 ); + } + + /* +@@ -268,7 +268,7 @@ XpGetPdmStartParams ( + XCloseDisplay( *selection_display ); + *selection_display = (Display *) NULL; + } +- return( (Status) NULL ); ++ return( (Status) 0 ); + } + + status = XmbTextListToTextProperty( *selection_display, list, 6, +@@ -283,7 +283,7 @@ XpGetPdmStartParams ( + XCloseDisplay( *selection_display ); + *selection_display = (Display *) NULL; + } +- return( (Status) NULL ); ++ return( (Status) 0 ); + } + + *type = text_prop.encoding;
meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb +3 -1
@@ -10,12 +10,14 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=9504a1264f5ddd4949254a57c0f8d6bb \ file://src/XpPage.c;beginline=2;endline=35;md5=2b7d3d2ba5505b19271cf31b6918997e" DEPENDS += "libxext libxau printproto" -PR = "r0" +PR = "r1" PE = "1" XORG_PN = "libXp" CFLAGS_append += " -I ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions" +SRC_URI += "file://fix-cast-error.patch" + SRC_URI[md5sum] = "7ae1d63748e79086bd51a633da1ff1a9" SRC_URI[sha256sum] = "71d1f260005616d646b8c8788365f2b7d93911dac57bb53b65753d9f9e6443d2"
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 23/28] udev: split utilities onto udev-utils
In reply to Saul WoldFrom: Otavio Salvador <[email protected]>
--- meta/recipes-core/udev/udev.inc | 6 +++++- meta/recipes-core/udev/udev_164.bb | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-)
meta/recipes-core/udev/udev.inc +5 -1
@@ -35,7 +35,7 @@ libexecdir = "${base_libdir}/udev" EXTRA_OECONF = "--disable-introspection --with-rootlibdir=${base_libdir} \ --with-pci-ids-path=${datadir}/pci.ids" -PACKAGES =+ "udev-acl udev-consolekit" +PACKAGES =+ "udev-acl udev-consolekit udev-utils" PACKAGES =+ "udev-cache libudev libudev-dev libudev-dbg" PACKAGES =+ "libgudev libgudev-dev libgudev-dbg"
@@ -46,6 +46,8 @@ INITSCRIPT_NAME_udev-cache = "udev-cache" INITSCRIPT_PARAMS_udev-cache = "start 36 S ." FILES_${PN} += "${libexecdir} ${libdir}/ConsoleKit" +RRECOMMENDS_${PN} += "udev-utils" + FILES_${PN}-dbg += "${libexecdir}/.debug" FILES_${PN}-dev = "${datadir}/pkgconfig/udev.pc" FILES_libudev = "${base_libdir}/libudev.so.*"
@@ -60,6 +62,8 @@ FILES_udev-cache = "${sysconfdir}/init.d/udev-cache" FILES_udev-acl = "${base_libdir}/udev/udev-acl ${base_libdir}/udev/rules.d/70-acl.rules" +FILES_udev-utils = "${bindir}/udevinfo ${bindir}/udevtest ${base_sbindir}/udevadm" + RDEPENDS_udev-consolekit += "udev-acl" FILES_udev-consolekit = "${libdir}/ConsoleKit"
meta/recipes-core/udev/udev_164.bb +1 -1
@@ -1,6 +1,6 @@ include udev.inc -PR = "r10" +PR = "r9" SRC_URI += "file://udev-166-v4l1-1.patch"
Signature · 1 line
1.7.6.4
Re: [CONSOLIDATED PULL 23/28] udev: split utilities onto udev-utils
meta/recipes-core/udev/udev_164.bb line 3
Quoted 2 lines · Saul Wold
meta/recipes-core/udev/udev_164.bb +1
-1-PR = "r10" +PR = "r9"
Er, really?
p.
[CONSOLIDATED PULL 25/28] Patch Upstream-Status Update
In reply to Saul Wold--- meta/recipes-devtools/guilt/files/guilt-bash.patch | 2 ++ .../guilt/files/guilt-import-commit.patch | 2 ++ meta/recipes-devtools/guilt/files/guilt-init.patch | 2 ++ meta/recipes-devtools/guilt/files/guilt-pop.patch | 2 ++ .../guilt/files/guilt-push-no-series.patch | 2 ++ meta/recipes-devtools/guilt/files/guilt-push.patch | 2 ++ .../guilt/files/guilt-set-git_exec_path.patch | 2 ++ meta/recipes-devtools/guilt/files/guilt.patch | 2 ++ .../guilt/files/improve_auto_header_gen.patch | 2 ++ .../files/make_git_commands_conditional.patch | 2 ++ .../guilt/files/optional_head_check.patch | 2 ++ .../guilt/files/uninstall_force.patch | 2 ++ 12 files changed, 24 insertions(+), 0 deletions(-)
meta/recipes-devtools/guilt/files/guilt-bash.patch +2 -0
@@ -9,6 +9,8 @@ in as /bin/sh makes the problem go away. So here we change the guilt scripts to explicitly call for bash to ensure we don't have a similar issue after deployment. +Upstream-Status: Inappropriate [oe-specific] + Signed-off-by: Paul Gortmaker <[email protected]> ---
meta/recipes-devtools/guilt/files/guilt-import-commit.patch +2 -0
@@ -8,6 +8,8 @@ are generated. If patches cannot be exported, fall back to importing commits via a more custom method. +Upstream-Status: Inappropriate [oe-specific] + Signed-off-by: Bruce Ashfield <[email protected]> ---
meta/recipes-devtools/guilt/files/guilt-init.patch +2 -0
@@ -1,5 +1,7 @@ guilt: allow previously initialized branches to be re-initialized +Upstream-Status: Inappropriate [oe-specific] + Signed-off-by: Bruce Ashfield <[email protected]> ---
meta/recipes-devtools/guilt/files/guilt-pop.patch +2 -0
@@ -3,6 +3,8 @@ guilt: pop and delete tags Add support for popping to a tag and the ability to delete a tag while popping from the tree +Upstream-Status: Inappropriate [oe-specific] + Signed-off-by: Bruce Ashfield <[email protected]> ---
meta/recipes-devtools/guilt/files/guilt-push-no-series.patch +2 -0
@@ -4,6 +4,8 @@ If a series file becomes mangled and a patch name appears in there more than once, then the guilt-push will fail a horrible and incomprehensible death. Make it fail in a sensible way. +Upstream-Status: Inappropriate [oe-specific] + Signed-off-by: Paul Gortmaker <[email protected]> ---
meta/recipes-devtools/guilt/files/guilt-push.patch +2 -0
@@ -2,6 +2,8 @@ guilt: add support for pushing and tagging It can be handy to push AND tag at the same time. +Upstream-Status: Inappropriate [oe-specific] + Signed-off-by: Bruce Ashfield <[email protected]> ---
meta/recipes-devtools/guilt/files/guilt-set-git_exec_path.patch +2 -0
@@ -8,6 +8,8 @@ guilt be in the same directory to ensure they are matched, so we use the environment variable GIT_EXEC_PATH to force the issue. +Upstream-Status: Inappropriate [oe-specific] + Signed-off-by: Bruce Ashfield <[email protected]> ---
meta/recipes-devtools/guilt/files/guilt.patch +2 -0
@@ -12,6 +12,8 @@ This change does three things: - enhances the header detection and creation of patches as they are pushed onto the tree. +Upstream-Status: Inappropriate [oe-specific] + Signed-off-by: Bruce Ashfield <[email protected]> ---
meta/recipes-devtools/guilt/files/improve_auto_header_gen.patch +2 -0
@@ -4,6 +4,8 @@ Patches that do not have a proper header are encountered when generating a tree. This improves the detection of these patches and generates a sane header so the eventual commit will be coherent +Upstream-Status: Inappropriate [oe-specific] + Signed-off-by: Bruce Ashfield <[email protected]> ---
meta/recipes-devtools/guilt/files/make_git_commands_conditional.patch +2 -0
@@ -5,6 +5,8 @@ Some of the git commands that are always called will report errors unecesarility in this scenario. This adds a variable that will inhibit those problematic calls +Upstream-Status: Inappropriate [oe-specific] + Signed-off-by <[email protected]> ---
meta/recipes-devtools/guilt/files/optional_head_check.patch +2 -0
@@ -25,6 +25,8 @@ Other modes such as pop or refresh can run into problems when the HEAD commit isn't tracked or expected, so they should remained checked. +Upstream-Status: Inappropriate [oe-specific] + Signed-off-by: Bruce Ashfield <[email protected]> ---
meta/recipes-devtools/guilt/files/uninstall_force.patch +2 -0
@@ -1,5 +1,7 @@ guilt: force removal when uninstalling +Upstream-Status: Inappropriate [oe-specific] + Signed-off-by: Bruce Ashfield <[email protected]> --- a/uninstall.orig
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 24/28] udev: remove commented code from init script (no code changes)
In reply to Saul WoldFrom: Otavio Salvador <[email protected]>
--- meta/recipes-core/udev/udev.inc | 12 ------------ 1 files changed, 0 insertions(+), 12 deletions(-)
meta/recipes-core/udev/udev.inc +0 -12
@@ -75,18 +75,6 @@ do_install_append () { install -d ${D}${sysconfdir}/udev/rules.d/ install -m 0644 ${WORKDIR}/local.rules ${D}${sysconfdir}/udev/rules.d/local.rules - #install -m 0644 ${WORKDIR}/permissions.rules ${D}${sysconfdir}/udev/rules.d/permissions.rules - #install -m 0644 ${WORKDIR}/run.rules ${D}${sysconfdir}/udev/rules.d/run.rules - #install -m 0644 ${WORKDIR}/udev.rules ${D}${sysconfdir}/udev/rules.d/udev.rules - #install -m 0644 ${WORKDIR}/links.conf ${D}${sysconfdir}/udev/links.conf - #if [ "${UDEV_DEVFS_RULES}" = "1" ]; then - # install -m 0644 ${WORKDIR}/devfs-udev.rules ${D}${sysconfdir}/udev/rules.d/devfs-udev.rules - #fi - - # Remove some default rules that don't work well on embedded devices - #rm ${D}${libexecdir}/rules.d/60-persistent-input.rules - #rm ${D}${libexecdir}/rules.d/60-persistent-storage.rules - #rm ${D}${libexecdir}/rules.d/60-persistent-storage-tape.rules install -d ${D}${sysconfdir}/udev/scripts/
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 27/28] util-linux: Update patch for non-GPLv3
In reply to Saul Wold--- .../util-linux-2.20.1/remove-lscpu.patch | 94 +------------------ 1 files changed, 5 insertions(+), 89 deletions(-)
meta/recipes-core/util-linux/util-linux-2.20.1/remove-lscpu.patch +5 -89
@@ -6,104 +6,20 @@ Take out lscpu stuff from the code Saul Wold <[email protected]> Nitin A Kamble <[email protected]> -Index: util-linux-2.19.1/sys-utils/Makefile.am +Index: util-linux-2.20.1/sys-utils/Makefile.am =================================================================== ---- util-linux-2.19.1.orig/sys-utils/Makefile.am 2011-04-05 03:43:02.000000000 -0700 -+++ util-linux-2.19.1/sys-utils/Makefile.am 2011-06-29 12:08:24.187440334 -0700 -@@ -17,12 +17,6 @@ +--- util-linux-2.20.1.orig/sys-utils/Makefile.am ++++ util-linux-2.20.1/sys-utils/Makefile.am +@@ -17,12 +17,6 @@ usrsbin_exec_PROGRAMS += ldattach tunelp dist_man_MANS += dmesg.1 ctrlaltdel.8 cytune.8 setarch.8 \ ldattach.8 tunelp.8 rtcwake.8 fsfreeze.8 fstrim.8 -if HAVE_CPU_SET_T -usrbin_exec_PROGRAMS += lscpu --lscpu_SOURCES = lscpu.c $(top_srcdir)/lib/cpuset.c +-lscpu_SOURCES = lscpu.c $(top_srcdir)/lib/cpuset.c $(top_srcdir)/lib/strutils.c -dist_man_MANS += lscpu.1 -endif - endif cytune_SOURCES = cytune.c cyclades.h -Index: util-linux-2.19.1/sys-utils/Makefile.in -=================================================================== ---- util-linux-2.19.1.orig/sys-utils/Makefile.in 2011-05-02 02:49:19.000000000 -0700 -+++ util-linux-2.19.1/sys-utils/Makefile.in 2011-06-29 12:10:47.647440371 -0700 -@@ -51,8 +51,6 @@ - @LINUX_TRUE@am__append_5 = dmesg.1 ctrlaltdel.8 cytune.8 setarch.8 \ - @LINUX_TRUE@ ldattach.8 tunelp.8 rtcwake.8 fsfreeze.8 fstrim.8 - --@HAVE_CPU_SET_T_TRUE@@LINUX_TRUE@am__append_6 = lscpu --@HAVE_CPU_SET_T_TRUE@@LINUX_TRUE@am__append_7 = lscpu.1 - @BUILD_FALLOCATE_TRUE@am__append_8 = fallocate - @BUILD_FALLOCATE_TRUE@am__append_9 = fallocate.1 - @BUILD_PIVOT_ROOT_TRUE@am__append_10 = pivot_root -@@ -98,7 +96,6 @@ - @BUILD_PIVOT_ROOT_TRUE@am__EXEEXT_4 = pivot_root$(EXEEXT) - @BUILD_SWITCH_ROOT_TRUE@am__EXEEXT_5 = switch_root$(EXEEXT) - @LINUX_TRUE@am__EXEEXT_6 = cytune$(EXEEXT) setarch$(EXEEXT) --@HAVE_CPU_SET_T_TRUE@@LINUX_TRUE@am__EXEEXT_7 = lscpu$(EXEEXT) - @BUILD_FALLOCATE_TRUE@am__EXEEXT_8 = fallocate$(EXEEXT) - @BUILD_UNSHARE_TRUE@am__EXEEXT_9 = unshare$(EXEEXT) - @LINUX_TRUE@am__EXEEXT_10 = ldattach$(EXEEXT) tunelp$(EXEEXT) \ -@@ -146,11 +143,6 @@ - ldattach_SOURCES = ldattach.c - ldattach_OBJECTS = ldattach.$(OBJEXT) - ldattach_LDADD = $(LDADD) --am__lscpu_SOURCES_DIST = lscpu.c $(top_srcdir)/lib/cpuset.c --@HAVE_CPU_SET_T_TRUE@@LINUX_TRUE@am_lscpu_OBJECTS = lscpu.$(OBJEXT) \ --@HAVE_CPU_SET_T_TRUE@@LINUX_TRUE@ cpuset.$(OBJEXT) --lscpu_OBJECTS = $(am_lscpu_OBJECTS) --lscpu_LDADD = $(LDADD) - pivot_root_SOURCES = pivot_root.c - pivot_root_OBJECTS = pivot_root.$(OBJEXT) - pivot_root_LDADD = $(LDADD) -@@ -206,13 +198,13 @@ - am__v_GEN_0 = @echo " GEN " $@; - SOURCES = arch.c ctrlaltdel.c $(cytune_SOURCES) $(dmesg_SOURCES) \ - $(fallocate_SOURCES) flock.c fsfreeze.c $(fstrim_SOURCES) \ -- ipcmk.c ipcrm.c ipcs.c ldattach.c $(lscpu_SOURCES) \ -+ ipcmk.c ipcrm.c ipcs.c ldattach.c \ - pivot_root.c readprofile.c renice.c $(rtcwake_SOURCES) \ - setarch.c setsid.c switch_root.c $(tunelp_SOURCES) unshare.c - DIST_SOURCES = arch.c ctrlaltdel.c $(cytune_SOURCES) $(dmesg_SOURCES) \ - $(am__fallocate_SOURCES_DIST) flock.c fsfreeze.c \ - $(fstrim_SOURCES) ipcmk.c ipcrm.c ipcs.c ldattach.c \ -- $(am__lscpu_SOURCES_DIST) pivot_root.c readprofile.c renice.c \ -+ pivot_root.c readprofile.c renice.c \ - $(rtcwake_SOURCES) setarch.c setsid.c switch_root.c \ - $(tunelp_SOURCES) unshare.c - am__vpath_adj_setup = srcdirstrip=`echo "$(srcdir)" | sed 's|.|.|g'`; -@@ -242,7 +234,7 @@ - MANS = $(dist_man_MANS) $(man_MANS) - am__dist_noinst_DATA_DIST = flock.1 ipcrm.1 ipcs.1 ipcmk.1 renice.1 \ - setsid.1 readprofile.1 dmesg.1 ctrlaltdel.8 cytune.8 setarch.8 \ -- ldattach.8 tunelp.8 rtcwake.8 fsfreeze.8 fstrim.8 lscpu.1 \ -+ ldattach.8 tunelp.8 rtcwake.8 fsfreeze.8 fstrim.8 \ - fallocate.1 pivot_root.8 switch_root.8 unshare.1 arch.1 - DATA = $(dist_noinst_DATA) - ETAGS = etags -@@ -438,7 +430,6 @@ - readprofile.1 $(am__append_5) $(am__append_7) $(am__append_9) \ - $(am__append_11) $(am__append_13) $(am__append_15) \ - $(am__append_17) --@HAVE_CPU_SET_T_TRUE@@LINUX_TRUE@lscpu_SOURCES = lscpu.c $(top_srcdir)/lib/cpuset.c - cytune_SOURCES = cytune.c cyclades.h - tunelp_SOURCES = tunelp.c lp.h - fstrim_SOURCES = fstrim.c $(top_srcdir)/lib/strutils.c -@@ -693,9 +684,6 @@ - ldattach$(EXEEXT): $(ldattach_OBJECTS) $(ldattach_DEPENDENCIES) - @rm -f ldattach$(EXEEXT) - $(AM_V_CCLD)$(LINK) $(ldattach_OBJECTS) $(ldattach_LDADD) $(LIBS) --lscpu$(EXEEXT): $(lscpu_OBJECTS) $(lscpu_DEPENDENCIES) -- @rm -f lscpu$(EXEEXT) -- $(AM_V_CCLD)$(LINK) $(lscpu_OBJECTS) $(lscpu_LDADD) $(LIBS) - pivot_root$(EXEEXT): $(pivot_root_OBJECTS) $(pivot_root_DEPENDENCIES) - @rm -f pivot_root$(EXEEXT) - $(AM_V_CCLD)$(LINK) $(pivot_root_OBJECTS) $(pivot_root_LDADD) $(LIBS) -@@ -743,7 +731,6 @@ - @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/ipcrm.Po@am__quote@ - @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/ipcs.Po@am__quote@ - @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/ldattach.Po@am__quote@ --@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/lscpu.Po@am__quote@ - @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pivot_root.Po@am__quote@ - @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/readprofile.Po@am__quote@ - @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/renice.Po@am__quote@
Signature · 1 line
1.7.6.4
[CONSOLIDATED PULL 26/28] matchbox-wm: Remove x-session-manager handling
In reply to Saul WoldFrom: Zhai Edwin <[email protected]>
Windows manager should be independent on session manager, especially when we have multiple session manager like mini-x and matchbox session.
This commit remove session-manager stuff in matchbox-wm, as matchbox-session already has duplicated code. Also adjust alternative priority for mini-X to make it higher priority over matchbox-session.
--- .../matchbox-wm/matchbox-wm_1.2.bb | 9 ++------- .../matchbox-wm/matchbox-wm_git.bb | 9 ++------- .../mini-x-session/mini-x-session_0.1.bb | 2 +- 3 files changed, 5 insertions(+), 15 deletions(-)
meta/recipes-graphics/matchbox-wm/matchbox-wm_1.2.bb +2 -7
@@ -2,7 +2,7 @@ SECTION = "x11/wm" DESCRIPTION = "Matchbox window manager" LICENSE = "GPLv2.0+" DEPENDS = "libmatchbox virtual/libx11 libxext libxcomposite libxfixes xdamage libxrender startup-notification expat" -PR = "r4" +PR = "r5" SRC_URI = "http://matchbox-project.org/sources/matchbox-window-manager/1.2/matchbox-window-manager-${PV}.tar.bz2 \ file://configure_fix.patch \
@@ -11,7 +11,7 @@ SRC_URI = "http://matchbox-project.org/sources/matchbox-window-manager/1.2/match S = "${WORKDIR}/matchbox-window-manager-${PV}" -inherit autotools pkgconfig update-alternatives +inherit autotools pkgconfig FILES_${PN} = "${bindir}/* \ ${datadir}/matchbox \
@@ -20,11 +20,6 @@ FILES_${PN} = "${bindir}/* \ ${datadir}/themes/Default/matchbox \ ${datadir}/themes/MBOpus/matchbox" -ALTERNATIVE_NAME = "x-session-manager" -ALTERNATIVE_LINK = "${bindir}/x-session-manager" -ALTERNATIVE_PATH = "${bindir}/matchbox-session" -ALTERNATIVE_PRIORITY = "10" - EXTRA_OECONF = " --enable-startup-notification \ --disable-xrm \ --enable-expat \
meta/recipes-graphics/matchbox-wm/matchbox-wm_git.bb +2 -7
@@ -12,7 +12,7 @@ DEPENDS = "libmatchbox virtual/libx11 libxext libxrender startup-notification ex SRCREV = "f4394eaed475de6e627d373c5b35ee2cf87072e3" PV = "1.2+git${SRCPV}" -PR = "r0" +PR = "r1" SRC_URI = "git://git.yoctoproject.org/matchbox-window-manager;protocol=git \ file://configure_fix.patch;maxrev=1818 \
@@ -20,12 +20,7 @@ SRC_URI = "git://git.yoctoproject.org/matchbox-window-manager;protocol=git \ S = "${WORKDIR}/git" -inherit autotools pkgconfig update-alternatives - -ALTERNATIVE_NAME = "x-session-manager" -ALTERNATIVE_LINK = "${bindir}/x-session-manager" -ALTERNATIVE_PATH = "${bindir}/matchbox-session" -ALTERNATIVE_PRIORITY = "10" +inherit autotools pkgconfig FILES_${PN} = "${bindir}/* \ ${datadir}/matchbox \
meta/recipes-graphics/mini-x-session/mini-x-session_0.1.bb +1 -1
@@ -16,7 +16,7 @@ inherit update-alternatives ALTERNATIVE_NAME = "x-session-manager" ALTERNATIVE_LINK = "${bindir}/x-session-manager" ALTERNATIVE_PATH = "${bindir}/mini-x-session" -ALTERNATIVE_PRIORITY = "10" +ALTERNATIVE_PRIORITY = "50" do_install() { install -d ${D}/${bindir}
Signature · 1 line
1.7.6.4
Re: [CONSOLIDATED PULL 26/28] matchbox-wm: Remove x-session-manager handling
meta/recipes-graphics/mini-x-session/mini-x-session_0.1.bb inherit update-alternatives · line 22
Quoted 13 lines · Saul Wold
meta/recipes-graphics/mini-x-session/mini-x-session_0.1.bb +1
-1@@ -16,7 +16,7 @@ inherit update-alternatives ALTERNATIVE_NAME = "x-session-manager" ALTERNATIVE_LINK = "${bindir}/x-session-manager" ALTERNATIVE_PATH = "${bindir}/mini-x-session" -ALTERNATIVE_PRIORITY = "10" +ALTERNATIVE_PRIORITY = "50" do_install() { install -d ${D}/${bindir}
This change is not mentioned in the commit summary line. It isn't at all obvious to me that this particular change is actually a desirable one but, if it is, it belongs in a separate patch rather than being jammed in with the matchbox-wm stuff.
p.
[CONSOLIDATED PULL 28/28] gnutls: remove gettext patch for non-GPLv3
In reply to Saul Wold--- meta/recipes-support/gnutls/gnutls_2.12.14.bb | 13 ++++++++++--- 1 files changed, 10 insertions(+), 3 deletions(-)
meta/recipes-support/gnutls/gnutls_2.12.14.bb +10 -3
@@ -1,10 +1,17 @@ require gnutls.inc -PR = "${INC_PR}.3" +PR = "${INC_PR}.4" SRC_URI += "file://gnutls-openssl.patch \ - file://configure-fix.patch \ - file://fix-gettext-version.patch" + file://configure-fix.patch" + +python() { + if not ((d.getVar("INCOMPATIBLE_LICENSE", True) or "").find("GPLv3") != -1): + # if GPLv3 add patch + src_uri = (d.getVar("SRC_URI", False) or "").split() + src_uri.append("file://fix-gettext-version.patch") + d.setVar("SRC_URI", " ".join(src_uri)) +} SRC_URI[md5sum] = "555687a7ffefba0bd9de1e71cb61402c" SRC_URI[sha256sum] = "5ee72ba6de7a23cf315792561954451e022dac8730149ca95f93c61e95be2ce3"
Signature · 1 line
1.7.6.4
Quoted 19 lines · Saul Wold
Richard,
This is a set of changes that have been built and booted for sato. This address the failure we have seen on the Autobuilder, please check the
master_under_testbuild currenly building.We have another kernel update from Bruce, with the sanity checks from Scott G. along with other change from the community. The matchbox changes make sense based on a better explaination from Edwin.
Please review overall, but I am positive about this change set.
Sau!
The following changes since commit
f309769d10cb3d8b72b8c7c4f7f418dcb8422c61:valgrind: Fix for automake update (2012-01-04 16:03:59 +0000)
Quoted 8 lines
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contribsgw/stage
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=sgw/stageBruce Ashfield (3):
kern-tools: import flexible branching support
linux-yocto: bump kernel version to v3.0.14
linux-yocto: usesrc_patchesfor out of tree kernel feature support
These look related to the failures on the autobuilder so I didn't take them.
Quoted 5 lines
Christopher Larson (1):
opkg-utils: use/usr/bin/envpythonDerek Buitenhuis (2):
binutils-cross-canadian: Allow ld-is-gold
I took these.
Quoted 1 line
binutils: Allow plugins
I'm sceptical about this. Does this really need to be a distro feature?
Quoted 2 lines
Gary Thomas (1):
xserver-kdrive: work around issues with -Werror=address
I've taken this.
Quoted 3 lines
Joshua Lock (2):
alsa-state: add alsa-state from oe classic
task-base: add alsa-state to task-base-alsa
I've held off this at this time, likely will take it next time around.
Quoted 8 lines
Otavio Salvador (3):
udev: use 'echo' instead of 'echo -n' in init script
udev: split utilities onto udev-utils
udev: remove commented code from init script (no code changes)Phil Blundell (1):
python-native: correct prefix handling for oe-core sysroot layout
Quoted 6 lines
Saul Wold (6):
image_types: Fix rootfs size calcuation
glib-2.0: ensure dtrace is diabled for all distro options and fix
packaging
libxp: fix cast error
Patch Upstream-Status Update
I took these.
Quoted 2 lines
util-linux: Update patch for non-GPLv3
gnutls: remove gettext patch for non-GPLv3
These are one line commit descriptions which tell me very little. Please improve the patch descriptions.
Quoted 11 lines
Scott Garman (7):
ncurses: move libraries tobase_libdir
libcap: move library tobase_libdir
util-linux: move libraries tobase_libdir
e2fsprogs: move libraries tobase_libdir
libusb1: move libraries tobase_libdir
libusb-compat: move libraries tobase_libdirinsane.bbclass: add QA tests for unsafe references toexec_prefixZhai Edwin (1):
matchbox-wm: Remove x-session-manager handling
I took these.
Quoted 3 lines
Zhenhua Luo (1):
linux-dtb: add multi-dtb build support and keep dtb in deploy cache
package
This looks like it should be done in do_deploy and doesn't fix the real problem just adding some races in.
Cheers,
Richard
Quoted 24 lines · Richard Purdie
Quoted 23 lines · Saul Wold
Richard,
This is a set of changes that have been built and booted for sato. This address the failure we have seen on the Autobuilder, please check the
master_under_testbuild currenly building.We have another kernel update from Bruce, with the sanity checks from Scott G. along with other change from the community. The matchbox changes make sense based on a better explaination from Edwin.
Please review overall, but I am positive about this change set.
Sau!
The following changes since commit
f309769d10cb3d8b72b8c7c4f7f418dcb8422c61:valgrind: Fix for automake update (2012-01-04 16:03:59 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contribsgw/stage
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=sgw/stage
Quoted 7 lines
Quoted 4 lines
Bruce Ashfield (3):
kern-tools: import flexible branching support
linux-yocto: bump kernel version to v3.0.14
linux-yocto: usesrc_patchesfor out of tree kernel feature supportThese look related to the failures on the autobuilder so I didn't take them.
The first one should fix errors with the the intel BSPs, I checked the autobuilder
status, but didn't see the linux-yocto failures. Does someone have a link ?
The second two shouldn't have impacted anything, but I'll have a look if there's a link to share.
Cheers,
Bruce
Quoted 79 lines
Quoted 6 lines
Christopher Larson (1):
opkg-utils: use/usr/bin/envpythonDerek Buitenhuis (2):
binutils-cross-canadian: Allow ld-is-goldI took these.
Quoted 1 line
binutils: Allow plugins
I'm sceptical about this. Does this really need to be a distro feature?
Quoted 2 lines
Gary Thomas (1):
xserver-kdrive: work around issues with -Werror=addressI've taken this.
Quoted 3 lines
Joshua Lock (2):
alsa-state: add alsa-state from oe classic
task-base: add alsa-state to task-base-alsaI've held off this at this time, likely will take it next time around.
Quoted 8 lines
Otavio Salvador (3):
udev: use 'echo' instead of 'echo -n' in init script
udev: split utilities onto udev-utils
udev: remove commented code from init script (no code changes)Phil Blundell (1):
python-native: correct prefix handling for oe-core sysroot layoutQuoted 6 lines
Saul Wold (6):
image_types: Fix rootfs size calcuation
glib-2.0: ensure dtrace is diabled for all distro options and fix packaging
libxp: fix cast error
Patch Upstream-Status UpdateI took these.
Quoted 2 lines
util-linux: Update patch for non-GPLv3
gnutls: remove gettext patch for non-GPLv3These are one line commit descriptions which tell me very little. Please improve the patch descriptions.
Quoted 11 lines
Scott Garman (7):
ncurses: move libraries tobase_libdir
libcap: move library tobase_libdir
util-linux: move libraries tobase_libdir
e2fsprogs: move libraries tobase_libdir
libusb1: move libraries tobase_libdir
libusb-compat: move libraries tobase_libdirinsane.bbclass: add QA tests for unsafe references toexec_prefixZhai Edwin (1):
matchbox-wm: Remove x-session-manager handlingI took these.
Quoted 3 lines
Zhenhua Luo (1):
linux-dtb: add multi-dtb build support and keep dtb in deploy cache packageThis looks like it should be done in
do_deployand doesn't fix the real problem just adding some races in.Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"
Quoted 34 lines · Bruce Ashfield
Quoted 24 lines · Richard Purdie
Quoted 23 lines · Saul Wold
Richard,
This is a set of changes that have been built and booted for sato. This address the failure we have seen on the Autobuilder, please check the
master_under_testbuild currenly building.We have another kernel update from Bruce, with the sanity checks from Scott G. along with other change from the community. The matchbox changes make sense based on a better explaination from Edwin.
Please review overall, but I am positive about this change set.
Sau!
The following changes since commit
f309769d10cb3d8b72b8c7c4f7f418dcb8422c61:valgrind: Fix for automake update (2012-01-04 16:03:59 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contribsgw/stage
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=sgw/stageQuoted 7 lines
Quoted 4 lines
Bruce Ashfield (3):
kern-tools: import flexible branching support
linux-yocto: bump kernel version to v3.0.14
linux-yocto: usesrc_patchesfor out of tree kernel feature supportThese look related to the failures on the autobuilder so I didn't take them.
Quoted 6 lines
The first one should fix errors with the the intel BSPs, I checked the autobuilder
status, but didn't see the linux-yocto failures. Does someone have a link ?The second two shouldn't have impacted anything, but I'll have a look if there's a link to share.
http://autobuilder.pokylinux.org:8010/builders/nightly-ppc/builds/210/steps/shell_67/logs/stdio
http://autobuilder.pokylinux.org:8010/builders/nightly-arm/builds/247/steps/shell_14/logs/stdio
Cheers,
Richard
Quoted 39 lines · Richard Purdie
Quoted 38 lines · Bruce Ashfield
Quoted 24 lines · Richard Purdie
Quoted 23 lines · Saul Wold
Richard,
This is a set of changes that have been built and booted for sato. This address the failure we have seen on the Autobuilder, please check the
master_under_testbuild currenly building.We have another kernel update from Bruce, with the sanity checks from Scott G. along with other change from the community. The matchbox changes make sense based on a better explaination from Edwin.
Please review overall, but I am positive about this change set.
Sau!
The following changes since commit
f309769d10cb3d8b72b8c7c4f7f418dcb8422c61:valgrind: Fix for automake update (2012-01-04 16:03:59 +0000)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contribsgw/stage
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=sgw/stageQuoted 7 lines
Quoted 4 lines
Bruce Ashfield (3):
kern-tools: import flexible branching support
linux-yocto: bump kernel version to v3.0.14
linux-yocto: usesrc_patchesfor out of tree kernel feature supportThese look related to the failures on the autobuilder so I didn't take them.
The first one should fix errors with the the intel BSPs, I checked the autobuilder
status, but didn't see the linux-yocto failures. Does someone have a link ?
Quoted 5 lines
Quoted 2 lines
The second two shouldn't have impacted anything, but I'll have a look if there's a link to share.
http://autobuilder.pokylinux.org:8010/builders/nightly-ppc/builds/210/steps/shell_67/logs/stdio
http://autobuilder.pokylinux.org:8010/builders/nightly-arm/builds/247/steps/shell_14/logs/stdio
Aha! Indeed. The strict patch checking kicked in and caught a latent missing cleanup.
I'll send a meta branch patch that fixes that shortly. The series will be valid with that
stacked on top.
Cheers,
Bruce
Quoted 10 lines
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"
Quoted 6 lines · Richard Purdie
Quoted 3 lines
Zhenhua Luo (1):
linux-dtb: add multi-dtb build support and keep dtb in deploy cache packageThis looks like it should be done in
do_deployand doesn't fix the real problem just adding some races in.
Can you add a bit more info here? Should we be building all the device trees in do_deploy? What races are added?
-M
Quoted 11 lines · On Thu, 2012-01-05 at 15:57 +0000, McClintock Matthew-B29882 wrote:
Quoted 6 lines · Richard Purdie
Quoted 3 lines
Zhenhua Luo (1):
linux-dtb: add multi-dtb build support and keep dtb in deploy cache
packageThis looks like it should be done in
do_deployand doesn't fix the real problem just adding some races in.Can you add a bit more info here? Should we be building all the device trees in
do_deploy? What races are added?
I guess what I'm asking is why this isn't happening in kernel_do_deploy (with an append) and installing the files into ${DEPLOYDIR}? It seems to be appending to do_install instead and this confuses the purposes of the different tasks.
If the files were placed into ${DEPLOYDIR} as part of do_deploy, things would be much more consistent.
Cheers,
Richard
Quoted 20 lines
-----Original Message-----
From: [email protected] [mailto:openembedded- [email protected]] On Behalf Of Richard Purdie
Sent: Friday, January 06, 2012 6:16 AM
To: McClintock Matthew-B29882; Patches and discussions about the oe-core layer
Subject: Re: [OE-core] [CONSOLIDATED PULL 00/28] Build Fixes and UpdatesQuoted 11 lines · On Thu, 2012-01-05 at 15:57 +0000, McClintock Matthew-B29882 wrote:
Quoted 6 lines · Richard Purdie
Quoted 3 lines
Zhenhua Luo (1):
linux-dtb: add multi-dtb build support and keep dtb in deploy cache
packageThis looks like it should be done in
do_deployand doesn't fix the real problem just adding some races in.Can you add a bit more info here? Should we be building all the device trees in
do_deploy? What races are added?
Quoted 6 lines
I guess what I'm asking is why this isn't happening in
kernel_do_deploy(with an append) and installing the files into ${DEPLOYDIR}? It seems to be appending todo_installinstead and this confuses the purposes of the different tasks.If the files were placed into ${DEPLOYDIR} as part of
do_deploy, things would be much more consistent.
[Luo Zhenhua-B19537] I think you point is to merge do_install_append and do_deploy_append to do_deploy_append, right?
Best Regards,
Zhenhua