Skip to contentSkip to conversation

arm, davinci: Add support for the Calimain board from OMICRON electronics

PATCH New Christian Riesch 3 participants 4 messages Jan 10, 2012 – Jan 11, 2012

lore
Share & tools
lore

Christian Riesch

author
#0 lore raw

PATCH 1/1 arm, davinci: Add support for the Calimain board from OMICRON electronics

This patch adds support for the Calimain board from
OMICRON electronics GmbH. The board features a Texas Instruments AM1808 SoC, 128 MB DDR2 memory, and 64 MB NOR flash memory connected to CS2 and CS3.

Signed-off-by Christian Riesch <[email protected]>
---
 MAINTAINERS                       |    5 +
 board/omicron/calimain/Makefile   |   45 +++++
 board/omicron/calimain/calimain.c |  201 ++++++++++++++++++++
 boards.cfg                        |    1 +
 include/configs/calimain.h        |  364 +++++++++++++++++++++++++++++++++++++
 5 files changed, 616 insertions(+), 0 deletions(-)
 create mode 100644 board/omicron/calimain/Makefile
 create mode 100644 board/omicron/calimain/calimain.c
 create mode 100644 include/configs/calimain.h
MAINTAINERS +5 -0
index c79283f..25d7a95 100644
@@ -792,6 +792,11 @@ Thierry Reding <[email protected]>
 	plutux		Tegra2 (ARM7 & A9 Dual Core)
 	medcom		Tegra2 (ARM7 & A9 Dual Core)
 
+Christian Riesch <[email protected]>
+Manfred Rudigier <[email protected]>
+
+	calimain	ARM926EJS (AM1808 SoC)
+
 Tom Rini <[email protected]>
 
 	omap3_evm	ARM ARMV7 (OMAP3xx SoC)
board/omicron/calimain/Makefile new file +45 -0

45 lines not on this page · raw message

board/omicron/calimain/calimain.c new file +201 -0

201 lines not on this page · raw message

boards.cfg +1 -0
index da1a3ce..d0d046b 100644
@@ -136,6 +136,7 @@ hawkboard                    arm         arm926ejs   da8xxevm            davinci
 hawkboard_nand               arm         arm926ejs   da8xxevm            davinci        davinci     hawkboard:NAND_U_BOOT
 hawkboard_uart               arm         arm926ejs   da8xxevm            davinci        davinci     hawkboard:UART_U_BOOT
 enbw_cmc                     arm         arm926ejs   enbw_cmc            enbw           davinci
+calimain                     arm         arm926ejs   calimain            omicron        davinci
 km_kirkwood                  arm         arm926ejs   km_arm              keymile        kirkwood	km_kirkwood:KM_DISABLE_PCI
 km_kirkwood_pci              arm         arm926ejs   km_arm              keymile        kirkwood	km_kirkwood:KM_RECONFIG_XLX
 mgcoge3un                    arm         arm926ejs   km_arm              keymile        kirkwood
include/configs/calimain.h new file +364 -0

364 lines not on this page · raw message

Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 arm, davinci: Add support for the Calimain board from OMICRON electronics

Quoted 6 lines · Christian Riesch

This patch adds support for the Calimain board from
OMICRON electronics GmbH. The board features a Texas Instruments AM1808 SoC, 128 MB DDR2 memory, and 64 MB NOR flash memory connected to CS2 and CS3.

Signed-off-by Christian Riesch <[email protected]>

[snip]

Quoted 1 line

+#define CONFIG_NET_MULTI

No longer used. Since there's one no longer used CONFIG variable can you please audit for others and then v2? Otherwise looks fine to me. Thanks.

Signature · 1 line
Tom
#2 lore raw

PATCH 1/1 arm, davinci: Add support for the Calimain board from OMICRON electronics

In reply to Christian Riesch

Hello Christian,

Quoted 6 lines · Christian Riesch

This patch adds support for the Calimain board from
OMICRON electronics GmbH. The board features a Texas Instruments AM1808 SoC, 128 MB DDR2 memory, and 64 MB NOR flash memory connected to CS2 and CS3.

Signed-off-by Christian Riesch <[email protected]>
Quoted 10 lines
---
 MAINTAINERS                       |    5 +
 board/omicron/calimain/Makefile   |   45 +++++
 board/omicron/calimain/calimain.c |  201 ++++++++++++++++++++
 boards.cfg                        |    1 +
 include/configs/calimain.h        |  364 +++++++++++++++++++++++++++++++++++++
 5 files changed, 616 insertions(+), 0 deletions(-)
 create mode 100644 board/omicron/calimain/Makefile
 create mode 100644 board/omicron/calimain/calimain.c
 create mode 100644 include/configs/calimain.h

just one comment, see below

[...]

Quoted 6 lines
board/omicron/calimain/calimain.c new file +0 -0
new file mode 100644
index 0000000..b2f2d96
@@ -0,0 +1,201 @@

[...]

board/omicron/calimain/calimain.c line 122

Quoted 13 lines
board/omicron/calimain/calimain.c new file +13 -0
+int board_early_init_f(void)
+{
+	/*
+	 * Power on required peripherals
+	 * ARM does not have access by default to PSC0 and PSC1
+	 * assuming here that the DSP bootloader has set the IOPU
+	 * such that PSC access is available to ARM
+	 */
+	if (da8xx_configure_lpsc_items(lpsc, ARRAY_SIZE(lpsc)))
+		return 1;
+
+	return 0;
+}

Please look at my comment to the patch from Sughosh here:

http://lists.denx.de/pipermail/u-boot/2012-January/115312.html

da8xx_configure_lpsc_items() should used in
arch/arm/cpu/arm926ejs/davinci/da850_lowlevel.c

so you can remove this here ... Maybe you can have a look at this patch too?

Rest looks good to me, thanks!

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
author
#3 lore raw

PATCH 1/1 arm, davinci: Add support for the Calimain board from OMICRON electronics

Hello Heiko,

Quoted 9 lines · Heiko Schocher

Hello Christian,

Quoted 6 lines · Christian Riesch

This patch adds support for the Calimain board from
OMICRON electronics GmbH. The board features a Texas Instruments AM1808 SoC, 128 MB DDR2 memory, and 64 MB NOR flash memory connected to CS2 and CS3.

Signed-off-by Christian Riesch <[email protected]>

[....]

Quoted 9 lines

Please look at my comment to the patch from Sughosh here:

http://lists.denx.de/pipermail/u-boot/2012-January/115312.html

da8xx_configure_lpsc_items() should used in
arch/arm/cpu/arm926ejs/davinci/da850_lowlevel.c

so you can remove this here ... Maybe you can have a look at this patch too?

Yes, I'll wait for v3 of Sughosh's patch and then resubmit. Regards, Christian