add new board vl_ma2sc

PATCH New Jens Scharsig 4 participants 7 messages Jan 16, 2012 – Jul 7, 2012

Share & tools

Jens Scharsig

author

2012-01-16 07:41 UTC #0 lore raw

PATCH 1/1 add new board vl_ma2sc

* add support for board VL+MA2SC
* adds vl_ma2sc_config for standard NOR boot configuration
* adds vl_ma2sc_ram_config for RAM load configuration

Signed-off-by Jens Scharsig <[email protected]>

---
 MAINTAINERS                   |    1 +
 board/BuS/vl_ma2sc/Makefile   |   54 ++++
 board/BuS/vl_ma2sc/vl_ma2sc.c |  596 +++++++++++++++++++++++++++++++++++++++++
 boards.cfg                    |    2 +
 include/configs/vl_ma2sc.h    |  466 ++++++++++++++++++++++++++++++++
 5 files changed, 1119 insertions(+), 0 deletions(-)
 create mode 100644 board/BuS/vl_ma2sc/Makefile
 create mode 100644 board/BuS/vl_ma2sc/vl_ma2sc.c
 create mode 100644 include/configs/vl_ma2sc.h

MAINTAINERS +1 -0

index a5b728e..12047fc 100644
@@ -819,6 +819,7 @@ Steve Sakoman <[email protected]>
 Jens Scharsig <[email protected]>
 
 	eb_cpux9k2	ARM920T (AT91RM9200 SoC)
+	vl_ma2sc	ARM926EJS (AT91SAM9263 SoC)
 
 Heiko Schocher <[email protected]>

board/BuS/vl_ma2sc/Makefile new file +54 -0

54 lines not on this page · raw message

board/BuS/vl_ma2sc/vl_ma2sc.c new file +596 -0

596 lines not on this page · raw message

boards.cfg +2 -0

index 576b392..2f7211f 100644
@@ -94,6 +94,8 @@ at91sam9xeek_dataflash_cs1   arm         arm926ejs   at91sam9260ek       atmel
 at91sam9xeek_nandflash       arm         arm926ejs   at91sam9260ek       atmel          at91        at91sam9260ek:AT91SAM9XE,SYS_USE_NANDFLASH
 snapper9260                  arm         arm926ejs   -                   bluewater      at91        snapper9260:AT91SAM9260
 snapper9g20                  arm         arm926ejs   snapper9260         bluewater      at91        snapper9260:AT91SAM9G20
+vl_ma2sc                     arm         arm926ejs   vl_ma2sc            BuS            at91
+vl_ma2sc_ram                 arm         arm926ejs   vl_ma2sc            BuS            at91        vl_ma2sc:RAMLOAD
 sbc35_a9g20_eeprom           arm         arm926ejs   sbc35_a9g20         calao          at91        sbc35_a9g20:AT91SAM9G20,SYS_USE_EEPROM
 sbc35_a9g20_nandflash        arm         arm926ejs   sbc35_a9g20         calao          at91        sbc35_a9g20:AT91SAM9G20,SYS_USE_NANDFLASH
 tny_a9260_eeprom             arm         arm926ejs   tny_a9260           calao          at91        tny_a9260:AT91SAM9260,SYS_USE_EEPROM

include/configs/vl_ma2sc.h new file +466 -0

466 lines not on this page · raw message

Signature · 1 line

1.7.3.4

Heiko Schocher

2012-01-16 08:21 UTC #1 lore raw

PATCH 1/1 add new board vl_ma2sc

Hello Jens,

Quoted 5 lines · Jens Scharsig

* add support for board VL+MA2SC
* adds vl_ma2sc_config for standard NOR boot configuration
* adds vl_ma2sc_ram_config for RAM load configuration
Signed-off-by Jens Scharsig <[email protected]>

Quoted 10 lines

---
 MAINTAINERS                   |    1 +
 board/BuS/vl_ma2sc/Makefile   |   54 ++++
 board/BuS/vl_ma2sc/vl_ma2sc.c |  596 +++++++++++++++++++++++++++++++++++++++++
 boards.cfg                    |    2 +
 include/configs/vl_ma2sc.h    |  466 ++++++++++++++++++++++++++++++++
 5 files changed, 1119 insertions(+), 0 deletions(-)
 create mode 100644 board/BuS/vl_ma2sc/Makefile
 create mode 100644 board/BuS/vl_ma2sc/vl_ma2sc.c
 create mode 100644 include/configs/vl_ma2sc.h

Please check your patch with tools/checkpatch, it shows a lot of warnings:

[hs at pollux u-boot]$ ./tools/checkpatch.pl index.html [...]
total: 17 errors, 13 warnings, 1131 lines checked

board/BuS/vl_ma2sc/vl_ma2sc.c line 4

Quoted 10 lines

board/BuS/vl_ma2sc/vl_ma2sc.c new file +4 -0

new file mode 100644
index 0000000..dfaf2cb
@@ -0,0 +1,596 @@
+/*
+ * Miscelaneous platform dependent initialisations
+ */
+

empty line not needed.

[...]

Quoted 23 lines

board/BuS/vl_ma2sc/vl_ma2sc.c new file +23 -0

+#ifdef CONFIG_CMD_NAND
+static void vl_ma2sc_nand_hw_init(void)
+{
+	unsigned long csa;
+	at91_smc_t	*smc	= (at91_smc_t *) ATMEL_BASE_SMC0;
+	at91_matrix_t	*matrix = (at91_matrix_t *) ATMEL_BASE_MATRIX;
+	at91_pmc_t	*pmc	= (at91_pmc_t *) ATMEL_BASE_PMC;
+
+	at91_set_pio_output(AT91_PIO_PORTA, 13, 1);	/* CAN_TX -> H */
+	at91_set_pio_output(AT91_PIO_PORTA, 12, 1);	/* CAN_STB -> H */
+	at91_set_pio_output(AT91_PIO_PORTA, 11, 1);	/* CAN_EN -> H */
+
+	/* Enable CS3 */
+	csa = readl(&matrix->csa[0]) | AT91_MATRIX_CSA_EBI_CS3A;
+	writel(csa, &matrix->csa[0]);
+
+	/* Configure SMC CS3 for NAND/SmartMedia */
+#if 1
+	writel(AT91_SMC_SETUP_NWE(1) | AT91_SMC_SETUP_NCS_WR(0) |
+		AT91_SMC_SETUP_NRD(1) | AT91_SMC_SETUP_NCS_RD(0),
+		&smc->cs[3].setup);
+
+	writel(AT91_SMC_PULSE_NWE(3) | AT91_SMC_PULSE_NCS_WR(3) |

board/BuS/vl_ma2sc/vl_ma2sc.c line 85

Quoted 10 lines

board/BuS/vl_ma2sc/vl_ma2sc.c new file +10 -0

+		AT91_SMC_PULSE_NRD(3) | AT91_SMC_PULSE_NCS_RD(3),
+		&smc->cs[3].pulse);
+
+	writel(AT91_SMC_CYCLE_NWE(5) | AT91_SMC_CYCLE_NRD(5),
+		&smc->cs[3].cycle);
+	writel(AT91_SMC_MODE_RM_NRD | AT91_SMC_MODE_WM_NWE |
+		AT91_SMC_MODE_DBW_8 |
+		AT91_SMC_MODE_TDF_CYCLE(2),
+		&smc->cs[3].mode);
+#else

don't add dead code.

Quoted 11 lines

board/BuS/vl_ma2sc/vl_ma2sc.c new file +11 -0

+#ifdef CONFIG_MACB
+static void vl_ma2sc_macb_hw_init(void)
+{
+	unsigned long	erstl;
+	at91_pmc_t	*pmc	= (at91_pmc_t *) ATMEL_BASE_PMC;
+	at91_pio_t	*pio	= (at91_pio_t *) ATMEL_BASE_PIO;
+	at91_rstc_t	*rstc	= (at91_rstc_t *) ATMEL_BASE_RSTC;
+	/* Enable clock */
+	writel(1 << ATMEL_ID_EMAC, &pmc->pcer);
+
+	/*

board/BuS/vl_ma2sc/vl_ma2sc.c line 135

Quoted 10 lines

board/BuS/vl_ma2sc/vl_ma2sc.c new file +10 -0

+	 * Disable pull-up on:
+	 *	RXDV (PC25) => PHY normal mode (not Test mode)
+	 *	ERX0 (PE25) => PHY ADDR0
+	 *	ERX1 (PE26) => PHY ADDR1 => PHYADDR = 0x0
+	 *
+	 * PHY has internal pull-down
+	 */
+
+	writel((1 << 25), &pio->pioc.pudr);
+	writel((1 << 25) | (1 << 26), &pio->pioe.pudr);

please use defines here for 25 and 26

[...]

Quoted 4 lines

board/BuS/vl_ma2sc/vl_ma2sc.c new file +4 -0
+#ifdef CONFIG_MISC_INIT_R
+
+int misc_init_r(void)
+{

board/BuS/vl_ma2sc/vl_ma2sc.c line 328

Quoted 10 lines

board/BuS/vl_ma2sc/vl_ma2sc.c new file +10 -0

+	uchar	buffer[8];
+	at91_pio_t	*pio = (at91_pio_t *) ATMEL_BASE_PIO;
+	u32		pin;
+
+	buffer[0] = 0x04;
+	buffer[1] = 0x00;
+	if (i2c_write(0x68, 0x0E, 1, buffer, 2) != 0)
+		puts("error reseting rtc clock\n\0");
+
+	/* HWversion lesen */

no german please ;-)

board/BuS/vl_ma2sc/vl_ma2sc.c line 73

Quoted 1 line

board/BuS/vl_ma2sc/vl_ma2sc.c new file +1 -0
+

no empty line here needed.

[...]

Quoted 6 lines

include/configs/vl_ma2sc.h new file +0 -0
new file mode 100644
index 0000000..d9c2a2d
@@ -0,0 +1,466 @@

[...]

include/configs/vl_ma2sc.h line 466

Quoted 4 lines

include/configs/vl_ma2sc.h new file +4 -0
+
+#endif
+
+/* EOF */

This comment is not needed.

bye,
Heiko

Signature · 2 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Jens Scharsig

author

2012-01-16 08:51 UTC #2 lore raw

PATCH 1/1 add new board vl_ma2sc

Hello Heiko:

Quoted 8 lines

Please check your patch with tools/checkpatch, it shows a lot of warnings:
[hs at pollux u-boot]$ ./tools/checkpatch.pl index.html [...]
total: 17 errors, 13 warnings, 1131 lines checked

The error based on the two code sequences

<snip>

vidinfo_t panel_info = {
	vl_col:			320,
	vl_row:			240,
	vl_clk:			6500000,
	vl_sync:		ATMEL_LCDC_INVDVAL_INVERTED |
				ATMEL_LCDC_INVLINE_INVERTED |
				ATMEL_LCDC_INVVD_INVERTED   |
				ATMEL_LCDC_INVFRAME_INVERTED,
	vl_bpix:		(ATMEL_LCDC_PIXELSIZE_8 >> 5),
	vl_tft:			1,
	vl_hsync_len:		5,	/* Horiz Sync Pulse Width */
	vl_left_margin:		68,	/* horiz back porch */
	vl_right_margin:	20,	/* horiz front porch */
	vl_vsync_len:		2,	/* vert Sync Pulse Width */
	vl_upper_margin:	18,	/* vert back porch */
	vl_lower_margin:	4,	/* vert front porch */
	mmio:			ATMEL_BASE_LCDC,
};

</sinp>

This block i have "stolen" from at91sam9263 board.

and
<snip>
#define CONFIG_ETHADDR 00:4D:41:02:52:43 /* MA2SC */
</sinp>

Can your teach me the right format for things like this?

Thanks

Jens Scharsig

Heiko Schocher

2012-01-16 09:41 UTC #3 lore raw

PATCH 1/1 add new board vl_ma2sc

Hello Jens,

Quoted 22 lines · Jens Scharsig

Hello Heiko:
Quoted 7 lines
Please check your patch with tools/checkpatch, it shows a lot of warnings:
[hs at pollux u-boot]$ ./tools/checkpatch.pl index.html [...]
total: 17 errors, 13 warnings, 1131 lines checked
The error based on the two code sequences
<snip>
vidinfo_t panel_info = {
	vl_col:			320,
	vl_row:			240,
	vl_clk:			6500000,
	vl_sync:		ATMEL_LCDC_INVDVAL_INVERTED |
				ATMEL_LCDC_INVLINE_INVERTED |
				ATMEL_LCDC_INVVD_INVERTED   |
				ATMEL_LCDC_INVFRAME_INVERTED,
	vl_bpix:		(ATMEL_LCDC_PIXELSIZE_8 >> 5),
	vl_tft:			1,

Quoted 8 lines

	vl_hsync_len:		5,	/* Horiz Sync Pulse Width */
	vl_left_margin:		68,	/* horiz back porch */
	vl_right_margin:	20,	/* horiz front porch */
	vl_vsync_len:		2,	/* vert Sync Pulse Width */
	vl_upper_margin:	18,	/* vert back porch */
	vl_lower_margin:	4,	/* vert front porch */
	mmio:			ATMEL_BASE_LCDC,
};

Try:

vidinfo_t panel_info = {
	.vl_col = 320,

[...]

Quoted 10 lines

</sinp>
This block i have "stolen" from at91sam9263 board.
and
<snip>
#define CONFIG_ETHADDR 00:4D:41:02:52:43 /* MA2SC */
</sinp>
Can your teach me the right format for things like this?

Hmm.. fix ethaddr in config file? I am not sure, if this is allowed in mainline ...

bye,
Heiko

Signature · 2 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Mike Frysinger

2012-01-16 09:57 UTC #4 lore raw

PATCH 1/1 add new board vl_ma2sc

In reply to Jens Scharsig

board/BuS/vl_ma2sc/Makefile line 45

Quoted 8 lines · On Monday 16 January 2012 02:41:24 Jens Scharsig wrote:

board/BuS/vl_ma2sc/Makefile new file +5 -0

 
+clean:
+	rm -f $(SOBJS) $(OBJS)
+
+distclean:	clean
+	rm -f $(LIB) core *.bak $(obj).depend

dead targets -> delete them
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120116/86ffb605/attachment.pgp>

Jens Scharsig

author

2012-01-16 10:22 UTC #5 lore raw

PATCH v2 1/1 add new board vl_ma2sc

In reply to Jens Scharsig

* add support for board VL+MA2SC
* adds vl_ma2sc_config for standard NOR boot configuration
* adds vl_ma2sc_ram_config for RAM load configuration

Signed-off-by Jens Scharsig <[email protected]>

---
Changes since V1:

* remove dead targets from Makefile
* remove fantasy mac address from config
* fix: codesyle 0 warnings/error with checkpatch

 MAINTAINERS                   |    1 +
 board/BuS/vl_ma2sc/Makefile   |   48 ++++
 board/BuS/vl_ma2sc/vl_ma2sc.c |  551 +++++++++++++++++++++++++++++++++++++++++
 boards.cfg                    |    2 +
 include/configs/vl_ma2sc.h    |  463 ++++++++++++++++++++++++++++++++++
 5 files changed, 1065 insertions(+), 0 deletions(-)
 create mode 100644 board/BuS/vl_ma2sc/Makefile
 create mode 100644 board/BuS/vl_ma2sc/vl_ma2sc.c
 create mode 100644 include/configs/vl_ma2sc.h

MAINTAINERS +1 -0

index a5b728e..12047fc 100644
@@ -819,6 +819,7 @@ Steve Sakoman <[email protected]>
 Jens Scharsig <[email protected]>
 
 	eb_cpux9k2	ARM920T (AT91RM9200 SoC)
+	vl_ma2sc	ARM926EJS (AT91SAM9263 SoC)
 
 Heiko Schocher <[email protected]>

board/BuS/vl_ma2sc/Makefile new file +48 -0

48 lines not on this page · raw message

board/BuS/vl_ma2sc/vl_ma2sc.c new file +551 -0

551 lines not on this page · raw message

boards.cfg +2 -0

index 576b392..2f7211f 100644
@@ -94,6 +94,8 @@ at91sam9xeek_dataflash_cs1   arm         arm926ejs   at91sam9260ek       atmel
 at91sam9xeek_nandflash       arm         arm926ejs   at91sam9260ek       atmel          at91        at91sam9260ek:AT91SAM9XE,SYS_USE_NANDFLASH
 snapper9260                  arm         arm926ejs   -                   bluewater      at91        snapper9260:AT91SAM9260
 snapper9g20                  arm         arm926ejs   snapper9260         bluewater      at91        snapper9260:AT91SAM9G20
+vl_ma2sc                     arm         arm926ejs   vl_ma2sc            BuS            at91
+vl_ma2sc_ram                 arm         arm926ejs   vl_ma2sc            BuS            at91        vl_ma2sc:RAMLOAD
 sbc35_a9g20_eeprom           arm         arm926ejs   sbc35_a9g20         calao          at91        sbc35_a9g20:AT91SAM9G20,SYS_USE_EEPROM
 sbc35_a9g20_nandflash        arm         arm926ejs   sbc35_a9g20         calao          at91        sbc35_a9g20:AT91SAM9G20,SYS_USE_NANDFLASH
 tny_a9260_eeprom             arm         arm926ejs   tny_a9260           calao          at91        tny_a9260:AT91SAM9260,SYS_USE_EEPROM

include/configs/vl_ma2sc.h new file +463 -0

463 lines not on this page · raw message

Signature · 1 line

1.7.3.4

Albert ARIBAUD

2012-07-07 11:06 UTC #6 lore raw

PATCH v2 1/1 add new board vl_ma2sc

Hi Jens,

Le Mon, 16 Jan 2012 11:22:02 +0100,
Jens Scharsig <[email protected]> a ?crit :

Quoted 6 lines

* add support for board VL+MA2SC
* adds vl_ma2sc_config for standard NOR boot configuration
* adds vl_ma2sc_ram_config for RAM load configuration
Signed-off-by Jens Scharsig <[email protected]>
---

Applied to u-boot-arm/master, thanks.

Amicalement,

Signature · 1 line

Albert.