Skip to contentSkip to conversation

Alsa enhancements

PATCH In review Joshua Lock 2 participants 7 messages Jan 10, 2012 – Jan 17, 2012

lore
Share & tools
lore
#0 lore raw

cover Alsa enhancements

CAVEAT: This series requires the alsa-state series recently submitted to the OE-Core mailing list.

This series enables alsa as a MACHINE_FEATURE by default in the ia32-base so that alsa is enabled for all current BSP's.

Following that the series drops the BSP-specific n450-audio recipe in favour of extending the common alsa-state recipe for alsa configuration.

Note: the n450-audio recipe was not working in any stock image as alsa was not a listed MACHINE_FEATURE and the amixer package is not included by default.

The following changes since commit 38f2b670bc37515bcb0fa7f98e338e5242d70386:

meta-cedartrail: Create new layer for cedartrail System. (2012-01-09 17:55:07 -0600)

are available in the git repository at:
git://github.com/incandescant/meta-intel master
https://github.com/incandescant/meta-intel/tree/master

Joshua Lock (3):
ia32-base: add alsa to MACHINE_FEATURES
alsa-state: add alsa state for n450
n450-audio: drop this machine specific recipe in favour of alsa-state

 conf/machine/include/ia32-base.inc                 |    2 +-
 meta-n450/conf/machine/n450.conf                   |    2 -
 .../recipes-bsp/alsa-state/alsa-state.bbappend     |    1 +
 .../alsa-state/alsa-state/n450/asound.state        |  450 ++++++++++++++++++++
 meta-n450/recipes-bsp/n450-audio/n450-audio.bb     |   30 --
 .../recipes-bsp/n450-audio/n450-audio/n450-audio   |   42 --
 6 files changed, 452 insertions(+), 75 deletions(-)
 create mode 100644 meta-n450/recipes-bsp/alsa-state/alsa-state.bbappend
 create mode 100644 meta-n450/recipes-bsp/alsa-state/alsa-state/n450/asound.state
 delete mode 100644 meta-n450/recipes-bsp/n450-audio/n450-audio.bb
 delete mode 100644 meta-n450/recipes-bsp/n450-audio/n450-audio/n450-audio
Signature · 1 line
1.7.7.5
#1 lore raw

PATCH 1/3 ia32-base: add alsa to MACHINE_FEATURES

---
 conf/machine/include/ia32-base.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
conf/machine/include/ia32-base.inc +1 -1
index 84693e2..8556d6e 100644
@@ -6,7 +6,7 @@
 # common settings for Intel-based machines
 #
 MACHINE_FEATURES += "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \
-                     acpi serial usbgadget"
+                     acpi serial usbgadget alsa"
 
 MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts"
 MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub"
Signature · 1 line
1.7.7.5
#2 lore raw

PATCH 2/3 alsa-state: add alsa state for n450

In reply to Joshua Lock

Add a custom asound.state for the n450 so that the alsa-state init script sets (and restores) sound configuration appropriately.

---
 .../recipes-bsp/alsa-state/alsa-state.bbappend     |    1 +
 .../alsa-state/alsa-state/n450/asound.state        |  450 ++++++++++++++++++++
 2 files changed, 451 insertions(+), 0 deletions(-)
 create mode 100644 meta-n450/recipes-bsp/alsa-state/alsa-state.bbappend
 create mode 100644 meta-n450/recipes-bsp/alsa-state/alsa-state/n450/asound.state
meta-n450/recipes-bsp/alsa-state/alsa-state.bbappend new file +1 -0
new file mode 100644
index 0000000..72d991c
@@ -0,0 +1 @@
+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
meta-n450/recipes-bsp/alsa-state/alsa-state/n450/asound.state new file +450 -0

450 lines not on this page · raw message

Signature · 1 line
1.7.7.5
#3 lore raw

PATCH 3/3 n450-audio: drop this machine specific recipe in favour of alsa-state

In reply to Joshua Lock
---
 meta-n450/conf/machine/n450.conf                   |    2 -
 meta-n450/recipes-bsp/n450-audio/n450-audio.bb     |   30 --------------
 .../recipes-bsp/n450-audio/n450-audio/n450-audio   |   42 --------------------
 3 files changed, 0 insertions(+), 74 deletions(-)
 delete mode 100644 meta-n450/recipes-bsp/n450-audio/n450-audio.bb
 delete mode 100644 meta-n450/recipes-bsp/n450-audio/n450-audio/n450-audio
meta-n450/conf/machine/n450.conf +0 -2
index 3e6a541..6ffdce9 100644
@@ -14,5 +14,3 @@ XSERVER ?= "${XSERVER_IA32_BASE} \
 SYSLINUX_OPTS = "serial 0 115200"
 SERIAL_CONSOLE = "115200 ttyS0" 
 APPEND += "console=ttyS0,115200 console=tty0" 
-
-MACHINE_EXTRA_RRECOMMENDS += "n450-audio"
meta-n450/recipes-bsp/n450-audio/n450-audio.bb deleted +0 -30
deleted file mode 100644
index 27904e3..0000000
@@ -1,30 +0,0 @@
-SUMMARY = "Provide a basic init script to enable audio"
-DESCRIPTION = "Set the volume and unmute the Front mixer setting during boot."
-SECTION = "base"
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58"
-
-PR = "r4"
-
-inherit update-rc.d
-
-RDEPENDS = "alsa-utils-amixer"
-
-SRC_URI = "file://n450-audio"
-
-INITSCRIPT_NAME = "n450-audio"
-INITSCRIPT_PARAMS = "defaults 90"
-
-do_install() {
-	install -d ${D}${sysconfdir} \
-	           ${D}${sysconfdir}/init.d
-	install -m 0755 ${WORKDIR}/n450-audio ${D}${sysconfdir}/init.d
-        cat ${WORKDIR}/${INITSCRIPT_NAME} | \
-            sed -e 's,/etc,${sysconfdir},g' \
-                -e 's,/usr/sbin,${sbindir},g' \
-                -e 's,/var,${localstatedir},g' \
-                -e 's,/usr/bin,${bindir},g' \
-                -e 's,/usr,${prefix},g' > ${D}${sysconfdir}/init.d/${INITSCRIPT_NAME}
-        chmod 755 ${D}${sysconfdir}/init.d/${INITSCRIPT_NAME}
-}
-
meta-n450/recipes-bsp/n450-audio/n450-audio/n450-audio deleted +0 -42

42 lines not on this page · raw message

Signature · 1 line
1.7.7.5
#4 lore raw
In reply to Joshua Lock
Quoted 3 lines · Joshua Lock

CAVEAT: This series requires the alsa-state series recently submitted to the OE-Core mailing list.

Nice. Thanks for finally resolving this. When the other patches hit oe-core, I'll pull these in...

Tom

Quoted 35 lines

This series enables alsa as a MACHINE_FEATURE by default in the ia32-base so that alsa is enabled for all current BSP's.

Following that the series drops the BSP-specific n450-audio recipe in favour of extending the common alsa-state recipe for alsa configuration.

Note: the n450-audio recipe was not working in any stock image as alsa was not a listed MACHINE_FEATURE and the amixer package is not included by default.

The following changes since commit 38f2b670bc37515bcb0fa7f98e338e5242d70386:

meta-cedartrail: Create new layer for cedartrail System. (2012-01-09 17:55:07 -0600)

are available in the git repository at:
git://github.com/incandescant/meta-intel master
https://github.com/incandescant/meta-intel/tree/master

Joshua Lock (3):
ia32-base: add alsa to MACHINE_FEATURES
alsa-state: add alsa state for n450
n450-audio: drop this machine specific recipe in favour of alsa-state

 conf/machine/include/ia32-base.inc                 |    2 +-
 meta-n450/conf/machine/n450.conf                   |    2 -
 .../recipes-bsp/alsa-state/alsa-state.bbappend     |    1 +
 .../alsa-state/alsa-state/n450/asound.state        |  450 ++++++++++++++++++++
 meta-n450/recipes-bsp/n450-audio/n450-audio.bb     |   30 --
 .../recipes-bsp/n450-audio/n450-audio/n450-audio   |   42 --
 6 files changed, 452 insertions(+), 75 deletions(-)
 create mode 100644 meta-n450/recipes-bsp/alsa-state/alsa-state.bbappend
 create mode 100644 meta-n450/recipes-bsp/alsa-state/alsa-state/n450/asound.state
 delete mode 100644 meta-n450/recipes-bsp/n450-audio/n450-audio.bb
 delete mode 100644 meta-n450/recipes-bsp/n450-audio/n450-audio/n450-audio
#5 lore raw
Quoted 7 lines · Tom Zanussi
Quoted 3 lines · Joshua Lock

CAVEAT: This series requires the alsa-state series recently submitted to the OE-Core mailing list.

Nice. Thanks for finally resolving this. When the other patches hit oe-core, I'll pull these in...

FYI the alsa-state recipe has hit master.

Joshua

Signature · 3 lines
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre
#6 lore raw
Quoted 12 lines · Joshua Lock
Quoted 7 lines · Tom Zanussi
Quoted 3 lines · Joshua Lock

CAVEAT: This series requires the alsa-state series recently submitted to the OE-Core mailing list.

Nice. Thanks for finally resolving this. When the other patches hit oe-core, I'll pull these in...

FYI the alsa-state recipe has hit master.

Boot-tested on n450 and pulled into meta-intel/master.

Thanks,

Tom

Quoted 1 line

Joshua