video: backlight: support s6e8ax0 panel driver based on MIPI DSI

PATCH New Donghwa Lee 4 participants 5 messages Jan 19, 2012 – Feb 1, 2012

Subsystems (2)

Framebuffer layer Backlight class/subsystem

lore

Share & tools

lore

Donghwa Lee

author

2012-01-19 05:28 UTC #0 lore raw

PATCH v7 2/2 video: backlight: support s6e8ax0 panel driver based on MIPI DSI

This patch is amoled panel driver based MIPI DSI interface. S6E8AX0 means it may includes many other ldi controllers, for example, S6E8AA0, S6E8AB0, and so on.

This patch can be modified depending on each panel properites. For example, second parameter of panel condition register can be changed depending on ldi controller or amoled type.

Changes since v6:
- change data type from const to static const

Signed-off-by Donghwa Lee <[email protected]>

Signed-off-by Inki Dae <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

---
 drivers/video/backlight/Kconfig   |    7 +
 drivers/video/backlight/Makefile  |    1 +
 drivers/video/backlight/s6e8ax0.c |  898 +++++++++++++++++++++++++++++++++++++
 drivers/video/backlight/s6e8ax0.h |   21 +
 4 files changed, 927 insertions(+), 0 deletions(-)
 create mode 100644 drivers/video/backlight/s6e8ax0.c
 create mode 100644 drivers/video/backlight/s6e8ax0.h

drivers/video/backlight/Kconfig +7 -0

index 278aeaa..478fc4a 100644
@@ -125,6 +125,13 @@ config LCD_AMS369FG06
 	  If you have an AMS369FG06 AMOLED Panel, say Y to enable its
 	  LCD control driver.
 
+config LCD_S6E8AX0
+	tristate "S6E8AX0 MIPI AMOLED LCD Driver"
+	depends on S5P_MIPI_DSI && BACKLIGHT_CLASS_DEVICE
+	default n
+	help
+	  If you have an S6E8AX0 MIPI AMOLED LCD Panel, say Y to enable its
+	  LCD control driver.
 endif # LCD_CLASS_DEVICE
 
 #

drivers/video/backlight/Makefile +1 -0

index fdd1fc4..6adba58 100644
@@ -14,6 +14,7 @@ obj-$(CONFIG_LCD_TOSA)		   += tosa_lcd.o
 obj-$(CONFIG_LCD_S6E63M0)	+= s6e63m0.o
 obj-$(CONFIG_LCD_LD9040)	+= ld9040.o
 obj-$(CONFIG_LCD_AMS369FG06)	+= ams369fg06.o
+obj-$(CONFIG_LCD_S6E8AX0)	+= s6e8ax0.o
 
 obj-$(CONFIG_BACKLIGHT_CLASS_DEVICE) += backlight.o
 obj-$(CONFIG_BACKLIGHT_ATMEL_PWM)    += atmel-pwm-bl.o

drivers/video/backlight/s6e8ax0.c new file +898 -0

898 lines not on this page · raw message

drivers/video/backlight/s6e8ax0.h new file +21 -0

new file mode 100644
index 0000000..1f1b270
@@ -0,0 +1,21 @@
+/* linux/drivers/video/backlight/s6e8ax0.h
+ *
+ * MIPI-DSI based s6e8ax0 AMOLED LCD Panel definitions.
+ *
+ * Copyright (c) 2011 Samsung Electronics
+ *
+ * Inki Dae, <[email protected]>
+ * Donghwa Lee <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#ifndef _S6E8AX0_H
+#define _S6E8AX0_H
+
+extern void s6e8ax0_init(void);
+
+#endif
+

Signature · 1 line

1.7.4.1

Tomi Valkeinen

2012-01-26 15:52 UTC #1 lore raw

PATCH v7 2/2 video: backlight: support s6e8ax0 panel driver based on MIPI DSI

Hi,

Quoted 14 lines · Donghwa Lee

This patch is amoled panel driver based MIPI DSI interface. S6E8AX0 means it may includes many other ldi controllers, for example, S6E8AA0, S6E8AB0, and so on.
This patch can be modified depending on each panel properites. For example, second parameter of panel condition register can be changed depending on ldi controller or amoled type.
Changes since v6:
- change data type from const to static const
Signed-off-by Donghwa Lee <[email protected]>
Signed-off-by Inki Dae <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>

Quoted 8 lines

---
 drivers/video/backlight/Kconfig   |    7 +
 drivers/video/backlight/Makefile  |    1 +
 drivers/video/backlight/s6e8ax0.c |  898 +++++++++++++++++++++++++++++++++++++
 drivers/video/backlight/s6e8ax0.h |   21 +
 4 files changed, 927 insertions(+), 0 deletions(-)
 create mode 100644 drivers/video/backlight/s6e8ax0.c
 create mode 100644 drivers/video/backlight/s6e8ax0.h

Why is this in backlight directory? It's a panel driver, not a backlight driver.

And the driver is s5p specific, wouldn't a directory like drivers/video/s5p/, where both the s5p DSI driver from the previous patch and this panel driver could be?

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120126/73d361ca/attachment.sig>

Inki Dae

2012-01-27 02:07 UTC #2 lore raw

PATCH v7 2/2 video: backlight: support s6e8ax0 panel driver based on MIPI DSI

Hi, Tomi.

Below is my comments.

Quoted 31 lines

-----Original Message-----
From: Tomi Valkeinen [mailto:tomi.valkeinen at ti.com]
Sent: Friday, January 27, 2012 12:53 AM
To: Donghwa Lee
Cc: linux-fbdev at vger.kernel.org; linux-arm-kernel at lists.infradead.org; Florian Tobias Schandinat; Andrew Morton; rpurdie at linux.intel.com; inki.dae at samsung.com; kyungmin.park at samsung.com
Subject: Re: [PATCH v7 2/2] video: backlight: support s6e8ax0 panel driver based on MIPI DSI
Hi,
Quoted 11 lines · Donghwa Lee
This patch is amoled panel driver based MIPI DSI interface. S6E8AX0 means it may includes many other ldi controllers, for example, S6E8AA0, S6E8AB0, and so on.
This patch can be modified depending on each panel properites. For example, second parameter of panel condition register can be changed depending on ldi controller or amoled type.
Changes since v6:
- change data type from const to static const
Quoted 7 lines
Signed-off-by Donghwa Lee <[email protected]>
Signed-off-by Inki Dae <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/video/backlight/Kconfig   |    7 +
 drivers/video/backlight/Makefile  |    1 +
 drivers/video/backlight/s6e8ax0.c |  898

Quoted 9 lines

+++++++++++++++++++++++++++++++++++++
Quoted 4 lines
 drivers/video/backlight/s6e8ax0.h |   21 +
 4 files changed, 927 insertions(+), 0 deletions(-)  create mode
100644 drivers/video/backlight/s6e8ax0.c create mode 100644 drivers/video/backlight/s6e8ax0.h
Why is this in backlight directory? It's a panel driver, not a backlight driver.

Yes, right. this backlight driver is specific to our mipi dsi driver because this uses the interface of mipi dsi driver to send some commands to real lcd panel.

Quoted 4 lines

And the driver is s5p specific, wouldn't a directory like drivers/video/s5p/, where both the s5p DSI driver from the previous patch and this panel driver could be?

Ok, we will create new directory, "exynos" instead of "s5p" because our SoC chip doesn't use such prefix(s5p, and s3c) anymore. and also as you mentioned, we should working on a common DSI framework. do you have any plan for this?

Thanks,
Inki Dae.

Quoted 1 line

Tomi

Jingoo Han

2012-01-27 03:00 UTC #3 lore raw

PATCH v7 2/2 video: backlight: support s6e8ax0 panel driver based on MIPI DSI

Hi, Inki Dae.

Quoted 57 lines

-----Original Message-----
From: linux-fbdev-owner at vger.kernel.org [mailto:linux-fbdev-owner at vger.kernel.org] On Behalf Of Inki Dae
Sent: Friday, January 27, 2012 11:08 AM
To: 'Tomi Valkeinen'; 'Donghwa Lee'
Cc: linux-fbdev at vger.kernel.org; linux-arm-kernel at lists.infradead.org; 'Florian Tobias Schandinat'; 'Andrew Morton'; rpurdie at linux.intel.com; kyungmin.park at samsung.com
Subject: RE: [PATCH v7 2/2] video: backlight: support s6e8ax0 panel driver based on MIPI DSI
Hi, Tomi.
Below is my comments.
Quoted 31 lines
-----Original Message-----
From: Tomi Valkeinen [mailto:tomi.valkeinen at ti.com]
Sent: Friday, January 27, 2012 12:53 AM
To: Donghwa Lee
Cc: linux-fbdev at vger.kernel.org; linux-arm-kernel at lists.infradead.org; Florian Tobias Schandinat; Andrew Morton; rpurdie at linux.intel.com; inki.dae at samsung.com; kyungmin.park at samsung.com
Subject: Re: [PATCH v7 2/2] video: backlight: support s6e8ax0 panel driver based on MIPI DSI
Hi,
Quoted 11 lines · Donghwa Lee
This patch is amoled panel driver based MIPI DSI interface. S6E8AX0 means it may includes many other ldi controllers, for example, S6E8AA0, S6E8AB0, and so on.
This patch can be modified depending on each panel properites. For example, second parameter of panel condition register can be changed depending on ldi controller or amoled type.
Changes since v6:
- change data type from const to static const
Quoted 7 lines
Signed-off-by Donghwa Lee <[email protected]>
Signed-off-by Inki Dae <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
---
 drivers/video/backlight/Kconfig   |    7 +
 drivers/video/backlight/Makefile  |    1 +
 drivers/video/backlight/s6e8ax0.c |  898
Quoted 9 lines
+++++++++++++++++++++++++++++++++++++
Quoted 4 lines
 drivers/video/backlight/s6e8ax0.h |   21 +
 4 files changed, 927 insertions(+), 0 deletions(-)  create mode
100644 drivers/video/backlight/s6e8ax0.c create mode 100644 drivers/video/backlight/s6e8ax0.h
Why is this in backlight directory? It's a panel driver, not a backlight driver.
Yes, right. this backlight driver is specific to our mipi dsi driver because this uses the interface of mipi dsi driver to send some commands to real lcd panel.

Quoted 8 lines

Quoted 4 lines
And the driver is s5p specific, wouldn't a directory like drivers/video/s5p/, where both the s5p DSI driver from the previous patch and this panel driver could be?
Ok, we will create new directory, "exynos" instead of "s5p" because our SoC chip doesn't use such prefix(s5p, and s3c) anymore. and also as you mentioned, we should working on a common DSI framework. do you have any plan for this?

I think so. New directory, "exynos" is necessary.
The "exynos" directory can include IPs such as MIPI, which are related to FB stack and are used for exynos SoC series.

However, s3c-fb.c will remain in "drivers/video" directory, because s3c-fb.c can be used for s3c24xx, s5p64xx SoC series as well as exynos series.

Thank you.

Quoted 11 lines

Thanks,
Inki Dae.
Quoted 1 line
Tomi
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Tomi Valkeinen

2012-02-01 06:11 UTC #4 lore raw

PATCH v7 2/2 video: backlight: support s6e8ax0 panel driver based on MIPI DSI

In reply to Inki Dae

Quoted 2 lines · Inki Dae

as you mentioned, we should working on a common DSI framework. do
you have any plan for this?

I have plans to do plans =). So no. This is related to the low-level display framework, of which I sent post to fbdev some months ago. I've been planning to revise that also.

Tomi