Skip to contentSkip to conversation

Code review request

mlmmj Ben Schmidt 2 participants 4 messages Jan 16, 2012 – Jan 22, 2012

lore
Share & tools
lore
#0 lore raw

Hi, everyone,

I am working towards implementing everything necessary for the new list texts and publishing an alpha or beta release, hopefully late this month.

As always, code review is worthwhile, and there are a number of changesets now ready for review. If you're a competent C coder, I'd love it if you'd take a look and send me any comments, or just give the changeset a thumbs up. Preferably do this on the list so others know the changeset has been reviewed and we don't duplicate work. Be sure to state explicitly which changeset you are referring to in your reply.

- http://mlmmj.org/hg/mlmmj/rev/0f9082bde7ef
- http://mlmmj.org/hg/mlmmj/rev/43979253cf97
- http://mlmmj.org/hg/mlmmj/rev/255d277b37db
- http://mlmmj.org/hg/mlmmj/rev/c9237f9a3465
- http://mlmmj.org/hg/mlmmj/rev/5dc52f70e76b
- http://mlmmj.org/hg/mlmmj/rev/8479195595af

Note that I am trialling having diff ignore whitespace changes when viewing the changesets online, so indentation changes won't appear. I think this will make some changesets easier to review.

Thanks in advance,

Ben.

#1 lore raw
Quoted 8 lines · Ben Schmidt

As always, code review is worthwhile, and there are a number of changesets now ready for review. If you're a competent C coder, I'd love
it if you'd take a look and send me any comments, or just give the changeset a thumbs up. Preferably do this on the list so others know the
changeset has been reviewed and we don't duplicate work. Be sure to state explicitly which changeset you are referring to in your reply.

Pardon my shameless plug here but, is there any chance this:

http://mlmmj.org/bugs/bug.php?id3

will be considered for the next mlmmj release? I love mlmmj but the current behavior is breaking gmane.

Thanks.

#2 lore raw
In reply to Ben Schmidt
Quoted 6 lines

Pardon my shameless plug here but, is there any chance this:

http://mlmmj.org/bugs/bug.php?id3

will be considered for the next mlmmj release? I love mlmmj but the current behavior is breaking gmane.

I saw that come through via the bug tracker recently. I'm glad it's in there now, as it had indeed been forgotten by me. Sorry. Thanks a lot for the work, though. It won't be wasted.

I don't think I'll consider it for the upcoming release, though, as I want to restrict remaining changes to those necessary to the updated list texts, and really obvious bug fixes. This patch, however, will require some discussion, possibly some reading of RFCs, and testing in a lot of different environments, to be sure we get it right. That will take time, and I don't want to delay this release any more.

However, I expect to release more frequently after getting this next release out, so I hope there won't be too long to wait before this (or something like it) is incorporated.

I will start a discussion about this issue (as well as the Resent-From issue, which is related, I believe) after the release is out. For now, though, I prefer to focus effort on final coding, reviewing and testing for the release.

Hope that's OK.

Cheers,

Ben.

#3 lore raw
In reply to Ben Schmidt
Quoted 9 lines · Ben Schmidt

I will start a discussion about this issue (as well as the Resent-From
issue, which is related, I believe) after the release is out. For now,
though, I prefer to focus effort on final coding, reviewing and testing
for the release.

Hope that's OK.

Fine with that. I'll keep an eye on the list, but please don't hesitate to ping me if necessary.