Skip to contentSkip to conversation

TRATS: set gpio of UART correctly

PATCH New Minkyu Kang 2 participants 2 messages Jan 26, 2012 – Feb 6, 2012

lore
Share & tools
lore

Minkyu Kang

author
#0 lore raw

PATCH 1/1 TRATS: set gpio of UART correctly

Signed-off-by Minkyu Kang <[email protected]>
Signed-off-by HeungJun, Kim <[email protected]>
Cc Chander Kashyap <[email protected]>
---
 board/samsung/trats/trats.c |   18 +++++++-----------
 1 files changed, 7 insertions(+), 11 deletions(-)
board/samsung/trats/trats.c +7 -11
index f795ff0..aa4291d 100644
@@ -336,21 +336,17 @@ static void board_uart_init(void)
 		(struct exynos4_gpio_part2 *)samsung_get_base_gpio_part2();
 	int i;
 
-	/* UART0-UART1 GPIOs (part1) : 0x22222222 */
-	for (i = 0; i < 7; i++) {
-		s5p_gpio_set_pull(&gpio1->a0, i, GPIO_PULL_NONE);
-		s5p_gpio_cfg_pin(&gpio1->a0, i, GPIO_FUNC(0x2));
-	}
-
 	/*
-	 * UART2-UART3 GPIOs (part2) : 0x00223322
-	 * GPA1CON[3] = I2C_3_SCL (3)
+	 * UART2 GPIOs
+	 * GPA1CON[0] = UART_2_RXD(2)
+	 * GPA1CON[1] = UART_2_TXD(2)
 	 * GPA1CON[2] = I2C_3_SDA (3)
+	 * GPA1CON[3] = I2C_3_SCL (3)
 	 */
-	for (i = 0; i < 5; i++) {
+
+	for (i = 0; i < 4; i++) {
 		s5p_gpio_set_pull(&gpio1->a1, i, GPIO_PULL_NONE);
-		s5p_gpio_cfg_pin(&gpio1->a1, i,
-				GPIO_FUNC((i == 2 || i == 3) ? 0x3 : 0x2));
+		s5p_gpio_cfg_pin(&gpio1->a1, i, GPIO_FUNC((i > 1) ? 0x3 : 0x2));
 	}
 
 	/* UART_SEL GPY4[7] (part2) at EXYNOS4 */
Signature · 1 line
1.7.5.4