Skip to contentSkip to conversation

ARM: Exynos4: Add cpu-offset property in gic device tree node

PATCH New Thomas Abraham 3 participants 3 messages Jan 31, 2012 – Feb 9, 2012

Subsystems (2)
Device tree bindings Arm Samsung Exynos
lore
Share & tools
lore

Thomas Abraham

author
#0 lore raw

PATCH v2 1/1 ARM: Exynos4: Add cpu-offset property in gic device tree node

Commit db0d4db22a78 ('ARM: gic: allow GIC to support non-banked setups) requires a cpu-offset property to be specified for non-banked gic controllers, which is the case for Exynos4.

Reported-by Karol Lewandowski <[email protected]>
Signed-off-by Thomas Abraham <[email protected]>

---
This patch solves the issue of boot failure with SMP enabled kernel for Exynos4 device tree enabled machine.

 arch/arm/boot/dts/exynos4210.dtsi |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos4210.dtsi +1 -0
index 63d7578..a1dd2ee 100644
@@ -29,6 +29,7 @@
 		compatible = "arm,cortex-a9-gic";
 		#interrupt-cells = <3>;
 		interrupt-controller;
+		cpu-offset = <0x8000>;
 		reg = <0x10490000 0x1000>, <0x10480000 0x100>;
 	};
Signature · 1 line
1.6.6.rc2
#1 lore raw

PATCH v2 1/1 ARM: Exynos4: Add cpu-offset property in gic device tree node

Quoted 5 lines · Thomas Abraham

Commit db0d4db22a78 ('ARM: gic: allow GIC to support non-banked setups) requires a cpu-offset property to be specified for non-banked gic controllers, which is the case for Exynos4.

Reported-by Karol Lewandowski<[email protected]>

( Minor note - my email address lacks 'i' at the end, i.e. it's
k.lewandowsk@ :)

Quoted 4 lines
Signed-off-by Thomas Abraham<[email protected]>

---
This patch solves the issue of boot failure with SMP enabled kernel for Exynos4 device tree enabled machine.

Tested-by Karol Lewandowski <[email protected]>

Thanks!

#2 lore raw

PATCH v2 1/1 ARM: Exynos4: Add cpu-offset property in gic device tree node

Quoted 11 lines · Karol Lewandowski
Quoted 5 lines · Thomas Abraham

Commit db0d4db22a78 ('ARM: gic: allow GIC to support non-banked setups) requires a cpu-offset property to be specified for non-banked gic controllers, which is the case for Exynos4.

Reported-by Karol Lewandowski<[email protected]>

( Minor note - my email address lacks 'i' at the end, i.e. it's
k.lewandowsk@ :)

Quoted 7 lines
Quoted 4 lines
Signed-off-by Thomas Abraham<[email protected]>

---
This patch solves the issue of boot failure with SMP enabled kernel for Exynos4 device tree enabled machine.

Tested-by Karol Lewandowski <[email protected]>

Applied with fixing Karol's e-mail address.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.